Re: [PATCH] driver: staging: wlan-ng: Fixed coding style

I resubmitted a new patch with only one style rule fixed. the rest will follow. On 04/03/2014 12:28 AM, Greg KH wrote: On Thu, Apr 03, 2014 at 12:16:56AM +0200, Sherif Shehab Aldin wrote: Fixed coding style for hfa384x_usb.c You do a lot of different types of cleanup in this patch, you are

Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

done and sent in a new mail. BTW regarding "Alignment should match open parenthesis" rule, It's missing from Documentation/CodingStyle On 04/03/2014 01:21 AM, Joe Perches wrote: On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote: Fixed coding style rule "Bre

Re: [PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues

test my changes? On 04/03/2014 09:45 AM, Dan Carpenter wrote: On Thu, Apr 03, 2014 at 09:13:29AM +0200, Sherif Shehab Aldin wrote: static void hfa384x_usbctlx_resptimerfn(unsigned long data) { - hfa384x_t *hw = (hfa384x_t *) data; + hfa384x_t *hw = (hfa384x_t *) unsigned

Re: [PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues

Yes I enabled it: $ grep PRISM2_USB .config CONFIG_PRISM2_USB=m But still getting the same output: $ make M=drivers/staging/wlan-ng/ Building modules, stage 2. MODPOST 0 modules On 04/03/2014 11:38 AM, Dan Carpenter wrote: On Thu, Apr 03, 2014 at 10:21:21AM +0200, Sherif wrote: Yes I see

Re: [PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues

11:42:47AM +0200, Sherif wrote: Yes I enabled it: $ grep PRISM2_USB .config CONFIG_PRISM2_USB=m But still getting the same output: $ make M=drivers/staging/wlan-ng/ Building modules, stage 2. MODPOST 0 modules That's very odd. It works for me. I don't know what to tell you. re

[PATCH] driver: staging: wlan-ng: Fixed coding style

Fixed coding style for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 70 - 1 file changed, 33 insertions(+), 37 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng

[PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/stagi

[PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/stagi

[PATCH] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

[PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 4cfd074

[PATCH 1/9] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/stagi

[PATCH 2/9] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 38 - 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng

[PATCH 3/9] driver: staging: wlan-ng: switched to pr_warn

changed printk(KERN_WARNING .. to pr_warn Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 2a44c79

[PATCH 4/9] driver: staging: wlan-ng: Setting character pointers as const

changed declaration of ctlx_str to: static const char * const ctlx_str[] Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng

[PATCH 7/9] driver: staging: wlan-ng: Fixed white spaces issues

In hfa384x_usb.c: Fixed allignment issues after open braces Moved Logical continuations to the correct lines Removed unnecessary blank lines Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 32 ++-- 1 file changed, 14 insertions(+), 18

[PATCH 9/9] driver: staging: wlan-ng: Removed #if 0 lines from hfa384x_usb.c

Removed lines that were ignored by #if 0 Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 777b1e7..4e9df48 100644 --- a

[PATCH 6/9] driver: staging: wlan-ng: Fixed Alignment to match open parenthesis

Fixed Alignment to match open parenthesis in hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 113 + 1 file changed, 59 insertions(+), 54 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers

[PATCH 8/9] driver: staging: wlan-ng: Removed multiple assignments

Removed multiple assignments from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 64b51b7

[PATCH 5/9] driver: staging: wlan-ng: Removed Unnecessary space after function pointer name

Removed Unnecessary space after function pointer name Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 65e59a3

[PATCH 01/10] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 47 - 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/drivers/stagi

[PATCH 04/10] driver: staging: wlan-ng: Setting character pointers as const

changed declaration of ctlx_str to: static const char * const ctlx_str[] Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng

[PATCH 03/10] driver: staging: wlan-ng: switched to pr_warn

changed printk(KERN_WARNING .. to pr_warn Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 943de9c

[PATCH 02/10] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

[PATCH 07/10] driver: staging: wlan-ng: Fixed white spaces issues

In hfa384x_usb.c: Moved Logical continuations to the correct lines Removed unnecessary blank lines Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH 09/10] driver: staging: wlan-ng: Removed #if 0 lines from hfa384x_usb.c

Removed lines that were ignored by #if 0 Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index cf27030..867edb4 100644 --- a

[PATCH 05/10] driver: staging: wlan-ng: Removed Unnecessary space after function pointer name

Removed Unnecessary space after function pointer name Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 74db234

[PATCH 08/10] driver: staging: wlan-ng: Removed multiple assignments

Removed multiple assignments from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 1a6116a

[PATCH 06/10] driver: staging: wlan-ng: Fixed Alignment to match open parenthesis

Fixed Alignment to match open parenthesis in hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 121 + 1 file changed, 63 insertions(+), 58 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers

[PATCH 10/10] driver: staging: wlan-ng: Removed unnecessary spaces after cast from hfa384x_usb.c

Fixed: No space is necessary after a cast Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c