Re: [PATCH v3 1/3] ARM: dts: imx6ul: Add csi node

2019-08-19 Thread Shawn Guo
On Wed, Jul 31, 2019 at 06:32:57PM +0200, Sébastien Szymanski wrote: > Add csi node for i.MX6UL SoC. > > Reviewed-by: Fabio Estevam > Signed-off-by: Sébastien Szymanski Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driver

Re: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent

2018-05-02 Thread Shawn Guo
Anson, Please have a look at this change. Shawn On Mon, Apr 23, 2018 at 02:47:38PM +0100, Rui Miguel Silva wrote: > Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a > orphan > clock and set the correct parent. > > before: > cat clk_orphan_summary >

Re: [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root

2018-05-02 Thread Shawn Guo
make the file easier for read. So I would suggest you keep it on a single line to stay consistent with other clk_set_parent() calls. Other than that, Acked-by: Shawn Guo > /* use old gpt clk setting, gpt1 root clk must be twice as gpt counter > freq */ > cl

Re: [PATCH v2 07/15] ARM: dts: increase default cma size to 40MB

2018-05-02 Thread Shawn Guo
On Mon, Apr 23, 2018 at 02:47:42PM +0100, Rui Miguel Silva wrote: > To support camera in i.MX7 the cma heap is used to allocate frame buffers. The > default size of CMA is 16MB which is not enough for higher resolutions (ex: > 1600x1200). > > So, increase the default CMA size to 40MB. > > Signed-

Re: [PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls

2018-05-02 Thread Shawn Guo
On Mon, Apr 23, 2018 at 02:47:45PM +0100, Rui Miguel Silva wrote: > The IOMUXC General Purpose Register has bitfield to control video bus > multiplexer to control the CSI input between the MIPI-CSI2 and parallel > interface. Add that register and mask. > > Signed-off-by: Rui Miguel Silva > --- >

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Shawn Guo
queued up for the next merge window sooner > rather than later, preferably getting most of this ready for that > window too. For the series, Acked-by: Shawn Guo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-10 Thread Shawn Guo
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: > Hi, > > this latest version of the imx-drm DT binding patches applies > on top of staging-next and also depends on the OF graph binding > patchset that moves the v4l2_of helpers to drivers/of. > Currently, the two patchsets are also

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Shawn Guo
On Tue, Mar 11, 2014 at 12:42:08PM +0100, Philipp Zabel wrote: > Hi Shawn, > > Am Dienstag, den 11.03.2014, 11:46 +0800 schrieb Shawn Guo: > > On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: > > > Hi, > > > > > > this latest version

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Shawn Guo
On Tue, Mar 11, 2014 at 02:34:38PM +0100, Lucas Stach wrote: > > Sorry, Philipp. The setup in my report is incorrect. The correct setup > > to see this issue consists of: > > > > 1) build a kernel without HDMI support, i.e. !CONFIG_DRM_IMX_HDMI > > > > 2) enable HDMI device in DT, i.e. adding t

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-06 Thread Shawn Guo
On Tue, Mar 11, 2014 at 11:46:11AM +0800, Shawn Guo wrote: > I just came across a couple problems when testing the series on > my imx6dl-sabresd board in dual display case - HDMI + LVDS. I tested it > using Russell's branch below, which I believe has all the pieces put > tog

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-07 Thread Shawn Guo
On Mon, Apr 07, 2014 at 10:09:27AM +0100, Russell King - ARM Linux wrote: > So no EDID. Did you update the "ddc" property to "ddc-i2c-bus" ? Ah, right. This is exactly the cause. Thanks, Russell. Shawn ___ devel mailing list de...@linuxdriverproject

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-07 Thread Shawn Guo
On Mon, Apr 07, 2014 at 12:05:35PM +0200, Philipp Zabel wrote: > > Did you get any chance to reproduce this dual display issue? Now it > > shows on mainline kernel. > > I have not yet reproduced, but I've sent a patch today ("imx-drm: > imx-drm-core: Fix imx_drm_encoder_get_mux_id") that might fi

Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id

2014-04-07 Thread Shawn Guo
l It fixes a color corruption issue on my dual display case (LVDS + HDMI). Tested-by: Shawn Guo Shawn > --- > drivers/staging/imx-drm/imx-drm-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/imx-drm-core.c > b/drivers/

Re: [PATCH v12][ 06/12] ARM: dts: imx5*, imx6*: correct display-timings nodes.

2014-04-08 Thread Shawn Guo
On Mon, Apr 07, 2014 at 02:44:45PM +0200, Denis Carikli wrote: > The imx-drm driver can't use the de-active and > pixelclk-active display-timings properties yet. > > Instead the data-enable and the pixel data clock > polarity are hardcoded in the imx-drm driver. > > So theses properties are now s

Re: [PATCH v12][ 12/12] ARM: imx_v6_v7_defconfig: Add more drm drivers.

2014-04-08 Thread Shawn Guo
On Mon, Apr 07, 2014 at 02:44:51PM +0200, Denis Carikli wrote: > The DRM_PANEL_SIMPLE is needed by the eukrea > mbimxsd51's displays. > > Signed-off-by: Denis Carikli Applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverde

Re: [PATCH] mtd: nand: Rename nand.h into rawnand.h

2017-08-09 Thread Shawn Guo
rawnand.h so we can later create a nand.h header > containing all common structure and function prototypes. > > Signed-off-by: Boris Brezillon > Signed-off-by: Peter Pan ... > arch/arm/mach-imx/mach-qong.c | 2 +- Acked-by: Shawn Guo __

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-03 Thread Shawn Guo
man > Cc: Philipp Zabel > Cc: Sascha Hauer > Cc: Shawn Guo > --- > drivers/gpu/drm/drm_modes.c | 5 + > include/uapi/drm/drm_mode.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index

Re: [PATCH 3/4] imx-drm: fix missing symbol exports

2013-12-16 Thread Shawn Guo
On Mon, Dec 16, 2013 at 11:34:05AM +, Russell King wrote: > Trying to build a modular imx-drm results in a number of missing symbol > exports, caused by the recent changes to this driver. Add the necessary > exports, and the missing MODULE_LICENSE() tag. Since commit 9c74360 (staging: imx-drm

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-16 Thread Shawn Guo
ttle doubt I replied on this one, for the whole series: Acked-by: Shawn Guo Tested-by: Shawn Guo > imx-drm: ipu-v3: fix potential CRTC device registration race > imx-drm: imx-tve: don't call sleeping functions beneath enable_lock > spinlo > imx-drm: imx-drm-c

Re: [PATCH 2/3] imx-drm: imx-drm-core: avoid going the long route round for drm_device

2013-12-17 Thread Shawn Guo
m_mode_config_cleanup(imxdrm->drm); > + drm_vblank_cleanup(drm); > + drm_kms_helper_poll_fini(drm); > + drm_mode_config_cleanup(drm); With the changes, 'imxdrm' in this function becomes an unused variable. Other than that, for the series: Acked-by: Shawn Guo Tes

Re: [PATCH] staging: imx-drm: imx-tve: Fix a sparse warning

2013-12-23 Thread Shawn Guo
tatic? > > Signed-off-by: Liu Ying Acked-by: Shawn Guo > --- > drivers/staging/imx-drm/imx-tve.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/imx-tve.c > b/drivers/staging/imx-drm/imx-tve.c > index 2c44fef

Re: [PATCH RFC 00/46] Preview of imx-drm cleanup series

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:25:28PM +, Russell King - ARM Linux wrote: > Here is my large patch series which cleans up imx-drm, and gets it ready > to move out of drivers/staging. This is a preview only. When moving to non-RFC patches, you may want to run checkpatch.pl on the patches. There a

Re: [PATCH RFC 24/46] imx-drm: provide common connector mode validation function

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:27:48PM +, Russell King wrote: > diff --git a/drivers/staging/imx-drm/imx-drm.h > b/drivers/staging/imx-drm/imx-drm.h > index 5649f180dc44..4eb594ce9cff 100644 > --- a/drivers/staging/imx-drm/imx-drm.h > +++ b/drivers/staging/imx-drm/imx-drm.h > @@ -68,4 +68,7 @@ int

Re: [PATCH RFC 30/46] imx-drm: remove separate imx-fbdev

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:28:19PM +, Russell King wrote: > @@ -449,6 +458,24 @@ static int imx_drm_driver_load(struct drm_device *drm, > unsigned long flags) > } > } > > + /* > + * All components are now initialised, so setup the fb helper. > + * The fb hel

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:28:03PM +, Russell King wrote: > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index e75e11b36dff..0e005f21d241 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-09 Thread Shawn Guo
On Wed, Jan 08, 2014 at 09:32:58PM +, Russell King - ARM Linux wrote: > On Tue, Jan 07, 2014 at 04:59:35PM +0800, Shawn Guo wrote: > > On Thu, Jan 02, 2014 at 09:28:03PM +, Russell King wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > >

Re: [RFC PATCH v2] staging: imx-hdmi: use rx sense status for plug detection if hpd is unreliable

2014-01-10 Thread Shawn Guo
On Fri, Jan 10, 2014 at 03:22:24PM +0100, Philipp Zabel wrote: > Due to the voltage divider on the HPD line, the HDMI connector on > imx6q-sabrelite doesn't reliably detect connected DVI monitors. > This patch allows to use the RX_SENSE0 signal as a workaround when > enabled by a boolean device tre

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Shawn Guo
On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: > On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux > wrote: > > > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This > > should report the current state of the hotplug detection. > > /sys/class/drm/card0-

Re: [PATCH v14 05/10] ARM: dts: imx5*, imx6*: correct display-timings nodes.

2014-06-24 Thread Shawn Guo
On Tue, Jun 24, 2014 at 04:01:58PM +0100, Russell King - ARM Linux wrote: > On Mon, Jun 16, 2014 at 12:11:19PM +0200, Denis Carikli wrote: > > The imx-drm driver can't use the de-active and > > pixelclk-active display-timings properties yet. > > > > Instead the data-enable and the pixel data clock

Re: [PATCH 0/2] Two imx-drm oops fixes

2014-09-09 Thread Shawn Guo
On Mon, Sep 08, 2014 at 12:09:49PM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 08, 2014 at 12:08:59PM -0700, Greg Kroah-Hartman wrote: > > On Mon, Sep 01, 2014 at 06:07:12PM +0100, Russell King - ARM Linux wrote: > > > Greg, > > > > > > Here's two oops fixes for imx-drm, which I've had queued u

[PATCH] imx-drm: ipuv3-plane: remove function ipu_plane_dpms()

2014-09-10 Thread Shawn Guo
el Signed-off-by: Shawn Guo --- Greg, This cleanup patch is based on Russell's fix -'imx-drm: ipuv3-plane: fix ipu_plane_dpms()'. Shawn drivers/staging/imx-drm/ipuv3-plane.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/driv

[PATCH RESEND] imx-drm: imx-drm-core: add basic suspend/resume support

2014-09-10 Thread Shawn Guo
inter from driver data, it also clears driver data in .unload hook. Signed-off-by: Shawn Guo --- Greg, This is a resend of '[PATCH v3] imx-drm: imx-drm-core: add suspend/resume support' [1], with a tiny change on the subject only. Shawn [1] http://thread.gmane.org/gmane.linux.ports.ar

Re: [PATCH 3/3] MAINTAINERS: add maintainer for i.MX DRM driver

2014-11-04 Thread Shawn Guo
On Tue, Nov 4, 2014 at 6:52 PM, Philipp Zabel wrote: > Add myself as the maintainer of the i.MX DRM driver. > > Signed-off-by: Philipp Zabel Acked-by: Shawn Guo > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAI