[PATCH 2/2] vt6656: Combined nested conditions

2013-12-19 Thread Sebastian Rachuj
p; cond2) { block(); } These adjustments increase the readability of the driver without altering its semantics. But still the file does not pass checkpatch completely (mainly due to lines over 80 characters). Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656

[PATCH 0/2] vt6656: Cleanup of checkpatch problems in bssdb.c

2013-12-19 Thread Sebastian Rachuj
This patch series reformats the bssdb.c file of the vt6656 driver in staging. It resolves all errors and some warnings which checkpatch.pl discovered. However some occurrences of the following warnings are not patched: - Lines over 80 characters - Too many indentation levels - printk should includ

[PATCH 03/11] Staging: vt6656: Remove unnecessary semicolons

2013-12-26 Thread Sebastian Rachuj
From: Simon Schuster After some blocks in bssdb.c there are semicolons that are not required to be there. Therefore they are removed with this patch. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 14 +++--- 1 file changed, 7

[PATCH 02/11] Staging: vt6656: Adjust comments in bssdb.c

2013-12-26 Thread Sebastian Rachuj
From: Simon Schuster Changes C99-style comments to C89-style ones to conform to the linux coding guidelines. Additionally removes plus and minus signs from the function description comments. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c

[PATCH 05/11] Staging: vt6656: Correct single space mistakes

2013-12-26 Thread Sebastian Rachuj
that preceed semicolons are removed as well. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 136 - 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers

[PATCHv2 0/11] Staging: vt6656: Cleanup of checkpatch problems in bssdb.c

2013-12-26 Thread Sebastian Rachuj
This patch series reformats the bssdb.c file of the vt6656 driver in staging. It resolves all errors and some warnings which checkpatch.pl discovered. As requested, the changes are now split into a series of smaller, fine-grained patches. The reference git tree, that was used to create it this tim

[PATCH 04/11] Staging: vt6656: Correct operator coding style

2013-12-26 Thread Sebastian Rachuj
From: Simon Schuster Adds spaces around operators (like &&, ||, !=, +, ...) and removes spaces before postfix increment and decrement operators. Parentheses around return values are removed, too. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656

[PATCH 08/11] Staging: vt6656: Combine "else { if" to "else if"

2013-12-26 Thread Sebastian Rachuj
looks like that else if (cond) { statements; } else { other_statements; } Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 114 + 1 file changed, 47 insertions(+), 67 deletions(-) diff --git

[PATCH 09/11] Staging: vt6656: Correct usage of braces

2013-12-26 Thread Sebastian Rachuj
: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index e281d3c..1972a5b 100644 --- a

[PATCH 10/11] Staging: vt6656: Combined nested conditions

2013-12-26 Thread Sebastian Rachuj
p; cond2) { block(); } Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 281 - 1 file changed, 139 insertions(+), 142 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb

[PATCH 11/11] Staging: vt6656: Reduce line length of bssdb.c

2013-12-26 Thread Sebastian Rachuj
characters. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 301 +++-- 1 file changed, 201 insertions(+), 100 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index

[PATCH 07/11] Staging: vt6656: Remove unnecessary spaces in format strings

2013-12-26 Thread Sebastian Rachuj
From: Simon Schuster A space in a format string is unnecessary if it is followed by a line feed. These spaces are removed by this patch. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 06/11] Staging: vt6656: Remove line feeds before else

2013-12-26 Thread Sebastian Rachuj
From: Simon Schuster An else belongs in the same line as the closing curly brace of the previous block. Hence, this patch removes line feeds separating a curly brace from the corresponding else. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c

[PATCHv3 0/13] Staging: vt6656: Cleanup of checkpatch problems in bssdb.c

2014-01-04 Thread Sebastian Rachuj
This patch series reformats the bssdb.c file of the vt6656 driver in staging. It resolves all errors and some warnings which checkpatch.pl discovered. However some occurrences of the following warnings are not patched: - Lines over 80 characters - Too many indentation levels - printk should includ

[PATCH 04/13] Staging: vt6656: Correct operator coding style

2014-01-04 Thread Sebastian Rachuj
From: Simon Schuster Adds spaces around operators (like &&, ||, !=, +, ...) and removes spaces before postfix increment and decrement operators. Parentheses around return values are removed, too. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656

[PATCH 03/13] Staging: vt6656: Remove unnecessary semicolons

2014-01-04 Thread Sebastian Rachuj
From: Simon Schuster After some blocks in bssdb.c there are semicolons that are not required to be there. Therefore they are removed with this patch. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 14 +++--- 1 file changed, 7

[PATCH 02/13] Staging: vt6656: Adjust comments in bssdb.c

2014-01-04 Thread Sebastian Rachuj
From: Simon Schuster Changes C99-style comments to C89-style ones to conform to the linux coding guidelines. Additionally removes plus and minus signs from the function description comments. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c

[PATCH 11/13] Staging: vt6656: Remove bogus parentheses in conditions

2014-01-04 Thread Sebastian Rachuj
Removes unrequired parentheses around comparisons in complex conditions. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 138 - 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/drivers

[PATCH 13/13] Staging: vt6656: Reduce line length of bssdb.c

2014-01-04 Thread Sebastian Rachuj
characters. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 301 +++-- 1 file changed, 201 insertions(+), 100 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index

[PATCH 12/13] Staging: vt6656: Remove explicit comparisons against NULL

2014-01-04 Thread Sebastian Rachuj
Explicit comparisons of pointers agains NULL (like if (p != NULL) ...) are not as readable as the implicit comparison (like if (p) ...). This patch converts all these explicit comparisons to implicit ones. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656

[PATCH 10/13] Staging: vt6656: Combined nested conditions

2014-01-04 Thread Sebastian Rachuj
p; cond2) { block(); } Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 281 - 1 file changed, 139 insertions(+), 142 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb

[PATCH 06/13] Staging: vt6656: Remove line feeds before else

2014-01-04 Thread Sebastian Rachuj
From: Simon Schuster An else belongs in the same line as the closing curly brace of the previous block. Hence, this patch removes line feeds separating a curly brace from the corresponding else. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c

[PATCH 05/13] Staging: vt6656: Correct single space mistakes

2014-01-04 Thread Sebastian Rachuj
that preceed semicolons are removed as well. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 136 - 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers

[PATCH 08/13] Staging: vt6656: Combine "else { if" to "else if"

2014-01-04 Thread Sebastian Rachuj
looks like that else if (cond) { statements; } else { other_statements; } Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 114 + 1 file changed, 47 insertions(+), 67 deletions(-) diff --git

[PATCH 07/13] Staging: vt6656: Remove unnecessary spaces in format strings

2014-01-04 Thread Sebastian Rachuj
From: Simon Schuster A space in a format string is unnecessary if it is followed by a line feed. These spaces are removed by this patch. Signed-off-by: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 09/13] Staging: vt6656: Correct usage of braces

2014-01-04 Thread Sebastian Rachuj
: Sebastian Rachuj Signed-off-by: Simon Schuster --- drivers/staging/vt6656/bssdb.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index e281d3c..1972a5b 100644 --- a