Ping?
Samuel Thibault, on Fri 15 Jan 2016 00:47:41 +0100, wrote:
> Commit f79b0d9c223c ("staging: speakup: Fixed warning
> instead of ") broke the port information in the speakup
> driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included,
> and no other header
-off-by: Samuel Thibault
Reviewed-by: Alan Cox
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -4250,6 +4250,7 @@ unsigned short *screen_pos(struct vc_dat
{
return screenpos(vc, 2 * w_offset, viewed);
}
+EXPORT_SYMBOL_GPL(screen_pos);
void getconsxy(struct vc_data *vc
mn10300 uses an mmio-driven uart. This is not supported by speakup, so
prevent from enabling it.
Signed-off-by: Samuel Thibault
--- a/drivers/staging/speakup/Kconfig
+++ b/drivers/staging/speakup/Kconfig
@@ -1,7 +1,7 @@
menu "Speakup console speech"
config SPEAKUP
- dep
Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
> wrote:
> > mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> > prevent from enabling it.
>
> Just wondering, what are the symptoms of
Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> I guess there are many other platforms where the UART is MMIO-driven...
Actually they can't ever get to be exposed to speakup's serialio.c:
their SERIAL_PORT_DFNS would set SERIAL_IO_MEM in the io_type field,
but that field doesn't ev
Markus Mayer, on Thu 30 Jun 2016 16:50:11 -0700, wrote:
> After introducing generic strtolower(), spk_strlwr() is no longer
> needed.
>
> Signed-off-by: Markus Mayer
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c| 2 +-
> drivers/staging/speak
Markus Mayer, on Fri 08 Jul 2016 15:43:11 -0700, wrote:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
Acked-by: Samuel Thibault
> ---
>
> Samuel, I left off your ACK, since the implemen
Hello,
Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote:
> There is a potential race in drivers/staging/speakup/speakup.ko.
> All operations with global pointers buff_in and buff_out are performed
> without any locks. Thus, a simultaneous write (via synth_buffer_clear or
> synth_buffer_ad
Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote:
> 05.09.2016 12:43, Samuel Thibault пишет:
> >Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote:
> >>There is a potential race in drivers/staging/speakup/speakup.ko.
> >>All operations with global pointe
Pavel Andrianov, on Mon 05 Sep 2016 13:33:33 +0300, wrote:
> synth_direct_store may be called via device_attributes interface.
Ah, right.
> In which function the lock should be added?
That'd be synth_direct_store then, around the while loop.
Samuel
__
drianov
Reviewed-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/speakup/kobjects.c
> b/drivers/staging/speakup/kobjects.c
> index 528cbdc..7fedee3 100644
> --- a/drivers/staging/
Hello,
Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev
>
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove
> warning produce by checkpatch.
> + unsigned long val;
> +
> + if (kstrtoul(start, 10, &val))
> +
Hello,
Just looking over the patch, it looks good. I don't think it needs to be
split in 4 pieces though, I'd say merge patches 1, 3, and 4 together,
where patch 3 would be modified to make dummy use spk_serial_out too, to
get a patch which does just one complete thing: make serial_out a
method.
Hello,
Greg KH, on Sat 19 Nov 2016 17:08:09 +0100, wrote:
> > Intention is to allow changing implementation of serial_out() for
> > speakup_dummy while allowing other drivers to continue unaffected.
>
> Why is that needed? Why not post the whole series that implements what
> you wish to have hap
walter harms, on mer. 28 juin 2017 16:49:03 +0200, wrote:
> Am 28.06.2017 15:13, schrieb Colin King:
> > diff --git a/drivers/staging/speakup/spk_ttyio.c
> > b/drivers/staging/speakup/spk_ttyio.c
> > index 442f191a017e..ed8e96b06ead 100644
> > --- a/drivers/staging/speakup/spk_ttyio.c
> > +++ b/dr
Jaya Durga, on mer. 12 juil. 2017 16:53:53 +0530, wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
IIRC synth_immediate is meant to be usable in atomic contexts too, so
usleep can't be used.
Samuel
___
devel mailing list
de..
e')
> drivers/staging/speakup/serialio.c:12:2: error: initializer element is not
> constant
> drivers/staging/speakup/serialio.c:12:2: error: (near initialization for
> 'rs_table[3].baud_base')
>
>
> Signed-off-by: Chen Gang
Acked-by: Samuel Thibault
&g
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
> Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
___
devel mailing list
de...@linuxdriverproject.o
Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
>
> Signed-off-by: Sasha Levin
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/synth.c |3 +++
> 1 file changed, 3 ins
of spk_do_catch_up.
Signed-off-by: Samuel Thibault
Index: linux-4.15/drivers/staging/speakup/spk_types.h
===
--- linux-4.15.orig/drivers/staging/speakup/spk_types.h
+++ linux-4.15/drivers/staging/speakup/spk_types.h
@@ -151,6 +151,7
Hello,
MugilRaj, le ven. 22 mai 2020 14:46:28 +0530, a ecrit:
> fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> Documentation/process/volatile-considered-harmful.rst
Yes, but the proper fix is usually not to just remove the volatile
qualifier, which will not fix anythi
Joe Perches, le ven. 22 mai 2020 09:36:05 -0700, a ecrit:
> On Fri, 2020-05-22 at 13:34 +0300, Dan Carpenter wrote:
> > On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote:
> > > fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> > > Documentation/process/volatile-cons
Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit:
> > Put another way: I don't think putting any hint here would help, on the
> > contrary, somebody has to really look at what protection is needed,
> > without getting influenced by rules-of-thumb.
>
> checkpatch newbies/robots will submit
ent:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Samuel Thibault
Thanks!
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov
> ' v5.7..master
> (A
clarifies the code
> and allows code reusing.
>
> Signed-off-by: Raphael S.Carvalho
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 71
>
> 1 files changed, 39 insertions(+), 32 deletions(-)
>
> diff --git a/dr
w user input that was used to select the voice.
> Note that using the raw input can also lead to an invalid memory read
> in the case of invalid or malicious user input.
>
> Signed-off-by: Christopher Brannon
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c
w user input that was used to select the voice.
> Note that using the raw input can also lead to an invalid memory read
> in the case of invalid or malicious user input.
>
> Signed-off-by: Christopher Brannon
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c
101 - 127 of 127 matches
Mail list logo
