Re: [PATCH] Drivers: hv: vmbus: handle various crash scenarios

2016-03-19 Thread Radim Krcmar
2016-03-18 13:33+0100, Vitaly Kuznetsov: > Kdump keeps biting. Turns out CHANNELMSG_UNLOAD_RESPONSE is always > delivered to CPU0 regardless of what CPU we're sending CHANNELMSG_UNLOAD > from. vmbus_wait_for_unload() doesn't account for the fact that in case > we're crashing on some other CPU and C

Re: [PATCH] Drivers: hv: vmbus: handle various crash scenarios

2016-03-19 Thread Radim Krcmar
2016-03-18 16:53+0100, Vitaly Kuznetsov: > Radim Krcmar writes: >> 2016-03-18 13:33+0100, Vitaly Kuznetsov: >>> @@ -530,9 +542,17 @@ static void vmbus_wait_for_unload(void) >> >> (I'm not a huge fan of the unloaded variable; what about reme

Re: [PATCH 1/4] Drivers: hv: vmbus: don't loose HVMSG_TIMER_EXPIRED messages

2016-02-15 Thread Radim Krcmar
2016-02-12 16:42+0100, Vitaly Kuznetsov: > We must handle HVMSG_TIMER_EXPIRED messages in the interrupt context > and we offload all the rest to vmbus_on_msg_dpc() tasklet. This functions > loops to see if there are new messages pending. In case we'll ever see > HVMSG_TIMER_EXPIRED message there we

Re: [PATCH 2/4] Drivers: hv: vmbus: avoid wait_for_completion() on crash

2016-02-15 Thread Radim Krcmar
wait instead. (Too bad we fix crashers, so there is nothing to test on. :]) > Reported-by: Radim Krcmar Reviewed-by: Radim Krčmář > Signed-off-by: Vitaly Kuznetsov > --- > drivers/hv/channel_mgmt.c | 4 ++-- > drivers/hv/connection.c | 2 +- > drivers/hv/hyperv_vmbus.h |

Re: [PATCH 3/4] Drivers: hv: vmbus: remove code duplication in message handling

2016-02-15 Thread Radim Krcmar
2016-02-12 16:42+0100, Vitaly Kuznetsov: > We have 3 functions dealing with messages and they all implement > the same logic to finalize reads, move it to vmbus_signal_eom(). > > Suggested-by: Radim Krcmar Reviewed-by: Radim Krčmář ___ d

Re: [PATCH 4/4] Drivers: hv: vmbus: avoid unneeded compiler optimizations in vmbus_wait_for_unload()

2016-02-15 Thread Radim Krcmar
2016-02-12 16:42+0100, Vitaly Kuznetsov: > Message header is modified by the hypervisor and we read it in a loop, > we need to prevent compilers from optimizing accesses. There are no such > optimizations at this moment, this is just a future proof. > > Suggested-by: Radim Krcma

Re: [PATCH v4 2/2] hv_utils: implement Hyper-V PTP source

2017-01-20 Thread Radim Krcmar
2017-01-19 15:16+0100, Vitaly Kuznetsov: > With TimeSync version 4 protocol support we started updating system time > continuously through the whole lifetime of Hyper-V guests. Every 5 seconds > there is a time sample from the host which triggers do_settimeofday[64](). > While the time from the hos