Fix the spelling/grammar errors in the comment block describing
the 'Function' member of 'struct rt_firmware_hdr'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
Fix a grammatical error in the comment describing 'struct
rt_firmware_hdr'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
b/drive
Make alignment and whitespace more consistent within the file
'rtl8723_hal.h' and with the kernel coding style guidelines.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/include/rtl8723b_hal.h | 261 ++
1 file changed, 144 insertions(+), 117 deletions(-)
di
Change the parameter of the macro to the snake case 'fw_hdr' instead
of '_pFwHdr'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/inclu
Replace camel-case member names with snake-case names per the linux
kernel coding style guidelines.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 14
.../staging/rtl8723bs/include/rtl8723b_hal.h | 32 +--
2 files changed, 23
Change the members of 'struct rt_firmware' to be snake case instead
of camel-case, per the kernel coding style guide.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c| 16
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++-
Camel-case is discouraged in the linux kernel coding style. Rename
this header using snake case instead.
Signed-off-by: Quytelda Kahja
---
.../rtl8723bs/include/{Hal8723BPhyReg.h => hal_phy_reg_8723b.h} | 0
drivers/staging/rtl8723bs/include/rtl8723b_hal.h| 2 +-
2 fi
Camel-case is discouraged in the linux kernel coding style. Rename
this header file using snake case instead.
Signed-off-by: Quytelda Kahja
---
.../rtl8723bs/include/{Hal8723BPhyCfg.h => hal_phy_cfg.h} | 0
drivers/staging/rtl8723bs/include/rtl8723b_hal.h| 2 +-
2 fi
Camel-case naming is discouraged int the linux kernel coding style.
Rename these files using snake case, and update the makefile to use
the new names.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/Makefile | 2 +-
.../staging/rtl8723bs/hal
The rate section lookup is a large switch statement in the middle of
'phy_get_tx_pwr_lmt()'; refactor this statement into it's own function
for increased readability.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 109 --
1 f
Rename camel-case 'PHY_GetTxPowerLimit()' to 'phy_get_tx_pwr_lmt()'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +++---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c| 2 +-
drivers/staging/rtl8723bs/include/hal_com_phyc
Two conditionals that set 'channel' based on 'band_type' in
'phy_get_tx_pwr_lmt()' can be simplified into one single-line conditional.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 8 ++--
1 file changed, 2 insertions(+)
This else-if conditional block does nothing; remove it.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index
Fix 'braces {} should be used on all arms of this statement' coding
style problem in 'phy_get_tx_pwr_lmt()'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/s
Factoring out the conditional lookup of bandwidth index into the power
limit table into it's own function simplifies the logic of
'phy_get_tx_pwr_lmt()'.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 26 ---
1 file changed, 17 i
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 6d8a07ac7bb3..dd097df86fa3 100644
--- a
Change camel-case names to snake-case names; to avoid variable name
conflicts, rename table index variables to idx_*.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 200 +-
1 file changed, 105 insertions(+), 95 deletions(-)
diff --git a
Two if statements that carry out the same operation can be combined with
a logical OR.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
b
Wrap lines longer than 80 characters where possible, delete double
newlines, and fix alignment per the kernel coding style guidelines.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 110 ++
1 file changed, 59 insertions(+), 51 deletions
The if conditionals used to work around wrong TX power limit indices
can be condensed into a single if/else-if statement for more concise
expression.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions
> get_monotonic_boottime() is deprecated because it uses the
> old 'timespec' structure. This replaces one of the last callers
> with a call to ktime_get_boottime, which also simplifies it
> a bit by avoiding a double conversion.
>
> Signed-off-by: Arnd Bergmann
Revie
Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd19ddd..1c6dc3a3e64a 100644
--- a
This patch replaces several instances where a pointer is compared to NULL
(i.e., `ptr == NULL`) with `!ptr`, which is preferred.
Signed-off-by: Quytelda Kahja
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android
Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 del
Removed parenthesis causing a coding style warning.
Signed-off-by: Quytelda Kahja
---
drivers/staging/fwserial/dma_fifo.c | 2 +-
drivers/staging/fwserial/fwserial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/dma_fifo.c
b/drivers/staging
Fix a coding style problem causing warnings from checkpatch.pl.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 50 ++-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging
Fix coding style warning from checkpatch.pl.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index ff3fed9c4a81..26a81fdd0044 100644
Fix a coding style warning from checkpatch.pl. Use GNU extensions to create
references to the results of problem macro arguments when they are evaluated so
that they can be used safely multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 24
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 40
1 file changed, 27 insertions(+), 13 deletions(-)
diff
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 74 +-
1 file changed, 50 insertions(+), 24 deletions(-)
diff
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010
Check the return value of of the register_lte_tty_driver() call in the
module initialization function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_mux.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers
Remove the macro 'gdm_tty_send' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
Remove the macro 'gdm_tty_send_control' which adds unnecessary complexity,
is unused, and has arguments that could mistakenly be evaluated multiple
times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drive
Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git
Fix a coding style problem.
Signed-off-by: Quytelda Kahja
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bcm2048/radio-bcm2048
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 46 ++--
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index
Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f554477fe6bc
Fix a coding style problem.
Signed-off-by: Quytelda Kahja
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_endian.c | 24
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
,
Quytelda Kahja
On Thu, Feb 22, 2018 at 6:02 AM, Greg KH wrote:
> On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote:
>> Since the testing for host endianness and in-driver conversion were
>> removed in 77e8a50149a2, the gdm_endian struct contains only one member,
>>
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_endian.c | 24
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
struct sdu_header isn't actually used anywhere in this driver, so
this change removes it on the assumption it isn't needed for any
API.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/stagi
The function pointer 'complete' in 'struct mbo' should use an identifier
for its argument.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.h b/drivers/stagi
Makes two very minor changes indicated by checkpatch:
1) Add a newline after components_show() definition.
2) Fix a line over the 80 character limit.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE()
followed by a return.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most
It isn't necessary for the driver to log out-of-memory errors, so
these have been removed and the functions simply return -ENOMEM.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/st
be increased in the future since we run
modern machines that aren't limited to 80 character terminals anymore,
so this warning may soon be irrelevant anyway.
Thank you,
Quytelda Kahja
On Mon, Feb 26, 2018 at 5:51 AM, Hans Verkuil wrote:
> On 02/20/2018 07:53 AM, Quytelda Kahja wrote:
>
The code that generates a WLAN capability mask is repeated in five
functions. This change refactors that code into a new function, which is
called now in each of those functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 88 ++
1
The case statement in get_ap_information() should not use literal integers
to parse information element IDs when these values are provided by name
in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/ks7010/ks_hostif.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f425975fbcbc..7935ba56bb1d 10064
SSID_MAX_SIZE is a constant defined locally in ks_hostif.h, but it should
be replaced with IEEE80211_MAX_SSID_LEN from the kernel's 802.11 header,
of which it is just a copy.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/staging/ks7010/ks_hostif.
This driver defined constants BSS_CAP_* to represent WLAN capability
codes; however, these constants are already defined in the header
'linux/ieee80211.h' as WLAN_CAPABILITY_*. This change removes the locally
defined constants and substitutes the kernel's constants.
Signed-off-by:
ilted than my imperative attempts. However, I will word my change
logs in the imperative as best I can in the future.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 12:54 PM, Tobin C. Harding wrote:
> On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote:
>> On Thu, Mar 01,
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7f29967 100644
--- a/drivers
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 67e2d7f29967
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7f29967 100644
--- a/drivers
ugh, so I assumed
there wasn't really much recovery to be made from that problem. If
you feel this doesn't improve the behavior of the driver, just drop
the patch.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 8:21 AM, Greg KH wrote:
> On Fri, Feb 23, 2018 at 11:58:33PM -0800, Quyt
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 67e2d7f29967
Replace literal bytestring with CIPHER_ID_WPA_WEP40 constant.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 7935ba56bb1d
There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().
Signed-off-by: Quytelda Kahja
---
drivers/s
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
The AUTH_TYPE_OPEN_SYSTEM and AUTH_TYPE_SHARED_KEY #define lines
are duplicated in ks_hostif.h. Replace them both with one set of
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
The handling of hostif_infrastructure_set_request_t and
hostif_infrastructure_set2_request_t is identical, with the exception
of the event type value. Merge the two structs so they can be handled
by a single function ('hostif_infrastructure_set_request').
Signed-off-by: Quyt
Instead of using memcmp() to directly compare BSSIDs, use
ether_addr_equal() from 'linux/etherdevice.h'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
There are several instances where comments are spaced so far to the
right they cause the line to go over the 80 character limit. Move
these comments to above the statements they describe instead.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 19 ---
1
portion of the request
initialization code in ks_hostif.c to be factored out into the
'init_request' function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 53 +++--
drivers/staging/ks7010/ks_hostif.h | 54 -
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 31 +++
1 file changed, 15 insertions(+), 16
The "_t" suffix is not needed for structure names in this driver,
and is a reflection of an older typedef system that is no longer
in place. Remove the "_t" suffix from every structure defined in this
driver.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010
Fix two spelling mistakes in comments.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
drivers/staging/ks7010/ks_wlan.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
The driver casts '&ks_wlan_handler_def' to 'struct iw_handler_def *',
but it is already of that type.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/
Reorder the members of 'ks_wlan_netdev_ops' to reflect the order
of their counterparts in the kernel's 'struct net_device_ops'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions
All of the net_device_ops callbacks are named after their counterparts
in the kernel's 'struct net_device_ops', except
ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for
greater consistency.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.
The ethernet address of the network device is already stored in the
'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private'
keeps a pointer to the driver's 'struct net_device', there is no reason
to duplicate this information in '
'mac_address_valid' is only ever assigned 0 or 1, so it makes more sense
to use a bool type for this variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/staging/ks7010/ks_wlan.h | 2 +-
drivers/staging/ks7010/ks_wlan_net.c | 4 ++-
Copying the dummy HW address into the struct net_device doesn't need
to be done byte by byte; use ether_addr_copy() instead.
Additionally, dev->dev_addr is not eight bytes long.
ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6)
in the net core code.
Signed-off-by: Quy
Remove an extra blank line indicated by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
drivers/staging/ks7010/ks_hostif.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging
'reg_net' is never used in this driver.
Signed-off-by: Quytelda Kahja x
---
drivers/staging/ks7010/ks_wlan.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 846bb1041850..1b7036c32d1c 100644
--- a/drivers/stag
1 - 100 of 256 matches
Mail list logo
