Change function's name to %s and __func__ to fix checkpatch.pl errors.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl
Fix indentation for switch-case statements to fix following
checkpatch.pl Error:
ERROR: switch and case should be at the same indent
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 442 +-
1 file changed, 221 insertions(+), 221 deletions
Change spelling of 'associcated' to 'associated', to fix the spelling
mistake.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drive
Remove braces from single if statement to solve style issue found using
checkpatch,pl
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b/drivers
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Correct spelling mistakes at two places in comments.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
b/drivers/staging/rtl8192u
Fix coding style errors related to braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 60 +++
1 file changed, 22 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b
Fix coding style errors by adding spaces around '&&' operators.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee802
Fix comparison to NULL, chang to !x operation.
Issue found using checkpatch.pl
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Fix placement of opening brace in if-else statement
to correct coding style issue.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
V2 - remove extra blank line before the closing brace.
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3
Fix coding style errors related to braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
V2 - Remove extra blank lines.
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 58 +++
1 file changed, 20 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8192u
Fix comparison to NULL, chang to !x operation.
Issue found using checkpatch.pl
Signed-off-by: Puranjay Mohan
---
V2 - Remove extra parentheses around *crypt
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
On Tue, May 14, 2019 at 04:09:05PM +0200, Greg KH wrote:
> On Tue, May 14, 2019 at 02:42:31PM +0530, Puranjay Mohan wrote:
> > Remove braces around a single if statement to fix following
> > checkpatch.pl warning.
> > WARNING: braces {} are not necessary for single statement b
Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Fix coding style errors related to braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 58 +++
1 file changed, 20 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b
Fix comparison to NULL, chang to !x operation.
Issue found using checkpatch.pl
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Fix coding style errors by adding spaces around '&&' operators.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee802
Correct spelling mistakes at two places in comments.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
b/drivers/staging/rtl8192u
This series fix the following errors/warnings:
-Correct spelling mistakes.
-Replace NULL comparison.
-Add space around operators.
-Remove braces from single if statement.
Puranjay Mohan (5):
Staging: rtl8192u: ieee80211: Fix coding style warning
Staging: rtl8192u: ieee80211: Fix spelling
quot;, __func__' to using 'rtl92e_dm_restore_state',
this function's name, in a string
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl
Fix following checkpatch.pl warning by including
instead of .
WARNING: Use #include instead of
Signed-off-by: Puranjay Mohan
---
drivers/staging/kpc2000/kpc_dma/dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/dma.c
b/drivers/staging
Fix following checkpatch.pl warnings by using %s and __func__
in strings instead of function names.
WARNING: Prefer using '"%s...", __func__' to using 'rtw_report_sec_ie', this
function's name, in a string
and other similar warning.
Signed-off-by: Puranjay Mo
Fix positions of braces for if-else statements.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8192u/ieee80211/ieee80211_wx.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
b/drivers/staging/rtl8192u
Fix following warnings reported by coccicheck:
WARNING: Comparison to bool
by using !x in place of (x == false) and
x in place of (x == true).
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 4 ++--
drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 2
Fix the following checkpatch.pl warning :
CHECK: Comparison to NULL could be written "!x"
by changing (x == NULL) to !x and (x != NULL) to x.
Signed-off-by: Puranjay Mohan
---
.../rtl8192u/ieee80211/ieee80211_module.c | 2 +-
.../staging/rtl8192u/ieee80211/ieee80211
Remove unneeded variable "ret" and directly return 0 in functions.
Fix following coccicheck warning:
Unneeded variable: "ret". Return "0".
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 9 +++--
1 file changed, 3 inser
Fix following checkpatch.pl warning by removing unnecessary braces:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Puranjay Mohan
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
Remove else after break statements to fix following checkpatch.pl
warnings:
WARNING: else is not generally useful after a break or return.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 26 +++
1 file changed, 12 insertions(+), 14 deletions
Fix following checkpatch.pl warning by adding braces around if
statement:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Remove functions which just print the name of function and return 0,
These functions fake the network core to say that they support these
options.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 28 +--
1 file changed, 1 insertion(+), 27
Use "%s", __func__ in place of strings which contain function names.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_T
Change comparison to zero to !x.
Replace (x == 0) to !x.
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8188eu/os_dep/rtw_android.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/rtw_android.c
b/drivers/staging/rtl8188eu/os_dep
Change (x == NULL) to !x and (x != NULL) to x, to fix
following checkpatch.pl warnings:
CHECK: Comparison to NULL could be written "!x".
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
di
Remove functions which return 0 without performing any task.
Fix following warnings issued by coccicheck:
Unneeded variable: "err". Return "0" on line 4484
and similar other warnings.
Signed-off-by: Puranjay Mohan
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 41 --
Use %s and __func__ in place of function names.
This solves following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_do_join', this
function's name, in a string
Signed-off-by: Puranjay Mohan
---
drivers/staging/rtl8188eu/
Use %s and __func__ in place of function names.
This solves following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_do_join', this
function's name, in a string
Signed-off-by: Puranjay Mohan
---
V1: Add staging in the subject.
37 matches
Mail list logo
