[PATCH v2 5/8] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module

2014-04-14 Thread Philipp Zabel
The former has to be done before disabling the DMFC, the latter has to be done afterwards. Otherwise the DMFC FIFOs never get cleared properly. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 68

[PATCH v2 1/8] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts

2014-04-14 Thread Philipp Zabel
This allows to request the DC related interrupts. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 19 +-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/staging/imx-drm

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Philipp Zabel
On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [...] > > Actually what was I thinking, the TVP5150 is already an example of > > such a device. > > > > All of this could be solved if there was some direction information > > in port nodes. > > I disagree. > > Philipp identified

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Philipp Zabel
On Tue, 2017-04-04 at 15:11 -0700, Steve Longerbeam wrote: > > On 03/30/2017 10:25 AM, Philipp Zabel wrote: > > The TVP5150 DT bindings specify a single output port (port 0) that > > corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). > > > >

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-06 Thread Philipp Zabel
On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c > b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644 > index 000..b383be4 > --

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-06 Thread Philipp Zabel
On Wed, 2017-04-05 at 11:53 -0300, Mauro Carvalho Chehab wrote: [...] > There are a number of drivers that can work with different > types of TV demodulators. Typical examples of such hardware can be > found at em28xx, saa7134, cx88 drivers (among lots of other drivers). > Those drivers don't use t

[PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
field order and colorimetry information. Signed-off-by: Philipp Zabel --- This is based on imx-media-staging-md-v14, and it is supposed to allow configuring the pipeline with media-ctl like this: 1) media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY8_1X16/1920x1080]" 2)

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdfor

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > > > On Thu, Apr 06, 2017 at 03:55:29PM +0200, P

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 17:43 +0200, Hans Verkuil wrote: > On 04/06/2017 04:54 PM, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: > >>> If the the field order is set to ANY in set_fmt,

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-13 Thread Philipp Zabel
On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git imx-media-staging-m

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-13 Thread Philipp Zabel
Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and > co

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-13 Thread Philipp Zabel
Hi Sakari, thank you for the review. On Tue, 2017-04-04 at 15:47 +0300, Sakari Ailus wrote: > Hi Steve, Philipp and Pavel, > > On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC inte

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-18 Thread Philipp Zabel
Hi Pavel, On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote: > Hi! > > > > The MUX framework is already in linux-next. Could you use that instead of > > > adding new driver + bindings that are not compliant with the MUX > > > framework? > > > I don't think it'd be much of a change in terms o

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-18 Thread Philipp Zabel
On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote: [...] > >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv, > >> &sdformat->format.height, > >> infmt->height / 4, MAX_H_SRC, > >>

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-05-08 Thread Philipp Zabel
Hi Hans, On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: > Hi Philipp, > > Sorry for the very long delay, but I finally had some time to think about > this. Thank you for your thoughts. > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-05-08 Thread Philipp Zabel
if (tryfmt->quantization == V4L2_QUANTIZATION_DEFAULT) > + tryfmt->quantization = fmt->quantization; According to Hans' latest comments, this could be changed to: --8<------ >From cca3cda9effcaca0891eb8044a79137023fed1c2 Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date:

Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

2017-05-29 Thread Philipp Zabel
On Mon, 2017-05-29 at 15:37 +0200, Hans Verkuil wrote: > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > > > - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX > > > > Signed-off-by:

Re: [PATCH v7 00/34] i.MX Media Driver

2017-05-29 Thread Philipp Zabel
On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: > Hi Steve, > > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > In version 7: > > > > - video-mux: switched to Philipp's latest video-mux driver and updated > >bindings docs, that makes use of the mmio-mux framework. > > > > - mmio-m

Re: [PATCH v8 19/34] media: Add i.MX media core driver

2017-06-09 Thread Philipp Zabel
On Wed, 2017-06-07 at 11:33 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > > Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs. > > Signed-off-by: Philipp Zabel > > Add the bayer formats to im

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input

Re: [PATCH v3 05/24] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > There is a pin conflict with GPIO_6. This pin functions as a power > input pin to the OV5642 camera sensor, but ENET uses it as the h/w > workaround for erratum ERR006687, to wake-up the ARM cores on normal > RX and TX packet done

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 57 > + > 1 file changed, 57 insertions(+) > create mo

Re: [PATCH v3 02/24] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add to the MIPI CSI2 receiver node: compatible string, interrupt sources, > clocks. > > Signed-off-by: Steve Longerbeam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch

Re: [PATCH v3 15/24] media: Add userspace header file for i.MX

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > ---

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/media/v4l-drivers/imx.rst | 443 ++ > drivers/staging/media/Kconfig | 2 + > drivers/stagi

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 11:03 -0800, Steve Longerbeam wrote: > > On 01/13/2017 03:55 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Add bindings documentation for the i.MX media driver. > >> > &

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 15:04 -0800, Steve Longerbeam wrote: > > On 01/13/2017 04:03 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > >> Both

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-16 Thread Philipp Zabel
On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] > >> +Unprocessed Video Capture: > >> +-- > >> + > >> +Send frames directly from sensor to camera interface, with no > >> +conversions: > >> + > >> +-> ipu_smfc -> camif > > I'd call this capture interface, thi

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. s/Serial/Sensor/ > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Kconfig | 13 + > drivers/staging/media/imx/Makefile | 2 + > d

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-20 Thread Philipp Zabel
from a requirement of a customer and is not > > necessary here. > > > > - The FIM must be explicitly enabled in the fim child node under the CSI > > port nodes, using the status property. If not enabled, FIM v4l2 controls > > will not appear in the vide

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-23 Thread Philipp Zabel
On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > > There is a VDIC entity in the i.MX IPU that performs de-interlacing with > > hardware filters for motion compensation. Some of the motion compensation > > modes ("low" and "medium" motion) require that the VDIC receive video > > frame

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-23 Thread Philipp Zabel
Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: > > On 01/16/2017 05:47 AM, Philipp Zabel wrote: > > On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: > > [...] > >>>> +Unprocessed Video Capture: > >>>> +---

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
Hi Steve, Hans, [added Laurent to Cc: who I believe might have an opinion on the media bus formats, too. Sorry for the wall of text, I have put a marker where the MEDIA_BUS argument starts] The central issue seems to be that I think media pad links / media bus formats should describe physical lin

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
On Mon, 2017-01-23 at 12:08 +0100, Hans Verkuil wrote: > On 01/23/2017 12:00 PM, Philipp Zabel wrote: > > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > As long as it is mentioned in the TODO, and ideally in the Kconfig as well, > then I'm fine with it. >

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-23 at 17:45 -0800, Steve Longerbeam wrote: > > On 01/23/2017 05:38 PM, Steve Longerbeam wrote: > > > >> > >>> Second, ignoring the above locking issue for a moment, > >>> v4l2_pipeline_pm_use() > >>> will call s_power on the sensor _first_, then the mipi csi-2 s_power, >

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
On Wed, 2017-01-18 at 17:44 -0800, Steve Longerbeam wrote: > > On 01/14/2017 02:42 PM, Steve Longerbeam wrote: > > > >>> +/* parse inputs property from a sensor node */ > >>> +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, > >>> +struct imx_media_subdev

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Philipp Zabel
Hi Hans, On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 00:01 +, Russell King - ARM Linux wrote: [...] > The iMX6 manuals call for a very specific seven sequence of initialisation > for CSI2, which begins with: > > 1. reset the D-PHY. > 2. place MIPI sensor in LP-11 state > 3. perform D-PHY initialisation > 4. configure CSI2 l

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 17:22 -0800, Steve Longerbeam wrote: > > On 01/30/2017 04:45 PM, Russell King - ARM Linux wrote: > > > > Hi, > > > > Trying this driver with an imx219 camera (which works with Philipp's > > driver) results in not much happening... no /dev/media* node for it, > > no subdevs, n

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > The central issue seems to be that I think media pad links / media bus > > formats should describe physical links, such as parallel or serial > > buses, and the formats of pixels flowing through them, whereas Steve > > would lik

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 13:14 +, Russell King - ARM Linux wrote: > On Tue, Jan 31, 2017 at 11:09:24AM +0100, Philipp Zabel wrote: > > On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > > To help illustrate my point, consider the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6-mipi-csi2':0[1]" media-ctl -l "'imx6-mipi-csi2':1->'ipu1_csi0_mux':0[1]" m

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 14:54 +0100, Philipp Zabel wrote: > Hi Steve, > > I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X > with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some > observations: > > # Link pipeline > media-ctl -l &qu

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] > +static int csi_set_fmt(struct v4l2_subdev *sd, > +struct v4l2_subdev_pad_config *cfg, > +struct v4l2_subdev_format *sdformat) > +{ > + struct csi_priv *priv = v4l2_get_subdevdata(sd); > +

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: > On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > [...] > > +static int csi_set_fmt(struct v4l2_subdev *sd, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] > > # Set pad formats > > media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" > > media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]" > > media-ctl --set-v4l2 "'ipu1_csi0_mux':2[fmt:UYVY2X8/1920x1080]" > > medi

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Wed, 2017-02-01 at 10:11 +, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 10:30:57AM +0100, Philipp Zabel wrote: > > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > > [...] > > > right, need to fix that. Probably by poking the attached >

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-02 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + > drivers/staging/media/imx/imx-mi

Re: [PATCH v3 12/24] add mux and video interface bridge entity functions

2017-02-06 Thread Philipp Zabel
On Sun, 2017-02-05 at 17:36 +0200, Laurent Pinchart wrote: > Hi Steve, > > Thank you for the patch > > On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > --- > > Documenta

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-07 Thread Philipp Zabel
017 04:48 PM, Laurent Pinchart wrote: > > >>> On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: > > >>>> On 01/24/2017 04:02 AM, Philipp Zabel wrote: > > >>>>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > > >>>>

[PATCH] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-02-07 Thread Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel --- This is a patch against the current imx-media-staging-md-wip branch. S_FMT wouldn't update the cropping rectangle d

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-08 Thread Philipp Zabel
Hi Sakari, On Tue, 2017-02-07 at 22:46 +0200, Sakari Ailus wrote: > Hi Steve, > > On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > >

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Philipp Zabel
On Wed, 2017-02-08 at 15:23 -0800, Steve Longerbeam wrote: [...] > >> + > >> +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, > >> + struct v4l2_subdev_pad_config *cfg, > >> + struct v4l2_subdev_format *sdformat) > >> +{ > >> + struct imxcsi2_dev *csi2 =

Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

2017-06-29 Thread Philipp Zabel
return imxsd; + return PTR_ERR(imxsd) == -EEXIST ? NULL : imxsd; or change the code where of_parse_subdev is called (from imx_media_of_parse, and recursively from of_parse_subdev) to not handle the -EEXIST return value as an error. With those fixed, Reviewed-by: Philipp Zabel Tested-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

2017-07-12 Thread Philipp Zabel
media core driver") > Signed-off-by: Arnd Bergmann > --- > v2: fix type mismatch > v3: rework of_parse_subdev() as well. Thanks! Reviewed-by: Philipp Zabel Tested-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 081/102] staging: nvec: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Marc Dietrich Cc: Greg Kroah-Hartman Cc: linux-te...@vger.kernel.org Cc: de...@driverdev.osuosl.org Signed-off-by: Philipp Zabel --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] media: imx: prpencvf: enable double write reduction

2017-07-24 Thread Philipp Zabel
Hi Steve, On Sat, 2017-07-22 at 15:04 -0700, Steve Longerbeam wrote: > Hi Philipp, > > This is the same as your patch to CSI, applied to ic-prpencvf. > > I'm not really sure what this cpmem bit is doing. The U/V planes > in memory are already subsampled by 2 in both width and height. > This must

Re: [PATCH] media: imx: prpencvf: enable double write reduction

2017-07-24 Thread Philipp Zabel
d-off-by: Steve Longerbeam Acked-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] [media] media: imx: use setup_timer

2017-08-14 Thread Philipp Zabel
_id == 0) ? 0 : 2; >   > - init_timer(&priv->eof_timeout_timer); > - priv->eof_timeout_timer.data = (unsigned long)priv; > - priv->eof_timeout_timer.function = csi_idmac_eof_timeout; > + setup_timer(&priv->eof_timeout_timer, csi_

[PATCH 09/11] staging: drm/imx: fix pageflip events during device close

2013-10-10 Thread Philipp Zabel
during a page flip. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 13 + drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b

[PATCH 08/11] staging: drm/imx: ipuv3-crtc: remove unused struct ipu_framebuffer

2013-10-10 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-crtc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index f63931b..292abea 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c +++ b/drivers

[PATCH 01/11] staging: drm/imx: also allow to allocate only 2 DMFC slots for DP full plane

2013-10-10 Thread Philipp Zabel
Connecting a 320x240 parallel display on i.MX6 resulted in an invalid DRDY signal because the DC would not receive NL/EOL events on every line. Reducing the allocated DMFC space from 4 slots (256 * 128-bit) to 2 slots (128 * 128-bit) solved the problem. Signed-off-by: Philipp Zabel --- drivers

[PATCH 06/11] staging: drm/imx: make waiting for idle channel optional

2013-10-10 Thread Philipp Zabel
From: Sascha Hauer Currently we wait for a channel until it's idle before actually disabling it. This is not needed for all channels though, so make waiting for idle a separate function and call it where necessary. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel --- drivers/st

[PATCH 03/11] staging: drm/imx: fix RGB formats, make ipu_cpmem_set_fmt take a drm_fourcc

2013-10-10 Thread Philipp Zabel
internal representation. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 121 +++- 2 files changed, 100 insertions(+), 22 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h b

[PATCH 02/11] staging: drm/imx: make struct ipu_rgb format definitions const

2013-10-10 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 +- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h b/drivers/staging/imx-drm/ipu-v3/imx

[PATCH 04/11] staging: drm/imx: add BGR565 format

2013-10-10 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-common.c index 54466df..f90bdb4 100644 --- a/drivers/staging/imx-drm/ipu

[PATCH 0/11] i.MX RGB565, plane and PRIME support

2013-10-10 Thread Philipp Zabel
Hi, This series fixes DMFC allocation for small displays and pageflip events during device close, clarifies the RGB memory formats, adds support for the RGB565 format and KMS planes, and enables DRM PRIME using the CMA helpers. In the next step, I would like to move the code from drivers/staging/

[PATCH 05/11] staging: drm/imx: Add 24-bit BGR support to DC

2013-10-10 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c index 21bf1c8..1a6e06d 100644 --- a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c

[PATCH 11/11] staging: drm/imx: Enable DRM PRIME support

2013-10-10 Thread Philipp Zabel
Lets the IPU driver make use of the PRIME functionality introduced by the "drm: GEM CMA: Add DRM PRIME support" patch. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 07/11] staging: drm-imx: add DRM_FORMAT_BGR888 to ipu crtc driver

2013-10-10 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index 574633b..f63931b 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c +++ b/drivers

[PATCH 10/11] staging: drm/imx: add drm plane support

2013-10-10 Thread Philipp Zabel
-off-by: Philipp Zabel --- drivers/staging/imx-drm/Makefile| 2 +- drivers/staging/imx-drm/TODO| 1 - drivers/staging/imx-drm/imx-drm-core.c | 5 + drivers/staging/imx-drm/imx-drm.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 2

Re: [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-11-13 Thread Philipp Zabel
Hi Eric, Am Mittwoch, den 13.11.2013, 08:53 +0100 schrieb Eric Bénard: > Hi Russell, > > Le Tue, 12 Nov 2013 17:04:55 +, > Russell King - ARM Linux a écrit : > > On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/dr

[PATCH 2/3] staging: drm/imx: handle framebuffer offsets correctly

2013-12-20 Thread Philipp Zabel
From: Lucas Stach Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipuv3-plane.c b/drivers/staging/imx-drm/ipuv3-plane.c index 685411c..2ef9516

[PATCH 1/3] staging: drm/imx: set second plane base address

2013-12-20 Thread Philipp Zabel
Even though we do not enable the hardware double buffering feature right now, set the second base address pointer (EBA1) as well to increase robustness. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-plane.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[PATCH 3/3] staging: drm/imx: don't drop crtc offsets when doing pageflip

2013-12-20 Thread Philipp Zabel
From: Lucas Stach Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-crtc.c | 3 ++- drivers/staging/imx-drm/ipuv3-plane.c | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging

[PATCH 0/3] imx-drm crtc/plane offset fixes

2013-12-20 Thread Philipp Zabel
These patches fix the issue of frame buffer offsets being forgotten during crtc pageflip. Also we set the second buffer address. Lucas Stach (2): staging: drm/imx: handle framebuffer offsets correctly staging: drm/imx: don't drop crtc offsets when doing pageflip Philipp Zabel (1): st

[RFC PATCH 3/5] gpu: ipu-v3: Add ipu_idmac_get_current_buffer function

2013-12-20 Thread Philipp Zabel
This function returns the currently active buffer (0 or 1) of a double buffered IDMAC channel. It is to be used by the CSI driver. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 9 + include/video/imx-ipu-v3.h | 1 + 2 files changed, 10 insertions(+) diff --git

[RFC PATCH 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2013-12-20 Thread Philipp Zabel
framework, but others, such as the dma controller (IDMAC) and image converter (IC) can be used by both. The IPUv3 core driver provides an internal API to access the modules, to be used by both DRM and V4L2 IPUv3 drivers. Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- drivers/gpu

[RFC PATCH 2/5] gpu: ipu-v3: Add SMFC code

2013-12-20 Thread Philipp Zabel
The Sensor Multi Fifo Controller (SMFC) is used as a buffer between the two CSIs (writing simultaneously) and up to four IDMAC channels. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 10 + drivers/gpu/ipu-v3/ipu-prv.h| 6

[RFC PATCH 4/5] gpu: ipu-v3: Add CSI and SMFC module enable wrappers

2013-12-20 Thread Philipp Zabel
IPU_CONF_..._EN bits are implementation details, not to be made public. Add wrappers around ipu_module_enable/disable, so the CSI V4L2 driver can enable/disable the CSI and SMFC modules. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 24 include

[RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2013-12-20 Thread Philipp Zabel
o move the core code out of staging so that we can start submitting V4L2 code for video capture and scaling / colorspace conversion in parallel. Philipp Zabel (5): gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging gpu: ipu-v3: Add SMFC code gpu: ipu-v3: Add ipu_idmac_get_current_buffer func

[RFC PATCH 5/5] gpu: ipu-v3: Register the CSI modules

2013-12-20 Thread Philipp Zabel
Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 35 +++ include/video/imx-ipu-v3.h | 1 + 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Philipp Zabel
Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now the HPD signal doesn't seem to work, but after overwriting the connection check, I got a stable and correct picture on the monitor: arch/arm/boot/dts/imx6q-sabrelite.dts | 22 ++ 1 file changed, 2

Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-01-03 Thread Philipp Zabel
Am Freitag, den 20.12.2013, 11:12 -0800 schrieb Greg Kroah-Hartman: > On Fri, Dec 20, 2013 at 06:52:41PM +0100, Philipp Zabel wrote: > > Hi, > > > > this is mostly about the first patch, which moves the IPUv3 core code > > (drivers/staging/imx-drm/ipu-v3) to drivers/gp

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Philipp Zabel
Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM Linux: > On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: > > Hi Russell, > > > > I've tested this series on a BD-SL (SabreLite) with HDMI. Right now > > the HPD signal doesn't se

[RFC PATCH 0/3] imx-drm dt bindings

2014-01-06 Thread Philipp Zabel
gards Philipp Philipp Zabel (3): ARM: dts: imx6qdl: Add ports and endpoints to IPU DIs staging: imx-drm-core: Use graph to find connection between crtc and encoder staging: imx-drm-core: associate crtc devices with di port nodes arch/arm/boot/dts/imx6q.dtsi

[RFC PATCH 1/3] ARM: dts: imx6qdl: Add ports and endpoints to IPU DIs

2014-01-06 Thread Philipp Zabel
. The order of endpoints in the ports is arbitrary. Each encoder with an associated input multiplexer has multiple input ports in the device tree. The order and reg property of the ports must correspond to the multiplexer input order. Signed-off-by: Philipp Zabel --- arch/arm/boot/dts/imx6q.dtsi

[RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-01-06 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 44 -- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 2490dc3..2c20434 100644 --- a

[RFC PATCH 3/3] staging: imx-drm-core: associate crtc devices with di port nodes

2014-01-06 Thread Philipp Zabel
. Explicitly converting the void* cookie to the port device tree node allows to get rid of the ipu_id and di_id fields. The multiplexer setting now can be obtained from the port reg property in the device tree. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 62

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Philipp Zabel
Hi Eric, Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: > This is an issue we've seen before. The SABRE Lite board has > a voltage divider on the HPD pins and some monitors (esp. DVI > monitors) either don't drive things high enough to assert HPD or > bounce with connect/disconnect.

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Philipp Zabel
Am Montag, den 06.01.2014, 19:31 -0700 schrieb Eric Nelson: > Hi Russell, > > On 01/06/2014 10:46 AM, Russell King - ARM Linux wrote: > > On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: > >> Hi Eric, > >> > >> Am Freitag, den 03.01.2014, 1

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Philipp Zabel
Am Dienstag, den 07.01.2014, 08:30 -0700 schrieb Eric Nelson: > Hi Philipp, > > On 01/07/2014 04:29 AM, Philipp Zabel wrote: > > Am Montag, den 06.01.2014, 19:31 -0700 schrieb Eric Nelson: > >> Hi Russell, > >> > >> On 01/06/2014 10:46 AM, Russell Ki

[RFC PATCH v2] staging: imx-hdmi: use rx sense status for plug detection if hpd is unreliable

2014-01-10 Thread Philipp Zabel
Due to the voltage divider on the HPD line, the HDMI connector on imx6q-sabrelite doesn't reliably detect connected DVI monitors. This patch allows to use the RX_SENSE0 signal as a workaround when enabled by a boolean device tree property 'hpd-unreliable'. Signed-off-by: Philipp

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-13 Thread Philipp Zabel
Am Samstag, den 11.01.2014, 11:40 + schrieb Russell King - ARM Linux: > On Sat, Jan 11, 2014 at 12:31:19PM +0100, Robert Schwebel wrote: > > On Fri, Jan 10, 2014 at 11:23:37PM +, Russell King - ARM Linux wrote: > > > We do this in DT by providing a "superdevice" node which specifies > > > t

Re: [RFC PATCH v2] staging: imx-hdmi: use rx sense status for plug detection if hpd is unreliable

2014-01-13 Thread Philipp Zabel
Am Samstag, den 11.01.2014, 11:23 +0800 schrieb Shawn Guo: > On Fri, Jan 10, 2014 at 03:22:24PM +0100, Philipp Zabel wrote: > > Due to the voltage divider on the HPD line, the HDMI connector on > > imx6q-sabrelite doesn't reliably detect connected DVI monitors. > > Th

[PATCH] imx-drm: imx-hdmi: move memory and resource allocation into probe function

2014-05-14 Thread Philipp Zabel
the irq only after the interrupt handler mutes are set up, to avoid spurious interrupts. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-hdmi.c | 163 +++-- 1 file changed, 83 insertions(+), 80 deletions(-) diff --git a/drivers/staging/imx-drm/imx

[PATCH v2 5/5] gpu: ipu-v3: Register the CSI modules

2014-05-26 Thread Philipp Zabel
This patch registers the two CSI platform devices per IPU. Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- Changes since RFC: - Rebased onto current staging-next --- drivers/gpu/ipu-v3/ipu-common.c | 37 - include/video/imx-ipu-v3.h | 1

<    1   2   3   4   >