From: Pascal COMBES
Fix alignement issues and two or three other coding style problems in
drivers/staging/crystalhd/crystalhd_lnx.c.
NB: -I did this for task 10 of Eudyptula challenge
<http://eudyptula-challenge.org/>
-I did not address camel case related problem because it
From: Pascal COMBES
Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c.
Signed-off-by: Pascal COMBES
---
As asked I split the patch in three (because I'm addressing 3 types of
problems). I also took into account your last comment: What I did seemmed
better to me, but a
From: Pascal COMBES
Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c:
No space needed before a cast.
Signed-off-by: Pascal COMBES
---
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index fd7f08a..15e8f02 100644
--- a
From: Pascal COMBES
Replace sizeof(type) by sizeof(variable) in
drivers/staging/crystalhd/crystalhd_lnx.c.
Signed-off-by: Pascal COMBES
---
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index 15e8f02..7b14b28 100644
--- a/drivers/staging
Le 13/04/2014 23:36, Paul Bolle a écrit :
> On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote:
>> From: Pascal COMBES
>>
>> Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c:
>> No space needed before a cast.
>>
>> Signed-off-by
Signed-off-by: Pascal COMBES
---
Description in subject.
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index 20be957..fd7f08a 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -112,7
Removed useless (because automatic) cast from void * in crystalhd_lnx.c
Signed-off-by: Pascal COMBES
---
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index fd7f08a..0e432bc 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers
Replace sizeof(type) by sizeof(variable) in crystalhd_lnx.c.
Signed-off-by: Pascal COMBES
---
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index 0e432bc..e6fb331 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging
I changed dereferences from iomem into the adequate ioread function.
Signed-off-by: Pascal COMBES
---
NB: -I didn't replace the old style ioread[bwl] by their newer
equivalents (ioread[8/16/32]). Is it worth?
-I did this for task 16 of the eudyptula challenge.
diff --git a/dr