Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
Hi David, > > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Kairui Song > Cc: Vitaly Kuznetsov > Cc: Andrew Morton > Cc: Matthew Wilcox

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
> >> --- > >> drivers/hv/hv_balloon.c | 14 -- > >> 1 file changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > >> index 211f3fe3a038..47719862e57f 100644 > >> --- a/drivers/hv/hv_balloon.c > >> +++ b/drivers/hv/hv_ballo

Re: [PATCH v1 5/8] hv_balloon: mark inflated pages PG_offline

2018-11-20 Thread Pankaj Gupta
ng, do we need to care for clearing PageOffline flag before > > > freeing > > > a balloon'd page? > > > > Yes we have to otherwise the code will crash when trying to set PageBuddy. > > > > (only one page type at a time may be set right now, and it makes sense. > > A page that is offline cannot e.g. be a buddy page) > > o.k > > > > So PageOffline is completely managed by the page owner. > > Makes sense. Thanks for explaining. Looks good to me. Acked-by: Pankaj gupta ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Pankaj Gupta
23 > #define KPF_ZERO_PAGE24 > #define KPF_IDLE 25 > #define KPF_PGTABLE 26 > diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c > index 37908a83ddc2..6c38d3b862e4 100644 > --- a/tools/vm/page-types.c > +++ b/tools/vm/page-types.c > @@ -133,7 +133,7 @@ static const char * const page_flag_names[] = { > [KPF_NOPAGE]= "n:nopage", > [KPF_KSM] = "x:ksm", > [KPF_THP] = "t:thp", > - [KPF_BALLOON] = "o:balloon", > + [KPF_OFFLINE] = "o:offline", > [KPF_PGTABLE] = "g:pgtable", > [KPF_ZERO_PAGE] = "z:zero_page", > [KPF_IDLE] = "i:idle_page", > -- > 2.17.2 Acked-by: Pankaj gupta > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel