[PATCH 1/2] staging/lustre: use osc_reply_portal for OUT services

2014-09-08 Thread Oleg Drokin
://review.whamcloud.com/8390 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3467 Reviewed-by: wangdi Reviewed-by: Fan Yong Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fld/fld_request.c| 1 + .../lustre/lustre/include/lustre/lustre_idl.h | 2

[PATCH 1/3] staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums

2014-10-11 Thread Oleg Drokin
Old version of lustre (1.8) calculated RPC checksums differently, but the compat code is no longer important since in-kernel version of lustre is nto compatible with 1.8 lustre servers (that are long deprecated too). Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include

[PATCH 3/3] staging/lustre/quota: Get rid of compat quota code

2014-10-11 Thread Oleg Drokin
Nobody should be using any fo the old lustre 1.8 era tools anymore, so drop compatibility with those. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c | 58 -- .../staging/lustre/lustre/llite/llite_internal.h | 18 --- 2 files changed

[PATCH 0/3] Lustre: remove old compat code

2014-10-11 Thread Oleg Drokin
These three patches remove support for code that is no longer needed. Mostly ability to talk to old version of lustre clients and servers. Oleg Drokin (3): staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums staging/lustre: get rid of deprecaed acl mount option code staging

[PATCH 2/3] staging/lustre: get rid of deprecaed acl mount option code

2014-10-11 Thread Oleg Drokin
This is long since unused code, so get rid of it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite

Re: [PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference

2015-09-15 Thread Oleg Drokin
Hello! On Sep 15, 2015, at 9:26 AM, Trevor Woerner wrote: > On 09/14/15 18:41, gr...@linuxhacker.ru wrote: >> Reviewed-on: http://review.whamcloud.com/14605 > > I'm confused why the patch found in this email doesn't match the patch I > find when I click on the above link? Some of the patches in

Re: [PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

2015-09-16 Thread Oleg Drokin
On Sep 16, 2015, at 1:35 AM, Sudip Mukherjee wrote: > On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> Since the client can never be server, this is all dead code. >> >> Signed-off-by: Oleg Drokin >> --- &

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-07 Thread Oleg Drokin
Hello! On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: >> >> This is not a critical bug and in the worst case the code here may >> cause miss of statistics counter increase. >> This is why I think it is not worth to backport the patch at all. > You are right, and if this is just for some r

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-07 Thread Oleg Drokin
On Aug 8, 2014, at 12:42 AM, Greg Kroah-Hartman wrote: > On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: >> Hello! >> >> On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: >>>> >>>> This is not a critical bug and in the wo

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-09 Thread Oleg Drokin
> Because maybe these stats preceed the introduction of perf and other > tracing/debug tools? I don't know, it's really low down on the list of > reasons why lustre can't be merged out of staging at the moment, you all > have much bigger issues to address first. I wonder what is the prioritized

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-11 Thread Oleg Drokin
On Aug 9, 2014, at 11:47 AM, Greg Kroah-Hartman wrote: > On Sat, Aug 09, 2014 at 10:34:36AM -0400, Oleg Drokin wrote: >> >>> Because maybe these stats preceed the introduction of perf and other >>> tracing/debug tools? I don't know, it's really low down

Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-11 Thread Oleg Drokin
On Aug 11, 2014, at 9:58 PM, Oleg Drokin wrote: > > On Aug 10, 2014, at 12:34 AM, Greg KH wrote: >> Very odd, with this patch applied, I now get a build warning: >> >> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’: >> drivers/staging/

[PATCH] staging/lustre/lnet: Fix potential uninitialized variable warning

2014-08-11 Thread Oleg Drokin
value is returned that is then checked before we actually use ipaddrs. Assign ipaddrs to NULL to quiet this. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/config.c b/dr

[PATCH 04/10] staging/lustre/ldlm: drop redundant ibits lock interoperability check

2014-08-15 Thread Oleg Drokin
Reviewed-on: http://review.whamcloud.com/11004 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4971 Reviewed-by: Andreas Dilger Reviewed-by: wangdi Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 1 + drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 50

[PATCH 00/10] Catchup lustre fixes

2014-08-15 Thread Oleg Drokin
aging/lustre/clio: reorder initialization in cl_req_alloc() staging/lustre/llite: hold inode mutex around ll_setattr_raw() Nathaniel Clark (1): staging/lustre/llite: check for integer overflow in hsm user request Oleg Drokin (3): staging/lustre/llite: Fix integer overflow in ll_fid2path l

[PATCH 01/10] staging/lustre/llite: check for integer overflow in hsm user request

2014-08-15 Thread Oleg Drokin
: Andreas Dilger Reviewed-by: John L. Hammond Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_user.h | 23 +- drivers/staging/lustre/lustre/llite/dir.c | 4 +++- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH 07/10] staging/lustre/llite: optimize ll_fid2path()

2014-08-15 Thread Oleg Drokin
iewed-on: http://review.whamcloud.com/11167 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5389 Reviewed-by: John L. Hammond Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 34 ++ .../staging/lustre/lustre/

[PATCH 05/10] staging/lustre/clio: reorder initialization in cl_req_alloc()

2014-08-15 Thread Oleg Drokin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5290 Reviewed-by: Bobi Jam Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/cl_io.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdcla

[PATCH 03/10] staging/lustre/llite: Make sure ft_flags is valid

2014-08-15 Thread Oleg Drokin
wed-on: http://review.whamcloud.com/10956 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5291 Reviewed-by: Bobi Jam Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_internal.h | 4 drivers/staging/lustre/lustre/llite/llite_mmap.c |

[PATCH 02/10] staging/lustre/mdc: cleanup intent if mdc_finish_enqueue() fails

2014-08-15 Thread Oleg Drokin
eviewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c index c64a38e..d02bf31 100644 --- a/drivers/stag

[PATCH 08/10] staging/lustre/llite: Fix integer overflow in ll_fid2path

2014-08-15 Thread Oleg Drokin
Reported by Dan Carpenter outsize = sizeof(*gfout) + gfin->gf_pathlen; Where outsize is int and gf_pathlen is u32 from userspace can lead to integer overflowwhere outsize is some small number less than sizeof(*gfout) Add a check for pathlen to be of sensical size. Signed-off-by: Oleg Dro

[PATCH 06/10] staging/lustre/llite: hold inode mutex around ll_setattr_raw()

2014-08-15 Thread Oleg Drokin
shan Xiong Reviewed-by: Faccini Bruno Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c index fd1b75a3..084fb92 100644 ---

[PATCH 10/10] lustre: Add some basic documentation

2014-08-15 Thread Oleg Drokin
This adds Documentation/filesystems/lustre.txt with some basic information about Lustre and how to use it. Signed-off-by: Oleg Drokin --- Documentation/filesystems/lustre.txt | 87 1 file changed, 87 insertions(+) create mode 100644 Documentation

[PATCH 09/10] lustre: Add MAINTAINERS entry

2014-08-15 Thread Oleg Drokin
Just add the entry with some info. Signed-off-by: Oleg Drokin --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7e2eb4c..369183b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8646,6 +8646,14 @@ W: http://www.lirc.org/ S: Odd

[PATCH 0/2] Getting rid of (some of) lustre typedefs

2014-08-15 Thread Oleg Drokin
f our userspace tools include it), hopefully that's still ok, though? More of this sort of patches will follow after we make sure of the correctness of the end result. Oleg Drokin (2): staging/lustre: get rid of seqno_t and mdsno_t typedefs staging/lustre: get rid of obd_* typedefs drive

[PATCH 2/2] staging/lustre: get rid of obd_* typedefs

2014-08-15 Thread Oleg Drokin
We have a bunch of typedefs for common things that made no sense and hid the actual type from plain view. Replace them with proper uXX or sXX types. Exception is in lustre_idl.h where they are replaced with __uXX and __sXX to be able to be included in userspace Signed-off-by: Oleg Drokin

[PATCH 1/2] staging/lustre: get rid of seqno_t and mdsno_t typedefs

2014-08-15 Thread Oleg Drokin
seqno_t is u64 and mdsno_t is u32 so just use them as such. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c | 6 +++--- drivers/staging/lustre/lustre/fld/fld_cache.c| 16 drivers/staging/lustre/lustre/fld/fld_internal.h

Re: [PATCH 09/10] lustre: Add MAINTAINERS entry

2014-08-17 Thread Oleg Drokin
On Aug 17, 2014, at 12:37 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 15, 2014 at 12:48:14PM -0400, Oleg Drokin wrote: >> Just add the entry with some info. >> >> Signed-off-by: Oleg Drokin >> --- >> MAINTAINERS | 8 >> 1 file changed, 8 insertio

Re: [PATCH 10/10] lustre: Add some basic documentation

2014-08-17 Thread Oleg Drokin
On Aug 17, 2014, at 12:37 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 15, 2014 at 12:48:15PM -0400, Oleg Drokin wrote: >> This adds Documentation/filesystems/lustre.txt with some >> basic information about Lustre and how to use it. >> >> Signed-off-by: Oleg Drok

[PATCH] lustre: Add some basic documentation

2014-08-17 Thread Oleg Drokin
This adds drivers/staging/lustre/README.txt with some basic information about Lustre and how to use it. Eventually this will need to move to Documentation/filesystems/lustre.txt Signed-off-by: Oleg Drokin --- drivers/staging/lustre/README.txt | 87 +++ 1

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread Oleg Drokin
> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > > On Tue, Aug 16 2016, James Simmons wrote: my that’s an old patch > >> >> +static inline bool >> +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md >> *lsm2) >> +{ >> +int idx; >> + >> +if (lsm1->lsm_md_magic !=

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread Oleg Drokin
> On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: >>> >>> On Tue, Aug 16 2016, James Simmons wrote: >> >> my that’s an old patch >> >>

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread Oleg Drokin
> On Feb 11, 2018, at 6:50 PM, NeilBrown wrote: > > Maybe - as you suggest in another email - it is due to some > client/server incompatibility. I guess it is unavoidable with an fs > like lustre to have incompatible protocol changes. Is there any > mechanism for detecting the version of other

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread Oleg Drokin
> On Feb 11, 2018, at 6:44 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: >> >> Certain things that sound useless (like the debug subsystem in Lustre) >> is very useful when you have a 10k nodes in a cluster and need to selectively >>

<    1   2   3   4   5