[PATCH 01/13] staging: mt7621-pci: MIPS/ralink: add MT7621 pcie driver

From: John Crispin NeilBrown: forward port and hack to work on GNUBEE1 Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Makefile|1 drivers/staging/mt7621-pci/Makefile |1 drivers/staging/mt7621-pci/TODO | 12 drivers/staging

[PATCH 13/13] staging: mt7621-dts: add dts files

Add device tree source for mt7621 and gnubee1 to make testing easier. Signed-off-by: NeilBrown --- drivers/staging/Kconfig|2 drivers/staging/Makefile |1 drivers/staging/mt7621-dts/Kconfig |5 drivers/staging/mt7621-dts/Makefile|3

[PATCH 09/13] staging: mt7621-eth: add gigabit switch driver (GSW)

drivers are very basic and only provides basic init and irq support. The SoC and switch core both have support for a special tag making DSA support possible. NeilBrown: - added setting to mt7621_hw_init to match working code from libreCMC This needs to be converted to use switchdev. Signed-off-by

[PATCH 08/13] staging: mt7621-eth: add the drivers core files

(Gigabit switch). Additionally there is a MDIO bus that can be used to talk to PHYs. In these cases one switch port get changed into a normal MAC port. Some SoCs have a dual MAC, we currently only support this on MT7623. NeilBrown: - removed everything not closely related to mt7621, as that is

[PATCH 12/13] staging: mt7621-eth: mediatek: add Kconfig and Makefile

From: John Crispin This patch adds the Makefile and Kconfig required to make the driver build. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2 ++ drivers/staging/Makefile

[PATCH 10/13] staging: mt7621-eth: add mdio support for mt762X family

From: John Crispin NeilBrown: this patch originally contained soc-mt7620.c but as I cannot test that, I removed it. Some functions from mdio-mt7620.c are needed for soc-mt7621.c support - fixed mt7620_has_carrier() to read correct register. Original comment: Add support for SoCs from

[PATCH 11/13] staging: mt7621-eth: add support for mt7621

. MT7621 is the first SoC to have the new QDMA engine builtin. The older PDMA engine is also present. unfortunatley, to get the best performance we need to run RX on PDMA and TX on QDMA. This SoC is also the first to have TX vlan offloading and TSO6 support. NeilBrown: the driver didn't work w

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, NeilBrown wrote: > Hi Greg, > I'd like to submit the following drivers to staging. They > are all for components of the mt7621 MIPS-based SOC from Mediatek. > I lifted them out of libreCMC and (for the ethernet code) out > of email posts from a

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

makes it clear that it is a "pcie driver". What extra detail did you want? Would it be sufficient to just copy the subject line so that it appears twice in the commit message? > > John Crispin's email is j...@phrozen.org. Thanks. NeilBr

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote: >> On Thu, Mar 15 2018, Dan Carpenter wrote: >> >> > This all seems fine. Generally the requirements for staging are that it >> > has a TODO, someone to wor

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

t of staging. I'll add notes to various TODO files based on your comments. If you have anything else to add, it would be most welcome. Thank you for making these patches available in the first place, so that my hardware can work! Thanks, NeilBrown signature.asc Description: PGP signature _

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

On Thu, Mar 15 2018, John Crispin wrote: > On 15/03/18 21:12, NeilBrown wrote: >> On Thu, Mar 15 2018, John Crispin wrote: >> >>> On 15/03/18 11:48, Dan Carpenter wrote: >>>> This all seems fine. Generally the requirements for staging are that it >>&g

Re: [PATCH] staging: lustre: Fix unneeded byte-ordering cast

, LNET_PROTO_TCP_MAGIC) as the condition of the if(). This is consistent with other code that tests magic, and it is consistent with the general understanding that "magic" should be in host-byte-order for the peer which sent the message. Could you resubmit with t

Re: [staging] 184ecc5ceb: BUG:unable_to_handle_kernel

MINOR I'll add a Kconfig rule preventing them from being built together until this is resolved properly. I'll also lok into making the module init routine more robust. Thanks, NeilBrown signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/7] staging: mt7621-dma: Remove assignment in if

han.lock, flags); > I don't like this change. We now call vchan_find_desc() in situations where we didn't before. It isn't a very expensive function so that doesn't matter a lot, but I think it is best not to do this. If you want to remove the warning (and I

Re: [PATCH 0/7] staging: mt7621: Checkpatch cleanup

-- > drivers/staging/mt7621-dma/ralink-gdma.c | 70 > > 2 files changed, 54 insertions(+), 53 deletions(-) > Thanks for these. Except for "Remove assignment in if" which I responded to separately: Reviewed-by: NeilBrown Th

Re: [PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers

e = mediatek_gpio_match, > }, > }; > -- > 2.10.0.GIT Reviewed-by: NeilBrown Thanks, NeilBrown signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 4/7] staging: mt7621-dma: Remove assignment in if

On Wed, Mar 21 2018, Christian Lütke-Stetzkamp wrote: > Fixes checkpatch error: ASSIGN_IN_IF by adding an inner if in the else > path, this also avoids calling vchan_find_desc when not needed. > > Signed-off-by: Christian Lütke-Stetzkamp Thanks. You can add Reviewed-by: NeilBro

Re: [PATCH] staging: lustre: lnet: use correct 'magic' test

nderstanding that 'magic' > should be in host-byte-order for the peer that sent the message. > > Fixes: 80782927e3aa ("staging: lustre: Fix unneeded byte-ordering cast") > Cc: NeilBrown Reviewed-by: NeilBrown thanks, NeilBrown > Signed-off-by: Justin Ski

Re: [PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet, obd}

https://review.whamcloud.com/29741 > Reviewed-by: Andreas Dilger > Reviewed-by: Jian Yu > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons Yes, this is a much better fix than my kconfig change. Reviewed-by: NeilBrown and thanks for your quick review on my last series! Thank

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

On Thu, Mar 29 2018, Chris Coffey wrote: > This fixes the following sparse warning: > > drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol > 'mtk_set_ethtool_ops' was not declared. Should it be static? > > Signed-off-by: Chris Coffey Reviewed-by: N

[PATCH] staging: mt7621-pci: Hack 2 more PCI interrupts for gnubee1

The mt7621-pci support 3 pci devices and has 3 interrupts. Each of these need to be enabled by the same sort of hack to map hwirq number to virq number. This is a hack which will go as soon as I understand how this is supposed to work. Signed-off-by: NeilBrown --- drivers/staging/mt7621-pci

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

On Mon, Apr 02 2018, Sean Wang wrote: > On Mon, 2018-04-02 at 09:34 +1000, NeilBrown wrote: >> On Thu, Mar 29 2018, Chris Coffey wrote: >> >> > This fixes the following sparse warning: >> > >> > drivers/staging/mt7621-eth/ethtool.c:213:6: warning:

<    1   2   3