[PATCH] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-22 Thread Michael Welling
27;pmc_init_seeprom' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:521:1: warning: symbol 'pmc_verify_cksum' was not declared. Should it be static? Also incorporates many indentation and coding style fixes as well as the removal of a volatile varia

[PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH r2 1/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Removes sparse warnings. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -28,6 +28,7

[PATCH r2 2/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10

[PATCH r2 3/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10

[PATCH r2 4/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH r2 5/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepr

[PATCH r2 6/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1

[PATCH r2 7/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
Removes unncessary curly braces. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -133,9

Re: [PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
On Sun, Mar 23, 2014 at 08:58:21AM -0700, Greg Kroah-Hartman wrote: > On Sun, Mar 23, 2014 at 09:01:48AM -0500, Michael Welling wrote: > > This patch series resolves the following sparse warnings: > > > > CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c >

[PATCH v3 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

2014-03-23 Thread Michael Welling
This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH v3 1/7] STAGING: cxt1e1: Remove sparse warnings

2014-03-23 Thread Michael Welling
Removes sparse warnings by including a header and adding static to some functions. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b

[PATCH v3 2/7] STAGING: cxt1e1: Indentation fixes

2014-03-23 Thread Michael Welling
Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10

[PATCH v3 3/7] STAGING: cxt1e1: Fixes comment blocks

2014-03-23 Thread Michael Welling
Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10

[PATCH v3 4/7] STAGING: cxt1e1: Remove volatile variable

2014-03-23 Thread Michael Welling
Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH v3 5/7] STAGING: cxt1e1: Formatting fixes checkpatch issues

2014-03-23 Thread Michael Welling
Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepr

[PATCH v3 6/7] STAGING: cxt1e1: More formatting fixes

2014-03-23 Thread Michael Welling
Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1

[PATCH v3 7/7] STAGING: cxt1e1: Remove curly braces

2014-03-23 Thread Michael Welling
Removes unnecessary curly braces from for loop in eeprom_delay. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging