Follow up patch for "STAGING: comedi: style and checkpatch fixes".
Removes the file name in the comment block per suggestions.
Signed-off-by: Michael Welling
---
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 7a5bf5b..91dea25 100644
--- a/drivers/stag
sily available in the mainline kernel. This is despite
the fact that the hardware is no longer manufactured.
Thanks,
Michael
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
loaded.
> Also, try asking this on the linux-input mailing list
Alright, I'll follow up along this path and see if I can make
something sensible of it.
A rewrite is obviously not the path I would have liked, but it's
probably the better way in the long term.
Thanks,
Michael
Remove unnecessary parentheses from conditionals.
Also clears 'Alignment should match open parenthesis'
checkpatch issue.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_led.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drive
Refactor switch cases in SwLedControlMode1() to reduce
indentation level. Also clears line over 80 characters
checkpatch warnings.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_led.c | 223 ---
1 file changed, 113 insertions
Wrap lines over 80 characters where appropriate to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_led.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c
b/drivers/staging
The the last two parameters of write_cam() have type u8.
Change the type of the passed arrays from unsigned char to u8.
Clears a line over 80 characters checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 +++---
1 file changed, 3 insertions
Remove unnecessary parentheses as reported by checkpatch
and from conditionals.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Use if(!x) instead of if(x == false).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index
Simplify function comments to a single line.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Add missing spaces around '|', '-', and '&' to follow kernel coding
style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --gi
Wrap lines over 80 characters where appropriate to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b
Simpliy calcualation: * 10 / 2 can be reduced to * 5
Also cleans missing spaces checkpatch issues.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core
Replace tabs with spaces or just remove spaces in declarations.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 34 +--
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 26 +--
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Simplify calcualation: * 10 / 2 can be reduced to * 5
Also cleans missing spaces checkpatch issues.
Signed-off-by: Michael Straube
---
changes in v2: fixed typo in patch 1/8 commit message
Simpliy -> Simplify
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +-
1 f
Wrap lines over 80 characters where appropriate to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 26 +--
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Use if(!x) instead of if(x == false).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index
Simplify function comments to a single line.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core
Add missing spaces around '|', '-', and '&' to follow kernel coding
style. Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --gi
Remove unnecessary parentheses as reported by checkpatch
and from conditionals.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Replace tabs with spaces or just remove spaces in declarations.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ioctl_set.c| 34 +--
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers
After the removal of code valid only for 5 GHz the function
Hal_GetChnlGroup88E returns always true.
Change the return type to void and remove the variable bIn24G.
Remove the tests for the return value and the variable bIn24G
from the only user Hal_ReadTxPowerInfo88E().
Signed-off-by: Michael
Remove code valid only for 5 GHz from Hal_GetChnlGroup88E().
This addresses the below TODO item.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Signed-off-by: Michael Straube
---
.../stag
Do not line break function definitions where not needed and
move the return type to the same line.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal
Rename function parameter of Hal_GetChnlGroup88E() to avoid CamelCase.
pGroup -> group
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
There is only one struct in rtw_qos.h and it is only included from
drv_types.h. Move the struct into drv_types.h to reduce the number
of header files.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/drv_types.h | 7 ++-
drivers/staging/rtl8188eu/include/rtw_qos.h
The function rtw_scan_abort() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 23
drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 -
2 files changed, 24 deletions(-)
diff --git a
Do not line break function definition. Clears a checkpatch issue.
CHECK: Lines should not end with a '('
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8
Simplify function comments. Clears a 'line over 80 characters'
checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/r
Rename the return value variable in some functions in rtw_efuse.c
to avoid CamelCase. bRet -> ret
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl818
The variable bContinual is only used to break out of the while loop.
Remove the variable and use break instead.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
exist.
Remove get_right_chnl_for_iqk() and the variable chn_index that is
used to save the return value. Replace the uses of chn_index with zero.
Remove the now unused define ODM_TARGET_CHNL_NUM_2G_5G.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/phy.c
Rename source and header file to avoid CamelCase.
odm_HWConfig.c -> odm_hwconfig.c
odm_HWConfig.h -> odm_hwconfig.h
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/Makefile | 2 +-
.../staging/rtl8188eu/hal/{odm_HWConfig.c => odm_hwconfig.
Rename variable in odm_SignalScaleMapping() to avoid CamelCase.
RetSig -> retsig
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Replace tabs with spaces in odm_hwconfig.c where appropriate.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/drivers/staging/rtl8188eu/hal
Rename parameter of odm_EVMdbToPercentage() to avoid CamelCase.
Value -> value
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/drivers/stag
Remove unnecessary parentheses in odm_rtl8188e.c.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
b/drivers/staging
Rename parameter of odm_SignalScaleMapping() to avoid CamelCase.
CurrSig -> currsig
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 31 ++--
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Rename odm_SignalScaleMapping to avoid CamelCase.
odm_SignalScaleMapping -> odm_signal_scale_mapping
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Rename odm_QueryRxPwrPercentage() to avoid CamelCase.
odm_QueryRxPwrPercentage -> odm_query_rxpwrpercentage
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
The function odm_SignalScaleMapping() is just a wrapper for
odm_SignalScaleMapping_92CSeries().
Rename odm_SignalScaleMapping_92CSeries() to odm_SignalScaleMapping()
and remove the wrapper.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 7 +--
1 file
Fix a spelling mistake reported by checkpatch.
Caculate -> Calculate
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
b/drivers/staging/rtl8188eu/
Add spaces around '*' in odm_hwconfig.c to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl
Add spaces around '+' in odm_hwconfig.c to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_
Correct block comment to clear a checkpatch warning.
WARNING: Block comments should align the * on each line
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal
Add spaces around '+' in fw.c to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/fw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging
Cleanup all inconsistent indenting reported by smatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c| 2 +-
.../staging/rtl8188eu/core/rtw_ieee80211.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_led.c | 4 ++--
drivers/staging/rtl8188eu/core
Remove braces from single line if statement.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
b/drivers/staging/rtl8188eu
Simplify block comment to a single line to clear a checkpatch warning.
WARNING: Block comments use * on subsequent lines
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/pwrseq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu
Rename odm_EVMdbToPercentage() to avoid CamelCase.
odm_EVMdbToPercentage -> odm_evm_db_to_percentage
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Rename parameter of odm_QueryRxPwrPercentage() to avoid CamelCase.
AntPower -> antpower
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
This satisfies a checkpatch warning and is the preferred
method for notating the license.
The SPDX identifier is a legally binding shorthand, which
can be used instead of the full boiler plate text.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8712/basic_types.h | 10
Rewrite if tests to clear a 'line over 80 characters' and
'Comparisons should place the constant on the right side of the test'
checkpatch warning.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 del
Line break array declaration to clear a 'line over 80 characters'
checkpatch warning. For consistency replace 0x0 with 0x00.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drive
Cleanup array declaration to clear two 'line over 80 characters'
checkpatch warnings and improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 32 ---
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git
On 10/3/18 11:30 PM, Joe Perches wrote:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Cleanup array declaration to clear two 'line over 80 characters'
checkpatch warnings and improve readability.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drive
On 10/3/18 11:30 PM, Joe Perches wrote:
static struct mlme_handler mlme_sta_tbl[] = {
Perhaps const here too, and as well, the struct
declaration could use const char * instead of char *
Making it const gives following warning.
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function
Am 03.10.18 um 23:26 schrieb Joe Perches:
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
Line break array declaration to clear a 'line over 80 characters'
checkpatch warning. For consistency replace 0x0 with 0x00.
[]
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlm
Change the type of MCS_rate_1R from unsigned char to const u8.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
NOTE:
This series depends on the previous sent series.
[1/3] staging: rtl8188eu: fix line over 80 characters - style
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2
Remove spaces and/or replace tabs with spaces in some declarations
in rtw_mlme_ext.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
The strings in the use of struct action_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
The strings in the uses of struct mlme_handler are constant.
Change the type of field str from 'char *' to 'const char *'.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
1 file changed, 1 insertion(+),
Add spaces around '|', '>>' and '/' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff -
The variable AntCombination is initialized to 2 and never changed.
So the else if path is never used. Remove the dead code and the
variable AntCombination.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 38
1 file changed, 7 insertions
Clear 'line over 80 characters' checkpatch warnings by adding
appropriate line breaks and moving a comment.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drive
Use __func__ instead of hardcoded function name in rtw_xmit_entry().
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Replace tabs with spaces and/or remove extra spaces where
appropriate.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
b/drivers
Add spaces around '*' and '/' to follow kernel coding style.
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmi
This series clears most of the remaining style/checkpatch issues
in the file os_dep/xmit_linux.c.
Michael Straube (4):
staging: rtl8188eu: use __func__ instead of hardcoded name - style
staging: rtl8188eu: add spaces around operators - style
staging: rtl8188eu: cleanup lines over 80
Cleanup block comments to clear 'please, no space before tabs'
and 'line over 80 characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
Clear a 'Alignment should match open parenthesis'
checkpatch issue.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8
Use __func__ instead of hardcoded name in qos_acm().
Reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu
Clear all missing spaces around operators checkpatch issues
in the file core/rtw_xmit.c. Use '+=' or '-=' where possible.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 60 ++-
1 file changed, 36 insertions(+), 24 deleti
Cleanup style/checkpatch issues in the file core/rtw_xmit.c.
Michael Straube (8):
staging: rtl8188eu: cleanup missing spaces around operators
staging: rtl8188eu: use __func__ in qos_acm()
staging: rtl8188eu: cleanup alignment issue
staging: rtl8188eu: remove commented code
staging
Remove whitespace in qos_acm() to improve readability.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
Remove unused commented code in the file core/rte_xmit.c.
Clears 'please, no space before tabs' and 'line over 80
characters' checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++-
1 file changed,
Line break lines over 80 characters in stop_sta_xmit() to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b
Line break lines over 80 characters in rtw_get_sta_pending() to
clear checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
Rename parameters of HalSetBrateCfg() in header to avoid CamelCase
and match the names used in the function definition in hal_com.c.
mBratesOS -> brates
BrateCfg -> rate_cfg
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file changed, 1 insertion
Rename parameter of hal_com_get_channel_plan() in header to avoid
CamelCase and match the name used in the function definition in
hal_com.c. AutoLoadFail -> load_fail
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file changed, 1 insertion(+)
Rename HalSetBrateCfg() to avoid CamelCase.
HalSetBrateCfg -> hal_set_brate_cfg
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 files changed
The parameter 'struct adapter *padapter' of hal_com_get_channel_plan()
is unused, so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 5 ++---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 +--
drivers/staging/rtl8188eu/include
Remove extra space in variable declaration.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_com.c
b/drivers/staging/rtl8188eu/hal/hal_com.c
index 6db5c34ed02e
Rename Hal_MappingOutPipe() to avoid CamelCase.
Hal_MappingOutPipe -> hal_mapping_out_pipe
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 fi
The parameter 'struct adapter *adapt' of HalSetBrateCfg() is unused,
so remove it.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_com.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
3 files
Rename parameters of Hal_MappingOutPipe() in header to avoid CamelCase
and match the names used in the function definition in hal_com.c.
pAdapter -> adapter
NumOutPipe -> numoutpipe
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
1 file chan
Cleanup remaining comparsions to false.
if(x == false) -> if(!x)
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 12 ++--
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 ---
driv
s rbi->ring_buffer in this case, which remains NULL
> until vmbus_open populates it.
>
> A simple reproduce, with a modular kernel, is to boot with init=/bin/bash
> head /sys/bus/vmbus/devices/*/channels/*/*
>
There are multiple race conditions with this and o
Use clamp() to simplify code in odm_evm_db_to_percentage().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/drivers/staging
Rename the variable Max_spatial_stream to avoid CamelCase.
Max_spatial_stream -> max_spatial_stream
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/driv
The variable is_cck_rate is used for boolean values, so change the
type from u8 to bool. The initializations to zero and use of ternary
operator in the assignments are unnecessary, remove them as well.
Suggested-by: Joe Perches
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
b/driv
Use clamp() to simplify code in odm_evm_db_to_percentage().
Signed-off-by: Michael Straube
---
v1 -> v2:
Added patch with suggestions from Joe Perches applied.
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --gi
Rename the variable Max_spatial_stream to avoid CamelCase.
Max_spatial_stream -> max_spatial_stream
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
On 10/21/18 2:26 PM, Joe Perches wrote:
It would be sensible to convert is_cck_rate from u8 to bool at the
same
time and remove the ternary ? true : false too.
As well, perhaps remove its apparently unnecessary initialization.
I've added a patch and resent the series. Thank you.
Mi
global state in struct hv_context.
> Get rid of this state in struct hv_context.
>
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/hv/hv.c | 10 +++---
> drivers/hv/hyperv_vmbus.h | 2 --
> 2 files changed, 3 insertions(+), 9 deletio
Srinivasan
> ---
> drivers/hv/hv_kvp.c | 26 ++
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
Reviewed-by: Michael Kelley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1 - 100 of 1079 matches
Mail list logo
