Re: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function

2015-11-09 Thread Michał Kępień
> Remove the function ll_finish_md_op_data() and replace all its calls > with the standrd function ll_finish_md_op_data(). I believe you meant to write "standard function kfree()". -- Best regards, Michał Kępień ___ devel

[PATCH] staging: ft1000: ft1000-usb: ft1000_hw.c: fix long lines

2015-06-16 Thread Michał Kępień
Fix checkpatch.pl warnings about lines longer than 80 characters. Signed-off-by: Michał Kępień --- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 58 - 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b

Re: [PATCH] Staging: fbtft: Use BIT macro

2015-10-06 Thread Michał Kępień
G_MKDIRTY BIT(24) > +#define DEBUG_UPDATE_DISPLAYBIT(25) > +#define DEBUG_INIT_DISPLAY BIT(26) > +#define DEBUG_BLANK BIT(27) > +#define DEBUG_REQUEST_GPIOS BIT(28) > +#define DEBUG_FREE_GPIOSBIT(29) > +#define DEBUG_REQUEST_GPIOS_MATCH BIT(30) > +#define DEBUG_VERIFY_GPIOS BIT(31) Why did you replace spaces with tabs only in the first hunk of your patch? -- Best regards, Michał Kępień ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof used

2015-10-08 Thread Michał Kępień
1t_8188e)/sizeof(u32); > + const u32 arraylen = ARRAY_SIZE(array_agc_tab_1t_8188e); Neither your subject nor your (non-existent) commit message mentions the const qualifier. This should be done in a separate patch, however you might first want to pon

[PATCH] staging: unisys: make visorbus_dev_groups static

2015-08-11 Thread Michał Kępień
visorbus_dev_groups is not referenced outside visorbus_main.c, so it can be declared static. Found using sparse. Signed-off-by: Michał Kępień --- drivers/staging/unisys/visorbus/visorbus_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys

Re: [PATCH] staging: sm750fb: replace twoToPowerOfx with shift operator

2015-09-24 Thread Michał Kępień
a line in a patch, you should make sure it doesn't raise any checkpatch warnings afterwards. Don't take my word for it, though. -- Best regards, Michał Kępień ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel