[PATCH v3 8/8] Staging: bcm: Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 276825f..bef13a6 100644 --- a/drivers/staging/bcm

[PATCH v3 5/8] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 2f540d6..bda33c8 100644 --- a/drivers

[PATCH v3 0/8] Cleanup patches for bcm staging driver

Hi, hopefully, this is the last version of the patchset. I fixed up my `sed` error and test compiled the module. Please notice: I cannot test the patches as I do not have the appropriate hardware. Kind regards, Matthias Beyer Matthias Beyer (8): Staging: bcm: Shortened some lines Staging

[PATCH v3 4/8] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e1a3e6d..2f540d6 100644 --- a/drivers

[PATCH 1/6] Staging: bcm: Misc whitespace fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index f1d7cb8..b4f0ea3 100644 --- a/drivers/staging/bcm/DDRInit.c +++ b/drivers/staging/bcm

[PATCH 4/6] Staging: bcm: Fixed indention for inner if-block

I'm destroying logical seperated checks with it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index cfaa2c1..d13cb49 100644 --- a

[PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 423bfd9..4564f40 100644 --- a/drivers/staging/bcm/DDRInit.c

[PATCH 3/6] Staging: bcm: Lines shortened in ddr_init()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 176 -- 1 file changed, 134 insertions(+), 42 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 4c7f518..cfaa2c1 100644 --- a/drivers/staging/bcm

[PATCH 2/6] Staging: bcm: Indentation fixes

This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm

[PATCH 5/6] Staging: bcm: Moved doubled if-block

This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 16 +--- 1 file changed, 5 insertions

[PATCH 0/6] drivers/staging/bcm/DDRInit.c cleanup patches

them, at least. Kind regards, Matthias Beyer Matthias Beyer (6): Staging: bcm: Misc whitespace fixes Staging: bcm: Indentation fixes Staging: bcm: Lines shortened in ddr_init() Staging: bcm: Fixed indention for inner if-block Staging: bcm: Moved doubled if-block Staging: bcm: Lines shor

Re: [PATCH v3 0/8] Cleanup patches for bcm staging driver

Hi, these patches are still not applied, am I right? Should I (rebase and) resend them? On 12-06-2014 14:13:16, Matthias Beyer wrote: > Hi, > > hopefully, this is the last version of the patchset. > > I fixed up my `sed` error and test compiled the module. > > Please

Re: [PATCH v4 0/2] Staging: bcm: InterfaceMisc. file cleanup

Hi, these patches are not applied yet, right? Should I (rebase and) resend them? On 11-06-2014 10:46:09, Matthias Beyer wrote: > Hi, > > I fixed what Dan suggested. > > Kind regards, > Matthias Beyer > > Matthias Beyer (2): > Staging: bcm: Shortened lines >

[PATCH 04/15] Staging: bcm: led_control.c: Simplified nested if conditions

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 612e61e..f528a45 100644 --- a/drivers

[PATCH 01/15] Staging: bcm: led_control.c: Indentation/Whitespace/Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 138 ++ 1 file changed, 79 insertions(+), 59 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index eee4f47..fd73dbd 100644 --- a/drivers

[PATCH 07/15] Staging: bcm: led_control.c: Refactored variable name

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 5060bad..9808f53 100644 --- a/drivers/staging/bcm/led_control.c

[PATCH 08/15] Staging: bcm: led_control.c: Removed dead code

This patch removes the never-entered else-block inside blink_in_normal_bandwidth(). The condition of the preceding if statement is always true. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 98 +++ 1 file changed, 37 insertions(+), 61

[PATCH 00/15] staging/bcm/led_control.c cleanup patches

Hardware, I cannot test these patches. I compiled them at least. Best regards, Matthias Beyer Matthias Beyer (15): Staging: bcm: led_control.c: Indentation/Whitespace/Line length cleanup Staging: bcm: led_control.c: Outsourced adapter driver state handling Staging: bcm: led_control.{c,h

[PATCH 02/15] Staging: bcm: led_control.c: Outsourced adapter driver state handling

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 325 -- 1 file changed, 171 insertions(+), 154 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index fd73dbd..3b3775b 100644 --- a/drivers

[PATCH 06/15] Staging: bcm: led_control.c: Outsourced code chunk

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 159 ++ 1 file changed, 93 insertions(+), 66 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 085493a..5060bad 100644 --- a/drivers

[PATCH 03/15] Staging: bcm: led_control.{c,h}: Fixed macro

This patch fixes the TURN_{ON,OFF}_LED() macros by adding the adapter as parameter. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 39 +++ drivers/staging/bcm/led_control.h | 16 2 files changed, 31 insertions(+), 24

[PATCH 09/15] Staging: bcm: led_control.c: Refactored line lengths

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 4cf4212..c0509ae 100644 --- a/drivers/staging/bcm

[PATCH 05/15] Staging: bcm: led_control.c: Replaced member accessing

This patch replaces member accessing with a variable in BcmGetGPIOPinInfo(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm

[PATCH 15/15] Staging: bcm: led_control.c: Replaced nested ifs with logical AND concatenation

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 8e6bb6b..8353677 100644 --- a/drivers/staging/bcm/led_control.c

[PATCH 14/15] Staging: bcm: led_control.c: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 4077972..8e6bb6b 100644 --- a/drivers/staging/bcm/led_control.c

[PATCH v4 0/8] [RESEND] Cleanup patches for staging driver

e hardware. Kind regards, Matthias Beyer Matthias Beyer (8): Staging: bcm: Shortened some lines Staging: bcm: replaced member accessing by variable Staging: bcm: Replaced member accessing with variable in device_run() Staging: bcm: Replaced member accessing with variable in InterfaceA

[PATCH v4 2/8] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..dd7b4a5 100644 --- a/drivers/staging/bcm

[PATCH v4 4/8] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e1a3e6d..2f540d6 100644 --- a/drivers

[PATCH v4 5/8] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 2f540d6..bda33c8 100644 --- a/drivers

[PATCH v4 1/8] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b

[PATCH v4 6/8] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff

[PATCH v4 3/8] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index dd7b4a5..e1a3e6d 100644 --- a/drivers/staging/bcm

[PATCH v4 7/8] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 9f9045d..276825f 100644 --- a/drivers

[PATCH 10/15] Staging: bcm: led_control.c: More variable names refactored

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index c0509ae..a387c6a 100644 --- a/drivers/staging/bcm

[PATCH v4 8/8] Staging: bcm: Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 276825f..bef13a6 100644 --- a/drivers/staging/bcm

[PATCH 11/15] Staging: bcm: led_control.c: Replaced time selecting ifelse with ternary operator

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index a387c6a..8a59115 100644 --- a/drivers/staging/bcm/led_control.c +++ b/drivers

[PATCH 1/4] Staging: bcm: line length fixed

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 495fe3d..467b0cf 100644 --- a/drivers/staging/bcm

[PATCH 2/4] Staging: bcm: Whitespace for indentation fixed

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 467b0cf..45d18de 100644 --- a/drivers/staging/bcm

[PATCH 4/4] Staging: bcm: Added missing blank line after declarations

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 6552b15..5455221 100644 --- a/drivers/staging/bcm/HandleControlPacket.c

[PATCH 0/4] drivers/staging/bcm/HandleControlPacket.c cleanup patches

Hi, this patchset contains cleanup patches for the drivers/staging/bcm/HandleControlPacket.c file. Please note: As I do not have the appropriate hardware, I cannot test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (4): Staging: bcm: line length

[PATCH 3/4] Staging: bcm: Replaced member accssing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 45d18de..6552b15 100644 --- a/drivers

[PATCH 13/15] Staging: bcm: led_control.c: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index ae49a59..4077972 100644 --- a/drivers/staging/bcm

[PATCH 12/15] Staging: bcm: led_control.c: Replaced doubled if-check by logical OR in one check

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 8a59115..ae49a59 100644 --- a/drivers/staging/bcm/led_control.c +++ b

[PATCH 0/4] stagign/bcm/hostmibs.c cleanup patches

able to test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (4): Staging: bcm: replaced member accessing with variable for readability Staging: bcm: Outsourced copying of classifier table Staging: bcm: Outsourced SF table copying Staging: bcm: hostm

[PATCH 3/4] Staging: bcm: Outsourced SF table copying

This commit includes renaming of variables which got outsourced into an own function to fit the kernel styleguide. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 70 +++--- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a

[PATCH 4/4] Staging: bcm: hostmibs.c: Shortened lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index 63bfb04..9ffd25b 100644 --- a/drivers/staging/bcm

[PATCH 2/4] Staging: bcm: Outsourced copying of classifier table

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index af3493c..13c1430 100644 --- a/drivers/staging/bcm/hostmibs.c

[PATCH 1/4] Staging: bcm: replaced member accessing with variable for readability

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index 42d9004..af3493c 100644 --- a/drivers/staging/bcm/hostmibs.c +++ b

Re: [PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

On 23-06-2014 13:44:22, j...@joshtriplett.org wrote: > On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote: > > Signed-off-by: Matthias Beyer > > As with the previous line-wrapping patch, this doesn't seem like a net > improvement; the lines seem far more readab

Question about patches for bcm

[0]: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-June/052454.html -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpq14tVrMdHv.pgp Description: PGP signature ___ devel maili

Re: Question about patches for bcm

On 26-06-2014 10:58:20, Kevin McKinney wrote: >On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer >wrote: > > Hi, > > I have a question related to some patches I send in. > > (I send them to de...@driverdev.osuosl.org, but they show up in the >

Re: Question about patches for bcm

/2014-June/thread.html On 26-06-2014 11:11:40, Kevin McKinney wrote: >On Thu, Jun 26, 2014 at 11:02 AM, Matthias Beyer >wrote: > > On 26-06-2014 10:58:20, Kevin McKinney wrote: > > A A On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer > > > A

[PATCH v2 1/6] Staging: bcm: Misc whitespace fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index f1d7cb8..cdd1029 100644 --- a/drivers/staging/bcm

[PATCH v2 3/6] Staging: bcm: Fixed indention for inner if-block

I'm destroying logical seperated checks with it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 4c7f518..ac45ead 100644 --- a

[PATCH v2 5/6] Staging: bcm: Lines shortened in ddr_init()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 176 -- 1 file changed, 134 insertions(+), 42 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index d2646d9..423bfd9 100644 --- a/drivers/staging/bcm

[PATCH v2 2/6] Staging: bcm: Indentation fixes

This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers

[PATCH v2 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 423bfd9..4564f40 100644 --- a/drivers/staging/bcm/DDRInit.c

[PATCH v2 0/6] drivers/staging/bcm/DDRInit.c cleanup patches

with possible merge conflicts Please review again. Matthias Beyer (6): Staging: bcm: Misc whitespace fixes Staging: bcm: Indentation fixes Staging: bcm: Fixed indention for inner if-block Staging: bcm: Moved doubled if-block Staging: bcm: Lines shortened in ddr_init() Staging: bcm

[PATCH v2 4/6] Staging: bcm: Moved doubled if-block

This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 16 +--- 1 file changed, 5 insertions

Re: Question about patches for bcm

eundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpPkdrX5SLuW.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo

[PATCH 0/4] drivers/staging/bcm/InterfaceRx.c cleanup patches

at least. Kind regards, Matthias Beyer Matthias Beyer (4): Staging: bcm: InterfaceRx.c: Lines shortened Staging: bcm: InterfaceRx.c: Outsourced control packet handling Staging: bcm: InterfaceRx.c: Outsourced code chunk Staging: bcm: InterfaceRx.c: Removed unused variable drivers/staging

[PATCH 1/4] Staging: bcm: InterfaceRx.c: Lines shortened

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceRx.c | 87 --- 1 file changed, 62 insertions(+), 25 deletions(-) diff --git a/drivers/staging/bcm/InterfaceRx.c b/drivers/staging/bcm/InterfaceRx.c index 1100817..9d6e1d0 100644 --- a/drivers

[PATCH 3/4] Staging: bcm: InterfaceRx.c: Outsourced code chunk

This patch outsources a chunk of code into a function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceRx.c | 129 +- 1 file changed, 71 insertions(+), 58 deletions(-) diff --git a/drivers/staging/bcm/InterfaceRx.c b/drivers/staging/bcm

[PATCH 2/4] Staging: bcm: InterfaceRx.c: Outsourced control packet handling

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceRx.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/staging/bcm/InterfaceRx.c b/drivers/staging/bcm/InterfaceRx.c index 9d6e1d0..47b6de7 100644 --- a/drivers

[PATCH 4/4] Staging: bcm: InterfaceRx.c: Removed unused variable

This patch removes the `process_done` variable from both format_eth_hdr_to_stack() and read_bulk_callback() (where it is declared), as it is not used anywhere (it is set in the format_eth_hdr_to_stack() function, but afterwards not used). Signed-off-by: Matthias Beyer --- drivers/staging/bcm

[PATCH 0/3] drivers/staging/bcm/InterfaceTx.c cleanup patches

piled them at least. Kind regards, Matthias Beyer Matthias Beyer (3): Staging: bcm: InterfaceTx.c: Shortened lines + Whitespace cleanup Staging: bcm: InterfaceTx.c: Outsourced code chunk Staging: bcm: InterfaceTx.c: checkpath fix: Blank line after declarations drivers/staging/bcm/Interfac

[PATCH 2/3] Staging: bcm: InterfaceTx.c: Outsourced code chunk

This patch outsources a chunk of code into an own function and refactors the variable names inside the new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceTx.c | 165 +++--- 1 file changed, 84 insertions(+), 81 deletions(-) diff --git a

[PATCH 3/3] Staging: bcm: InterfaceTx.c: checkpath fix: Blank line after declarations

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceTx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/InterfaceTx.c b/drivers/staging/bcm/InterfaceTx.c index 89e9e79..9b3f64b 100644 --- a/drivers/staging/bcm/InterfaceTx.c +++ b/drivers

[PATCH 1/3] Staging: bcm: InterfaceTx.c: Shortened lines + Whitespace cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceTx.c | 86 +++ 1 file changed, 61 insertions(+), 25 deletions(-) diff --git a/drivers/staging/bcm/InterfaceTx.c b/drivers/staging/bcm/InterfaceTx.c index ea7707b..b1f2899 100644 --- a/drivers

[PATCH 5/5] Staging: bcm: LeakyBucket.c: Removed unneccessary return; statement

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/LeakyBucket.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c index f2852c9..8c4030d 100644 --- a/drivers/staging/bcm/LeakyBucket.c +++ b/drivers/staging/bcm

[PATCH 1/5] Staging: bcm: LeakyBucket.c: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/LeakyBucket.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c index f95b067..151f620 100644 --- a/drivers/staging/bcm

[PATCH 4/5] Staging: bcm: LeakyBucket.c: Outsourced ctrl packet sending

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/LeakyBucket.c | 76 --- 1 file changed, 40 insertions(+), 36 deletions(-) diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c index 0d1a6e5..f2852c9 100644 --- a/drivers

[PATCH 2/5] Staging: bcm: LeakyBucket.c: Shortened lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/LeakyBucket.c | 153 ++ 1 file changed, 104 insertions(+), 49 deletions(-) diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c index 151f620..1151c83 100644 --- a/drivers

[PATCH 3/5] Staging: bcm: LeakyBucket.c: Outsourced code chunk into function

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/LeakyBucket.c | 146 +++--- 1 file changed, 74 insertions(+), 72 deletions(-) diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c index 1151c83..0d1a6e5 100644 --- a/drivers

[PATCH 0/5] drivers/staging/bcm/LeakyBucket.c cleanup patches

hardware, I'm not able to test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (5): Staging: bcm: LeakyBucket.c: Replaced member accessing by variable Staging: bcm: LeakyBucket.c: Shortened lines Staging: bcm: LeakyBucket.c: Outsourced code chunk

[PATCH v5 2/2] Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 69 + 1 file changed, 31 insertions(+), 38 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c index fff7d68..a0f159e 100644 --- a/drivers

[PATCH v5 1/2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm

[PATCH v5 0/2] [RESEND] drivers/staging/bcm/InterfaceMisc.c cleanup

Hi, this is a resend of my (rebased) patchset for the drivers/staging/bcm/InterfaceMisc.c file, which is not yet applied. Please note: As I do not have the approrpiate hardware, I'm not able to test these changes. I compiled them at least. Kind regards, Matthias Beyer Matthias Bey

Re: [PATCH] staging: bcm: add missing blank lines after declarations

ed = 0; > PUCHAR pcBuffer = (PUCHAR)pBuffer; /* char > pointer to take care of odd byte cases. */ > + > uiNumBytes -= (EEPROM_CALPARAM_START - > uiOffset); > ulBytesTobeSkipped +=

[PATCH 00/38] drivers/staging/bcm/Bcmchar.c variable rename patchset

Hi, this is my variable rename patchset for the drivers/staging/bcm/Bcmchar.c file. Note, as always: As I do not have the appropriate hardware, I cannot test these patches, but I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (38): Staging: bcm: Bcmchar.c: Renamed

[PATCH 01/38] Staging: bcm: Bcmchar.c: Renamed variable: "Adapter" -> "ad"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 904 +- 1 file changed, 452 insertions(+), 452 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 8b23ec9..78b09cb 100644 --- a/drivers/staging

[PATCH 04/38] Staging: bcm: Bcmchar.c: Renamed variable: "uiBit" -> "bit"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 404a39a..0c2885b 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm

[PATCH 02/38] Staging: bcm: Bcmchar.c: Renamed variable: "threadReq" -> "thread_req"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 78b09cb..ff55056 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm

[PATCH 03/38] Staging: bcm: Bcmchar.c: Renamed variable: "IoBuffer" -> "io_buff"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 252 +- 1 file changed, 126 insertions(+), 126 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index ff55056..404a39a 100644 --- a/drivers/staging

[PATCH 05/38] Staging: bcm: Bcmchar.c: Renamed variable: "ucRead" -> "read"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 0c2885b..15410cd 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm

[PATCH 06/38] Staging: bcm: Bcmchar.c: Renamed variable: "Status" -> "status"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 462 +- 1 file changed, 231 insertions(+), 231 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 15410cd..627498e 100644 --- a/drivers/staging

[PATCH 08/38] Staging: bcm: Bcmchar.c: Renamed variable: "pvBuffer" -> "buff"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 32ae6ee..ffb842f 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b

[PATCH 09/38] Staging: bcm: Bcmchar.c: Renamed variable: "ulSFId" -> "sf_id"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index ffb842f..a831a27 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm

[PATCH 19/38] Staging: bcm: Bcmchar.c: Renamed variable: "pReadData" -> "read_data"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index a588a5f..58bfa46 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers

[PATCH 07/38] Staging: bcm: Bcmchar.c: Renamed variable: "ucResetValue" -> "reset_val"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 627498e..32ae6ee 100644 --- a/drivers/staging/bcm/Bcmchar.c

[PATCH 23/38] Staging: bcm: Bcmchar.c: Renamed variable: "ReadBytes" -> "read_bytes"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 7e0aa5f..be14490 100644 --- a/drivers/staging/bcm

[PATCH 22/38] Staging: bcm: Bcmchar.c: Renamed variable: "BuffSize" -> "buff_size"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index be1f4ec..7e0aa5f 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b

[PATCH 26/38] Staging: bcm: Bcmchar.c: Renamed variable: "InputAddr" -> "input_addr"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index eda1ba6..0698ca5 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm

[PATCH 25/38] Staging: bcm: Bcmchar.c: Renamed variable: "pWriteBuff" -> "write_buff"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 964ab91..eda1ba6 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers

[PATCH 24/38] Staging: bcm: Bcmchar.c: Renamed variable: "WriteBytes" -> "write_bytes"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index be14490..964ab91 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b

[PATCH 20/38] Staging: bcm: Bcmchar.c: Renamed variable: "sFlash2xRead" -> "flash_2x_read"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 58bfa46..28188c7 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b

[PATCH 27/38] Staging: bcm: Bcmchar.c: Renamed variable: "WriteOffset" -> "write_off"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 0698ca5..5730b26 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging

[PATCH 28/38] Staging: bcm: Bcmchar.c: Renamed variable: "psFlash2xBitMap" -> "flash_2x_bit_map"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 5730b26..f47168b 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers

[PATCH 21/38] Staging: bcm: Bcmchar.c: Renamed variable: "pReadBuff" -> "read_buff"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 28188c7..be1f4ec 100644 --- a/drivers/staging/bcm

[PATCH 2/3] Staging: bcm: Bcmnet.c: Renamed variable: "psIntfAdapter" -> "intf_ad"

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c index 4cbe5b2..800c1ef 100644 --- a/drivers/staging/bcm/Bcmnet.c +++ b/drivers/staging/bcm/Bcmnet.c

<    1   2   3   4   5   >