Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

Hi Pieter, as far as I know, this driver was removed from the source tree. Please update your local copy of the kernel. -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. On 02-12-2014 18:25:49, Pieter Waegeman wrote: > --- > d

Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

o contact me directly if you get stuck with it! -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpGL2Rj4YPQ2.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.

Re: [PATCH] Staging: bcm: fix spaces before commas in Bcmchar.c

: > This is a patch to the Bcmchar.c file that fixes a space before comma warning > found by checkpatch.pl. > Signed-off-by: Jack Wilson -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. pgpDApKCsYCOL.pgp Description: PGP

[PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO

re, though, whether such a patch would be welcome. Either way, I propose to remove the TODO note on checkpatch cleanup with the attached patch. Matthias Beyer (1): Remove checkpatch.pl cleanups todo drivers/staging/android/TODO | 1 - 1 file changed, 1 deletion(-)

[PATCH 1/1] Remove checkpatch.pl cleanups todo

Signed-off-by: Matthias Beyer --- drivers/staging/android/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index 64d8c87..4ce0ac6 100644 --- a/drivers/staging/android/TODO +++ b/drivers/staging/android/TODO @@ -1,5 +1,4 @@ TODO

[PATCH] drivers: staging: rtl8723au: hal: Remove pointless test

This patch removes the pointless `else if` test. Signed-off-by: Matthias Beyer Reported-by: David Binderman --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers

[PATCH] drivers: staging: rtl823au: hal: Remove pointless test

As reported by David Binderman, this test is useless as of if (a < 3) { /* ... */ } else if (a >= 3) { /* ... */ } so this patch removes the second check. Matthias Beyer (1): drivers: staging: rtl8723au: hal: Remove pointless test drivers/staging/rtl8723

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

Pinging here as nobody responded yet. Maybe this was overlooked. On 23-08-2016 21:44:16, Matthias Beyer wrote: > As reported by David Binderman, this test is useless as of > > if (a < 3) { > /* ... */ > } else if (a >= 3) { > /* ... */ > }

[PATCH v2 0/1] Remove pointless test

Re-sending as On 01-09-2016 17:54:47, Greg KH wrote: > There is no patch here :( 8< As reported by David Binderman, this test is useless as of if (a < 3) { /* ... */ } else if (a >= 3) { /* ... */ } so this patch removes the second check. Matth

[PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test

This patch removes the pointless `else if` test. Signed-off-by: Matthias Beyer Reported-by: David Binderman --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers

[PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

This patchset fixes some errors and warnings reported by checkpatch.pl. Matthias Beyer (5): drivers: staging: rtl8723au: core: Fix checkpatch.pl errors drivers: staging: rtl8723au: core: simplify if-break-else drivers: staging: rtl8723au: core: Refactor pointless branching drivers

[PATCH 1/5] drivers: staging: rtl8723au: core: Fix checkpatch.pl errors

This patch fixes the ERRORs which are reported from the checkpatch.pl script for this file. Signed-off-by: Matthias Beyer --- drivers/staging/rtl8723au/core/rtw_mlme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b

[PATCH 2/5] drivers: staging: rtl8723au: core: simplify if-break-else

As the if statement breaks/continues the loop, the else block is not useful and can be omitted. Signed-off-by: Matthias Beyer Signed-off-by: Manuel Messner --- drivers/staging/rtl8723au/core/rtw_mlme.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff

[PATCH 3/5] drivers: staging: rtl8723au: core: Refactor pointless branching

As ether_addr_equal returns a bool, we can simply use the return value to set the variable. Signed-off-by: Matthias Beyer Signed-off-by: Manuel Messner --- drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH 4/5] drivers: staging: rtl8723au: core: Fix "space prohibited" warning

This patch fixes the "space prohibited between function name and open parenthesis '('" warning from checkpatch.pl Signed-off-by: Matthias Beyer Signed-off-by: Manuel Messner --- drivers/staging/rtl8723au/core/rtw_mlme.c | 10 +- 1 file changed, 5 insertions(+),

[PATCH 5/5] drivers: staging: rtl8723au: core: Fix indentation

Signed-off-by: Matthias Beyer Signed-off-by: Manuel Messner --- drivers/staging/rtl8723au/core/rtw_mlme.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

On 06-09-2016 12:00:37, Jes Sorensen wrote: > Matthias Beyer writes: > > This patchset fixes some errors and warnings reported by checkpatch.pl. > > > > Matthias Beyer (5): > > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors > > drivers: staging: r

[PATCH 3/3] Staging: bcm: Outsourced IsFlash2x() handling

This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 98 --- 1 file changed, 56 insertions(+), 42 deletions(-) diff --git a/drivers

[PATCH 0/3] Staging: bcm: Bcmchar.c cleanup patches

gards, Matthias Beyer Matthias Beyer (3): Staging: bcm: Fixed line lengths Staging: bcm: Outsourced cmd handling to function Staging: bcm: Outsourced IsFlash2x() handling drivers/staging/bcm/Bcmchar.c | 246 +- 1 file changed, 150 insertions(+), 96 dele

[PATCH 2/3] Staging: bcm: Outsourced cmd handling to function

This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command handling to shorten the bcm_char_ioctl_nvm_rw() function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 72 ++- 1 file changed, 44 insertions(+), 28 deletions

[PATCH 1/3] Staging: bcm: Fixed line lengths

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 76 --- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index ae7490b..e5283dd 100644 --- a/drivers/staging/bcm

[PATCH v2 1/3] Staging: bcm: Fixed line lengths

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 76 --- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index ae7490b..e5283dd 100644 --- a/drivers/staging/bcm

[PATCH v2 2/3] Staging: bcm: Outsourced cmd handling to function

This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command handling to shorten the bcm_char_ioctl_nvm_rw() function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 72 ++- 1 file changed, 44 insertions(+), 28 deletions

[PATCH v2 3/3] Staging: bcm: Outsourced IsFlash2x() handling

This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 101 -- 1 file changed, 58 insertions(+), 43 deletions(-) diff --git a/drivers

[PATCH v2 0/3] Staging: bcm: Bcmchar.c cleanup patches

Hi, I applied some fixes to my patches as they did not compile before. I guess I'm not able to test these patches without the appropriate hardware, unfortunately. Hope you guys like them anyway. Regards, Matthias Beyer Matthias Beyer (3): Staging: bcm: Fixed line lengths Staging

Re: [PATCH v2 3/3] Staging: bcm: Outsourced IsFlash2x() handling

On 20-05-2014 22:52:41, Dan Carpenter wrote: > On Tue, May 20, 2014 at 05:12:46PM +0200, Matthias Beyer wrote: > > This patch outsources the code from the IsFlash2x() check in > > bcm_char_ioctl_nvm_rw() function to shorten it. > > > > This patch introduces a

[PATCH v3 0/4] Staging: bcm: Bcmchar.c cleanup patches

Note: I compiled it, but I'm not able to test it as I do not have the appropriate hardware. Regards, Matthias Beyer Matthias Beyer (4): Staging: bcm: Fixed line lengths Staging: bcm: Outsourced cmd handling to function Staging: bcm: Outsourced IsFlash2x() handling Staging: bcm: Indenta

[PATCH v3 1/4] Staging: bcm: Fixed line lengths

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 76 --- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index ae7490b..e5283dd 100644 --- a/drivers/staging/bcm

[PATCH v3 3/4] Staging: bcm: Outsourced IsFlash2x() handling

This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 98 --- 1 file changed, 55 insertions(+), 43 deletions(-) diff --git a/drivers

[PATCH v3 2/4] Staging: bcm: Outsourced cmd handling to function

This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command handling to shorten the bcm_char_ioctl_nvm_rw() function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 70 ++- 1 file changed, 42 insertions(+), 28 deletions

[PATCH v3 4/4] Staging: bcm: Indentation fixes in Bcmchar.c

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 218 ++ 1 file changed, 115 insertions(+), 103 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 93b94b4..52809dc 100644 --- a/drivers/staging

[PATCH 00/27] Cleanup for drivers/staging/bcm/CmHost.c

thias Beyer Matthias Beyer (27): Staging: bcm: Shortened code by using variable Staging: bcm: Shortened lines in OverrideServiceFlowParams() Staging: bcm: Shortened lines in get_dsx_sf_data_to_application() Staging: bcm: Outsourced restoring of endianess for ip adresses Staging: bcm: Simplifi

[PATCH 01/27] Staging: bcm: Shortened code by using variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 4564c63..6793e25 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging

[PATCH 06/27] Staging: bcm: Shortened line

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 181c4e9..3f29dea 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c

[PATCH 03/27] Staging: bcm: Shortened lines in get_dsx_sf_data_to_application()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 16262bb..3d8c049 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers

[PATCH 02/27] Staging: bcm: Shortened lines in OverrideServiceFlowParams()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 6793e25..16262bb 100644 --- a/drivers/staging/bcm/CmHost.c +++ b

[PATCH 05/27] Staging: bcm: Simplified by using variables

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 59a3eb9..181c4e9 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm

[PATCH 09/27] Staging: bcm: Shortened lines in RestoreCmControlResponseMessage()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 102 +++ 1 file changed, 73 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 2743d16..3b65990 100644 --- a/drivers/staging/bcm

[PATCH 04/27] Staging: bcm: Outsourced restoring of endianess for ip adresses

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3d8c049..59a3eb9 100644 --- a/drivers/staging/bcm/CmHost.c +++ b

[PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3f29dea..9fea9a8 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging

[PATCH 24/27] Staging: bcm: Shortened lines in CopyIpAddrToClassifier()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 72 1 file changed, 52 insertions(+), 20 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 7fb8568..5bd6e1c 100644 --- a/drivers/staging/bcm

[PATCH 26/27] Staging: bcm: Shortened lines in SearchClsid()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 6dfa361..182efccd 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm

[PATCH 08/27] Staging: bcm: Shortened lines in SetupTargetDsxBuffers()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9fea9a8..2743d16 100644 --- a/drivers/staging/bcm/CmHost.c +++ b

[PATCH 25/27] Staging: bcm: Shortened lines in deleteSFBySfid()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 5bd6e1c..6dfa361 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c

[PATCH 27/27] Staging: bcm: Shortened prototype for GetNextTargetBufferLocation()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 182efccd..fb1d932 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c

[PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 3b65990..f54b177 100644 --- a/drivers/staging/bcm/CmHost.c

[PATCH 12/27] Staging: bcm: Shortened lines in RestoreSFParam()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index ea73c52..377e681 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm

[PATCH 13/27] Staging: bcm: Replaced long member-accessing

This patch replaces long object->member.member foo by variable useage. Increases the reading experience a lot by introducing only one variable (as it decreases the whoa-wall-of-text experience). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c |

[PATCH 15/27] Staging: bcm: Outsourced PHS rule applying

This patch outsources the big PHS-rule-applying code chunk into a function. It also replaces member accessing by using variables. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 170 +-- 1 file changed, 99 insertions(+), 71 deletions

[PATCH 14/27] Staging: bcm: Shortened some lines in DumpCmControlPacker()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 106 +++ 1 file changed, 78 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 644087c..89030cc 100644 --- a/drivers/staging/bcm

[PATCH 16/27] Staging: bcm: Replaced struct member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 96 ++-- 1 file changed, 49 insertions(+), 47 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 21074ae..d5e2ac2 100644 --- a/drivers/staging/bcm

[PATCH 11/27] Staging: bcm: Shortened lines in StoreSFParam()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index f54b177..ea73c52 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c

[PATCH 18/27] Staging: bcm: Shortened line in DeleteAllClassifiersForSF()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index a13f2ad..aa121b7 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c

[PATCH 19/27] Staging: bcm: Shortened lines in DeleteClassifierRuleFromSF()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index aa121b7..9186619 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm

[PATCH 17/27] Staging: bcm: Shortened lines in CopyToAdapter()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 97 1 file changed, 70 insertions(+), 27 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index d5e2ac2..a13f2ad 100644 --- a/drivers/staging/bcm

[PATCH 20/27] Staging: bcm: Replaced member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 77 +++- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9186619..20e4174 100644 --- a/drivers/staging/bcm

[PATCH 23/27] Staging: bcm: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index d5d5a9f..7fb8568 100644 --- a/drivers/staging/bcm

[PATCH 21/27] Staging: bcm: Shortened lines in CopyClassifierRuleToSF()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 128 ++- 1 file changed, 89 insertions(+), 39 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 20e4174..94f3f15 100644 --- a/drivers/staging/bcm

[PATCH 22/27] Staging: bcm: Shortened lines and replaced member accessing in CopyIpAddrToClassifier()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/CmHost.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 94f3f15..d5d5a9f 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

On 26-05-2014 11:38:25, Dan Carpenter wrote: > On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote: > > Signed-off-by: Matthias Beyer > > --- > > drivers/staging/bcm/CmHost.c | 14 ++ > > 1 file changed, 10 insertions(+), 4 deletions(-) &g

Re: [PATCH 10/27] Staging: bcm: Shortened lines in StoreCmControlResponseMessage()

On 26-05-2014 16:08:42, Dan Carpenter wrote: > On Fri, May 23, 2014 at 10:23:48PM +0200, Matthias Beyer wrote: > > - pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), > > GFP_KERNEL); > > + pstAddIndication = kmalloc(sizeof(stru

[PATCH 0/1] Staging: bcm: Line length fixes

Hi, this is a patch which fixes the line length in the drivers/staging/bcm/InterfaceMisc.c file. Regards, Matthias Beyer Matthias Beyer (1): Staging: bcm: Shortened lines drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions

[PATCH 1/1] Staging: bcm: Shortened lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c index 4173fd7..e001f2a 100644 --- a/drivers

[PATCH v2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm

[PATCH v2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm

[PATCH 5/7] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e334ca7..19e0f17 100644 --- a/drivers

[PATCH 6/7] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff

[PATCH 1/7] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b

[PATCH 7/7] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index a1fa3d5..ea19436 100644 --- a/drivers

[PATCH 2/7] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..539f830 100644 --- a/drivers/staging/bcm

[PATCH 0/7] Cleanup patches for bcm staging driver

into a seperate function Please notice: I cannot test these patches. I compiled them successfully, but for testing I do not have the appropriate hardware. Kind regards, Matthias Beyer Matthias Beyer (7): Staging: bcm: Shortened some lines Staging: bcm: replaced member accessing by variable

[PATCH 3/7] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 539f830..ab4c65a 100644 --- a/drivers/staging/bcm

[PATCH 4/7] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index ab4c65a..e334ca7 100644 --- a/drivers

[PATCH 3/6] Staging: bcm: Lines shortened in ddr_init()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 176 -- 1 file changed, 134 insertions(+), 42 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 4c7f518..cfaa2c1 100644 --- a/drivers/staging/bcm

[PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 423bfd9..4564f40 100644 --- a/drivers/staging/bcm/DDRInit.c

[PATCH 1/6] Staging: bcm: Misc whitespace fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index f1d7cb8..b4f0ea3 100644 --- a/drivers/staging/bcm/DDRInit.c +++ b/drivers/staging/bcm

[PATCH 4/6] Staging: bcm: Fixed indention for inner if-block

I'm destroying logical seperated checks with it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index cfaa2c1..d13cb49 100644 --- a

[PATCH 5/6] Staging: bcm: Moved doubled if-block

This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 16 +--- 1 file changed, 5 insertions

[PATCH 0/6] Cleanup patches for bcm staging driver, DDRInit.c file

them, at least. Kind regards, Matthias Beyer Matthias Beyer (6): Staging: bcm: Misc whitespace fixes Staging: bcm: Indentation fixes Staging: bcm: Lines shortened in ddr_init() Staging: bcm: Fixed indention for inner if-block Staging: bcm: Moved doubled if-block Staging: bcm:

[PATCH 2/6] Staging: bcm: Indentation fixes

This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm

[PATCH v3 0/2] Staging: bcm: InterfaceMisc.c file cleanup

Hi, I reworked what Dan suggested. I also added another patch which outsources a chunk of code from the InterfaceRDM() and InterfaceRWM() functions, which was doubled. I missed that one in the first place. I hope you like the changes. Kind regards, Matthias Beyer Matthias Beyer (2): Staging

[PATCH v3 1/2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm

[PATCH v3 2/2] Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 74 ++--- 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c index fff7d68..51f6e1f 100644 --- a/drivers

[PATCH v2 6/7] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff

[PATCH v2 1/7] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b

[PATCH v2 5/7] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 4c26de1..3fb8f4a 100644 --- a/drivers

[PATCH v2 4/7] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index b6238f0..4c26de1 100644 --- a/drivers

[PATCH v2 7/7] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index c7a2afe..b51f4e8 100644 --- a/drivers

[PATCH v2 0/7] Cleanup patches for bcm staging driver

Hi, I fixed what Dan suggested. Please notice: I cannot test these patches. I compiled them successfully, but for testing I do not have the appropriate hardware. Kind regards, Matthias Beyer Matthias Beyer (7): Staging: bcm: Shortened some lines Staging: bcm: replaced member accessing by

[PATCH v2 2/7] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..039408d 100644 --- a/drivers/staging/bcm

[PATCH v2 3/7] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 039408d..b6238f0 100644 --- a/drivers/staging/bcm

Re: [PATCH v2 0/7] Cleanup patches for bcm staging driver

Hi, I'm so sorry, I forgot the "--in-reply-to" flag for this patchset. Do you want me to resend with the appropriate flag? On 11-06-2014 09:50:16, Matthias Beyer wrote: > Hi, > > I fixed what Dan suggested. > > Please notice: I cannot test these patches. I compile

[PATCH v4 0/2] Staging: bcm: InterfaceMisc. file cleanup

Hi, I fixed what Dan suggested. Kind regards, Matthias Beyer Matthias Beyer (2): Staging: bcm: Shortened lines Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking drivers/staging/bcm/InterfaceMisc.c | 125 ++-- 1 file changed, 77 insertions

[PATCH v4 2/2] Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 69 + 1 file changed, 31 insertions(+), 38 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c index fff7d68..a0f159e 100644 --- a/drivers

[PATCH v4 1/2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm

[PATCH v3 6/8] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff

[PATCH v3 3/8] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index dd7b4a5..e1a3e6d 100644 --- a/drivers/staging/bcm

[PATCH v3 7/8] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 9f9045d..276825f 100644 --- a/drivers

[PATCH v3 2/8] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..dd7b4a5 100644 --- a/drivers/staging/bcm

[PATCH v3 1/8] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b

  1   2   3   4   5   >