keep line length when variable
names have 30 characters).
Series should apply to staging-next/testing (c610f7f7).
Smoke tested on rtl8192e card vs staging-next:
- Module load/unload
- Interface up/down
Mateusz Kulikowski (8):
staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings
staging: rtl
Reformat r8192E_phyreg.h to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1442 ++---
1 file changed, 721 insertions(+), 721 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
b/drivers
Both files have the same contents (with the exception of comments).
One of them will not survive future commits.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 92 ---
1 file changed, 65 insertions(+), 27 deletions(-)
diff --git a
Trivial fix - add newline in dm_InitializeTXPowerTracking_TSSI()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index
) variables.
tx_bb_gain is also flattened - register values are stored in array;
Amplification value can be calculated using dm_tx_bb_gain_idx_to_amplify().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.h
This file is not used and its contents are duplicated in r8192E_phyreg.h.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 --
1 file changed, 908 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h
- Replace ?: with min_t
- Remove condition that is always true
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e
Separate parts of dm_TXPowerTrackingCallback_TSSI() into two new functions:
- dm_tx_update_tssi_weak_signal()
- dm_tx_update_tssi_strong_signal()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 176 +++--
1 file changed, 93 insertions
Fix several SPACING errors to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++---
drivers/staging/rtl8192e
ve 30 characters).
Mateusz Kulikowski (21):
staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings
staging: rtl8192e: Copy comments from r819XE_phyreg.h to r8192E_phyreg.h
staging: rtl8192e: remove r819xE_phyreg.h
staging: rtl8192e: Fix SPACING errors
staging: rtl8192e: Remove bb tx gains from r8192
Both files have the same contents (with the exception of comments).
One of them will not survive future commits.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 92 ---
1 file changed, 65 insertions(+), 27 deletions(-)
diff --git a
Trivial fix - add newline in dm_InitializeTXPowerTracking_TSSI()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index
Reformat r8192E_phyreg.h to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1442 ++---
1 file changed, 721 insertions(+), 721 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
b/drivers
Fix several SPACING errors to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++---
drivers/staging/rtl8192e
This file is not used and its contents are duplicated in r8192E_phyreg.h.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 --
1 file changed, 908 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h
- Replace ?: with min_t
- Remove condition that is always true
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e
Separate parts of dm_TXPowerTrackingCallback_TSSI() into two new functions:
- dm_tx_update_tssi_weak_signal()
- dm_tx_update_tssi_strong_signal()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 180 +++--
1 file changed, 95 insertions
) variables.
tx_bb_gain is also flattened - register values are stored in array;
Amplification value can be calculated using dm_tx_bb_gain_idx_to_amplify().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.h
cal and
- a = b = c = d expressions are split
- Replace if/then series with clamp_t()
- Removed unneeded scopes
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/dot11d.h | 4 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 22 +-
.../staging/rtl81
).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c| 12 ++---
drivers/staging/rtl8192e/rtllib.h| 3 ++
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++
drivers/staging/rtl8192e/rtllib_rx.c | 74 +---
drivers
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 365
Simplify function to make checkpatch.pl happy. Changes:
- Helper variables used
- Local variable names compacted
- Conditions were rephrased to return quickly (and decrease indent).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 170
Take out MIFE_TYPE_HT_CAP processing into separate function -
rtllib_parse_mfie_ht_cap()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 50 +---
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8192e
Remove the following private variables:
- force_mic_error - changes force_mic_error that is not used
- radio - changes sw_radio_on that is not used
- adhoc_peer_list - unimplemented
- firm_ver - unimplemented
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
Replace temporary conditional (?:) with ordinary condition or max_t.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 30 +-
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
2 files changed, 22 insertions(+), 10 deletions(-)
diff
rtl8192_pci_findadapter() was looking for invalid DeviceID (0x8172),
instead of proper for rtl8192e/se devices (0x8192)
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e
Further reduction of checkpatch.pl LONG_LINE warnings:
- Local variables are compacted where it's needed
- Helper (local) variables are used (to avoid expressions like a.b.c.d.e)
Both changes should be optimized out by compilers.dd
Signed-off-by: Mateusz Kulikowski
---
.../staging/rtl
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
Replace printk() with pr_* where possible.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 4 +-
drivers/staging/rtl8192e/rtllib_crypt.c | 17
drivers/staging/rtl8192e
Simplify function to make checkpatch.pl happy. Changes:
- Helper variables used
- Conditions were rephrased to return quickly (and decrease indent).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 111 -
1 file changed, 53
Rework some conditions to bail out of functions faster therby
decreasing overall indent. This patch should not cause any negative
side effect (except for different execution time).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 +-
drivers/staging
Use dedicated macro to compare ethernet addresses in probe_rq_parse().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/drivers/staging/rtl8192e
On 14.04.2015 00:12, Dan Carpenter wrote:
> I don't know why you are doing a v2. I went back to the original thread
> and I see that no one complained about it.
>
> Since no one replied to v1 thread, then probably Greg is going to apply
> that one first because it is first in his inbox. Greg's i
On 08.04.2015 01:08, Mateusz Kulikowski wrote:
> This series of patches fixes another set of checkpatch.pl warnings.
>
Please ignore this patchset and use v2 once it is reviewed.
Best Regards,
Mateusz
___
devel mailing l
On 14.04.2015 00:33, Dan Carpenter wrote:
> On Tue, Apr 14, 2015 at 12:15:57AM +0200, Mateusz Kulikowski wrote:
>> I made checkpatch regressions in v1 (that I missed at a time)
>
> As near as I can tell the only difference is that you left some curly
> braces in on patch
On 14.04.2015 10:00, Dan Carpenter wrote:
> BAReq->addr1 is part of struct rtllib_hdr_2addr. It's 4 bytes into
> the struct so it's fine.
You're right - should I explicitly add __aligned() in such places or just
leave comment in that case (for future commiters)?
> I sort of like the ether_addr_c
On 14.04.2015 10:07, Dan Carpenter wrote:
> On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote:
>> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
>> Replace printk() with pr_* where possible.
(...)
>> #define RTLLIB_DEBUG_DATA(level, data, data
On 14.04.2015 10:40, Dan Carpenter wrote:
> On Mon, Apr 13, 2015 at 11:47:38PM +0200, Mateusz Kulikowski wrote:
>> +if (*rfa_pti_r > 4) {
>> +(*rfa_pti_r)--;
>
>
> Honestly, I thought that patch 14 was too hard to revie
Hi,
On 03.05.2015 21:10, Greg KH wrote:
> On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote:
>> rtl8192e driver uses memcpy() to copy hw addresses in several places.
>> checkpatch.pl suggests to use ether_addr_copy(), but most of
>> addresses in driver may
Hi,
On 04.05.2015 11:29, Gujulan Elango, Hari Prasath (H.) wrote:
> This patch addresses a spatch warning on assigning a negative
> value to a unsigned integer.Similar patch has been submitted by
> Larry Finger earlier to silence the same spatch warning in another
> file.
>
> Signed-off-by: Hari
but fix has to wait until
I do more driver refactorings (It's hard to keep line length when variable
names have 30 characters).
Mateusz Kulikowski (33):
staging: rtl8192e: Declare ethernet addresses as __aligned(2)
staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings
staging: r
Replace memcpy() with ether_addr_copy() where possible to make
checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 13 +++---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 19
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential "Fix" to ether_addr_copy().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 20
1 file changed, 12 insertions(+), 8
Use dedicated macro to compare ethernet addresses in probe_rq_parse().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/drivers/staging/rtl8192e
It is neither compiled nor used in rtl8192e.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt.c | 254
drivers/staging/rtl8192e/rtllib_crypt.h | 34 -
2 files changed, 288 deletions(-)
delete mode 100644 drivers/staging/rtl8192e
Use pr_debug() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
Use netdev_dbg() instead of RTLLIB_DEBUG_WX().
Rewrite some messages to be more readable.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_wx.c | 33 -
2 files changed, 16 insertions(+), 18
Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 ++-
drivers/staging/rtl8192e/rtl8192e
Use pr_* where needed (rtllib init code).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 2 --
drivers/staging/rtl8192e/rtllib_module.c | 8 +++-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c
- Extract frame_ctl once and use it as variable.
- Drop endian conversion in is_beacon() function
(used in simplified function only)
- Simplify debug messages
- Invert STYPE checks in debug messages - it is valid
as only BEACON and PROBE_RESP are allowed
Signed-off-by: Mateusz Kulikowski
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 364
Use netdev_dbg() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 6
drivers/staging/rtl8192e/rtllib_rx.c | 58
drivers/staging/rtl8192e/rtllib_tx.c | 5 ++--
3 files changed, 35 insertions(+), 34 deletions
Remove alloc failed messages where not needed to make checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging
Assert macro printed warning message (and was used once).
Remove it, and add netdev_warn() in place where it was called.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +++--
drivers/staging/rtl8192e/rtllib_debug.h | 8
2 files changed, 3
- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c
Remove rest of rtllib "debug" system - it is no longer used -
proper netdev_* functions are used in most cases.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 45 --
drivers/staging/rtl8192e/rtllib_mod
- Use netdev_dbg() instead of RTLLIB_DEBUG_MGMT()
- Remove RTLLIB_DEBUG_MGMT()
- Pass net_device to auth_parse(), auth_rq_parse() and assoc_rq_parse()
- Remove duplicated messages
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h | 2 -
drivers/staging/rtl8192e
- Use netdev_dbg or netdev_vdbg instead of RTLLIB_DEBUG()
- Reformat some messages for better readability
- Remove RTLLIB_DEBUG messages that make no sense
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 35 +
drivers/staging/rtl8192e
This header is not used - remove it to make driver code smaller.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h | 382 -
1 file changed, 382 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h
diff --git
cal and
- a = b = c = d expressions are split
- Replace if/then series with clamp_t()
- Removed unneeded scopes
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/dot11d.h | 4 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 22 +--
.../staging/rtl81
This function never supported checking of MAC block.
Instead of printing several warnings - print it once and exit.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers
Improve readability and make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
index 2b337c4..5a08935
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
Replace printk() with netdev_* if possible, pr_* in other cases.
All pr_* use __func__ to easily trace message back to rtllib
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
drivers/staging
Take out MIFE_TYPE_HT_CAP processing into separate function -
rtllib_parse_mfie_ht_cap()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 49 +---
1 file changed, 29 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8192e
Remove the following private variables:
- force_mic_error - changes force_mic_error that is not used
- radio - changes sw_radio_on that is not used
- adhoc_peer_list - unimplemented
- firm_ver - unimplemented
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
Use netdev_dbg() instead, remove duplicated logs.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 101 ---
drivers/staging/rtl8192e/rtllib_wx.c | 12 +++--
3 files changed, 54 insertions
- Use netdev_* with log level depending on how serious error is
- Rework some messages to be more readable
- Pass net_device where needed for pretty prints
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 24 +++--
drivers/staging/rtl8192e/rtl8192e
Use print_hex_dump_bytes() if VERBOSE_DEBUG is enabled.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 20
drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 +--
drivers/staging/rtl8192e/rtllib.h | 11 ---
drivers/staging
This messages are not needed, as failure is reported earlier in code.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 1 -
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging
Reindent lines to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 83 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 18 ---
2 files changed, 65 insertions(+), 36 deletions(-)
diff --git a/drivers
Warninig is printed if precision is lost - it can't happen at moment as
all get_key implementations return either -1 or small buffers.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_wx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dr
Replace :? with min_t for readability. Remove check that is always false.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 8 +---
drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers
WOL capability was reported in an awkward way - print it nicely.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
b/drivers/staging/rtl8192e
On 10.05.2015 00:29, Joe Perches wrote:
> On Sat, 2015-05-09 at 23:18 +0200, Mateusz Kulikowski wrote:
>> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
>> structures. Use ETH_ALEN as array length in places where it was hardcoded to
>> 6.
> []
On 10.05.2015 15:19, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
>> Replace memcpy() with ether_addr_copy() where possible to make
>> checkpatch.pl happy.
>
> I need proof that this is ok to do, please provide that in the changelog
&
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>> */
>> skb_pull(sub_skb, SNAP_SIZE);
>> -memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
>> ETH_ALEN);
>> -memcpy(skb_push(sub_skb, ET
On 10.05.2015 15:20, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
>> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
>> checkpatch.pl warning.
>> It will prevent accidential "Fix" to ether_addr_copy().
>
>
On 11.05.2015 15:22, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote:
(...)
>> len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv);
>> -erq->length = (len >= 0 ? len : 0);
>> +if (len > U
On 10.05.2015 00:37, Joe Perches wrote:
> On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote:
>> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
>> Replace printk() with netdev_* if possible, pr_* in other cases.
>> All pr_* use __func__ to easily trace m
On 10.05.2015 09:53, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote:
>> Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
>> for errors that really should be reported to user.
>> Use netdev_warn() for the rest.
&g
On 11.05.2015 15:48, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> +if (info_element->len >= 4 &&
>> +info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
>> +
On 10.05.2015 09:49, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
>> Code was not altered significantly, therefore in some places it generates
>> LO
On 12.05.2015 23:19, Greg KH wrote:
> On Tue, May 12, 2015 at 09:52:01PM +0200, Mateusz Kulikowski wrote:
>> On 10.05.2015 15:19, Greg KH wrote:
>>> On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
>>>> Replace memcpy() with ether_addr
On 13.05.2015 10:22, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
>> On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>>>
>>> Which part isn't aligned? I think they both are.
>>>
>> struct rtllib
On 15.05.2015 01:14, Dan Carpenter wrote:
> On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
>> On 13.05.2015 10:22, Dan Carpenter wrote:
>>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
>>>> On 11.05.2
Hi,
On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
> replace the printk with netdev subsystem debug infrastructure.
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +++-
drivers/staging/rtl8192e/rtl8192e
Replace memcpy() with ether_addr_copy() where possible to make
checkpatch.pl happy.
Change was target tested (download 1Mb file over WPA2 network)
with BUG trap for unaligned addresses in ether_addr_copy()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2
It is neither compiled nor used in rtl8192e.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt.c | 254
drivers/staging/rtl8192e/rtllib_crypt.h | 34 -
2 files changed, 288 deletions(-)
delete mode 100644 drivers/staging/rtl8192e
Use pr_* where needed (rtllib init code).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 2 --
drivers/staging/rtl8192e/rtllib_module.c | 8 +++-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c
Use dedicated macro to compare ethernet addresses in probe_rq_parse().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/drivers/staging/rtl8192e
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 397
Use netdev_dbg() instead of RTLLIB_DEBUG_WX().
Rewrite some messages to be more readable.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_wx.c | 33 -
2 files changed, 16 insertions(+), 18
- Extract frame_ctl once and use it as variable.
- Drop endian conversion in is_beacon() function
(used in simplified function only)
- Simplify debug messages
- Invert STYPE checks in debug messages - it is valid
as only BEACON and PROBE_RESP are allowed
Signed-off-by: Mateusz Kulikowski
Use netdev_dbg() instead, remove duplicated logs.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 101 ---
drivers/staging/rtl8192e/rtllib_wx.c | 12 +++--
3 files changed, 54 insertions
- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c
- Use netdev_dbg() instead of RTLLIB_DEBUG_MGMT()
- Remove RTLLIB_DEBUG_MGMT()
- Pass net_device to auth_parse(), auth_rq_parse() and assoc_rq_parse()
- Remove duplicated messages
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h | 2 -
drivers/staging/rtl8192e
Remove rest of rtllib "debug" system - it is no longer used -
proper netdev_* functions are used in most cases.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 45 --
drivers/staging/rtl8192e/rtllib_mod
Make set_swcam, setKey and rtllib_probe_resp parameter (MAC address)
const.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 4 ++--
drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 4 ++--
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
3 files changed, 6
1 - 100 of 676 matches
Mail list logo
