Bhumika,
> Make these const as they are only stored in the type field of a device
> structure, which is const.
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing l
uffer busy, the storvsc
> allocated buffer descriptor should also be freed.
Which kernel version is this patch aimed at?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
Long,
>> Which kernel version is this patch aimed at?
>
> Martin, thanks for pointing this out. This should also go to stable
> trees.
The reason I asked is that it didn't apply to neither fixes, nor
for-next.
I applied it to 4.13/scsi-fixes by hand and added a stabl
>>>>> "Sitsofe" == Sitsofe Wheeler writes:
Sitsofe> A previous patch attempted to add a quirk to workaround this
Sitsofe> but the quirk was only enabled after the features had been
Sitsofe> scanned for, wouldn't work for "small" disks
What
time around we identified this as a problem with Microsoft's
interpretation of the T10 SBC spec. And they promised that they are
going to fix that.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing
t. Whereas I know
several other devices that will benefit from the TRY_VPD_PAGES blacklist
option.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
try_rc16_first(struct scsi_device *sdp)
{
if (sdp->host->max_cmd_len < 16)
return 0;
if (sdp->try_rc_10_first)
return 0;
if (sdp->scsi_level > SCSI_SPC_2)
return 1;
if (scsi_device_protection(sdp))
(16) with the UNMAP bit set
unless the device sets LBPME=1 in the READ CAPACITY(16) response.
So what does the storsvc report as its thin provisioning capabilities?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ce a blacklist flag that can be used to
trigger VPD page inquiries on devices that are known to support them.
Reported-by: KY Srinivasan
Signed-off-by: Martin K. Petersen
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 4a6e4ba5a400..a5b1a224628a 100644
--- a/drivers/scsi/scs
#x27;t
see why we'd need to overload no_write_same which was meant for an
entirely different purpose.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_UNMAP flag or something like
that. But BLIST_TRY_VPD_PAGES seems more generally useful and it does
fix the problem at hand. That's why I went that route.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
).
If a WRITE SAME(10/16) command fails and the UNMAP bit is not set we'll
set no_write_same=1 and disable REQ_WRITE_SAME support.
If a WRITE SAME(10/16) command fails and the UNMAP bit is set we'll
disable REQ_DISCARD support.
Not sure where the 10 vs. 16 byte 2TB l
the READ CAPACITY(16) response. I'll see if I can locate the details.
Otherwise I'm willing to entertain that idea.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
express large regions, DSM TRIM on the SATA side is limited to 32
MB per range. So in many cases we end up maxing out the payload capacity
even with a single contiguous range.
We expect LBP SCSI devices to queue commands. Being able to express
multiple ranges in one shot is less cri
e LBP VPD.
I'll contemplate the LBPME => mandatory VPD lookup thing for bit.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
r
implementations are buggy. Even with a Linux implementation readily
available it's hard to get them to test since Linux is not a tier 1
platform in the consumer segment. For enterprise drives it's an entirely
different matter, of course.
we were
trying to avoid with this patch series. Namely sending down commands
unsupported by the target device.
This kind of thing really needs to be a sysadmin decision and can be
handled with a udev rule.
--
Martin K. Petersen Oracle Linux Engineering
__
ives that are
known to be working correctly. Your drive is an ADATA and therefore very
likely to be blacklisted by default by a vendor SATL.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ation?
One challenge in that department is that a single UNMAP command may turn
into many, many, many DSM TRIM commands on the underlying SATA device.
That's why we went with WRITE SAME for the internal Linux SATL, capping
the maximum number of blocks to what we can fit in a single DSM TRIM
co
al details.
Great! I'd just like to have a reasonable level of confidence in what's
happening down the stack before I entertain turning something on that's
not being properly advertised.
--
Martin K. Petersen Oracle Linux Engineering
__
TY(16) response. The LBP VPD is correctly
provided with LBPU flag set but because LBPME is reported as disabled we
will not attempt to issue UNMAP commands to the device.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@l
ovisioned) in the
Logical Block Provisioning VPD page (see 6.6.4).
That's a "shall". The LBP VPD elaborates on the provisioning type,
commands preference, etc. But it's all gated by LBPME=1 in the READ
CAPACITY(16) response.
--
Martin K. Petersen Oracle Linux Engin
>>>>> "KY" == KY Srinivasan writes:
KY> We will fix this bug in the next release of Windows; we are also
KY> looking at backporting the fix to prior versions of Windows.
Excellent. Thanks for looking into this!
--
Martin K. Peterse
e_async will
> wait forever for its I/O to complete while holding
> scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
Applied to 4.15/scsi
Dan,
> We should set the error code if fc_remote_port_add() fails.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's. The Hyper-V host side can handle the
> higher count with no issues.
Long/KY/Cathy/Stephen: Please ack/review Michael's patches.
--
Martin K. Petersen Oracl
ode, skewing
> the interrupt load to that CPU.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Michael,
> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's. The Hyper-V host side can handle the higher
> count with no issues.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Lin
ll need an ack from davem.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
201 - 229 of 229 matches
Mail list logo
