Re: [PATCH 2/9] staging: greybus: remove license "boilerplate"

: Alex Elder > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: "Bryan O'Donoghue" > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Greg Kroah-Hartman > --- Acked-by: Mark Greer

Re: [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/

> Cc: Alex Elder > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org >

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

rwal I am sorry for not responding until now. For some strange reason, email from this list are being delayed. I just got this today (April 30). Thanks for the patch, Kangjie, and thanks for the review, Vaibhav. And FWIW, Reviewed-by: Mark Greer Mark -- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: remove redundant assignment to variable is_empty

udio_manager_module *module, *next; > - int is_empty = 1; > + int is_empty; > > down_write(&modules_rwsem); Reviewed-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. One thing it does is to break the RT build. > > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Johan Hovold >

Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Hiremath > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: Thomas Gleixner > Cc: Kate Stewa

Re: [PATCH 02/11] staging: greybus: Remove redundant license text

text was removed. > > Cc: Vaibhav Hiremath > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O&#x

Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

n audio.h > + * (Android media layer) > + */ > enum { > GBAUDIO_DEVICE_NONE = 0x0, > /* reserved bits */ > -- > 1.9.1 Reviewed-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

, "Invalid kcontrol count=%d for %s\n", > w->ncontrols, w->name); > return ret; > } Acked-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] greybus: audio: remove unused code

ing again they can take a look at the git history. Thanks for this, Alexandre. Acked-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 3/4] staging: greybus: audio: Cleanup junk codec registers

On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote: > From: Vaibhav Agarwal > > Dummy codec register were initially added while populating dummy codec > mixer controls until module topology parser was available. Now, these > dummy registers are nowhere used and thus can be safely rem

Re: [PATCH v2 2/4] staging: greybus: audio: Initialize sig_bits before configuring hwparams

is dependent on codec capability and thus populated via > codec dai_driver definition. In our case, it is fixed to 16 based on the > data format, container supported. > > Signed-off-by: Vaibhav Agarwal > --- Acked-by: Mark Greer _

Re: [PATCH v2 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

Hi Vaibhav. On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote: > mixer control->info call back function checks for -ve values to rebase > min and max values. However, le32 variable is used to fetch values from > GB module FW. Thus -ve value checking is not required. Fix this!! nit:

Re: [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote: > From: Vaibhav Agarwal > > Proper byte order was completely disregarded for multi byte data shared > between AP and module (and APB1). Fix this. > > Signed-off-by: Vaibhav Agarwal > --- Hi Vaibhav. I think you got them all exce

Re: [PATCH v3 0/4] Cleanup greybus audio driver

same are accepted there, I'll share relevant patches > for GB Audio codec driver as well. > > Changes from v2: > - patch 1/4 > - Update commit message - Mark Greer > - Move le32_to_cpu change to patch 4/4 - Mark Greer > - patch 3/4 > - Remove junk codec re

Re: [PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

, > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t format, uint32_t rate, u8 channels, > > Signed-off-by: Marcos Paulo de Souza > --- Good catch, thanks. Acked-by: Mark Greer __

Re: [PATCH] staging: greybus: audio: constify snd_soc_dai_ops structures

_dai_ops gbcodec_dai_ops = { > .startup = gbcodec_startup, > .shutdown = gbcodec_shutdown, > .hw_params = gbcodec_hw_params, Thanks Arvind. Acked-by: Mark Greer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel