We actually mean to clear the ET_INTR_TXDMA_ISR reg after handling
a completed transfer, not the ET_INTR_TXDMA_ERR reg, which should
get handled immediately after.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send & receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index fc
To better describe it's use as a hard limit.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 551b250..df83ea3 100644
--- a/dr
There's no need to handle any rx/tx interrupts in the middle of an mtu
change, so don't.
After this change, receive and transmit interrupts are only handled in
one place, which paves the way to using NAPI.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 --
1 file
Replace a long list of contiguous writel() calls with a for loop iterating
over the same address values.
Also remove redundant comments on the macstat registers, the variable names
are good enough.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 59
Replace a long list of contiguous writel() calls with a for loop iterating
over the same values.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
> On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote:
>
> > do {
> > pci_read_config_dword(pdev,
> > - L
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction
On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> > - bool done = true;
> > + int count = 0;
> > + int limit = budget;
> > + bool not_done = false;
>
> Don't use neg
On Thu, Aug 21, 2014 at 08:40:20AM +, David Laight wrote:
> From: Mark Einon
> > Replace a long list of contiguous writel() calls with a for loop iterating
> > over the same address values.
> >
> > Also remove redundant comments on the macstat registers, the variabl
et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send & receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon
---
Updated after Stephen Hemminger commented
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote:
> Hi Mark,
>
> On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote:
>
> >
> > Hi Fabio, thanks for the review.
> >
> > It's a space alignment of parameters to go with the previous change, to
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon
---
Modified to remove function parameter indenting changes, which are
largely unrelated.
drivers/staging/et131x/et131x.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --
Since the CMA API is now used directly the allocated memory is no longer
automatically zeroed.
Explicitly zero CMA allocated memory to ensure that no data is exposed
to userspace.
Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999
Signed-off-by: Liam Mark
---
drivers/staging/android/ion
On Fri, 19 Jan 2018, Dan Carpenter wrote:
> On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> > Since the CMA API is now used directly the allocated memory is no longer
> > automatically zeroed.
> >
> > Explicitly zero CMA allocated memory to ensure tha
On Sat, 20 Jan 2018, Greg KH wrote:
> On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> > Since the CMA API is now used directly the allocated memory is no longer
> > automatically zeroed.
> >
> > Explicitly zero CMA allocated memory to ensure that no data
("staging: android: ion: Use CMA APIs directly")
Signed-off-by: Liam Mark
---
Changes in v2:
- Clean up the commit message.
- Add 'Fixes:'
drivers/staging/android/ion/ion_cma_heap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/ion/ion_cma_hea
On Wed, 24 Jan 2018, Laura Abbott wrote:
> On 01/22/2018 09:46 AM, Liam Mark wrote:
> > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly")
> > the CMA API is now used directly and therefore the allocated memory is no
> > longer automatica
("staging: android: ion: Use CMA APIs directly")
Signed-off-by: Liam Mark
---
Changes in v2:
- Clean up the commit message.
- Add 'Fixes:'
Changes in v3:
- Add support for highmem pages
drivers/staging/android/ion/ion_cma_heap.c | 17 +
1 file changed,
Fix the dup_sg_table function to initialize the dma_address of the new
sg list entries instead of the source dma_address entries.
Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table")
Signed-off-by: Liam Mark
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1
pping")
Signed-off-by: Liam Mark
---
drivers/staging/android/ion/ion.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index f480885e346b..e5df5272823d 100644
--- a/drivers/staging/android
On Mon, 12 Feb 2018, Dan Carpenter wrote:
> On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote:
> > Fix the dup_sg_table function to initialize the dma_address of the new
> > sg list entries instead of the source dma_address entries.
> >
> > Fixes: 17fd283f3
On Mon, 12 Feb 2018, Laura Abbott wrote:
> On 02/09/2018 10:21 PM, Liam Mark wrote:
> > The ION begin_cpu_access and end_cpu_access functions use the
> > dma_sync_sg_for_cpu and dma_sync_sg_for_device APIs to perform cache
> > maintenance.
> >
> > Curren
On Thu, 15 Feb 2018, Laura Abbott wrote:
> On 02/12/2018 01:25 PM, Liam Mark wrote:
> >
> > On Mon, 12 Feb 2018, Dan Carpenter wrote:
> >
> > > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote:
> > > > Fix the dup_sg_table function to initia
On Fri, 16 Feb 2018, Greg KH wrote:
> On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote:
> > Fix the dup_sg_table function to initialize the dma_address of the new
> > sg list entries instead of the source dma_address entries.
> >
> > Fixes: 17fd283f3
Fix the dup_sg_table function to initialize the dma_address of the new
sg list entries instead of the source dma_address entries.
Since ION duplicates the sg_list this issue does not appear to result in
an actual bug.
Signed-off-by: Liam Mark
Acked-by: Laura Abbott
---
Changes in v2:
- Add
where there is minimal CPU access
and therefore uncached memory performs better.
Signed-off-by: Liam Mark
---
drivers/staging/android/ion/ion.c | 16
drivers/staging/android/ion/ion.h | 5 -
drivers/staging/android/ion/ion_cma_heap.c| 3
On Wed, 7 Mar 2018, Laura Abbott wrote:
> On 02/28/2018 09:18 PM, Liam Mark wrote:
> > The issue:
> >
> > Currently in ION if you allocate uncached memory it is possible that there
> > are still dirty lines in the cache. And often these dirty lines in the
> &g
m specific
> symbol, or PCI.
Acked-by: Mark Brown
Thanks again for doing this work, it's really good to see!
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org
m specific
> symbol, or PCI.
Acked-by: Mark Brown
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote:
> The existing GB Audio codec driver is dependent on MSM8994 Audio driver.
> During the development stage, this dependency was configured due to
> various changes involved in MSM Audio driver to enable addtional codec
> card and some
On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote:
> With patch#6 in this series, I'm proposing some of the (dummy) helper
> APIs required to link DAPM DAI widgets for the GB Audio modules
> added/removed dynamically.
> Eventually, I would like to propose relevant changes in snd-s
On Wed, Jun 10, 2020 at 08:01:18PM +0200, Alexandre Belloni wrote:
> My point was that if we were to keep that driver, the goal would be to
> have it out of staging instead of simply making it compile.
Yes, definitely - that should be the goal for anything in staging.
signature.asc
Description:
On Fri, Jun 12, 2020 at 09:07:24PM +0530, Vaibhav Agarwal wrote:
> On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote:
> > > Kindly suggest me the preferred way to follow on this thread.
> > This is effectively out of tree code, until someone submits it properly
>
Him today.
Thanks and may God bless you.
David Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 07/17/2013 05:49 PM, Greg KH wrote:
On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
This patch adds the Digi driver to staging.
Which digi driver? For what hardware? What type of driver is it?
Please provide some more details here.
From the readme:
This Digi softwar
On 07/18/2013 01:40 PM, Greg KH wrote:
On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote:
On 07/17/2013 05:49 PM, Greg KH wrote:
On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
This patch adds the Digi driver to staging.
Which digi driver? For what hardware
After prolonged testing for a few days of normal use with new et131x
hardware, I've concluded that this was a hardware issue with the older
hardware I had. Removing this item from the TODO.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |1 -
1 file changed, 1 deletion(-)
Can you paste an example
where it does this?
FYI, there is no DGNC_UNLOCK in the dgap driver? Maybe he was looking at
the dgnc while commenting on the dgap??? Just a guess.
Mark
___
devel mailing list
de...@linuxdriverproject.org
h
ngelog?
Cheers,
Mark
>
> Signed-off-by: Rupesh Gujare
> ---
> drivers/staging/ozwpan/ozproto.h |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ozwpan/ozproto.h
> b/drivers/staging/ozwpan/ozproto.h
> index e532347..0c49c8a 1006
7 +19,7 @@
> #define OZ_PRESLEEP_TOUT 11
>
> /* Maximun sizes of tx frames. */
^^^
If you are going to spin this patch again, you may as well fix this typo
too...
Cheers,
Mark
___
devel mailing list
de.
The rcv_pend_lock spinlock isn't used anymore. remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |2 --
1 file changed, 2 deletions(-)
create mode 100644 drivers/staging/et131x/Module.symvers
diff --git a/drivers/staging/et131x/Module.symvers
b/drivers/st
Remove braces from a few single line if statements.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
Ignoring checkpatch for some lines - now just over 80 chars, but much
more readable.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 120 +--
1 file changed, 40 insertions(+), 80 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b
phy_lock is no longer used in any useful code, it's all been moved into
a phy_device. Remove the lock definition and init.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/st
Remove braces from a few single line if statements.
Signed-off-by: Mark Einon
---
Fair enough Dan, I wouldn't argue with that, I was eager to reduce lines.
Removing those multi-line changes...
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 dele
On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote:
> Sorry, this is still in my postponed messages folder. I meant to send
> it earlier.
>
> On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote:
> > Ignoring checkpatch for some lines - now just over 80 chars,
Remove braces from a few single line if statements.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index a8f7cd7..7cd3d34 100644
phy_lock is no longer used in any useful code, it's all been moved into
a phy_device. Remove the lock definition and init.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/st
Adding some trivial formatting suggestions made by Dan Carpenter to
the TODO.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 9272a24
The rcv_pend_lock spinlock isn't used anymore. remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |2 --
1 file changed, 2 deletions(-)
create mode 100644 drivers/staging/et131x/Module.symvers
diff --git a/drivers/staging/et131x/Module.symvers
b/drivers/st
On Thu, Sep 19, 2013 at 10:53:02PM +0100, Russell King wrote:
> This code sequence is unsafe in modules:
>
> static u64 mask = DMA_BIT_MASK(something);
> ...
> if (!dev->dma_mask)
> dev->dma_mask = &mask;
Acked-by: Mark Brown
signature.asc
De
().
>
> Signed-off-by: Russell King
> ---
> drivers/staging/et131x/et131x.c | 17 ++---
> 1 files changed, 2 insertions(+), 15 deletions(-)
Acked-by: Mark Einon
Cheers,
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Contact: claims.your @cheapnet.it
Regards,
Mark Suzman
CEO, Board Member, Bill & Melinda Gates Foundation
©1991-2022 Bill & Melinda Gates Foundation. All rights
I am Mrs Ann Mark, a born again christian and a widow and i want to make a
donation of $ 5.5 Million US Dollars to help orphans and widows and charitable
home in your country, and i assumed that you will be able to receive this fund
and use it to my wished to the needs in your country and i am
Y. WE ARE SORRY FOR ANY INCONVENIENCE THE DELAY IN TRANSFERRING OF YOUR
FUND MUST HAVE CAUSED YOU.
BEST REGARDS.
DR MARK CHARLES
NNPC DIRECTOR OF FINANCE
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/ma
Y. WE ARE SORRY FOR ANY INCONVENIENCE THE DELAY IN TRANSFERRING OF YOUR
FUND MUST HAVE CAUSED YOU.
BEST REGARDS.
DR MARK CHARLES
NNPC DIRECTOR OF FINANCE
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/ma
/ixgbevf/vf.h
b/drivers/net/ethernet/intel/ixgbevf/vf.h
index ef9f773..7242a97 100644
--- a/drivers/net/ethernet/intel/ixgbevf/vf.h
+++ b/drivers/net/ethernet/intel/ixgbevf/vf.h
@@ -32,7 +32,9 @@
#include
#include
#include
+#include
+#include
Surely you didn't mean to include the same
KY Srinivasan wrote:
-Original Message-
From: Rustad, Mark D [mailto:mark.d.rus...@intel.com]
Sent: Thursday, April 14, 2016 4:01 PM
To: KY Srinivasan
Cc: David Miller ; netdev
; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow
KY Srinivasan wrote:
-Original Message-
From: Rustad, Mark D [mailto:mark.d.rus...@intel.com]
Sent: Thursday, April 14, 2016 5:07 PM
To: KY Srinivasan
Cc: David Miller ; netdev
; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow
From: Justice Mark Oweriole
(Philanthropist)
Urgent attention,
Subject matter: Sincere compensation.
You might find it so difficult to remember me. Though, it is indeed, a very
long time. On my singular, I am much delighted and privileged to contact you
again, after couple of
From: Justice Mark Oweriole
(Philanthropist)
Urgent attention,
Subject matter: Sincere compensation.
You might find it so difficult to remember me. Though, it is indeed, a very
long time. On my singular, I am much delighted and privileged to contact you
again, after couple of
if you have projects that needs funding for further
discussion and negotiation with any of the companies that will be interested to
fund your project.
Regards,
Mark Johnson
___
devel mailing list
de...@linuxdriverproject.org
http
you have projects that need funding for further
discussion and negotiation .
Regards,
Mark Johnson
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
501 - 565 of 565 matches
Mail list logo
