[PATCH] staging: dgap: replace dgap_savestring function with kstrdup

Removes dgap_savestring function to use kstrdup instead. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/drivers

staging: dgap: Question about declaring variables

I understand that unnecessarily initializing them is wrong. But if they do need initialized, is it preferred to do it in the declaration or in the code before it is used? Thanks Mark ___ devel mailing list de...@linuxdriverproject.org http

Re: staging: dgap: Question about declaring variables

On 05/22/2014 04:38 PM, Dan Carpenter wrote: > On Thu, May 22, 2014 at 01:49:22PM -0400, Mark Hounschell wrote: >> I understand that unnecessarily initializing them is wrong. But if they >> do need initialized, is it preferred to do it in the declaration or in >> the c

[PATCH] staging: dgap: Remove unnecessary initialization of variables in declarations

Removes unnecessary initialization of variables in declarations Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 175 +--- 1 file changed, 84 insertions(+), 91 deletions(-) diff --git a

[PATCH] staging: dgap: Remove more extra white space and tabs

Removes more extra white space and tabs Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 178 +--- 1 file changed, 86 insertions(+), 92 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH] staging: dgap: Replace double negative conditionals

This patch replaces double negativeconditionals Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging

[PATCH] staging: dgap: Simplify get_altpin and get_useintr functions

Simplify dgap_config_get_useintr and dgap_config_get_altpin changing the case statement to an if statement. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

[PATCH] staging: dgap: Change GFP_ATOMICs to GFP_KERNEL

We don't need to use GFP_ATOMIC at driver load time so use GFP_KERNEL instead. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

. Unclear yet. When we do this, the useintr and altpin configuration file stuff will need converted to module options. There was also some ioctl code removed entirely before the driver was merged into staging. It was specific to the dgap_mgmt device (currently dead as a resul

[PATCH] staging: dgap: misc cleanup of NULL conditionals

refactors NULL conditionals Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 64 ++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH] staging: dgap: Simplify dgap_find_config

Simplify ugly dgap_find_config function Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 84 +++-- 1 file changed, 43 insertions(+), 41 deletions(-) diff --git a/drivers/staging/dgap

[PATCH] staging: dgap: Use EIO instead of ENXIO

Replaces ENXIO with EIO errno Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

Re: [PATCH] staging: et131x: remove Module.symvers

On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote: > Removing a build generated file. > > Cc: Mark Einon > Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock") > Signed-off-by: Bjørn Mork Hi Bjørn, Unfortunately this issue has alre

staging: dgap:

Hi Dan, I've been away for a while but should be able to find some time to work on the dgap driver some more. Do you have a TODO list? Thanks Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/ma

Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero

On Sat, Aug 30, 2014 at 01:32:16PM -0700, Greg KH wrote: > On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote: > > Replace a long list of contiguous writel() calls with a for loop iterating > > over the same values. > > > > Signed-off-by: Mark Einon > >

[PATCH 2/4] staging: et131x: Remove spinlock fbr_lock

The spinlock fbr_lock is only used in a single call sequence staring from et131x_poll. As this call is already locked by napi->poll_lock, we can remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/stag

[PATCH 4/4] staging: et131x: Fix whitespace - alignment matching open parenthesis

Fix occurrences in et131x.c of: CHECK: Alignment should match open parenthesis Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 130 +--- 1 file changed, 67 insertions(+), 63 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers

[PATCH 3/4] staging: et131x: Add auto-negotiation and 1000BT_Half as supported protocols

The driver supports auto-negotiation and 100BaetT_Half but doesn't advertise or list it in it's phydev. Fix that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/et131

[PATCH 1/4] staging: et131x: Remove dead code in isr

' We don't actually need the dead code, as we're now using NAPI to handle enabling interrupts - but we do need to enable interrupts if NAPI is not scheduled - so enable interrupts if this is the case. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/

[PATCH 4/8] staging: et131x: Remove ununsed statistics

>From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd are not returned or used for anything meaningful - remove the code that collects them, and the struct members too. Signed-off-by: Mark Einon --- drivers/staging/et1

[PATCH 3/8] staging: et131x: Tidy up rx/tx dropped & bytes stats

Remove some fairly useless comments regarding rx/tx _bytes and _dropped, and use rcvd_pkts_dropped stat value to provide rx_dropped. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

Memory allocation errors do not denote NETDEV_TX_BUSY, simply drop the packet silently with kfree_skb() and return NETDEV_TX_OK. Also remove this item from the TODO list. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - drivers/staging/et131x/et131x.c | 51

[PATCH 5/8] staging: et131x: Remove struct tcb->flags

'struct tcb' member 'flags' was only used to collect tx stats, now we are no longer collecting those particular stats, we no longer need tcb->flags or the code used to peek into the skb to set it's value. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.

[PATCH 6/8] staging: et131x: Combine two if statements with same effect

Both these if statements have the same effect when true, so combine them and save a few lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x

[PATCH 0/8] staging: et131x: Whittle down the remaining TODO items

Tackle the last few major TODO items for this driver. Mark Einon (8): staging: et131x: Remove et131x_send_packets() function staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet staging: et131x: Tidy up rx/tx dropped & bytes stats staging: et131

[PATCH 7/8] staging: et131x: Simplify code in nic_rx_pkts() for multicast_pkts_rcvd

nding code can be tiedied up a little. Tested somewhat with omping, with no adverse effects seen. Also remove this item from the TODO list. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - drivers/staging/et131x/et131x.c | 54 ++--- 2 files

[PATCH 1/8] staging: et131x: Remove et131x_send_packets() function

Remove et131x_send_packets() and replace the only use in et131x_tx with the removed function's body. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 76 - 1 file changed, 29 insertions(+), 47 deletions(-) diff --git a/drivers/st

[PATCH 8/8] staging: et131x: Remove 'reduce number of spinlocks' TODO item

The number of spinlocks has been halved, from 8 to 4 since this comment was made, let's see if this is enough. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README

Re: [PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

On Sat, Sep 13, 2014 at 12:23:04PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:40PM +0100, Mark Einon wrote: > > + if (send_packet(skb, adapter)) > > + goto drop_err; > > + > > + return NETDEV_TX_OK; > > + > > +drop_err: >

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

#x27;git send-email' v2.1.0 that sent the mail, and I don't have the offending character in any versions of the mail I can see. Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > &

[PATCH 08/12] staging: et131x: Fix 'else is not generally useful after a break or return'

Fix this checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c

[PATCH 07/12] staging: et131x: Fix indenting using mixed tabs and spaces

Fix two lines where mixed tabs and spaces were used for indenting. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8b2f9a9..c158b01

[PATCH 05/12] staging: et131x: Remove useless assignment to NULL

The stack variable skb is no longer used after it's set to NULL. Don't set it to NULL. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131

[PATCH 03/12] staging: et131x: Simplify unlocking tcb_send_qlock in et131x_tx_timeout()

the tx_global_lock, so this shouldn't matter. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 74d5f309..ef3a076 100644 --- a/drivers

[PATCH 06/12] staging: et131x: Add spinlock definition comments

Checkpatch --strict advises that spinlocks should be described when defined, seems a good idea so this change does that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b

[PATCH 02/12] staging: et131x: Remove blank lines form et131x.c

Remove some unecessary blank lines from et131x.c Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8da4883..74d5f309 100644 --- a/drivers/staging

[PATCH 10/12] staging: et131x: Remove spaces after casts

In three places in et131x.c, spaces exist after a cast. Remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 17a3a36..c6b5193

[PATCH 12/12] staging: et131x: Use variable names instead of types in sizeof

A few calls to sizeof() in et131x.c give the type as a parameter - use the equivalent variable name instead. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

[PATCH 04/12] staging: et131x: Remove send_hw_lock spinlock

We don't need to use this lock - the tx path is protected by the networking subsystem xmit_lock, so we don't also need it in nic_send_packet(). The other use of this spinlock in et1310_enable_phy_coma() to protect a low power flag makes no sense, so can just be removed. Signed-off-by:

[PATCH 01/12] staging: et131x: Remove extra blank lines in et131x.h

Remove some blank lines from et131.h, including dounble blank lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b/drivers/staging/et131x/et131x.h

[PATCH 09/12] staging: et131x: logical continuations should be on the previous line

Fix two occurrences of the checkpatch check: CHECK: Logical continuations should be on the previous line Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

[PATCH 11/12] staging: et131x: Use braces on all arms of if/else statements

In some places in et131x.c, one arm of am if/else statement has braces and the other not - put braces on both arms where this happens. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 01/12 v2] staging: et131x: Remove extra blank lines in et131x.h

Remove some blank lines from et131.h, including double blank lines. Signed-off-by: Mark Einon --- Fixing minor typo in commit log. drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b

[PATCH 1/8] staging: et131x: Remove unused et131x_adapter struct members

These two adapter struct members are not used, remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index eefa9f1..358db97 100644 --- a/drivers

[PATCH 2/8] staging: et131x: Remove unused MP_TCB defines

These two defines are not used, so remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 358db97..d3615ae 100644 --- a/drivers/staging/et131x

[PATCH 6/8] staging: et131x: Use braces on all arms of if/else in et131x_handle_recv_pkts

The 'if' blocks have braces, so the 'else' blocks should too. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index a00

[PATCH 8/8] staging: et131x: Remove TODO item regarding split lines

Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 01d9351..13c8168 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -8,7 +8,6 @@ Note

[PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

Modify some packet status ring associated variables to save a few split lines: pktstat_ringsize -> psr_size psr_num_entries -> psr_entries index -> ii Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 39 +-- 1 file changed, 17 i

[PATCH 4/8] staging: et131x: Reduce split lines in et131x_rx_dma_memory_alloc()

Modify temporary variables so that split lines can be reduced: index -> k fbr_tmp_physaddr -> fbr_physaddr Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et13

[PATCH 7/8] staging: et131x: Reduce split lines by renaming flowcontrol

Rename adapter->flowcontrol to adapter->flow, reducing split lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/

[PATCH 3/8] staging: et131x: Remove unused ce_stats struct member

This ce_stats struct member is no longer used. Remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d3615ae..f1bf33b 100644 --- a/drivers/staging/et131x

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

et_device struct) > > + * > > + * Returns a value indicating if the interrupt was handled. > > + */ > > +static irqreturn_t et131x_isr(int irq, void *dev_id) > > +{ > > + bool handled = true; > > + bool enable_interrupts = true; > > + struct net

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote: > On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote: > > This patch moves the et131x gigabit ethernet driver from drivers/staging > > to drivers/net/ethernet/agere. > > > > There are no known issues at t

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

igurator to skip all > > + the questions about Atheros devices. If you say Y, you will be aske= > should this be "Agere devices" instead? Yes it should - well spotted, thanks - I'll change this in v2. Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote: > On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote: > > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: > > > > Hi Tobias, > > > > Thanks for the d

[PATCH 3/4] staging: et131x: Add space after { in pci ID table

Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 6539a8a..10f20b3 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x

[PATCH 1/4] staging: et131x: zero allocation of fbr to prevent random address access

br memory on allocation. Subsequent frees of this fbr memory explicitly zeros the ring_virtaddr value. Reported-by: Tobias Klauser Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 4/4] staging: et131x: Remove unnecessary defines to enable driver PM

The Power Management functions can be conditional by assigning pm ops directly to .driver.pm, instead of using #ifdef's, saving some lines of code. Reported-by: Tobias Klauser Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 ++- 1 file changed, 2 insertions(

[PATCH 2/4] staging: et131x: don't cast a void* to a struct pointer

Casting a void* popinter to a struct pointer is unnecessary, don't do it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 2889f86..65

[PATCH v2] et131x: Promote staging et131x driver to drivers/net

This patch moves the et131x gigabit ethernet driver from drivers/staging to drivers/net/ethernet/agere. Signed-off-by: Mark Einon --- Changes from v1: -modified MAINTAINERS in scope with changes -Fixed typo in Kconfig, Atheros -> Agere -Made review changes from Tobias Klauser, see patch

[PATCH 1/4] staging: et131x: Use ether_addr_copy when copying ethernet addresses

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 4b2ae49..b976c75 100644 --- a/drivers/staging/et131x

[PATCH 4/4] staging: et131x: Remove unnecessary parentheses

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index cd90831..0a927d2 100644 --- a/drivers/staging/et131x

[PATCH 3/4] staging: et131x: Remove unnecessary OOM message

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f5459ec..cd90831 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH 2/4] staging: et131x: Cat some lines less than 80 columns

Some split lines are less than 80 chars if rejoined, so rejoin them. Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

Re: [PATCH v2] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote: > On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote: > > This patch moves the et131x gigabit ethernet driver from drivers/staging > > to drivers/net/ethernet/agere. > > checkpatch type modification you might

Re: [PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

On Wed, Sep 24, 2014 at 01:11:42PM +0300, Dan Carpenter wrote: > On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote: > > static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter) > > { > > u8 id; > > - u32 index; > > + u32 ii

Re: [PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

for readability. This loop should > look like. > > for (i = 0; i < NUM_TCB; i++) { > tcb->next = tcb + 1; > tcb++; > } Fair point, I've simplified this loop in a patch. There are also a lot of comments that are either out of date or incorrect. I've also attempted to address this with another patch. Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: et131x: Simplify for loop in et131x_init_send()

The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH 1/2] staging: et131x: Audit and update comments

were just plain incorrect. Remove these too. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 328 +++- 1 file changed, 21 insertions(+), 307 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 0a927d2

[PATCH 1/2 resend] staging: et131x: Audit and update comments

were just plain incorrect. Remove these too. Signed-off-by: Mark Einon --- Resending after refresh against current head of staging-next, as previous patch only applied with fuzz. drivers/staging/et131x/et131x.c | 328 +++ 1 file changed, 21 insertions(+), 307

[PATCH 2/2 resend] staging: et131x: Simplify for loop in et131x_init_send()

The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

> --- Hi again, You probably wanted to send this patch to the maintainer of this driver, instead of me. I suggest you re-run scripts/getmaintainer.pl on the patch. Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxd

Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message

both staging-next and linux-next. Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] et131x: Promote staging et131x driver to drivers/net

This patch moves the et131x gigabit ethernet driver from drivers/staging to drivers/net/ethernet/agere. Signed-off-by: Mark Einon --- This patch appiles to both staging-next and the linux-next tag next-20140930, and takes into account all feedback recieved from the recent RFC for this patch

Re: [PATCH] et131x: Promote staging et131x driver to drivers/net

g a patch that adds the driver to drivers/net/... > Don't worry about the staging driver at the moment. If it gets added to > drivers/net we can then delete the staging driver. > > Sound easier? Should make the patches half as big. S

Re: [PATCH] staging: et131x: Remove et131x driver from drivers/staging

On Sat, Oct 04, 2014 at 01:37:31AM +0300, Dan Carpenter wrote: > Congrats. :) > > regards, > dan carpenter > And thanks for all the help, both! Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdr

Re: [PATCH 06/44] gpio-poweroff: Drop reference to pm_power_off from devicetree bindings

On Tue, Oct 07, 2014 at 06:28:08AM +0100, Guenter Roeck wrote: > pm_power_off is an implementation detail. Replace it with a more generic > description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland Acked-by: Mark Rutland &

Re: [PATCH 05/44] mfd: as3722: Drop reference to pm_power_off from devicetree bindings

On Tue, Oct 07, 2014 at 06:28:07AM +0100, Guenter Roeck wrote: > Devicetree bindings are supposed to be operating system independent > and should thus not describe how a specific functionality is implemented > in Linux. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rut

Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings

On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark R

Re: [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

Acked-by: Arnd Bergmann Acked-by: Mark Rutland That makes it obvious that others have looked at your patches, and will help maintainers when deciding whether to pick them up. Additionally, for those who have reviewed or tested patches, it gains them some recognition for that effort. Additionally, i

Re: [PATCH 05/44] mfd: as3722: Drop reference to pm_power_off from devicetree bindings

of view shared by the device tree maintainers, and it's been that way for a while. I don't really follow your concern. For one thing were this followed more strictly this file wouldn't need patching at all to correct for this Linux-internal rework... Thanks, Mark

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

ing that nothing "changed" in the source for type of patch that just moves functions around in a file. thanks, Greg, Would just testing the thing be of any help? Regards Mark ___ devel mailing list de...@linuxdriverproject.org http://drive

Re: linux-3.18-rc1 bug report

both cases Regards David Binderman Yes, this is certainly wrong. Eventually, all that code parsing the config file will have to be removed. Those above 2 sections particularly because I don't see any way to support the concentrators at the moment. Thanks

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

On 10/14/2014 08:01 AM, Mark Hounschell wrote: On 10/13/2014 10:04 PM, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH : On Mon, Oct 13, 2014 at 11:34:25AM +0900

Re: [PATCH RESEND] staging: dgap: re-arrange functions for removing forward declarations

On 10/29/2014 05:22 AM, Greg KH wrote: On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell Signed-off-by: Daeseok Youn --- RESEND: This patch is tested all by Mark. It is good to merge. Greg

[PATCH] staging: dgap: Remove myself from the MAINTAINERS file

respond to an inquiry concerning it or its firmware. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Cc: Ben Hutchings --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cf1a98d..1c19938 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3394,7

Re: [PATCH] staging: dgap: Remove myself from the MAINTAINERS file

On 09/15/2015 09:05 AM, Greg Kroah-Hartman wrote: On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote: Removes myself from the MAINTAINERS file for the dgap driver. There appears to be no way to get the firmware files required by the dgap driver into the linux-firmware tree. The

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

removed as it should not be needed. Mark, can you verify that this is not needed with your hardware anymore? As far as I can see it is still needed. If no config file, no devices are created and configured. I had planned to remove that code such that all the different cards supported are still

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

t;dgap:" prefix on print message on dgap. remove "out of memory" message. Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c | 306 +++ 1 files changed, 133 insertions(

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

On 07/16/2014 08:42 PM, DaeSeok Youn wrote: 2014-07-16 23:17 GMT+09:00 Mark Hounschell : On 07/16/2014 05:26 AM, DaeSeok Youn wrote: 2014-07-16 8:50 GMT+09:00 Greg KH : On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: Hi, 2014-07-16 0:29 GMT+09:00 Greg KH : On Tue, Jul 15

Re: [PATCH] staging: dgap: introduce dgap_cleanup_nodes()

re freed when dgap is unloaded or failed to initialize. > > Signed-off-by: Daeseok Youn > --- > Mark, please review this patch. > Thanks. > > drivers/staging/dgap/dgap.c | 47 > +++ > 1 files changed, 47 insertions(+), 0 deletions(

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

to initialize. Signed-off-by: Daeseok Youn --- V2: Do not need to free for NULLNODE. I have been too busy to solve this issue, sorry for late. Mark, Can you test this patch? I try to make simple module which is testing dgap_parsefile() and dgap_cleanup_nodes(). I'll be happy to, but I

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

On 07/31/2014 07:14 PM, DaeSeok Youn wrote: Hi, Mark 2014-07-31 21:44 GMT+09:00 Mark Hounschell : On 07/31/2014 12:02 AM, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and

[PATCH] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

org/show_bug.cgi?id=77121 Cc: sta...@vger.kernel.org Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c ind

[PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

org/show_bug.cgi?id=77121 Cc: sta...@vger.kernel.org Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c ind

Re: [PATCH] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Sat, Aug 09, 2014 at 09:39:17PM -0700, Greg KH wrote: > On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote: > > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed > > before it is initialised, by: > > > > - letting et131x_

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Mon, Aug 11, 2014 at 01:39:59PM +0800, gre...@linuxfoundation.org wrote: > On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: > > Do you have this hardware ? And did you test this ? > > Mark is the maintainer of this driver, I assume he has the hardware, if > no

[PATCH 0/8] Implement NAPI in et131x

ranch, not staging-next - so won't apply cleanly in it's current state. Please let me know if I need to do anything about this. Cheers, Mark --- Mark Einon (8): staging: et131x: Use eth_mac_addr() instead of duplicating the functionality staging: et131x: Don't handle rx/tx

[PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality

There's already working code to set the mac address, so let's use it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 53 + 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drive

<    1   2   3   4   5   6   >