On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate
On 02/28/2014 05:36 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:49:09PM -0500, Mark Hounschell wrote:
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap
On 03/01/2014 04:57 AM, Mark Hounschell wrote:
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
---
This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dga
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
On 03/03/2014 10:11 AM, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers
On 03/03/2014 10:30 AM, Dan Carpenter wrote:
On Mon, Mar 03, 2014 at 10:11:07AM -0500, Mark Hounschell wrote:
@@ -6689,7 +6681,6 @@ static void dgap_create_tty_sysfs(struct un_t *un, struct
device *c)
ret = sysfs_create_group(&c->kobj, &dgap_tty_attribute_group);
ine.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index cac2791..ff7bf2a 100644
--- a/drivers/staging/d
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 100 +++-
1 file changed, 80 insertions(+), 20
This patch series fixes some discrepancies noted in a
previous patch series.
Removes the rest of the debug/tracing code
Removes a nasty macro
Add curly braces back in for a multi-line indent block
Fixes some pr_warns with newline chars in the strings
Yes, these pr_warns will eventually ch
This patch fixes some pr_warns that have newline
chars in the string because they mess up the
output.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap
This patch removes more, if not all, of the debug/tracing code
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 27 ---
drivers/staging/dgap/dgap.h | 5 -
2 files changed, 32 deletions(-)
diff --git a/drivers/staging/dgap
Multi-line indent blocks get curly braces for readability.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 08ef106
On 03/03/2014 04:50 PM, Dan Carpenter wrote:
On Mon, Mar 03, 2014 at 04:36:23PM -0500, Mark Hounschell wrote:
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers
This patch replaces the DGAP_VERIFY_BOARD macro with
the dgap_verify_board function because of checkpatch error.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 62 +++--
1 file changed, 43 insertions(+), 19
We should not remove a sysfs group we failed to create
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 5dfce34..85f85eb
dgap_global_lock is no longer required. This patch
removes it.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
This patch fixes a checkpatch warning for not checking
the return value of sscanf.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
This patch removes the rawreadok module param and sysfs var
previously used to enable flip buffer bypass. Code dealing
with that param was removed previously.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 26 --
1 file changed
This patch fixes a checkpatch warning for
suspect code indent for conditional statements
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
This patch fixes a few of the many 80+ character lines
as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 260 +---
drivers/staging/dgap/dgap.h | 64 +--
2 files changed, 179
patch 01 prevents removal of sysfs group we have failed to create
patch 02 removes the now unnecessary dgap_global_lock
patch 03 removes the now unused rawreadok insmod paramater and associated
sysfiles
and code used to show and store this paramater. It was previously used
to
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 100 +---
1 file changed, 67 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
This patchset fixes more 80+ char lines as reported by checkpatch
There are still many more.
--
1.8.1.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 55 +
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
if (!brd->msgbuf) {
kfree(brd);
return -ENOMEM;
I'm pretty sure this has already been fixed up in current staging-next.
Thanks
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
On 03/05/2014 04:39 PM, Dan Carpenter wrote:
Btw, if you don't get any messages from me that means I have given your
patch the stamp of approval. So good job on your previous patchset. :)
On Wed, Mar 05, 2014 at 03:54:49PM -0500, Mark Hounschell wrote:
@@ -1613,7 +1616,8 @@ static
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const
unsigned char *buf, int
if (down_interruptible(&dgap_TmpWrit
On 03/06/2014 10:11 AM, Dan Carpenter wrote:
On Thu, Mar 06, 2014 at 09:56:29AM -0500, Mark Hounschell wrote:
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 52 +
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
This patch removes more dead code and code associated
with that dead code. The from_user variable in the
dgap_tty_write function was never true. The code under
its test was never being executed. So variables and
functions supporting only that code are also dead.
Signed-off-by: Mark Hounschell
r
not checking its return. So we remove the printk's
and check the return of driver_create_file.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const
unsigned char *buf, int
if (down_interruptible(&dgap_TmpWrit
On 03/06/2014 02:29 PM, Dan Carpenter wrote:
On Thu, Mar 06, 2014 at 01:57:55PM -0500, Mark Hounschell wrote:
This patch removes printks associated with sysfile creation
and changes the dgap_create_driver_sysfiles function to return
an int so we can check for errors in the sysfile creation
This patch simplifies and cleans up the dgap_init_module function. It also fixes
a possible double free condition as a result pci_unregister_driver possibly
being called twice.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 38
This is just for comments. The indentation was alread so far
over 80 chars I (as recommended earlier) make a couple of
new functions. Somehow I don't think this is proper and there
is probably a better way to do this. This is untested.
Signed-off-by: Mark Hounschell
---
drivers/staging
ap_write_wakeup(bd, ch, &ch->ch_tun, UN_EMPTY,
+ &lock_flags, &lock_flags2);
+ dgap_write_wakeup(bd, ch, &ch->ch_pun, UN_EMPTY,
+ &lock_flags, &lock_flags2);
if (ch->ch_flags & CH_WEMPTY) {
ch->ch_flags &= ~CH_WEMPTY;
wake_up_interruptible(&ch->ch_flags_wait);
I need to test this. I have been unable to do any thing in my testing
that actually causes ldisc->ops->write_wakeup) to actually get called??
But after looking I do like this better.
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 03/08/2014 04:59 AM, Mark Hounschell wrote:
On 03/07/2014 05:46 PM, Dan Carpenter wrote:
I still prefer my patch. Unless I'm missing something? Could you
review it and I will submit it as a patch tomorrow.
I've reviewed it and see no obvious problems. If you like it better, I&
This patch fixes a few 80+ char lines
as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 55 -
1 file changed, 30 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
This patch fixes a few more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
This patch fixes a few more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 162 ++--
1 file changed, 113 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/dgap
Patch 1 - removes some unused defines in dgap.h
Patch 2 - removes some unneeded code supporting
the old firmware loading process.
--
1.8.1.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/
This patch removes more unneeded code that was
supporting the old firmware loading process
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 149
1 file changed, 149 deletions
This patch removes some unused defines in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 53 ++---
1 file changed, 2 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers
This patch removes the unused DGAP_TRYLOCK macro
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
index 415d816..feeea7c 100644
--- a/drivers
This patch gets rid of the DGAP_SPINLOCK_INIT macro
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4 ++--
drivers/staging/dgap/dgap.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
patches 1-3 remove most of the unneeded state machine
tracking code and variables previously used in the old
firmware loading process.
patch 4 adds back in a pr_info that provided information
on each board found and configured. This got removed in
a previous patch that removed the debug and traci
The only driver states we need now is READY or !READY.
No need for a sysfs method of seeing those 2 states so
the sysfs entries for dgap_driver_state is also removed.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 26
This patch removes more unneeded brd-state states
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 35 +--
drivers/staging/dgap/dgap.h | 2 --
2 files changed, 17 insertions(+), 20 deletions
This patch removes unused brd->state states previously
used in the userland firmware download process.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 5 -
drivers/staging/dgap/dgap.h | 17 -
2 fi
This patch adds a pr_info per board that indicates
board number, type, etc..
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ddeff5f
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote:
> From: mourn
>
> Signed-off-by: mourn
> ---
> drivers/staging/android/uapi/ion.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
The changes look good, however you should be a bit more specific about whic
I'll try that again...
On Thu, Mar 13, 2014 at 01:50:47PM +0000, Mark Einon wrote:
> On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote:
> > From: mourn
> >
> > Signed-off-by: mourn
> > ---
> > drivers/staging/android/uapi/ion.h |
char printable[bytesToDumpPerLine + 1];
- char hex[(bytesToDumpPerLine * 3) + 1];
+ char printable[24];
+ char hex[64];
Hi,
This isn't a good fix - this introduces a bug as later in this function,
'printable' and 'hex' are memset and assigned using the
bytesToDum
his looks like code churn - does it fix anything?
It's also on the rx path for the device, I'm not familiar with the device
details but it could be called with high frequency - so only initialising these
variables on the paths where they are used would be a good thing.
Cheers,
Mark
ceMACAddress);
You've also gone way over the 80 char limit for the line, for no real reason.
if anything, I would consider making
psfCSType->cCPacketClassificationRule.u8EthernetSourceMACAddress more readable.
Similarly for the changes below.
Cheers,
Mark
>
>
On Sun, Mar 16, 2014 at 10:16:09PM -0400, Gary Rookard wrote:
>
>
> On Sun, 16 Mar 2014, Gary Rookard wrote:
>
> >
> >
> >On Sun, 16 Mar 2014, Mark Einon wrote:
> >
> >>On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
> &g
p_write_wakeup(bd, ch, &ch->ch_tun, UN_EMPTY,
+ &lock_flags, &lock_flags2);
+ dgap_write_wakeup(bd, ch, &ch->ch_pun, UN_EMPTY,
+ &l
, src, len)
We know we're in the kernel, so there's no need for this #ifdef - also
why not get rid of the define altogether, and use the memcpy_toio()
function call direct? ...similarly for the other defines here.
Cheers,
Mark
#define CHANNEL_GUID_MISMATCH(chType, chName, field
This patch re-factors some code to fix some 80+ lines as reported by checkpatch.
This patch was suggested and authored by Dan Carpenter. A test case for this
patch has been written and used to show the patch to be correct.
Suggested-by: Dan Carpenter
Signed-off-by: Mark Hounschell
Tested-by
patch 1 re-factors some code to fix warnings by
checkpatch about 80+ char lines. This patch was
suggested by Dan Carpenter. A test case for this
patch has been written and used and used to show
the patch to be correct.
patch 2 gets rid of the DGAP_LOCK and DGAP_UNLOCK macros
patch 3 re-factors
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 442 ++--
drivers/staging/dgap/dgap.h | 7 -
2 files changed
This patch fixes more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 40 +---
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a
On 03/19/2014 11:49 AM, Greg Kroah-Hartman wrote:
Your subject [02/xx] seems a bit odd :)
Oops. The xx was there in my patches until I knew how many there would
be in the series. Forgot to change it. Sorry. Want me to redo? Easy enough.
___
devel
This patch fixes all the simple_strtol and simple_strtoul warnings
as reported by checkpatch. After this patch, checkpatch will report
zero errors or warnings on dgap.c.
Signed-off-by: Mark Hounschell
Tested-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 69
patch 1 removes some unused code in dgap.c
patch 2 removes some unneeded comments in dgap.c
patch 3 fixes some whitespace warnings by checkpatch in dgap.h
patch 4 fixes several 80+ char lines in dgap.h.
Note that many of these 80+ char lines
are lines using "volatile" which also
This patch removes some unused code in dgap.c.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index a5fc3c7..ea66c9f 100644
--- a/drivers
This patch fixes several 80+ char line warnings as reported
by checkpatch in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 244 +++-
1 file changed, 129 insertions(+), 115 deletions(-)
diff --git a
This patch removes some unneeded comments from dgap.c
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ea66c9f
This patch removes some unused code in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 53 -
1 file changed, 53 deletions(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
index
This patch fixes some whitespace warnings as reported
by checkpatch in dgap.h.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 47 +++--
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers
This patch fixes checkpatch warnings about using volatiles in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.h | 152 ++--
1 file changed, 76 insertions(+), 76 deletions(-)
diff
This patch fixes a checkpatch warning about adding typedefs
in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h
index
patch 1: remove some extra empty lines not previously caught.
patch 2: the firmware loading provess loads the config file
for each board found. It only needs to load it once.
patch 3: fixes a checkpatch warning about a macro needing parenthesis
patch 4: removes volatiles from dgap.h as rec
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.h
This patch removes excessive empty lines from dgap.h
not previously caught.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap
This patch just fixes a pr_info. brd->state is not proper
at this point in time.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/d
The config file is currently read for each board found.
It only needs to be read one time. The buffer it is read
into can now be freed immediately after it is parsed
instead of at driver unload time.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 18
struct bs_t *bs;
+ struct bs_t __iomem *bs;
uintmajor = 0;
uintminor = 0;
int rc = 0;
Thanks for any pointers
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://drive
On 03/28/2014 07:34 AM, Dan Carpenter wrote:
> These patches are fine and they were applied already.
>
> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd,
>> uchar _
On 03/28/2014 09:08 AM, Mark Hounschell wrote:
> On 03/28/2014 07:34 AM, Dan Carpenter wrote:
>> These patches are fine and they were applied already.
>>
>> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>>> @@ -4368,15 +4364,16 @@ static void dg
On 04/03/2014 04:56 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:18PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning about adding typedefs
in dgap.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.h | 2 +-
1 file changed
On 04/03/2014 04:51 AM, Dan Carpenter wrote:
On Tue, Mar 25, 2014 at 04:38:15PM -0400, Mark Hounschell wrote:
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Really this is a bug in checkpatch.pl. We have the source for that, so
Fix checkpatch check:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Mark Einon
---
dr
Fix checkpatch warnings, lines over 80 chars using tabs where possible.
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/rtl8821ae/hw.h | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.h
b/drivers
Fix all occurences of the checkpatch error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/rtl8821ae/hw.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.
On 04/14/2014 12:00 PM, Greg Kroah-Hartman wrote:
> On Thu, Apr 03, 2014 at 08:57:56AM -0400, Mark Hounschell wrote:
>> This patch removes the uchar define in dgap.h and
>> changes all uses of uchar to u8.
>>
>> Signed-off-by: Mark Hounschell
>> Tested-by: Ma
On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote:
> On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote:
>> The config file is currently read for each board found.
>> It only needs to be read one time. The buffer it is read
>> into can now be freed immediate
This patch removes the uchar typedef in dgap.h
and changes all uses of it to u8.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 100 ++--
drivers/staging/dgap/dgap.h | 65 ++--
2 files
On 04/15/2014 06:01 AM, Dan Carpenter wrote:
> On Mon, Apr 14, 2014 at 03:17:19PM -0400, Mark Hounschell wrote:
>> On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote:
>>> On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote:
>>>> The config file is curre
, since the oops is rarely the same, do I need
to include an oops message with my patch or should I just indicate
"various oops"?
Thanks
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailma
All code in this file is encapsulated in a useless #if 1
declaration, remove it.
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c
Fixes all checkpatch errors reporting that statics shouldn't be initialised
to their defualt values.
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8
We set btrssi to zero and then immediately assign it. Assign it
on declaration instead.
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/btcoexist
Fix checkpatch issues relating to using leading spaces instead of tabs.
Whitespace changes only.
Signed-off-by: Mark Einon
---
.../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging
Sparse complains about halbtc8192e2ant_low_penalty_ra() not being used,
and subsequently halbtc8192e2ant_set_sw_penalty_tx_rateadaptive() when
this is removed. remove both functions.
Signed-off-by: Mark Einon
---
.../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 48
1
In halbtc8192e2ant.c, fix all instances of the sparse warning:
warning: symbol 'xxx' was not declared. Should it be static?
Signed-off-by: Mark Einon
---
.../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 218 ++--
1 file changed, 114 insertions(+), 104 deletion
201 - 300 of 565 matches
Mail list logo
