Fixes three checkpatch warnings due to braces used when single
statements are sufficient.
Signed-off-by: Mark Stenglein
---
drivers/staging/iio/accel/adis16209.c | 3 +--
drivers/staging/iio/accel/adis16240.c | 6 ++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers
Fixes three instances of the following checklist error:
- ERROR: Macros with complex values should be enclosed
in parentheses
Simply adds parentheses around the macros to fix the problem.
Signed-off-by: Mark Stenglein
---
drivers/staging/most/mostcore/core.c | 12 ++--
1 file
n audio.h
> + * (Android media layer)
> + */
> enum {
> GBAUDIO_DEVICE_NONE = 0x0,
> /* reserved bits */
> --
> 1.9.1
Reviewed-by: Mark Greer
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote:
> As the pxa architecture switched towards the dmaengine slave map, the
> old compatibility mechanism to acquire the dma requestor line number and
> priority are not needed anymore.
Acked-by: Mark Brown
If there's no
On Fri, Apr 20, 2018 at 03:28:26PM +0200, Geert Uytterhoeven wrote:
> The first 6 patches can be applied independently by subsystem
> maintainers.
> The last two patches depend on the first 6 patches, and are thus marked
> RFC.
Would it not make sense to try to apply everything en masse rather th
, "Invalid kcontrol count=%d for %s\n",
> w->ncontrols, w->name);
> return ret;
> }
Acked-by: Mark Greer
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
f or hypervisor page tables.
> + */
> + touch = READ_ONCE(*(char *)input);
> + dmb(sy);
> + }
> +
> + /* Let the caller sort it out. */
> + return -1;
AFAICT, callers of slow_virt_to_phys() don't check the
On Sun, Dec 01, 2019 at 11:40:32AM +, Jonathan Cameron wrote:
> +CC Mark as we probably need a more general view point on
> the question of whether SPI mode should be enforced by binding
> or in the driver.
Not sure I see the question here, I think I was missing a bit of
the con
On Tue, Dec 03, 2019 at 04:51:54PM +, Jonathan Cameron wrote:
> If the driver picks a mode because that's what it says on the datasheet
> it prevents odd board configurations from working. The question
> becomes whether it makes sense in general to assume those odd board
> conditions don't ex
On Wed, Dec 04, 2019 at 07:18:15AM +, Ardelean, Alexandru wrote:
> One example (for spi-cpha):
> if (of_property_read_u32(nc, "spi-cpha", &tmp) == 0) {
> spi->mode |= SPI_CPHA_OVERRIDE;
> if (tmp)
> spi->mode |= SPI_CPHA;
We could al
aml renames;
> - file renames (still on txt format);
This seems like it should've been split up a bit. :/
Acked-by: Mark Brown
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driver
On Fri, May 08, 2020 at 01:43:07PM +0100, Jonathan Cameron wrote:
> Dan Carpenter wrote:
> > It feels like we should just make a devm_ version of regulator_enable().
> > Or potentially this is more complicated than it seems, but in that case
> > probably adding devm_add_action_or_reset() is more
ing again they can take a look at the git history.
Thanks for this, Alexandre.
Acked-by: Mark Greer
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
br[1]) {
> kfree(rx_ring->fbr[0]);
> return -ENOMEM;
> }
>
> The other changes seem good.
Yes, I agree - if this function is going to clear up after itself, there
are a few other allocations further down that also need to handle freeing
already allocated resources,
On Fri, Feb 07, 2014 at 07:12:50PM +0800, Zhao, Gang wrote:
> Mark, could you look at this patch? It has not been acked.
Sure, in time, I'm making my way through them. Unfortunately kernel
programming is not my day job, and gets done in my spare time (which
is a bit limited at present).
ap_trace.patch
016-remove-kcompat_and_types.h.patch
017-rename-driver-to-dgap.patch
Regards
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-01-31
10:53
Remove userland downld.c source file.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urN linux-3.13.1-orig/drivers/staging/dgap/downld.c
linux-3.13.1-new/drivers/staging/dgap/downld.c
--- linux-3.13.1-orig/drivers/staging/dgap/downld.c 2014-01-29
08:06:37.0 -0500
Add in kernel firmware loading support
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-03
13:34
Remove user land dgap_downld.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h
linux-3.13.1-new/drivers/staging/dgap/dgap_downld.h
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h2014-01-29
08:06
Merge dgap_parse.h into dgap-driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-10
15:39
Merge dgap_conf.h into dgap-driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_conf.h
linux-3.13.1-new/drivers/staging/dgap/dgap_conf.h
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_conf.h 2014-01-29
08:06:37.0
Merge digi.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.h
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.h
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.h2014-02-10
16:27
Merge dgap_pci.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-10
16:27
Merge dgap_sysfs.c into dgap_driver.c
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11
09:03
Merge dgap_sysfs.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11
09:13
Remove dgap_kcompat.h and_dgap_types.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11
09:55
Merge dgap_tty.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11
08:47
Remove dgap_trace.c and dgap_trace.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11
09:33
On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote:
>> Merge dgap_fep5.h into dgap_driver.h
>>
>> Signed-off-by: Mark Hounschell
>> Cc: Greg Kroah-Hartman
>
> Same here, why merge these files?
>
On 02/12/2014 01:41 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 12, 2014 at 12:49:46PM -0500, Mark Hounschell wrote:
>> Add in kernel firmware loading support
>>
>> Signed-off-by: Mark Hounschell
>> Cc: Greg Kroah-Hartman
>
> You also do other things in this
7.0 -0500
>> +++ linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c 2014-01-31
>> 10:22:53.675819451 -0500
>
> Did you generate this with git? What happened to the diffstat?
>
No, I did not use git. I used what was suggeste
On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote:
>> On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote:
>>> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote:
>>>> Merge dgap_fep5.h into
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging
Remove userland downld.c source file. This file is not used by the kernel.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap/downld.c | 798
1 file changed, 798 deletions(-)
diff -urN linux-3.13.1-orig/drivers/staging/dgap/downld.c
Add in kernel firmware loading support
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap/dgap_driver.c | 635 ---
drivers/staging/dgap/dgap_driver.h |6
2 files changed, 381 insertions(+), 260 deletions(-)
diff -urN linux-3.13.1-orig
Remove user land dgap_downld.h. This file is not used by the kernel.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap/dgap_downld.h | 69 ---
1 file changed, 69 deletions(-)
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_parse.h into dgap-driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_conf.h into dgap-driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
diff -urpN linux
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge digi.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_pci.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_tty.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_sysfs.c into dgap_driver.c
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_sysfs.h into dgap_driver.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers
Remove dgap_trace.c and dgap_trace.h. These files are not required.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap/Makefile |4
drivers/staging/dgap/dgap_driver.c |5
drivers/staging/dgap/dgap_trace.c | 185 ---
drivers
Remove dgap_kcompat.h and_dgap_types.h. These files are only required for
older 2.x.x kernels.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
drivers/staging/dgap/dgap_driver.c |2
drivers/staging/dgap/dgap_driver.h | 22
drivers/staging/dgap/dgap_kcompat.h | 64
I always pretend submitters
> work for the US government to sabotage things and insert backdoors. I
> want to verify that the patch does exactly what it says and nothing
> more.
>
Understood. I just sent v2 of the series. I hope all is OK.
Regards
Mark
___
On 02/14/2014 12:34 PM, Greg Kroah-Hartman wrote:
> Minor nits for future patch submissions:
>
> On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
>> There is a lot of cleanup work to do on these digi drivers and merging as
>> much as is possible will make it
On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
>> There is a lot of cleanup work to do on these digi drivers and merging as
>> much as is possible will make it easier. I also notice that many merged
>> driv
On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote:
> On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote:
>> On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
>>> On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
>>>> There is a lot of cl
On 02/17/2014 05:50 PM, Greg Kroah-Hartman wrote:
> On Mon, Feb 17, 2014 at 02:32:28PM -0500, Mark Hounschell wrote:
>> On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote:
>>> On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote:
>>>> On 02/14/2014 12:3
On 02/18/2014 08:14 AM, Dan Carpenter wrote:
> On Tue, Feb 18, 2014 at 08:00:57AM -0500, Mark Hounschell wrote:
>> That's odd. I just installed vanilla 3.14-rc3 yesterday from kernel.org.
>> It boots up fine but does not appear to have the same dgap driver as
>> staging-
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_conf.h | 289
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.h | 33
This patch series whittles down the drivers/staging/dgap directory to
just 4 files (dgap_driver.c, dgap_driver.h, Makefile, and Kconfig).
This was done because there is a lot of cleanup work to do on these
digi drivers and merging as much as is possible will make it easier.
I also notice that ma
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 22
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 9
This patch makes all merged and original functions static to dgap.c.
Doing so has revealed more dead code via gcc warnings.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 159 +
drivers/staging/dgap
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 12
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.h | 353
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 1 -
drivers
This patch removes all the original CVS tags because they are in my way
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_conf.h | 1 -
drivers/staging/dgap/dgap_downld.h | 1 -
drivers/staging/dgap/dgap_driver.c | 1 -
drivers/staging/dgap/dgap_fep5.c | 1
This patch removes userland source code files downld.c and dgap_downld.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_downld.h | 68
drivers/staging/dgap/downld.c | 797 -
2 files changed, 865 deletions
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 1 -
drivers
Removes unneeded files dgap_trace.c and dgap_trace.h
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/Makefile | 3 +-
drivers/staging/dgap/dgap_driver.c | 1 -
drivers/staging/dgap/dgap_trace.c | 185 -
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/Makefile | 3
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 540 +++-
1 file changed, 338 insertions
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap_driver.c | 1 -
drivers
On 02/19/2014 03:17 PM, Dan Carpenter wrote:
> This one has white space problems. Run scripts/checkpatch.pl on your
> patches before sending. Comments below.
>
> On Wed, Feb 19, 2014 at 01:12:15PM -0500, Mark Hounschell wrote:
>> +static int dgap_firmware_load(struct
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 529 +++-
1 file changed, 327 insertions
On 02/20/2014 03:58 AM, Dan Carpenter wrote:
> On Wed, Feb 19, 2014 at 04:54:15PM -0500, Mark Hounschell wrote:
>> This patch adds in-kernel firmware loading support and removes
>> support for the original userland firmware loading process.
>>
>> Signed-off-by: Mark Ho
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 525 +++-
1 file changed, 323 insertions(+), 202 deletions(-)
diff
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 525 +++-
1 file changed, 323 insertions
When a kernel subsystem undergoes a global change such as the serial
subsystem has been since 3.5 or so, if a driver is in staging, does it
automatically get those changes if they are applicable to it?
Thanks
Mark
___
devel mailing list
de
On 02/24/2014 07:49 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 19, 2014 at 01:12:14PM -0500, Mark Hounschell wrote:
>> Renames driver file dgap_driver.c and dgap_driver.h to
>> dgap.c and dgap.h because we are now single source and
>> include file and better fits kern
blem types such as returns, white space, 80 char
limits, etc, by individual patches? Or would a one shot patch fixing all
that checkpatch finds be OK?
Thanks
mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.o
The last patch series exposed some dead code causing compile warnings.
This patch removes that dead code and fixes the warnings
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 145
1 file changed, 145
hat this
is proper.
Thanks for reviewing.
mark
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 7cb1ad5..d56b3b2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -223,7 +223,7 @@ static void dgap_get_vpd(struct board_t *brd);
static void dgap_do_
On 02/25/2014 11:48 AM, Greg KH wrote:
On Tue, Feb 25, 2014 at 10:56:22AM -0500, Mark Hounschell wrote:
When opening a port the dgap driver OOPs with a message:
tty_init_dev: driver does not set tty->port... will crash the kernel... fix the
driver... etc...
Then I have to reboot the box.
On 02/25/2014 01:40 PM, Mark Hounschell wrote:
+struct dgap_port {
+struct tty_port port;
+};
Do you really need a wrapping structure here?
I may be incorrect, but I think so. I will investigate this further
before I make a patch.
It looks to me like this is how it should be done
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty->port. This will crash the kernel later. Fix the
driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell
Cc: Greg Kr
On 02/26/2014 09:01 AM, Dan Carpenter wrote:
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote:
-static void dgap_sysfs_create(struct board_t *brd)
+static int dgap_tty_register_ports(struct board_t *brd)
{
struct channel_t *ch;
- int j = 0;
+ int i
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty->port. This will crash the kernel later. Fix the
driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell
Cc: Greg Kr
On 02/26/2014 10:30 AM, Dan Carpenter wrote:
> On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
>> This patch addresses the follow error message followed
>> by a kernel oops:
>>
>> dgap: driver does not set tty->port. This will crash the kernel late
for a userland
application used to load firmware into the boards. It is no longer in
the repo and firmware loading is now done in kernel.
Regards
Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
{
ch->ch_flags &= ~CH_WLOW;
Thanks Dan. I see what should be done. I like and can work on this. But
is it OK to save all the 80 char problems until the end of this next
series or more likely a separate patch all together? Since I'm trying to
make i
This patch fixes all "include" related errors in
dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/st
This patch fixes white space errors in dgap.c
as reported by checkpatch. It also changes
unnecessary mutliple empty lines with a single
empty line
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 314
1 file changed, 86 insertions
This patch fixes "foo* bar should be foo *bar" errors
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drive
This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dg
This patch fixes all indent errs in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 148 +++-
1 file changed, 77 insertions(+), 71 deletions(-)
diff --git a/drivers/staging/dgap
This patch series begins the process of cleaning up
dgap.c and dgap.h using the checkpath tool. One or more
of these patches will show checkpatch errors that will
be cleaned up in following patches
--
1.8.1.4
___
devel mailing list
de...@linuxdriverpro
Fix all return staments in err as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 672 ++--
1 file changed, 336 insertions(+), 336 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
This patch fixes bracing errors in dgap.c
as reported by checkpatch
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 338
1 file changed, 121 insertions(+), 217 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
This patch fixes "do not use assignment in if condition"
errors reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 75 ++---
1 file changed, 50 insertions(+), 25 deletions(-)
di
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 38 +-
1 file changed, 5
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
I don't want to review it more than once if I can avoid
that.
On Fri, Feb 28, 2014 at 12:42:08PM -0500, Mark Hounschell wrote:
The original debug and tracing code is no longer required.
This patch removes it
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
- if ((tty
() is disgusting. From what I read in
CodingStyle, I should replace it with the actual code because of the
returns in it?
The -EFAULT vs -EINVAL thing can be addressed later on once I understand
the difference?
Thanks
Mark
___
devel mailing list
de
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 8
1 fi
101 - 200 of 565 matches
Mail list logo
