Re: [PATCH] bcm2835-audio: Fix checkpatch errors

2017-02-13 Thread Man Choy
On Mon, Feb 13, 2017 at 8:03 PM, Greg Kroah-Hartman wrote: > On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote: >> A quick question, I just updated my linux-next tree last night, >> checkout tag "next-20170210" and working on the cleanup. How do I >> doubl

[PATCH] bcm2048: Fix checkpatch checks

2017-02-17 Thread Man Choy
Fix following checks: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); CHECK: spaces preferred around that '+' (ctx:VxV) + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); ^ CHE

[PATCH] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index a61c02b..1cd38e7 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup

[PATCH v2] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 1cd38e7..968d8b6 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup

Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
On Thu, Feb 23, 2017 at 9:34 PM, Joe Perches wrote: > On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote: > [] >> diff --git a/drivers/staging/speakup/synth.c >> b/drivers/staging/speakup/synth.c > [] >> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_s

[PATCH] Staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Fix following warning: WARNING: line over 80 characters +&synth->attributes) < 0) Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH] speakup: synth: Fix checkpatch warning

2017-02-25 Thread Man Choy
Fix following checkpatch warning: WARNING: line over 80 characters +&synth->attributes) < 0) total: 0 errors, 1 warnings, 485 lines checked Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 4 ++-- 1 file

Re: [PATCH] speakup: synth: Fix checkpatch warning

2017-02-27 Thread Man Choy
On Mon, Feb 27, 2017 at 10:42 PM, Greg KH wrote: > On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote: >> Fix following checkpatch warning: >> >> WARNING: line over 80 characters >> +&synth->attribut

Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Man Choy
On Mon, Feb 27, 2017 at 4:21 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: >> Fix following checks: >> >> CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather >> than BUG() or BUG_

[PATCH] bcm2835-audio: Fix checkpatch errors

2017-02-12 Thread Man Choy
Fix following errors: ERROR: do not initialise statics to NULL +static struct snd_card *g_card = NULL; ERROR: do not initialise statics to NULL +static struct bcm2835_chip *g_chip = NULL; Signed-off-by: Man Choy --- drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- 1 file changed, 2

Re: [PATCH] bcm2835-audio: Fix checkpatch errors

2017-02-12 Thread Man Choy
On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman wrote: > On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: >> Fix following errors: >> >> ERROR: do not initialise statics to NULL >> +static struct snd_card *g_card = NULL; >> >> ERROR: do no