et_ptr.s.addr -
cvmx_ptr_to_phys(skb->head);
Signed-off-by: Luis de Bethencourt
---
drivers/staging/octeon/ethernet-rx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..bd83
checkpatch makes an exception to the 80-colum rule for quotes strings, and
Documentation/CodingStyle recommends not splitting quotes strings across lines
because it breaks the ability to grep for the string. Fixing these.
WARNING: quoted string split across lines
Signed-off-by: Luis de
checkpatch makes an exception to the 80-colum rule for quotes strings, and
Documentation/CodingStyle recommends not splitting quotes strings across lines
because it breaks the ability to grep for the string. Fixing these.
WARNING: quoted string split across lines
Signed-off-by: Luis de
On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote:
> On Tue, 2014-11-25 at 20:19 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings ac
On Tue, Nov 25, 2014 at 01:00:07PM -0800, Joe Perches wrote:
> On Tue, 2014-11-25 at 20:40 +0000, Luis de Bethencourt wrote:
> > On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote:
> > > On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote:
> > > > ch
On Wed, Nov 26, 2014 at 01:45:23PM -0800, Greg KH wrote:
> On Tue, Nov 25, 2014 at 01:26:14PM +0000, Luis de Bethencourt wrote:
> > This patch fixes the checkpatch.pl warnings:
> >
> > WARNING: line over 80 characters
> > + int cores_in_use
On Wed, Nov 26, 2014 at 08:05:55AM -0800, Joe Perches wrote:
> On Wed, 2014-11-26 at 15:42 +0000, Luis de Bethencourt wrote:
> > On 26 November 2014 at 01:49, Joe Perches wrote:
> []
> > > There is a script I posted a while back that
> > > groups various c
On Wed, Nov 26, 2014 at 06:34:10PM -0800, Greg KH wrote:
> On Thu, Nov 27, 2014 at 12:35:23AM +0000, Luis de Bethencourt wrote:
> > On Wed, Nov 26, 2014 at 01:45:23PM -0800, Greg KH wrote:
> > > On Tue, Nov 25, 2014 at 01:26:14PM +, Luis de Bethencourt wrote:
> >
Fixing 80 character limit warnings in octeon/ethernet-rx.c
Signed-off-by: Luis de Bethencourt
---
drivers/staging/octeon/ethernet-rx.c | 51 +---
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers
On Thu, Nov 27, 2014 at 08:34:00AM -0800, Joe Perches wrote:
> On Thu, 2014-11-27 at 17:18 +0100, Luis de Bethencourt wrote:
> > Fixing 80 character limit warnings in octeon/ethernet-rx.c
>
> Hello again Luis.
>
> Another thing you might consider is to align
> multipl
On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote:
> On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote:
> > Fixing 80 character limit warnings in octeon/ethernet-rx.c
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
> > drivers/
Fixing 80 character limit warnings in octeon/ethernet-rx.c
Signed-off-by: Luis de Bethencourt
---
drivers/staging/octeon/ethernet-rx.c | 49
1 file changed, 33 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers
On Fri, Nov 28, 2014 at 05:14:32PM +0300, Dan Carpenter wrote:
> On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote:
> > On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote:
> > > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote:
checkpatch makes an exception to the 80-column rule for quotes strings, and
Documentation/CodingStyle recommends not splitting quotes strings across lines
because it breaks the ability to grep for the string. Fixing these.
WARNING: quoted string split across lines
Signed-off-by: Luis de
The previous patch switched some dev functions to move the string to a second
line. Doing this for all similar functions because it makes the driver easier
to read if all similar lines use the same criteria.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/media/lirc/lirc_zilog.c | 155
On Thu, Dec 04, 2014 at 01:16:11PM -0200, Mauro Carvalho Chehab wrote:
> Hi Luis,
>
> Em Tue, 25 Nov 2014 20:36:29 +0000
> Luis de Bethencourt escreveu:
>
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle reco
checkpatch makes an exception to the 80-colum rule for quotes strings, and
Documentation/CodingStyle recommends not splitting quotes strings across lines
because it breaks the ability to grep for the string. Fixing these.
WARNING: quoted string split across lines
Signed-off-by: Luis de
The previous patch switched some dev functions to move the string to a second
line. Doing this for all similar functions because it makes the driver easier
to read if all similar lines use the same criteria.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/media/lirc/lirc_zilog.c | 57
On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings ac
On Wed, Dec 10, 2014 at 04:01:04PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 23:57 +0000, Luis de Bethencourt wrote:
> > On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> > > On Wed, 2014-12-10 at 22:33 +, Luis de Bethencourt wrote:
> > > >
checkpatch makes an exception to the 80-colum rule for quotes strings, and
Documentation/CodingStyle recommends not splitting quotes strings across lines
because it breaks the ability to grep for the string. Fixing these.
WARNING: quoted string split across lines
Signed-off-by: Luis de
The previous patch switched some dev functions to move the string to a second
line. Doing this for all similar functions because it makes the driver easier
to read if all similar lines use the same criteria.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/media/lirc/lirc_zilog.c | 57
Missing newline character at the end of string passed to dev_err()
Signed-off-by: Luis de Bethencourt
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc
There is no need to use 'else' if in main branch 'return' is present.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c
b/dr
If an "if" branch is terminated by a "goto", there's no need to have an
"else" statement and an indented block of code.
Remove the "else" statement to simplify the code flow.
Signed-off-by: Luis de Bethencourt
---
Hi,
The following patches rem
There is no need to use 'else' if in main branch 'goto' is present.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.
On Wed, Apr 08, 2015 at 08:09:03AM -0300, Mauro Carvalho Chehab wrote:
> Em Sun, 8 Feb 2015 20:55:36 +
> luisbg escreveu:
>
> > Improve code readability by moving out all pre-init values from the init
> > function.
> >
> > Signed-off-by: Luis de Bethenco
Hi al,
Looks good and silences the checkpatch warnings.
Christian,
There are more checkpatch warnings in this file. Could you fix them as well?
Reviewed-by: Luis de Bethencourt
On Thu, Nov 19, 2015 at 02:40:59PM +0100, Christian Colic wrote:
> Fix checkpatch check: CHECK: spaces prefer
On 25/04/16 16:43, Parth Sane wrote:
> Fixed alignment to match open parenthesis.
>
> Signed-off-by: Parth Sane
>
> ---
> Changes in v6:
> -Added line before Signed-off message
>
This last version looks good to me. Did you find this issue with checkpatch.pl?
Thanks,
Luis
__
el/git/torvalds/linux.git/commit/?id=5f10ef7dce02d8e36665974aca0977cda58c1122
Verbosity in the commit message is a good thing :)
I have tested that your patch still applies cleanly to Greg's staging-testing
branch.
Thanks,
Luis
>> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt
>>
ng as a tip.
Please keep submitting fixes. Appreciated.
Luis
>> On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt
>> wrote:
>>
>> On 26/04/16 15:33, Parth Sane wrote:
>>> Hi,
>>> Thanks for the feedback. I did find this issue with the assistance
>&g
On 05/05/16 05:52, David Kershner wrote:
> From: Erik Arfvidson
>
> The following struct members were never used:
> putfile_active_buffer::pnext
> putfile_request::file_request_number
> putfile_request::data_sequence_number
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: David Kershner
>
On 05/05/16 05:54, David Kershner wrote:
> From: David Binder
>
> Fixes the spelling of a global variable passed into a kernel macro.
>
> Signed-off-by: David Binder
> Signed-off-by: David Kershner
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 1 file changed, 1 insertion(+)
On 06/05/16 02:05, David Kershner wrote:
> From: Erik Arfvidson
>
> The following struct members were never used:
> putfile_active_buffer::pnext
> putfile_request::file_request_number
> putfile_request::data_sequence_number
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: David Kershner
>
e aren't any more packets to receive
> - * stop the poll
> - */
> + /* If there aren't any more packets to receive stop the poll */
> if (rx_count < budget)
> napi_complete(napi);
>
&g
On 20/05/16 10:51, Daeseok Youn wrote:
> the "brd" value cannot be NULL in dgnc_finalize_board_init().
> Because "brd" as a parameter of this function was already
> checked for NULL.
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/dgnc/dgnc_driver.c | 3 ---
> 1 file changed, 3 deletions
On 20/05/16 10:51, Daeseok Youn wrote:
> the "brd" was already checked for NULL before calling dgnc_do_remap().
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/dgnc/dgnc_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/s
On 20/05/16 17:27, Daniel Lockyer wrote:
> Kernel code style is to prefer the former so add `int` to the method
> parameters.
>
> Signed-off-by: Daniel Lockyer
> ---
> drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/driver
On 20/05/16 19:04, Kevin McKinney wrote:
> This patchset will fix the below issues reported checkpatch.pl tool.
>
> Kevin McKinney (3):
> Staging: wlan-ng: fix Alignment should match open parenthesis.
> This patch fixes alignment of parenthesis found by checkpatch.pl
> tool.
> Stag
On 26/05/16 04:22, Kevin McKinney wrote:
> This patchset will address issues reported by checkpatch.pl tool
> for file prism2usb.c.
>
> Kevin McKinney (3):
> Staging: wlan-ng: fix alignment not matching.
> Staging: wlan-ng: fix unnecessary parentheses.
> Staging: wlan-ng: fix comparison to N
On 26/05/16 05:56, DaeSeok Youn wrote:
> 2016-05-26 6:48 GMT+09:00 Luis de Bethencourt :
>> On 20/05/16 10:51, Daeseok Youn wrote:
>>> the "brd" value cannot be NULL in dgnc_finalize_board_init().
>>> Because "brd" as a parameter of this function w
On 26/05/16 09:01, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
>
> Signed-off-by: Shubham Bansal
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion.c
> b/dri
On 26/05/16 13:32, Kevin wrote:
> On Thu, May 26, 2016 at 01:24:28PM +0100, Luis de Bethencourt wrote:
>> On 26/05/16 04:22, Kevin McKinney wrote:
>>> This patchset will address issues reported by checkpatch.pl tool
>>> for file prism2usb.c.
>>>
>>> Ke
On 27/05/16 02:42, Daeseok Youn wrote:
> the "brd" value cannot be NULL in dgnc_finalize_board_init().
> Because "brd" as a parameter of this function was already
> checked for NULL.
>
> the dgnc_finalize_board_init() as a static function was called
> only from dgnc_found_board() function and brd-
On 27/05/16 02:43, Daeseok Youn wrote:
> the "brd" was already checked for NULL before calling dgnc_do_remap().
>
> the dgnc_do_remap() function was called only
> from the dgnc_found_board() and the DGNC_BOARD_MAGIC value
> was assigned to "brd->magic" in dgcn_found_board(). So it doesn't
> need t
On 27/05/16 07:52, Daeseok Youn wrote:
> The 'intr_count' variable was used only for increasing.
> So the 'intr_count' variable is not useful for this driver.
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/dgnc/dgnc_cls.c| 2 --
> drivers/staging/dgnc/dgnc_driver.h | 1 -
> drivers/
On 27/05/16 07:53, Daeseok Youn wrote:
> The 'intr_modem' variable was used only for increasing.
> So the 'intr_modem' variable is not useful for this driver.
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/dgnc/dgnc_cls.c| 1 -
> drivers/staging/dgnc/dgnc_driver.h | 1 -
> drivers/s
On 27/05/16 07:55, Daeseok Youn wrote:
> The 'ch_intr_rx' variable was used only for increasing.
> So the 'ch_intr_rx' variable is not useful for this driver.
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/dgnc/dgnc_cls.c| 1 -
> drivers/staging/dgnc/dgnc_driver.h | 2 --
> drivers/
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a type issues like
> i.e Prefer kernel type 'u8' over 'uint8_t'
> Prefer kernel type 'u16' over 'uint16_t'
> Prefer kernel type 'u32' over 'uint32_t'
> Prefer kernel type 's1
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a Block comments
> issues found by the checkpatch.pl tool.
>
> i.e. Block comments use a trailing */ on a separate line
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya
We can
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya
The patch looks good :) adding th
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a line over 80
> characters issues found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya
Looks good :)
This is the only instance of the line over 8
On 29/05/16 14:31, Jaime Arrocha wrote:
> From: Jaime Arrocha
>
> Fixed several checks about camel case use provided by checkpatch.pl.
> CHECK: Avoid CamelCase
> Changes verified to work by compiling module.
>
> Signed-off-by: Jaime Arrocha
Purpose of the patch is good but it fails to apply in
The value assigned to ret will be overwritten before it could be read in a
future iteration of the loop. Removing the unnecessary assignment.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/gdm724x/gdm_usb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
Luis de Bethencourt
---
drivers/staging/iio/accel/sca3000_core.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/iio/accel/sca3000_core.c
b/drivers/staging/iio/accel/sca3000_core.c
index a8f533a..94656f6 100644
--- a/drivers/staging/iio/a
On 31/05/16 21:23, Jonathan Cameron wrote:
>
>
> On 31 May 2016 20:47:50 BST, Luis de Bethencourt
> wrote:
>> val is set to the value of ret right after ret is checked. If ret is
>> not
>> zero it goes to error_ret. So only value ret can have is zero, which
>
sca3000_read_ctrl_reg() returns a negative number on failure, check for
this instead of zero.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Andrew F. Davis
Reviewed-by: Jonathan Cameron
---
Patch corrected thanks to comments from Andrew F. Davis and Jonathan Cameron.
https://lkml.org/lkml
Go to error_ret if sca3000_read_ctrl_reg() failed.
Signed-off-by: Luis de Bethencourt
---
Noticed this while inspecting the code for the 1/2 patch.
Thanks,
Luis
drivers/staging/iio/accel/sca3000_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/accel
On 31/05/16 22:08, Luis de Bethencourt wrote:
> sca3000_read_ctrl_reg() returns a negative number on failure, check for
> this instead of zero.
>
> Signed-off-by: Luis de Bethencourt
> Reviewed-by: Andrew F. Davis
> Reviewed-by: Jonathan Cameron
> ---
>
> Patch c
fixes checkpatch.pl WARNING: quoted string split across lines
+MODULE_AUTHOR("David A. Schleef , "
+ "Frank Mori Hess ");
total: 0 errors, 1 warnings, 114 lines checked
Modules with multiple authors have a MODULE_AUTHOR line for each one.
Signed-off-by:
fixes checkpatch.pl WARNING: quoted string split across lines
+MODULE_AUTHOR("David A. Schleef , "
+ "Frank Mori Hess ");
Modules with multiple authors have a MODULE_AUTHOR line for each one.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Ian Abbott
---
dr
Remove explicit true/false comparations to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/r8192U_core.c | 7 ---
drivers/staging/rtl8192u/r8192U_dm.c | 21 +++--
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers
On Tue, Jun 23, 2015 at 02:56:38PM +0200, Frans Klaver wrote:
> On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt
> wrote:
> > Remove explicit true/false comparations to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
> > drivers
Remove explicit true/false comparations to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/r8192U_core.c | 13 -
drivers/staging/rtl8192u/r8192U_dm.c | 21 +++--
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a
Remove explicit true/false comparations to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/r8192U_core.c | 13 -
drivers/staging/rtl8192u/r8192U_dm.c | 21 +++--
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a
On Tue, Jun 23, 2015 at 03:04:32PM +0200, Frans Klaver wrote:
> On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt
> wrote:
> > Remove explicit true/false comparations to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
> > drivers
Remove explicit true/false comparations to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++--
drivers
On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote:
> On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt
> wrote:
>
> >> > if (dm_digtable.dig_algorithm_switch) {
> >> > @@ -3062,7 +3062,8 @@ static void dm_dynamic_txpow
On Tue, Jun 23, 2015 at 03:59:41PM +0200, Frans Klaver wrote:
> On Tue, Jun 23, 2015 at 3:59 PM, Luis de Bethencourt
> wrote:
> > On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote:
> >> On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt
> >> wr
Inverting the value of eof is a more direct way of passing to the debugging
function if eof is false or not.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre
Use the newer and nicer kstrtoint(), because simple_strtoul() is now obsolete.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/speakup/varhandlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/varhandlers.c
b/drivers/staging/speakup
On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> Nope. Your patch is totally wrong (buggy). Please be more careful in
> the future.
>
> regards,
> dan carpenter
>
I saw other commits replace the obsolete simple_strtoul() this way and the
documentation makes it look like it is a
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4
On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparations to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
>
> > d
On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
> > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> > > Nope. Your patch is totally wrong (buggy). Please be more careful i
On Wed, Jun 24, 2015 at 12:19:27PM +0200, Luis de Bethencourt wrote:
> On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote:
> > On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
> > > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
&
On Thu, Jun 25, 2015 at 10:04:59AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 12:12:01PM +0200, Luis de Bethencourt wrote:
> > On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote:
> > > On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote
Signed-off-by: Luis de Bethencourt
---
drivers/staging/speakup/keyhelp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/keyhelp.c
b/drivers/staging/speakup/keyhelp.c
index 9475674..02d5c70 100644
--- a/drivers/staging/speakup/keyhelp.c
+++ b/drivers
instead of returning.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/speakup/keyhelp.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/speakup/keyhelp.c
b/drivers/staging/speakup/keyhelp.c
index 02d5c70..8133b6e
On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote:
> I am a high school student trying to become familiar with linux kernel
> development. This is my first patch.
>
> checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config
> WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX
if (s32Error) {
> --
> 1.9.1
>
Appliess cleanly on staging-testing. Removes all checkpatch ERRORS related to
spaces placing in that file.
Reviewed-by: Luis de Bethencourt
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Patches to be applied on top of
https://patchwork.kernel.org/patch/6655831/
Thanks!
Luis
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Removing all checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 276 ++
1 file changed, 92 insertions(+), 184 deletions(-)
diff --git a/drivers
Fix all checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging
Fix all checkpatch.pl warnings:
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 84 +++
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/wilc1000
Fix typo "packe" to "packet".
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
in
Fix typo "packe" to "packet".
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
in
On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote:
> On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> > Fix all checkpatch.pl warnings:
> > WARNING: unnecessary whitespace before a quoted newline
>
> Unassociated but:
>
> > diff --
Switch printks with IP addresses to use vsprintf extension %pI4.
Suggested-by: Joe Perches
Signed-off-by: Luis de Bethencourt
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b
On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote:
> Variable "u32 c" always re-initialize in for loop.
> Initialized value of "u32 c" is not used in function
> and is redundant, hence removed.
>
> Suggested-by: Dan Carpenter
> Signed-off-by: Sunil Shahu
> ---
> drivers/staging/rtl871
On Fri, Jun 26, 2015 at 06:51:33PM +0300, Dan Carpenter wrote:
> On Fri, Jun 26, 2015 at 05:50:27PM +0200, Luis de Bethencourt wrote:
> > On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote:
> > > Variable "u32 c" always re-initialize in for loop.
> > >
On Mon, Jul 06, 2015 at 07:22:09PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 26, 2015 at 04:43:44PM +0200, Luis de Bethencourt wrote:
> > Patches to be applied on top of
> > https://patchwork.kernel.org/patch/6655831/
>
> I don't use patchwork, and when on an airpla
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4
On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote:
> On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparisons to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
>
> &
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4
bool Reval is set to match the value of bHalfWirelessN24GMode just to
this. The value can be returned directly. Removing uneeded bool.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/r8192U_core.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers
Remove explicit true/false comparisons to bool variables.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4
bool Reval is set to match the value of bHalfWirelessN24GMode just to
this. The value can be returned directly. Removing uneeded bool.
Signed-off-by: Luis de Bethencourt
Suggested-by: Joe Perches
Suggested-by: Franks Klaver
---
drivers/staging/rtl8192u/r8192U_core.c | 9 +
1 file
On Mon, Jul 20, 2015 at 09:54:56PM +0300, Dan Carpenter wrote:
> On Mon, Jul 20, 2015 at 06:35:42PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparisons to bool variables.
> >
> > Signed-off-by: Luis de Bethencourt
> > ---
>
> Put a no
On Tue, Jul 21, 2015 at 06:01:51AM +0200, Frans Klaver wrote:
> On 20 July 2015 21:42:39 CEST, Luis de Bethencourt
> wrote:
> >On Mon, Jul 20, 2015 at 09:54:56PM +0300, Dan Carpenter wrote:
> >> On Mon, Jul 20, 2015 at 06:35:42PM +0200, Luis de Bethencourt wrote:
> &
1 - 100 of 184 matches
Mail list logo
