The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c
b/drivers/staging/lustre/lustre/ptlrpc/sec.c
index 187fd1d..e6fe
On 05/13/2016 12:43 PM, Drokin, Oleg wrote:
On May 12, 2016, at 6:33 PM, Lidza Louina wrote:
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Thank you for the patch, it looks good code-wise, but
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 9 +++-
_udesc)" block instead of at the top of the function,
since it isn't used anywhere else.
Cheers, Andreas
Definitely, will do.
I'll change desc to rc and update the if statement and send another
patch now.
Lidza
- Patrick
On 05/16/2016 09:17 AM, Lidza Louina wrote:
The lustre_m
The lustre_msg_buf method could return NULL. Subsequent code didn't
check if it's null before using it. This patch adds two checks.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 3 +++
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 8 ++-
On 05/17/2016 02:53 AM, Dan Carpenter wrote:
When I read the code, I just assumed desc was a pointer and it should
have been:
if (!desc)
return NULL;
For me, "if (rc) " is way more readable than "if (rc != 0) ". So
readability could go either way depending on what you
The wl pointer was initialized as a pointer to a struct wilc and
assigned to a piece of memory the size of the pointer. It should be the
size of struct wilc.
Signed-off-by: Lidza Louina
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 05/27/2016 02:07 PM, Joe Perches wrote:
On Fri, 2016-05-27 at 13:51 -0400, Lidza Louina wrote:
The wl pointer was initialized as a pointer to a struct wilc and
assigned to a piece of memory the size of the pointer. It should be the
size of struct wilc.
This isn't necessary.
The co
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch casts the unsigned regular int to suppress
smatch warnings.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
-devel] [PATCH] staging/lustre/lnet: correctly casts value
for arithmetic
NAK.
On Jun 23, 2016, at 1:24 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch casts the unsigned regular int to suppress
> smatch warnings.
>
>
-devel] [PATCH] staging/lustre/lnet: correctly casts value
for arithmetic
On Jun 23, 2016, at 2:07 PM, Lidza Louina wrote:
> The smatch warning was "drivers/staging/lustre/lnet/lnet/api-ni.c:516
> lnet_res_lh_initialize() warn: should '1 << ibits' be a 64 bit type?"
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch makes the code use the correct type of int to
suppress a smatch warning.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
-devel] [PATCH v2] staging/lustre/lnet: changes value to
correct type for assignment
On Jun 23, 2016, at 2:56 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch makes the code use the correct type of int to
> suppress a smatc
/lustre/lnet: changes value to
correct type for assignment
On Jun 23, 2016, at 3:27 PM, Lidza Louina wrote:
>
> - Original Message -
> From: oleg.dro...@intel.com
> To: lidza.lou...@oracle.com
> Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
> de...@dr
The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.
Signed-off-by: Lidza Louina
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Sep 26, 2013 at 6:19 AM, Dan Carpenter wrote:
> This one is not right.
>
> On Wed, Sep 25, 2013 at 07:08:53PM -0400, Lidza Louina wrote:
>> This patch changes error handling to the
>> tty_driver allocations in dgap_tty_register.
>>
>> Before, it di
On Thu, Sep 26, 2013 at 6:22 AM, Dan Carpenter wrote:
> On Wed, Sep 25, 2013 at 07:08:54PM -0400, Lidza Louina wrote:
>> This patch removes this smatch warning:
>> unsigned '--un->un_open_count' is never less than zero
>>
>> The code decremented the un_ope
On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat wrote:
> This check is not required.
>
> Signed-off-by: Sachin Kamat
> Cc: Lidza Louina
> ---
> drivers/staging/dgnc/dgnc_kcompat.h |5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Sign
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
dri
On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
>>
>> DPR_INIT(("DGAP REGISTER TTY: MAJORS: %d %d\n",
>> brd->S
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Sign
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
dri
On Mon, Sep 30, 2013 at 9:46 PM, Greg KH wrote:
> On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
>> On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat
>> wrote:
>> > This check is not required.
>> >
>> > Signed-off-by: Sachin Kamat
>
On Tue, Oct 1, 2013 at 1:59 PM, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 12:32:06PM -0400, Lidza Louina wrote:
>> On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter
>> wrote:
>> > On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> >> @@ -30
On Thu, Oct 3, 2013 at 1:23 AM, Greg KH wrote:
> On Tue, Oct 01, 2013 at 12:54:20PM -0400, Lidza Louina wrote:
>> + return 0;
>> +
>> +err_unregister_serial:
>> +tty_unregister_driver(brd->SerialDriver);
>> +err_free_print_ttys:
>
The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(*brd), GFP_KERNEL);
Signed-off-by: Lidza Louina
---
drivers/staging
Originally, this driver created it's own allocating
function. This patch removes that function and calls
kzalloc directly.
This patch affects:
- driver.c
- driver.h
- fep5.c
- tty.c
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_driver.c | 18 ++
dr
Acked-by: Lidza Louina
On Tue, Jan 14, 2014 at 10:40 AM, Masanari Iida wrote:
> This patch fixed trailing whitespace error found by
> checkpatch.pl in dgap/digi.h
>
> Signed-off-by: Masanari Iida
> ---
> drivers/staging/dgap/digi.h | 24
>
I'll try this patchset again after Masanari Iida's patches are accepted after
the merge window.
Lidza
On Fri, Jan 17, 2014 at 11:01 AM, Lidza Louina wrote:
> This patch removes the KERNEL_VERSION conditionals.
> The driver is built for this kernel version, so the
> conditio
55AM -0400, Mark Hounschell wrote:
>> > >> On 07/17/2013 05:49 PM, Greg KH wrote:
>> > >>> On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
>> > >>>> This patch adds the Digi driver to staging.
>> > >>>
This patch updates the list of maintainers for the staging/comedi
driver.
Signed-off-by: Lidza Louina
---
MAINTAINERS | 2 +-
drivers/staging/comedi/TODO | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bf61e04..6ddb33d
i International <http://www.digi.com>.
>>
>> Signed-off-by: Lidza Louina
>
> Looks good, but a few minor questions.
>
> This is the "raw" driver that Mark pointed you at, right? You haven't
> changed anything for it yet?
Yes, I haven't changed any of
On Mon, Aug 12, 2013 at 2:49 PM, Greg KH wrote:
> On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote:
>> I've just realized I made a mistake by adding the Makefile.inc.
>
> Oops, I missed that.
>
>> Is it possible for me to make a fresh set of patches (add
On Mon, Aug 12, 2013 at 2:50 PM, Dan Carpenter wrote:
> On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote:
>> I've just realized I made a mistake by adding the Makefile.inc.
>>
>> Is it possible for me to make a fresh set of patches (adding the files,
>
This series of patches builds the DGNC driver into the kernel and fixes
small problems caused by the new tty layer's API.
The DGNC driver is a TTY Serial Port Driver for the Digi International
Neo and Classic PCI based product line by Digi International
<http://www.digi.com>.
Lidz
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/Makefile.inc | 133 --
1 file changed, 133 deletions(-)
delete mode 100644 drivers/staging/dgnc/Makefile.inc
diff --git a/drivers/staging/dgnc/Makefile.inc
b/drivers/staging/dgnc/Makefile.inc
deleted file
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 299453f..f155c8f 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -683,7
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 154 +++-
1 file changed, 43 insertions(+), 111 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 1fbd09f..299453f 100644
--- a/drivers/staging
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 461e881..63b80e2 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 37 ++---
1 file changed, 2 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 1e22b4b..1fbd09f 100644
--- a/drivers/staging/dgnc
Signed-off-by: Lidza Louina
---
drivers/staging/Kconfig | 1 +
drivers/staging/Makefile | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 57d8b34..d461590 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -142,4
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/Makefile |2 +-
drivers/staging/dgnc/dgnc_driver.c |9 -
drivers/staging/dgnc/dgnc_proc.c | 1551
3 files changed, 1 insertion(+), 1561 deletions(-)
delete mode 100644 drivers/staging/dgnc
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 63b80e2..a00fe2b 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index a00fe2b..1e22b4b 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc
On Mon, Aug 12, 2013 at 5:10 PM, Greg KH wrote:
> On Mon, Aug 12, 2013 at 05:05:06PM -0400, Lidza Louina wrote:
>> Signed-off-by: Lidza Louina
>> ---
>> drivers/staging/Kconfig | 1 +
>> drivers/staging/Makefile | 1 +
>> 2 files changed, 2 insertions(+)
>
On Mon, Aug 12, 2013 at 5:11 PM, Greg KH wrote:
> On Mon, Aug 12, 2013 at 05:05:07PM -0400, Lidza Louina wrote:
>> Signed-off-by: Lidza Louina
>
> Why?
>
> You need to supply a "why this patch is needed" type of a description
> for something that is non-obvious
On Mon, Aug 12, 2013 at 5:13 PM, Greg KH wrote:
> On Mon, Aug 12, 2013 at 05:05:05PM -0400, Lidza Louina wrote:
>> Signed-off-by: Lidza Louina
>> ---
>> drivers/staging/dgnc/Makefile.inc | 133
>> --
>> 1 file changed, 133 de
On Tue, Aug 13, 2013 at 3:30 AM, Dan Carpenter wrote:
>
> These parenthesis are not needed and look ugly.
Alrighty. I'll fix that next version.
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
On Tue, Aug 13, 2013 at 3:32 AM, Dan Carpenter wrote:
> This does several things which are not described. It needs to be
> broken into more than one patch as well.
Ok, I'll break it up next version. One for changing the ioctl function params,
and another for removing the 3 commands.
The Makefile contains the variables needed for the driver to build.
The Makefile.inc isn't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/Makefile.inc | 133 --
1 file changed, 133 deletions(-)
delete mode 100644 drivers/staging
The declaration for the ioctl function has changed. The previous version of
this declaration took struct file *file as a parameter and the new one does
not. This patch removes that parameter.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2
The value tty->termios needed to be dereferenced to be assigned to the variable
ts.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
in
This patch fixes this error: invalid type argument of ‘->’ (have ‘struct
ktermios’).
There were changes in the tty layer's API. Access to the termios flags changed
from tty->termios->*flag* to tty->termios.*flag*.
Signed-off-by: Lidza Louina
---
drivers/staging/dgn
This patch removes the use of read_cnt, real_raw, buf and rawreadok. The
variable buf is never used in the code. The variables rawreadok read_cnt and
real_raw don't exist in the new API. Reading the data raw is no longer
supported by the tty layer.
Signed-off-by: Lidza Louina
---
dr
proc API.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/Makefile |2 +-
drivers/staging/dgnc/dgnc_driver.c |6 +-
drivers/staging/dgnc/dgnc_proc.c | 1551
3 files changed, 4 insertions(+), 1555 deletions(-)
delete mode 100644 drivers/st
The functions tty_flip_buffer_push, tty_insert_flip_string,
tty_insert_flip_char and tty_buffer_request_room now require a struct of type
tty_port instead of struct tty_struct. This patch makes those changes.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 14
The commands TIOCGETP, TCGETS, and TCGETA are not supposed to be seen by the
ioctl. This patch removes the switch cases for these commands.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 34 --
1 file changed, 34 deletions(-)
diff --git a
Eek, for some reason, gmail has been
sending html, sorry I'm spamming. =[
On Tue, Aug 13, 2013 at 7:20 PM, Dan Carpenter wrote:
> On Tue, Aug 13, 2013 at 03:49:52PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_proc.c file, all references to proc functions in
>&g
For some reason, gmail has been sending out
html. Sorry for spamming. =[
On Tue, Aug 13, 2013 at 7:27 PM, Dan Carpenter wrote:
> On Tue, Aug 13, 2013 at 03:49:58PM -0400, Lidza Louina wrote:
>> This patch removes the use of read_cnt, real_raw, buf and rawreadok. The
>> variab
On Wed, Aug 14, 2013 at 5:04 PM, Greg KH wrote:
> On Tue, Aug 13, 2013 at 03:49:52PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_proc.c file, all references to proc functions in
>> dgnc_driver.c and from the Makefile's build.
>>
>> There were a lot o
This patch removes the dgnc_proc.c file, all references to proc
functions in dgnc_driver.c and from the Makefile's build.
Drivers now use sysfs instead of proc.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/Makefile | 2 +-
drivers/staging/dgnc/dgnc_driver.c | 9 -
2
On Wed, Aug 14, 2013 at 7:04 PM, Greg KH wrote:
> On Wed, Aug 14, 2013 at 07:01:49PM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_proc.c file, all references to proc
>> functions in dgnc_driver.c and from the Makefile's build.
>>
>> Drivers now use sys
On Wed, Aug 14, 2013 at 9:32 PM, Greg KH wrote:
> Can you take this patch and apply it to a clean version of my
> staging.git tree on the staging-next branch?
>
> Can you please rebase on this branch and try sending it out again? How
> are you generating this patch?
I found the problem, Sachin K
This patch removes the dgnc_proc.c and dgnc_proc.h files and all
references to proc functions in dgnc_driver.c. This also removes proc.h
from the include headers in driver.c, mgmt.c and sysfs.c and proc.o
from the Makefile.
Drivers now use sysfs instead of proc.
Signed-off-by: Lidza Louina
On Thu, Aug 15, 2013 at 1:14 PM, Greg KH wrote:
> On Thu, Aug 15, 2013 at 10:28:22AM -0400, Lidza Louina wrote:
>> This patch removes the dgnc_proc.c and dgnc_proc.h files and all
>> references to proc functions in dgnc_driver.c. This also removes proc.h
>> from the includ
This patch fixes a warning associated with assigining
a pointer in the dgnc_mbuf function.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc
This patch removes the inode variable from the
dgnc_mgmt_ioctl function. It's never used in the
function.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
On Tue, Aug 20, 2013 at 4:48 AM, Dan Carpenter wrote:
> The ifdef here is to support older kernels which don't have the
> the ->unlocked_ioctl function pointer. We don't care about older
> kernels so we could delete the #else side of this and remove the
> #ifdef.
>
> You can do that in a later pa
This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 4
drivers/staging/dgnc/dgnc_mgmt.c | 7 +--
dr
This patch fixes a warning associated with assigining
a pointer in the dgnc_mbuf function.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc
Ok, I'm sending it now.
On Tue, Aug 20, 2013 at 7:27 PM, Greg KH wrote:
> On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote:
>> This patch fixes a warning associated with assigining
>> a pointer in the dgnc_mbuf function.
>>
>> Signed-off-by: Lidza Lo
This patch builds the dgnc driver into the kernel.
Signed-off-by: Lidza Louina
---
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 1665705..0d9d92b 100644
--- a/drivers
This patch removes trailing whitespace in
the dgnc_driver.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc
This patch removes trailing whitespace in
the dgnc_cls.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index dca5ea3..a273385
This patch removes trailing whitespace in
the dpacompat.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dpacompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index 44379eb..f96963b
This patch removes trailing whitespace in
the dgnc_cls.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc
This patch removes trailing whitespace in
the dgnc_tty.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 178
1 file changed, 89 insertions(+), 89 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
This patch removes trailing whitespace in
the kcompat.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_kcompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_kcompat.h
b/drivers/staging/dgnc/dgnc_kcompat.h
index a0f5874
This patch removes trailing whitespace in
the sysfs.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index
This patch removes trailing whitespace in
the digi.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/digi.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h
index ab90382
This patch removes trailing whitespace in
the dgnc_neo.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc
This patch removes trailing whitespace in
the dgnc_sysfs.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc/dgnc_sysfs.h
index fe99110..4b87ce1
This patch removes trailing whitespace in
the driver.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index
This patch removes trailing whitespace in
the dgnc_mgmt.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_mgmt.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc
This patch removes trailing whitespace in
the dgnc_trace.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_trace.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_trace.c
b/drivers/staging/dgnc/dgnc_trace.c
index
This patch removes trailing whitespace in
the neo.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
index ffb4209..f7f569b
This patch fixes the error: "foo* bar" should be "foo *bar".
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 593
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.h.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_d
This patch fixes the error "code indent should use
tabs where possible" in dgnc_sysfs.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/st
This patch fixes the error "code indent should use
tabs where possible" in dgnc_neo.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgnc/
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 70 +++---
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/st
This patch fixes the error "code indent should use
tabs where possible" in dgnc_tty.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 156
1 file changed, 78 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/dgnc/
This patch removes the code supporting CVS
from its files.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 2 --
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c| 2 --
drivers/staging/dgnc/dgnc_pci.h
This patch fixes the error: open brace '{'
following struct go on the same line.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 3 +--
drivers/staging/dgnc/digi.h| 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/st
This patch fixes this error: invalid type
argument of ‘->’ (have ‘struct ktermios’).
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/driv
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.
It also removes cases for the commands TIOCGETP
TCGETS and TCGETA.
Signed-off-by: Lidza Louina
This patch removes the unused variable page
in mgmt.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_mgmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_mgmt.c b/drivers/staging/dgap/dgap_mgmt.c
index 1147f1d..dce33d4 100644
--- a/drivers/staging/dgap
This patch fixes the error: incompatible types
when assigning to type ‘struct ktermios *’ from
type ‘struct ktermios’
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_fep5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_fep5.c b/drivers
This patch removes the use of read_cnt, real_raw and rawreadok.
These variables don't exist in the new API. Reading the data
raw is no longer supported by the tty layer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 47 -
1
1 - 100 of 201 matches
Mail list logo
