[PATCH] staging: gdm72xx: remove unneeded test

2015-05-27 Thread Laurent Navet
The same code is executed regardless ret value, so this test can be removed. Signed-off-by: Laurent Navet --- drivers/staging/gdm72xx/usb_boot.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c index 3ccc447..7f80553

[PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Laurent Navet
The strcpy operation may write past the end of the fixed-size destination buffer if the source buffer is too large. Found by coverity scan : CID 144979 Signed-off-by: Laurent Navet --- build tested only drivers/staging/line6/audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Laurent Navet
reak the driver > completely and make it unusable. > >> >> As a side note I'm not sure if pod_try_init from >> drivers/staging/line6/pod.c >> cleans up properly after failed line6_init_audio. > > Yeah. It doesn't seem to clean up at all. > Laurent Navet. -

[PATCH] staging: unisys: visorbus: add missing include

2016-10-15 Thread Laurent Navet
write' was not declared. Should it be static? warning: symbol 'visorchannel_get_header' was not declared. Should it be static? warning: symbol 'visorchannel_create' was not declared. Should it be static? warning: symbol 'visorchannel_create_with_lock' was not declared.

[PATCH] staging: slicoss: fix possible missing iounmap

2013-11-15 Thread Laurent Navet
if slic_card_locate failed, memmapped_ioaddr is not unmapped. Signed-off-by: Laurent Navet --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 652272b..ab7206d

Re: Anybody working on line6?

2014-06-30 Thread Laurent Navet
> I'm helping Greg do a bit of cleanup in the staging tree. I noticed > that > nobody seems to have worked towards moving line6 out of staging in over > a year. Are there any plans to clean it up and move it out soon? > Because > otherwise we're going to have to delete the d