These routines include:
ODM_StartWorkItem()
ODM_StopWorkItem()
ODM_FreeWorkItem()
ODM_ScheduleWorkItem()
ODM_IsWorkItemScheduled()
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 20
drivers/staging/rtl8188eu/include/odm_interface.h | 10
This batch includes
ODM_StartWorkItem
ODM_StopWorkItem
ODM_FreeWorkItem
ODM_AcquireSpinLoc
ODM_ReleaseSpinLock
ODM_ReleaseTimer
ODM_ReleaseAllTimers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 7 ---
drivers/staging/rtl8188eu/hal/odm_interface.c
This is equivalent to PHY_GetBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 8
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 4 insertions(+), 12
] *fctrl
drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core
This one is a duplicate of PHY_QueryBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 68 +++
drivers/staging/rtl8188eu/hal/odm.c | 49
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow 'pstapriv->sta_aid' 32 <= 32
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.
/rtw_br_ext.c:1157:64: warning: cast to
restricted __be16
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to
restricted __be16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 43 +++--
1 file changed, 22 insertions(+), 21
There are two different enum statements that have been combined.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 4 +--
drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 32 +++---
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++---
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 7 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 35 ---
2 files changed, 42 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging
This is the same as macro PHY_SetBBReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 14 +++---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 3 ---
3 files changed, 7 insertions
This driver only handles RTL8188EU with USB interface, thus several hardware
defines and macros can be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 --
drivers/staging/rtl8188eu/hal/rtl8188e_mp.c | 18 +++--
drivers/staging/rtl8188eu
This header contains a number of routines that do not to be available
globally. Once this change was made, a number of the routines were not
used, and could be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 67 -
drivers
This member of struct odm_dm_struct is always set to ODM_RTL8188E for this
driver. Accordingly, the code can be simplified. A number of routines
now are no longer needed and are deleted.
Signed-off-by: Larry Finger
---
.../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +-
drivers/staging
Any routines that are empty as a result of these changes are also removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 11 ---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 ---
drivers/staging/rtl8188eu/core/rtw_sreset.c | 2
: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 12 +---
drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 35 +++
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 5 +---
drivers/staging/rtl8188eu/include/odm.h | 24
865,7 +865,6 @@ static int __init rtw_drv_entry(void)
RT_TRACE(_module_hci_intfs_c_, _drv_err_, ("+rtw_drv_entry\n"));
DBG_88E(DRV_NAME " driver version=%s\n", DRIVERVERSION);
- DBG_88E("build time: %s %s\n", __DATE__, __TIME__);
rtw_sus
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/usb_intf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8712/usb_intf.c
b/drivers/staging
(-)
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h
b/drivers/staging/rtl8188eu/include/rtw_io.h
index eb6f0e5..3d1dfcc 100644
--- a/drivers/staging/rtl8188eu/include/rtw_io.h
+++ b/drivers/staging/rtl8188eu/include/rtw_io.h
@@ -123,7 +123,7 @@ struct _io_ops
On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt
---
drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/dri
On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote:
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io
On 01/02/2014 03:05 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
--- a/drivers/staging/rtl8188eu/include/odm_interface.h
+++ b/drivers/staging/rtl8188eu/include/odm_interface.h
@@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
#define _cat(_name, _ic_type
On 01/02/2014 02:44 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote:
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer
overflow 'pst
adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 01/28/2014 09:01 AM, Greg Kroah-Hartman wrote:
On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote:
On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote:
Am 28.01.2014 15:00, schrieb Dan Carpenter:
These macros need parentheses, otherwise it causes a macro expansion bug
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
On 02/02/2014 03:04 PM, Randy Dunlap wrote:
On 02/02/2014 12:07 PM, Larry Finger wrote:
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
You also changed 0x7b8 to 0x7bb.
Did you mean to do that?
No, I did not. Thanks for catching that
On 02/02/2014 03:26 PM, Greg KH wrote:
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries. This exchange was determined
by noticing that the vendor code is 0x07b8 for Abocom at
http://www.linux-usb.org/usb.ids.
Signed-off-by: Larry Finger
---
V2 - fix typo in revised version that
On 02/02/2014 12:07 PM, Stefan Lippers-Hollmann wrote:
Hi
[ CC'ing the relevant parties ]
On Sunday 02 February 2014, Dave Jones wrote:
On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
>
> Please find the latest report on new defect(s) introduced to Linux found
wit
On 02/04/2014 08:41 AM, Andrea Merello wrote:
Yes, I attach a cumulative patch for latest version of my work.
When I will send this asking for merge in kernel, I will split it in
some patches, because I also also included fix and improvements for
other already supported cards (not directly relat
Andrea,
After applying the latest patch, I get the following warning and errors when
building the USB driver rtl8187:
CC drivers/video/fbmon.o
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_set_anaparam’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:595:3: warning: passi
On 02/04/2014 01:57 PM, Andrea Merello wrote:
Sorry, my fault.. you had already reported me the iowrite16 vs
iowrite8 for anaparam3 issue, but I forgot to fix it :(
If you are reasonably sure that a 16bits-wide write is OK on the
rtl8187b hardware (In reference code I have here only 8bits are
wr
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++---
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8188eu
This wrapper is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
This wrapper is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 8
drivers/staging/rtl8188eu/include/odm_interface.h | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
This routine is the equivalent of rtw_write16.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +++-
drivers/staging/rtl8188eu/hal/odm_interface.c| 6 --
drivers/staging/rtl8188eu/include/odm_interface.h| 2 --
3 files changed, 3
On 02/03/2014 04:38 PM, Dan Carpenter wrote:
MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer
in sync. It leads to a bogus pointer dereference.
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8188eu
This routine is the equivalent of rtw_write32.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 2 +-
drivers/staging/rtl8188eu/hal/odm_interface.c | 7 ---
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 1 insertion(+), 10
This wrapper for vzalloc() is not used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers
The driver contains a large number of wrapper routines. None of them are
needed.
Signed-off-by: Larry Finger
Larry Finger (12):
staging: r8188eu: Remove ODM_Read1Byte
staging: r8188eu: Remove ODM_Read2Byte
staging: r8188eu: Remove ODM_Read4Byte
staging: r8188eu: Remove ODM_Write1Byte
This routine is the equivalent of rtl_write6.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 23 +-
drivers/staging/rtl8188eu/hal/odm.c| 3 ++-
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 4 +++-
drivers
This is essentially a synonym for rtw_read8.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 6 +++---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
3 files changed, 3 insertions(+), 11
Engelmayer
Acked-by: Larry Finger
This Ack is valid for all 5 patches.
Larry
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu
Greg,
This E-mail is to prepare you for a new Realtek RTL8192EE driver that I intend
to submit early next week. I hope it will be in time for kernel 3.16.
This device is incorporated in the recently introduced Lenovo T440s tablet, and
from the correspondence that I have received, there have b
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 127 ++
problems have been fixed. The code needs additional
polishing before it can be merged into the regular wireless tree; however,
that should not take more than a single cycle.
Signed-off-by: Larry Finger
Larry Finger (4):
staging: r8192ee: Add source files for core driver
staging: r8192ee: Add code
In addition, this commit contains a TODO file for this driver
Signed-off-by: Larry Finger
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/rtl8192ee/Kconfig | 8
drivers/staging/rtl8192ee/Makefile | 40
On 05/26/2014 09:55 AM, Jet Chen wrote:
Jet,
0day kernel testing robot got the below dmesg and the first bad commit is
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
commit 0629f3b8c33899140b48d5897259eab8ebae78ca
Author: Larry Finger
AuthorDate: Wed May 21
On 05/26/2014 01:06 PM, Ben Hutchings wrote:
On Wed, 2014-05-21 at 16:25 -0500, Larry Finger wrote:
[...]
--- /dev/null
+++ b/drivers/staging/rtl8192ee/Kconfig
@@ -0,0 +1,8 @@
+config R8192EE
+ tristate "Realtek RTL8192EE Wireless Network Adapter"
depends on MAC80211 &&
Finger
Larry Finger (3):
staging: r8192ee: Fix kernel WARN splat associated with rate control
staging: r8192ee: Fix build errors when PCI is not available
staging: r8821ae: Fix potential problem with rate control registration
drivers/staging/rtl8192ee/Kconfig | 7 +++
drivers/staging
The zero day testing facility reported a problem with duplicate
registration of the rate-control algorithm. Although not yet reported,
this driver needs the same fix.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8821ae/rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
name is used for the rtlwifi drivers in the regular
wireless tree, and the staging drivers r8192ee and r8821ae. The fix
is to rename the algorithm used in r8192ee.
Reported-by: Jet Chen
Signed-off-by: Larry Finger
Tested-by: Jet Chen
---
drivers/staging/rtl8192ee/rc.c | 2 +-
1 file changed, 1
A build of this driver fails when PCI is not selected. It would also
fail if MAC80211 is not selected. Kconfig is fixed to handle these
conditions, and to select additional necessary components.
Reported-by: Randy Dunlap
Reported-by: Ben Hutchings
Signed-off-by: Larry Finger
---
drivers
42e4c20f114c71e12cdf35d9b5dd60d2546c7d57
yesterday in staging-next. If it has not reached linux-next, the attached patch
should fix the problem.
Thanks,
Larry
>From d10ca90ffaf99f43bb61d5b4001f6a6acfde3454 Mon Sep 17 00:00:00 2001
From: Larry Finger
Date: Mon, 26 May 2014 13:35:48 -0500
Subj
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Ah yes, all the "benefits" of adding a new driver in one tree (staging) that
depends of changes in another (wireless). I have been maintaining this patch in
my own source for several weeks.
Acked-by: Larry Finger
Thanks,
Larry
---
Hi,
On 06/09/2014 10:39 AM, Jes Sorensen wrote:
Greg KH writes:
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Greg,
Thanks for pushing my other changes to Linus. This set goes on top of
the set I sent you on 2014/05/31 and the fix from 2014/06/03. I
On 06/20/2014 10:40 AM, Kristina Martšenko wrote:
Hi Larry and Florian,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving rtl8712 out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because othe
On 06/20/2014 09:52 PM, Nick Krause wrote:
Is this patch being merged or is this not an issue. I am confused
did I make a mistake in my patch or is there being a different
patch being merged.
Thank Nick
On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote:
On Fri, 2014-06-20 at 22:26 -0400, Nic
On 06/21/2014 12:52 PM, Christian Lamparter wrote:
On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote:
On 20/06/14 23:52, Christian Lamparter wrote:
On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote:
Kristina wrote:
I'm helping Greg do a bit of cleanup in the staging
On 09/04/2014 03:58 PM, Andreea Bernat wrote:
Hello,
I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modif
On 09/29/2014 01:17 AM, Greg KH wrote:
On Sun, Sep 28, 2014 at 08:39:51PM -0500, Larry Finger wrote:
A new version of this driver has been merged into the wireless-testing tree
as commit 21e4b0726dc671c423e2dc9a85364716219c4502. It is both possible and
desirable to delete the staging version to
On 09/29/2014 12:05 PM, Greg KH wrote:
On Sun, Sep 28, 2014 at 08:39:51PM -0500, Larry Finger wrote:
A new version of this driver has been merged into the wireless-testing tree
as commit 21e4b0726dc671c423e2dc9a85364716219c4502. It is both possible and
desirable to delete the staging version to
On 08/09/2015 11:08 AM, Swee Hua Law wrote:
add space after , to fix coding style issue
Signed-off-by: Swee Hua Law
---
drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c
b/drivers/stagi
On 08/09/2015 12:22 PM, Jacob Kiefer wrote:
This patch fixes the following sparse errors:
CHECK drivers/staging/rtl8723au/core/rtw_security.c
drivers/staging/rtl8723au/core/rtw_security.c:189:39: \
warning: incorrect type in assignment (different base types)
drivers/staging/rtl8723au/cor
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
here's a series of cleanups to rtl8188eu (and one to rtl8723au).
I'm just resending the same patches I sent yesterday. Apparently my
mailserver got greylisted and all of my messages to osuosl have been
discarded. Now it should be fixed.
My apologies
change.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Even though you are just moving code, I think you should fix the long line
warnings from scripts/checkpatch, otherwise note that they are not fixed here,
but they will be fixed in a later patch. As for the other
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
This macro has no added value, it makes uselessly code more verbose.
Nitpick here. It should be "uselessly makes".
Larry
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188
, there is no content change.
Once again, this would be a perfect place to fix the long lines.
Larry
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 335 ---
1 file changed, 168 insertions(+), 167
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Empty commit messages are generally not accepted.
Larry
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Jes Sorensen
Cc: Larry Finger
Another empty commit message.
Larry
---
drivers/staging/rtl8723au/include/rtw_cmd.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
It's just a wrapper tp down_interruptible().
Typo in line above and see compile warnings below:
Larry
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Another empty commit message.
Larry
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed
On 09/15/2015 11:43 AM, Luca Ceresoli wrote:
Dear Larry,
Larry Finger wrote:
BTW, if a do a change not related to checkpatch warnings, say I remove
unneeded typecasts, and the change has impact on long lines which are
still long after the change, should I also wrap code to fit 80 chars _in
On 09/18/2015 03:19 PM, BryanSPaul wrote:
replaced memcpy functions with ether_addr_copy
Signed-off-by: Bryan Paul
You seem not to be aware that ether_addr_copy() requires alignment of the
operands. Until you demonstrate that you have investigated such alignment,
NACK
Larry
---
drive
On 09/22/2015 02:24 AM, Lars Svensson wrote:
Fixing Sparse warnings about intentional type casts in rtw_security.c
as below.
CHECK drivers/staging/rtl8723au/core/rtw_security.c
drivers/staging/rtl8723au/core/rtw_security.c:248:22: \
warning: cast to restricted __le32
drivers/staging/rtl8723
On 09/26/2015 11:49 AM, Punit Vara wrote:
This patch is to the rtl871x_ioctl_linux.c that fixes up following
warning reported by checkpatch.pl :
- Comparisons should place the constant on the right side of the test
Signed-off-by: Punit Vara
This warning is crap. WTF difference does it make??
conversions
should not be needed.
Thanks to Larry Finger for help sorting this out.
CHECK drivers/staging/rtl8723au/core/rtw_security.c
drivers/staging/rtl8723au/core/rtw_security.c:248:22: \
warning: cast to restricted __le32
drivers/staging/rtl8723au/core/rtw_security.c:249:24: \
warning
TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192ee/base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c
index 71ed12e..b8b897a 10064
TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger
---
V2 - Remove extraneous parenthesis
drivers/staging/rtl8192ee/base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192
On 07/21/2014 09:10 PM, Greg KH wrote:
> On Mon, Jul 21, 2014 at 08:50:26PM -0400, Chris Murphy wrote:
>> Problem: On Asus TX201LA running 15.6 kernel x86_64, driver repeatedly
>> disconnects and reconnects. Dual boot same machine on Win 8.1 is very stable.
>>
>> Behavior starts as soon as Linux is
On 08/01/2014 08:06 AM, Miguel Oliveira wrote:
> Fix sparse warning:
> drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol
> 'efuse_GetCurrentSize23a' was not declared. Should it be static?
>
> Signed-off-by: Miguel Oliveira
> ---
> drivers/staging/rtl8723au/include/rtw_efuse.h |
From: Holger Paradies
The stick is not recognized.
This dongle uses r8188eu but usb-id is missing.
3.16.0
Signed-off-by: Holger Paradies
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu
The Elecom WDC-150SU2M uses this chip.
Reported-by: Hiroki Kondo
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index
The Elecom WDC-150SU2M uses this chip.
Reported-by: Hiroki Kondo
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index
On 01/28/2018 08:05 AM, Erik Liodden wrote:
Add identifier names to function definition arguments to comply with
the kernel coding style and the naming convention in the rest of the
file.
Issues found by checkpatch.
Signed-off-by: Erik Liodden
---
As far as I am concerned, this patch is mere
.
Signed-off-by: Christopher Diaz Riveros
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 32c7225a831e
re, followed
by #define of a different macro [-Wheader-guard]
warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
by #define of a different macro [-Wheader-guard]
Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
Signed-off-by: Colin
On 6/1/20 3:24 PM, Pascal Terjan wrote:
This patch switches to and and
deletes a lot of duplicate definitions plus many unused ones.
Non obvious changes:
- struct ieee80211_ht_cap is different enough that I preferred to keep
(and rename) it for now.
- mcs_rate in translate_scan was not read
On 7/12/20 7:38 AM, Ivan Safonov wrote:
Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
dma_transfer_addr, bpending and last.
Signed-off-by: Ivan Safonov
---
Have you tested this change? Previously with this driver, an unused quantity was
removed from one of the structs and th
I have already fixed 4 places with unnecessary alignment, but, alas, there is no
great desire to test them on real hardware.
I have now tested on real hardware and it works fine.
Acked-by: Larry Finger
Larry
___
devel mailing li
On 7/24/20 8:28 AM, Dinghao Liu wrote:
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Besides Greg's comment, you need to re-parse this sentence. I realize that
English is probably not your first language, but this one
On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)
Fixed the above error which was found on line #721 by inserting a blank
space at the appro
On 7/25/20 1:39 PM, Joe Perches wrote:
On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that
On 7/26/20 3:40 AM, Aditya Jain wrote:
On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl87
This commit adds files hal/odm_RTL8188E.c, hal/odm_RegConfig8188E.c,
hal/rtl8188e_cmd.c, and hal/rtl8188e_dm.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 399 +++
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 130
drivers/staging
This commit adds files os_dep/usb_intf.c, os_dep/usb_ops_linux.c,
and os_dep/xmit_linux.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 892 +++
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 288
drivers/staging/rtl8188eu
This commit adds files hal/rtl8188e_rxdesc.c, hal/rtl8188e_sreset.c, and
hal/rtl8188e_xmit.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 202
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c | 80 ++
drivers/staging
501 - 600 of 621 matches
Mail list logo
