Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h | 4
the old name.
Although this bug only affects 5 of the 8 drivers it touched, I decided to
revert the entire patch. Continuing to constantify the other three could
too easily lead to introduction of future bugs.
Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
Signed-off
On 10/10/2016 11:56 AM, Johannes Berg wrote:
On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote:
This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a.
For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and
rtl8821ae,
the Coccinelle script missed the fact that the code changes
tines that update the software variables.
The configuration struct of rtl8192cu, which was not touched in the
previous patch, is now constantfied.
Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
Suggested-by: Johannes Berg
Signed-off-by: Larry Finger
Cc: Stable [4.8
On 10/12/2016 02:53 AM, Kalle Valo wrote:
Larry Finger writes:
In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
the configuration struct for most of the drivers was changed to be
constant. The problem is that five of the modified drivers need to be
able to
On 10/12/2016 11:54 AM, Kalle Valo wrote:
Larry Finger writes:
In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
the configuration struct for most of the drivers was changed to be
constant. The problem is that five of the modified drivers need to be
able to
tines that update the software variables.
The configuration struct of rtl8192cu, which was not touched in the
previous patch, is now constantfied.
Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
Suggested-by: Johannes Berg
Signed-off-by: Larry Finger
Cc: Stable
Cc: J
When there is a CRC error in the SPROM read from the device, the code
attempts to handle a fallback SPROM. When this also fails, the driver
returns zero rather than an error code.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/ssb/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
necessary change
that affects Bluetooth operation was missed.
Fixes: c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module parameter")
Signed-off-by: Ping-Ke Shih
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 5 -
1 file c
On 11/17/2016 12:05 PM, Larry Finger wrote:
From: Ping-Ke Shih
In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module
parameter"), wifi was fixed for those laptops that have only a single
antenna but have an incorrectly coded EEPROM. This error causes the
driver to
nter() to
use work queue")
Reported-by: Ping-Ke Shih
Signed-off-by: Larry Finger
Cc: Stable
---
Kalle,
Please push this patch to 4.10. It fixes a long-standing bug.
Thanks,
Larry
---
drivers/net/wireless/realtek/rtlwifi/base.c | 8 +++
drivers/net/wireless/realtek/rtlwifi/core.c | 9
On 06/29/2017 01:43 AM, Jaya Durga wrote:
The following variables and struct name
are renamed to avoid camelcase issue
Configuration to configuration
BeaconPeriod to beacon_period
DSConfig to ds_config
ATIMWindowto atim_window
pnic_Config to pnic_config
FHConfig to fh_config
Hop
code into the main wireless tree in small pieces.
To minimize interference between the rtlwifi drivers in the wireless tree
and this new driver, the new one can only be built as a module. In
addition, all code is built into a single module.
Larry Finger
Signed-off-by: Larry Finger
Cc: Ping-Ke
are no changes other than removing all EXPORT
statements, and the fixing of checkpatch messages. The latter will
be backported to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi
This commit adds the TODO file and implements some reviewers comments
made against some patches to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/TODO | 8
into a single module r8822be. When this driver is
moved to the wireless tree, halmac, phydm, and rtl8822be will become
new modules.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/Kconfig
On 08/17/2017 04:07 PM, tedheadster wrote:
Larry, you've migrated a bunch of staging code, and tried various
approaches. Do you have any lessons on what has worked and what hasn't
and if there is anything we can do to make the process better?
I am also quite interested in such work. We asked
On 08/24/2017 07:14 AM, Kalle Valo wrote:
Dan Carpenter writes:
Smatch is distrustful of the "capab" value and marks it as user
controlled. I think it actually comes from the firmware? Anyway, I
looked at other drivers and they added a bounds check and it seems like
a harmless thing to have
e added it here as well.
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Thanks,
Larry
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
index f7f207cbaee3..a30b928d5ee1 100644
--- a/drivers/staging/rtlwifi/base.c
+++ b/drivers/staging/rtlwifi/base.c
@@ -1414,
hat a non-null driver_adapter is passed instead.
Detected by CoverityScan, CID#1454613 ("Explicit null dereferenced")
Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver")
Signed-off-by: Colin Ian King
Acked-by: Larry Finger
Thanks,
Larry
---
drivers
h more readable. In a followup, I will fix the spelling of
polarity, but yours is fine.
Acked-by: Larry Finger
Larry
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc
On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
Like the version in drivers/net/wireless, this driver requires the
MAC80211 framework, otherwise we run into a link error:
ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlw
access btcoex's common status.
2. remove obsolete field bt_exist
Signed-off-by: Ping-Ke Shih
Signed-off-by: Larry Finger
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/debug.c | 226
1 file changed, 1
On 08/24/2017 08:54 PM, Andrew Lunn wrote:
netdev frowns upon debugfs. You should try to keep this altogether,
making it easy to throw away before the driver is moved out of
staging.
You might want to look at ethtool -d. That will be accepted.
Andrew,
What is the problem with debugfs?
Please
On 08/25/2017 03:42 AM, Dan Carpenter wrote:
"hdr" can't be NULL. We take skb->data which is non-NULL and add an
offset to get "hdr".
Signed-off-by: Dan Carpenter
Thanks. Looks good.
Acked-by: Larry Finger
Larry
_
On 08/26/2017 08:01 AM, Yurii Pavlenko wrote:
Hello,
I have attached a small patch to fix a warning "Prefer kcalloc over kzalloc with
multiply"
for efuse.c as part of challenge 10 of Eudyptula.
Best regards,
Yurii Pavlenko
Signed-off-by: Yurii Pavlenko
Before you waste any more of our tim
On 08/26/2017 03:47 PM, Himanshu Jha wrote:
Kfree on NULL pointer is a no-op and therefore checking is redundant.
Signed-off-by: Himanshu Jha
---
Acked-by: Larry Finger
For some reason not fully explained, gmail is placing ALL your E-mails in my
spam folder. You might wish to explore that
On 08/29/2017 06:30 AM, Andreas Ziegler wrote:
The debugging output in deinit_priv is guarded by an #ifdef using
CONFIG_RTL_DEBUG. This symbol does not exist and should be
CONFIG_RTLWIFI_DEBUG instead.
Signed-off-by: Andreas Ziegler
NACK.
Yes, there is a problem; however, CONFIG_RTLWIFI_DEB
On 08/30/2017 02:58 AM, Andreas Ziegler wrote:
Indeed, sorry I missed that as well.
So what should we make of that #ifdef? The code inside it doesn't compile
(anymore? I didn't find any development history for that patch except the
original mail), as there is no definition of struct submit_ctx i
Some useless debugging code from the initial writing of the driver was not
removed before it was submitted. That oversight is now fixed and the
remaining code in routine deinit_priv() is simplified.
Larry
Larry Finger (2):
staging: r8822be: Remove some dead code
staging: r8822be: Simplify
The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section
is left over from debugging of the original driver, and should be
deleted.
Reported by: Andreas Ziegler
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
Now that the extraneous debugging code is removed, routine deinit_priv()
clearly contains code that serves no useful purpose.
A null test before a call to kfree() and a spurious cast are also removed.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc
On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
checkpatch emits multiple warnings of type
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
Replace two calls to kzalloc() with calls to kcalloc().
I have previously discussed this kind of change. This recommendation by
ch
On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
driver. Both functions call rtl_addr_delay(), this function is unused
outside of these call sites.The driver (and kernel) code base is cleaner
if unused functions are removed.
Rem
On 09/28/2015 06:18 AM, Sudip Mukherjee wrote:
On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote:
On 09/26/2015 11:49 AM, Punit Vara wrote:
This patch is to the rtl871x_ioctl_linux.c that fixes up following
warning reported by checkpatch.pl :
- Comparisons should place the constant
staging/rtl8188eu/os_dep/mon.c:188:6: warning: symbol
'rtl88eu_mon_deinit' was not declared. Should it be static?
Signed-off-by: Larry Finger
Cc: Jakub Sitnicki
---
drivers/staging/rtl8188eu/os_dep/mon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/o
does not appear on
any of the developer's setups. For those users whose systems are affected
by the TX blockage, but do not lock up on boot, a module parameter is added
to disable the interrupt clear
Signed-off-by: Larry Finger
Cc: Stable [V4.1+]
---
Kalle,
If possible, please send this p
On 10/10/2015 11:58 AM, Punit Vara wrote:
This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
bssid has datatype u8 and pnetwork->network.MacAddress has data type
u
On 10/18/2015 09:00 PM, Greg KH wrote:
On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote:
One more thing I would like suggestion how can start switching this
driver to LIB80211 ,MAC80211 ? Which is the first file I should focus
? Simultaneously I am trying to understand the flow of driv
This adds the USB ID for the Sitecom WLA2100. The Windows 10 inf file
was checked to verify that the addition is correct.
Reported-by: Frans van de Wiel
Signed-off-by: Larry Finger
Cc: Frans van de Wiel
Cc: Stable [All stable versions]
---
drivers/staging/rtl8712/usb_intf.c | 1 +
1 file
On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote:
Hi,
Support for RTL8723AU devices was added to
wireless-drivers-next.git recently:
https://marc.info/?l=linux-wireless&m=144541406318463
commit:
https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/drivers/net/wir
On 11/01/2015 04:30 AM, =?UTF-8?q?R=C3=A9my=20Oudompheng?= wrote:
Previously the code could exit with failure too early.
Your mailer is broken. The above line is what shows as the return address.
Larry
___
devel mailing list
de...@linuxdriverprojec
event_callback = wlanevents[evt_code].event_callback;
+ if (event_callback)
+ event_callback(padapter, (u8 *)peventbuf);
pevt_priv->evt_done_cnt++;
_abort_event_:
return;
Acked-by: Larry Finger
Thanks,
Larry
_
.
Signed-off-by: Larry Finger
---
Larry Finger (9):
staging: r8188eu: Set device type to wlan
staging: r8188eu: Fix Sparse warnings in rtw_wlan_util
staging: r8188eu: Fix sparse warnings in ioctl_linux.c
staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c
staging: r8188eu: Fix sparse
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers
Sparse shows the following warning:
CHECK drivers/staging/rtl8188eu/core/rtw_wlan_util.c
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1635:25: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ieee80211.h | 16
1 file
/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging/rtl8188eu
__le16
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:expected unsigned short
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:got restricted __le16
*
Signed-off-by: Larry
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:expected unsigned
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 41
/rtl8188eu/core/rtw_br_ext.c:1166:69: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1166:69:expected restricted
__sum16 [usertype] check
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1166:69:got int
Signed-off-by: Larry Finger
/rtl8188eu/os_dep/ioctl_linux.c:3949:38:expected void const
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:got void [noderef]
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3963:9: warning: cast removes
address space of expression
Signed-off-by: Larry Finger
The driver places a 254-byte buffer on the stack when writing long output.
To reduce stack usage, a buffer of the required length is acquired using
kmemdup().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 58 +++
1 file changed, 42
On 10/18/2013 05:08 PM, Ben Hutchings wrote:
On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
Sparse checking results in the following warnings:
CHECK drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
Cc: Stable a [3.12+]
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep
c)/include
With that change, you may add
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 10/23/2013 08:10 PM, Chen Gang wrote:
> On 10/24/2013 12:06 AM, Larry Finger wrote:
>> On 10/23/2013 03:52 AM, Chen Gang wrote:
>>> If command line use EXTRA_CFLAGS (e.g. "EXTRA_CFLAGS=-mmedium-calls"
>>> for arc architecture, with allmodconfig), it can not
/rtl8188eu/os_dep/ioctl_linux.c:3949:38:expected void const
*
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3949:38:got void [noderef]
*pointer
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3963:9: warning: cast removes
address space of expression
Signed-off-by: Larry Finger
*
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:expected unsigned short
*fctrl
drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:got restricted __le16
*
Signed-off-by: Larry
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:expected unsigned
short *fctrl
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 41
This set of patches resubmits the set of fixes for sparse warnings. The two that
were criticized have been removed, and this set should not have white-space
damage.
Signed-off-by: Larry Finger
Larry Finger (5):
staging: r8188eu: Fix sparse warnings in ioctl_linux.c
staging: r8188eu: Fix
/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:got restricted __le16
*
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
b/drivers/staging/rtl8188eu
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ieee80211.h | 16
1 file changed
On 10/24/2013 05:10 AM, Dan Carpenter wrote:
I have looked at how this is called from ioctl_private_call() and it
seems like these are actual user pointers and the code is buggy. The
patch silences the warnings instead of fixing the bugs.
Thanks for the review.
Greg - please drop this one and
Two code lines were accidentally deleted in the code. Restore them.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
Two code lines were accidentally deleted. Restore them.
Signed-off-by: Larry Finger
Cc: Stable
---
V2 - rewrite silly commit message.
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging
Because the original driver was designed to build for Windows, FreeBSD, and
Linux,
there are wrappers for many of the OS primitives. These patches remove a number
of them.
Signed-off-by: Larry Finger
Larry Finger (11):
staging: r8188eu: Remove pointless thread_exit macro
staging: r8188eu
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 16 +++
drivers/staging/rtl8188eu/core/rtw_cmd.c | 12
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
drivers/staging
This wrapper does nothing on Linux. When calls to it were removed, a number of
routines became empty and could also be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 -
drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 -
drivers/staging
Each instance may bre replaced by udelay
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 6 +++---
drivers/staging/rtl8188eu/hal/odm.c| 10 -
drivers/staging/rtl8188eu/hal
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16
drivers/staging/rtl8188eu/core/rtw_mp.c| 4
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 14 +++---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12
Again there are two - _exit_critical() and _exit_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
drivers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mp.c| 4 ++--
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 10 +-
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 12 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5
There are two such wrappers - _enter_critical() and _enter_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu
On 12/20/2013 01:14 AM, Dan Carpenter wrote:
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
@@ -1509,10 +1509,6 @@ _func_enter_;
rtw_p2p_set_state(pwdinfo
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909
[gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you
On 12/20/2013 01:18 PM, Greg KH wrote:
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any.
On 12/20/2013 02:34 PM, Greg KH wrote:
Nah, I just switched to 4.8 and rebuilt all of the different kernel
trees on this box with it, so I'll stay there for now.
The problem wasn't the fault of gcc 4.8. I only use the staging tree to base
patches to send to you, and my .config in that director
A recent set of patches revealed that a line of code had been incorrectly
removed in an earlier edit. That line is added back. In addition, a
configuration
problem resulted in a number of "unused variable" warnings.
Signed-off-by: Larry Finger
Larry Finger (2):
staging: r8188e
block was removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 12
drivers/staging/rtl8188eu/core/rtw_debug.c | 1 -
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8
drivers/staging/rtl8188eu/core/rtw_recv.c | 1 -
drivers
A line in the P2P code had been removed in the process of converting the vendor
driver to a form suitable for the kernel. The output of this call was ignored,
and the initial analysis incorrectly determined that the call had no other
effect.
Signed-off-by: Larry Finger
---
drivers/staging
Please tell me if the following fixes are appropriate. In particular, I am
uncertain of
the __force attributes.
Thanks,
Larry
Sparse lists the following:
CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c
drivers/staging/rtl8188eu/core/rtw_br_ext.c:1156:63: warning: restricted
__sum16 deg
Each of the uses in the code asks for a sleep of 100 usec or so. On Linux,
these are converted to msleep(1).
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/hal
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/drv_types.h | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 22 ++
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +-
drivers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
drivers/staging/rtl8188eu/include/osdep_service.h | 4
drivers/staging/rtl8188eu/include/usb_ops.h | 2 +-
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 10 --
4 files
a simple yield() is sufficient.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5 -
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++--
4 files changed, 3
This set of patches removes a number of wrappers around standard routines,
cleans up some sparse warhings, and also removed a smatch warning.
Signed-off-by: Larry Finger
Larry Finger (31):
staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os
staging: r8188eu: Replace wrapper
The current kernels do not include this entry point. Delete the call.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include
All of these routines are empty.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 5 -
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 16
drivers/staging/rtl8188eu/os_dep/rtw_android.c| 2 --
drivers/staging/rtl8188eu/os_dep
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 1 -
drivers/staging/rtl8188eu/include/usb_ops.h | 2 +-
drivers/staging/rtl8188eu/os_dep
: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c | 56 -
drivers/staging/rtl8188eu/hal/odm_HWConfig.c| 4 +-
drivers/staging/rtl8188eu/include/odm.h | 4 --
drivers/staging/rtl8188eu/include/odm_precomp.h | 7
4 files changed, 1 insertion
This one is a duplicate od macro PHY_QueryRFReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++--
drivers/staging/rtl8188eu/hal/odm.c | 4 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu
This member of struct odm_dm_struct is always set to ODM_CE in this driver.
As a result, a number of switch and if statements can be simplified. In
addition, a number of routines are no longer used and can be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm.c
It is a duplicate of macro PHY_SetRFReg.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++---
drivers/staging/rtl8188eu/hal/odm.c| 8 +++---
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6 ++--
drivers/staging
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol
'rtw_mfree_all_stainfo' was not declared. Should it be static?
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol
'rtw_free_pwrctrl_priv' was not declared. Should it be static?
That routine is not used and has been deleted.
Signed-off-by: La
401 - 500 of 621 matches
Mail list logo
