On 12/17/2016 01:39 PM, Jannik Becher wrote:
Fixed sparse warning "cast to restricted __le32".
struct recv_stat and struct phy_stat have always little endian members.
Signed-off-by: Jannik Becher
---
drivers/staging/rtl8712/rtl8712_recv.h | 28 ++--
1 file changed, 14 i
s not, and a test is needed to prevent kernel panics.
Fixes: commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
kfree_skb")
Signed-off-by: Larry Finger
Cc: Stable (4.9+)
Cc: Wei Yongjun
---
Kalle,
This change should be sent to mainline during the 4.10 merge period,
or
On 12/20/2016 05:21 AM, Kalle Valo wrote:
Larry Finger writes:
With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
kfree_skb"), the method used to free an skb was changed because the
kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
guards
it ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").
Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
Signed-off-by: Larry Finger
---
Kalle,
This patch needs to be included in 4.10.
Larry
---
drivers/net/wireless/realtek/rtlwifi/usb.c | 1 +
1 file changed, 1 ins
contain a
function with a similar name or produce this warning.
Aced-by: Larry Finger
Arnd,
Please let me now if gcc-7 shows any warnings for the code in
drivers/net/wireless/realtek/rtlwifi/. My distro supplies gcc-4.8, and it wouod
be a lot of work to implement gcc-7.
Larry
Cc: sta
On 02/10/2017 08:08 AM, Greg KH wrote:
On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_o
On 02/10/2017 08:58 AM, Greg KH wrote:
On Fri, Feb 10, 2017 at 08:52:12AM -0600, Larry Finger wrote:
On 02/10/2017 08:08 AM, Greg KH wrote:
On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212
On 02/10/2017 12:23 PM, Perry Hooker wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_ops_linux.c | 5 +++--
1 file changed, 3 insertions(+), 2 d
Now that endian checking is an automatic part of Sparse, it is advisable
to fix these warnings under controlled conditions, which include testing
on big-endian hardware. This set of patches fix all the issues.
Signed-off-by: Larry Finger
Larry Finger (7):
staging: r8712u: Fix some Sparse
The headers describing a number of network packets do not have the
correct endian settings for several types of data.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/ieee80211.h | 84 ++---
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a
/rtl871x_xmit.c:580:36:expected unsigned short
[unsigned] [short] [usertype]
drivers/staging/rtl8712/rtl871x_xmit.c:580:36:got restricted __be16
[usertype]
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl871x_xmit.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
: warning: cast from restricted
__le32
Each of these cases is transferring a quantity that is little-endian. There
is no need for conversion.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl8712_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
Although the driver works on big-endian hardware, Sparse generates a lot
of warnings. Many of these are the result of incorrect coding of these
macros.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/wifi.h | 109 -
1 file changed, 52 insertions
] cap_info
drivers/staging/rtl8712/rtl871x_mlme.c:1712:35:got int
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl871x_mlme.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c
b/drivers/staging/rtl8712/rtl871x_mlme.c
] len
drivers/staging/rtl8712/rtl871x_recv.c:657:21:got restricted __be16
[usertype]
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl871x_recv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_recv.c
b/drivers/staging/rtl8712
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 0dc18d6..f4167f1 100644
--- a/drivers/staging
On 01/28/2015 09:53 AM, Heba Aamer wrote:
This patch fixes the following checkpatch.pl warning:
Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)
I used the following coccinelle script:
@@
expression E1,E2;constant E3;
@@
- memcpy(E1, E2, E3)
+ ether_addr_copy(E
On 01/29/2015 01:54 PM, Aya Mahfouz wrote:
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote:
On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote:
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
On 01/28/2015 09:53 AM, Heba Aamer wrote:
This patch fixes the
s a pointer that
starts from an even offset.
Signed-off-by: Heba Aamer
---
v2: modifying patch description
drivers/staging/rtl8712/usb_intf.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
This is much better.
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8
On 01/31/2015 10:19 AM, Dan Carpenter wrote:
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
while (phead != plist) {
- psta = container_of(plist, struct sta_info , list);
+ container_of(plist, struct sta_info, list);
Argh!!! No.
For
On 02/22/2015 01:28 PM, Daniele Alessandrelli wrote:
Fix all checkpatch "braces {} are not necessary" warnings for
rtl8723au/hal/rtl8723a_hal_init.c
Signed-off-by: Daniele Alessandrelli
Acked-by: Larry Finger
Thanks,
Larry
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_i
On 02/27/2015 10:44 AM, Matteo Semenzato wrote:
From: Matteo Semenzato
This patch fixes the following errors:
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: switch and case should be at the same indent
Signed-off-by: Matteo Semenzato
On 03/07/2015 09:33 AM, Matteo Semenzato wrote:
From: Matteo Semenzato
The rtw_cmd_thread semaphore was being unlocked twice.
Signed-off-by: Matteo Semenzato
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl
On 03/08/2015 10:54 AM, Mike Krinkin wrote:
The %*ph specifier allows to pass a pointer and length instead of
pushing each byte via stack. The patch converts code to use it.
Signed-off-by: Mike Krinkin
Why not use %pM as long as you are changing this code? It will format the
results in a bet
[PATCH v2 4/4]
All four look great now,
Reviewed-by: Arnd Bergmann
I agree.
Tested-by: Larry Finger
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
While testing the patches that removed the semaphores from this driver,
kmemleak reported some leaked skbs. There were also some false positives.
I also found code that dereferenced a pointer before it was checked. All
of these conditions are fixed.
Signed-off-by: Larry Finger
Larry Finger (3
the old skb could be reused.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/recv_linux.c| 1 -
drivers/staging/rtl8712/rtl8712_recv.h | 1 -
drivers/staging/rtl8712/usb_ops_linux.c | 24
3 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers
Routine r8712_usb_read_port() dereferences "precvbuf" before testing it
for NULL.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/usb_ops_linux.c | 72 -
1 file changed, 34 insertions(+), 38 deletions(-)
diff --git a/drivers/stagi
When this driver preallocates some URBs, kmemleak is unable to find that
allocated memory when it scans. When the driver is unloaded, that memory
is reclaimed, therefore, the report is a false positive.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/xmit_linux.c | 2 ++
1 file changed
anics.
Fixes: 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu:
use sizeof(*ptr) instead of sizeof(struct)")
Signed-off-by: Larry Finger
Cc: Jacky Boen
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driver
When this driver preallocates some SKBs, kmemleak is unable to find that
allocated memory when it scans. When the driver is unloaded, that memory
is released; therefore, the report is a false positive.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 2 ++
1 file
anics.
Fixes: 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu:
use sizeof(*ptr) instead of sizeof(struct)")
Signed-off-by: Larry Finger
Cc: Jacky Boen
---
V2 - Remove extra blank line inserted by mistake.
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
1 file changed, 1 in
y to start the patch subject with "staging:
rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than
rtl8188eu as the former is the actual name of the driver, but either will work.
I have tested all 4 of these patches with no problems, thus
Acked-by: Larry Fing
("staging: rtl8188eu: Remove
rtw_zmalloc(), wrapper for kzalloc()")
Signed-off-by: Larry Finger
Cc: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/st
Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock
in most routines but not in rtl88e_dm_watchdog(), which could
lead to a race condition. The necessary locking to prevent this condition
is added.
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel Andrianov
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel Andrianov
---
drivers/net/wireless/realtek/rtlwifi/ps.c | 25 +
drivers/net/wireless/realtek/rtlwifi/ps.h | 3 ---
2 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/net/wireless/rea
Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock
in most routines but not in rtl92ee_dm_watchdog(), which could
lead to a race condition. The necessary locking to prevent this condition
is added.
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel
shown to occur, thus these patches are not backported to stable
kernels.
Signed-off-by: Larry Finger
Larry Finger (6):
rtlwifi: Remove unused parameter from rtl_ps_set_rf_state()
rtlwifi: rtl8188ee: Fix potential race condition
rtlwifi: rtl8192ee: Fix potential race condition
rtlwifi
Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock
in most routines but not in rtl8821ae_dm_watchdog() which could
lead to a race condition. The necessary locking to prevent this condition
is added.
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel
Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock
in most routines but not in rtl8723be_dm_watchdog(), which could
lead to a race condition. The necessary locking to prevent this condition
is added.
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel
Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock
in most routines but not in rtl8723e_dm_watchdog(), which could
lead to a race condition. The necessary locking to prevent this condition
is added.
Reported-by: Pavel Andrianov
Signed-off-by: Larry Finger
Cc: Pavel
The driver for RTL8192CE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8192ce/hw.c| 83 --
1 file changed, 12
All of the rtlwifi family of drivers have a similar routine that acquires
the hardware info from efuse and initializes a number of variables in the
driver's private area. A common routine is created for all drivers to use.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Ber
The driver for RTL8188EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8188ee/hw.c| 76 --
1 file changed, 13
in rtl8723ae. These are converted into switch statements that
are much easier to read.
The changes in the hwinfo routines was suggested by Arnd Bergmann.
All of this material is intended for kernel 4.8.
Signed-off-by: Larry Finger
Larry Finger (10):
rtlwifi: Create common routine to get
The driver for RTL8192CU chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c| 61 ++
1 file changed, 15
The driver for RTL8723AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c| 76 --
1 file changed, 11
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c| 84 +++---
1 file changed, 11
This driver contains some complicated if ... else if ... else constructions.
These are replaced by switch statements to improve readability.
Signed-off-by: Larry Finger
---
.../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c| 210 +++--
1 file changed, 107 insertions(+), 103
The driver for RTL8723BE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8723be/hw.c| 74 --
1 file changed, 12
The driver for RTL8192EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8192ee/hw.c| 73 --
1 file changed, 12
The driver for RTL8192DE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8192de/hw.c| 77 +-
1 file changed, 15
in rtl8723ae. These are converted into switch statements that
are much easier to read.
The changes in the hwinfo routines was suggested by Arnd Bergmann.
All of this material is intended for kernel 4.8.
Signed-off-by: Larry Finger
---
V2 - Applied changes suggested by Joe Perches
Fixed a bug
The driver for RTL8192CU chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8723AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
All of the rtlwifi family of drivers have a similar routine that acquires
the hardware info from efuse and initializes a number of variables in the
driver's private area. A common routine is created for all drivers to use.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Ber
The driver for RTL8192CE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8188EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8723BE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8192DE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
This driver contains some complicated if ... else if ... else
constructions. These are replaced by switch statements to improve
readability.
Signed-off-by: Larry Finger
---
V2 - Changes suggested by Joe Perches were incorporated
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8192EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
On 06/27/2016 04:23 PM, Joe Perches wrote:
On Mon, 2016-06-27 at 10:52 -0500, Larry Finger wrote:
This driver contains some complicated if ... else if ... else
constructions. These are replaced by switch statements to improve
readability.
[]
diff --git a/drivers/net/wireless/realtek/rtlwifi
in rtl8723ae. These are converted into switch statements that
are much easier to read.
The changes in the hwinfo routines was suggested by Arnd Bergmann.
All of this material is intended for kernel 4.8.
Signed-off-by: Larry Finger
---
V2 - Applied changes suggested by Joe Perches
Fixed a bug
All of the rtlwifi family of drivers have a similar routine that acquires
the hardware info from efuse and initializes a number of variables in the
driver's private area. A common routine is created for all drivers to use.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Ber
The driver for RTL8192CU chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8192EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
This driver contains some complicated if ... else if ... else constructions.
These are replaced by switch statements to improve readability.
Signed-off-by: Larry Finger
---
V2 - Changes suggested by Joe Perches were incorporated
V3 - Missing break statments are added.
This patch requires
The driver for RTL8723AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8723BE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8192DE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8192CE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8188EE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The Realtek RTL8723BS chips, which are connected via SDIO, also contain
a serial Bluetooth device. In order for BT to work, the device must be
added to the acpi_device_id table.
Signed-off-by: Larry Finger
---
I have no idea if this device should be added here, or if the device could
be added
On 07/20/2016 06:25 AM, Jes Sorensen wrote:
Arnd Bergmann writes:
On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote:
Arnd Bergmann writes:
I think that would be better, albeit not a big issue.
Ok, and since Kalle applied the first patch to his tree, I'm now sending
a series of t
Some RTL8821AE devices sold in Great Britain have the country code of
0x25 encoded in their EEPROM. This value is not tested in the routine
that establishes the regulatory info for the chip. The fix is to set
this code to have the same capabilities as the EU countries.
Signed-off-by: Larry Finger
On 08/22/2016 10:36 AM, Kalle Valo wrote:
Larry Finger writes:
Some RTL8821AE devices sold in Great Britain have the country code of
0x25 encoded in their EEPROM. This value is not tested in the routine
that establishes the regulatory info for the chip. The fix is to set
this code to have the
allowed for COUNTRY_CODE_ETSI were more properly suited
for China and Israel, not the EU. This problem has also been fixed.
Signed-off-by: Larry Finger
Cc: Stable
---
V2 - Explain why channels for ETSI have been modified.
---
drivers/net/wireless/realtek/rtlwifi/regd.c | 4 +++-
1 file changed, 3
and the expected value for the project ID.
Signed-off-by: 陆朱伟
Signed-off-by: Larry Finger
---
drivers/bluetooth/btrtl.c | 104 --
drivers/bluetooth/btrtl.h | 5 +++
2 files changed, 97 insertions(+), 12 deletions(-)
diff --git a/drivers/bluetooth
On 09/14/2016 04:55 PM, Zach Brown wrote:
Adding led support for phy causes namespace conflicts for some
phy drivers.
The rtl871 driver declared an enum for representing LED states. The enum
contains constant LED_OFF which conflicted with declartation found in
linux/leds.h. LED_OFF changed to LE
that action, I have changed it to only be printed
when the RTL8XXXU_DEBUG_USB bit is set in the debug mask.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek
On 09/17/2016 03:59 PM, Jes Sorensen wrote:
Larry Finger writes:
As soon as debugging is turned on, the logs are filled with messages
reporting the interrupt status. As this quantity is usually zero, this
output is not needed. In fact, there will be a report if the status is
not zero, thus the
that action, I have changed it to only be printed
when the newly added RTL8XXXU_DEBUG_INTERRUPT bit is set in the debug
mask.
Signed-off-by: Larry Finger
---
V2 - Added new debugging flag as requested by Jes.
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
drivers/net/wireless
The entries in this enum may be referenced in debug output. Adding explicit
values simplifies the lookup.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/wifi.h | 208 ++--
1 file changed, 104 insertions(+), 104 deletions(-)
diff --git a/drivers/net
: Larry Finger
---
This patch depends on "realtek: Add switch variable to 'switch case not
processed' messages" submitted by Joe Perches.
Larry
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 2 ++
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c | 2 ++
drivers/
g cases with the hex value. To aid in debugging, the values for
entries in the hardware variables enum are explicitly defined in hex.
Larry Finger (2):
rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines
rtlwifi: Add explicit values to hw_variables enum
.../net/wireless/realtek/rt
On 09/24/2016 12:43 PM, Joe Perches wrote:
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote:
The entries in this enum may be referenced in debug output. Adding explicit
values simplifies the lookup.
A negative aspect to this style is forced renumbering
if a HW_VAR entry is inserted.
Is
On 09/25/2016 04:18 PM, Gonçalo Salazar wrote:
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Please let me know of any feedback you have.
Thanks,
Gonçalo Salazar
Your subject heeds to specify which driver is involved. In addition, fixes for
st
On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any feedback you have.
I missed this last time, but everything above the --- line goes into the
On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
2016-09-26 1:53 GMT+01:00 Larry Finger :
On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/def.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8192de/dm.c| 4
A number of these drivers were submitted to the kernel before
checkpatch.pl was modified to state that that the address of the
FSF should not be included. This set of patches remove this
information from the sources.
Signed-off-by: Larry Finger
Larry Finger (8):
rtlwifi: rtl8192de: Remove
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/fw.h
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/def.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8192se/dm.c| 4
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/def.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/dm.c| 4
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.h
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 4
drivers/net/wireless/realtek/rtlwifi/pci.h | 4
drivers/net/wireless
Since this driver was added to the kernel, the checkpatch script was
modified to request that the address of the FSF not be included.
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/def.h | 4
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/dm.c| 4
301 - 400 of 621 matches
Mail list logo
