truct is
allocated with rtw_zmalloc()
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index 153ec61493ab..96df62f95b6b 100644
--- a/drivers/staging/rtl8188eu/core/rtw_wla
This routine is essentially a duplicate of rtw_read32.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 9 +
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 2 +-
drivers/staging/rtl8188eu/hal/odm.c | 8
drivers
de vzalloc and vfree.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 +
drivers/staging/rtl8188eu/core/rtw_mp.c| 1 +
drivers/staging/rtl8188eu/core/rtw_recv.c | 1 +
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 1 +
drivers/staging/rtl81
On 02/07/2014 06:04 PM, Greg KH wrote:
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote:
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled "staging: r8188eu:
Remove wrappers around vmalloc and vzalloc" and
commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitle
de vzalloc and vfree.
This problem was reported by the kbuild test robot.
Signed-off-by: Larry Finger
---
V2 - add attribution to the build robot
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 +
drivers/staging/rtl8188eu/core/rtw_mp.c| 1 +
drivers/staging/rtl8188eu/core
ually works, it will be submitted to the
drivers/net/wireless tree of the regular kernel, and it should be there by 3.15.
That said, Acked-by: Larry Finger
Larry
---
drivers/staging/rtl8821ae/wifi.h | 450 ---
1 file changed, 226 insertions(+), 224 de
On 02/09/2014 01:30 AM, Surendra Patil wrote:
Fixed multiple coding style errors and warnings
wifi.h:1077: WARNING: please, no space before tabs
wifi.h:762: WARNING: missing space after struct definition
wifi.h:972: WARNING: please, no spaces at the start of a line
wifi.h:1825: WARNING: Unnecessa
On 02/09/2014 02:29 AM, Surendra Patil wrote:
Fixed few coding style errors in header files
base.h:58: WARNING: please, no space before tabs
base.h:81: ERROR: "(foo*)" should be "(foo *)"
pci.h:338: ERROR: "foo * bar" should be "foo *bar"
pci.h:151: ERROR: do not use C99 // comments
Signed-off-b
As has been noted, this driver is very rough. This set of patches is
intended to smooth some of the rough edges.
Signed-off-by: Larry Finger
Larry Finger (6):
staging: r8188eu: Replace wrapper around _rtw_memcmp()
staging: r8188eu: Remove dead file
staging: r8188eu: Remove some dead code
The headers for this driver contain a number of unused structs and macros
that are removed. File include/ioctl_cfg80211.h is now empty and was
deleted.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ioctl_cfg80211.h | 107 -
drivers/staging/rtl8188eu
This wrapper is replaced with a simple memcmp(). As the wrapper inverts the
logic of memcmp(), care needed to be taken.
This patch also adds one include of vmalloc.h that was missed in a previous
patch.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 16
After the previous cleanups, file hal/odm_interface.c is now empty. It
is hereby deleted, and removed from Makefile.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/Makefile| 1 -
drivers/staging/rtl8188eu/hal/odm_interface.c | 1 -
2 files changed, 2 deletions(-)
delete
rt of that union.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 16 -
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_debug.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 14 ---
The driver contains a macro that gets the next item in a linked list.
Replace it with a simple copy of the pointer.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 32 +++---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging
ble_Ch14' 33 <= 255
Not listed here is one remaining buffer overflow message that I believe to be
an error in Smatch.
These warnings were reported by the 0-DAY kernel build testing backend.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 32
previously assumed 'pregpriv' could be null (see line 4469)
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 +-
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/d
Smatch reports the following:
drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info:
ignoring unreachable code.
Upon investigation, the code in this region has the capability of creating
an infinite loop.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8821ae
This alignment entry in union recv_frame does nothing. It certainly
dues not ensure alignment.
Suggested-by: jes.soren...@redhat.com
Signed-off-by: Larry Finger
Cc: jes.soren...@redhat.com
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a
the disk file every time the device reinits.
Signed-off-by: Larry Finger
Larry Finger (12):
staging: r8188eu: Remove unnecessary list_head entry from recv_frame
union
staging: r8188eu: Remove pointless "alignment" entry in recv_frame
staging: r8188eu: Remove union w
These functions are not called from the outside source.
Suggested-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 38
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
Struct recv_frame_hdr already contains a list head. This one is pointless.
Suggested-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 7 ---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
2 files changed, 4 insertions
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 81fdcf5
This simple routine is replaced by a simple access of the len member.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 5 -
2 files changed, 1 insertion(+), 6
This wrapper is a simple call to mutex_exit().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 7 ---
drivers/staging/rtl8188eu/os_dep
From: Stas Sergeev
The present code reloads the firmware file from the disk every time the
interface
re-inits. Change to hold the firmware in memory, and only download to the
device.
Signed-off-by: Stas Sergeev
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal
-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 6 ++
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h| 9 -
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/staging
This is simply another name for INIT_WORK().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_led.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 6 --
3 files changed, 2 insertions(+), 8
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_xmit.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_xmit.h
b/drivers/staging/rtl8188eu/include/rtw_xmit.h
index 1ac1dd3..62f5db1 100644
--- a/drivers/staging/rtl8188eu/include
This is simply a wrapper around schedule_work().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_led.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
This wrapper returned the result of mutex_lock_interruptible(); however,
none of the callers checked the returned value.
As a result of a gcc upgrade to version 4.8.1, two false unitialized variable
warnings appeared. To silence the warnings, they are initialized to 0.
Signed-off-by: Larry
On 02/15/2014 04:41 AM, Dan Carpenter wrote:
On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote:
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 1fa5370..d5f6a32 100644
--- a/drivers/staging/rtl8188eu/hal
On 02/16/2014 03:09 AM, Dan Carpenter wrote:
On Sun, Feb 16, 2014 at 11:02:52AM +0800, Zhao, Gang wrote:
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
This alignment entry in union recv_frame does nothing. It certainly
dues not ensure alignment.
^
typo here.
I
On 02/15/2014 02:41 PM, Greg KH wrote:
On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote:
I've applied this series up to here.
Nevermind, the others applied, so I've merged them, just not this patch.
I have split this patch into two parts that I will send tomorrow. The first one
just
From: Manu Gupta
The D-Link DWA-123 REV D1 with USB ID 2001:3310 uses this driver.
Signed-off-by: Manu Gupta
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers
From: Fengguang Wu
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with
struct assignment
Generated by: coccinelle/misc/memcpy-assign.cocci
Signed-off-by: Fengguang Wu
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file
: Larry Finger
Cc: Jes Sorensen
Larry Finger (6):
staging: r8723au: Add source files for new driver - part 1
staging: r8723au: Add source files for new driver - part 2
staging: r8723au: Add source files for new driver - part 3
staging: r8723au: Add source files for new driver - part 4
This commit also creates a TODO file.
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/rtl8723au/Kconfig | 37
drivers/staging/rtl8723au/Makefile | 58
On 03/28/2014 10:26 PM, Joe Perches wrote:
On Fri, 2014-03-28 at 21:37 -0500, Larry Finger wrote:
The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
A driver for it has been available in a GitHub repo for several months.
[]
133 files changed, 89878 insertions(+)
eek
23au/r8723au.ko]
undefined!
ERROR: "cfg80211_disconnected" [drivers/staging/rtl8723au/r8723au.ko] undefined!
ERROR: "ieee80211_amsdu_to_8023s" [drivers/staging/rtl8723au/r8723au.ko]
undefined!
ERROR: "cfg80211_scan_done" [drivers/staging/rtl8723au/r8723au.ko] undefin
ivers/input/Kconfig:8:symbol INPUT is selected by ACPI_CMPC
drivers/platform/x86/Kconfig:635: symbol ACPI_CMPC depends on RFKILL
To avoid substituting one build error for another, I added a "depends on
RFKILL".
My suspicion is that this particular error is caused by a kbuild b
On 04/07/2014 04:08 AM, Paul Bolle wrote:
Larry,
0) I stumbled on two minor Kconfig related issues in the r8723au driver
in staging-next.
1) drivers/staging/rtl8723au/include/drv_types.h
Why is CONFIG_BR_EXT used? I couldn't find a Kconfig symbol BR_EXT nor a
preprocessor define for CONFIG_BR_E
e" to
match
the actual routine. The third warning comes from testing that a u8 quantity is
positive.
Reported-by: kbuild test robot
Signed-off-by: Larry Finger
Cc: Jes Sorensen
Cc: kbuild-...@01.org
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
drivers/staging/rtl8723au/
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/rtl871x_recv.c | 15 +++
1 file
While analyzing parts of the recently merged r8723au driver, Jes Sorensen
found two bugs that are found in other Reaktek drivers in staging. This
set of patches fixes them.
Signed-off-by: Larry Finger
Larry Finger (3):
staging: r8188eu: Calling rtw_get_stainfo() with a NULL sta_addr will
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 20
On 04/09/2014 11:24 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:12 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by
e" to
match
the actual routine. The third warning comes from testing that a u8 quantity is
positive.
Reported-by: kbuild test robot
Signed-off-by: Larry Finger
Cc: Jes Sorensen
Cc: kbuild-...@01.org
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++--
drivers/staging/rtl8723a
On 04/09/2014 11:25 AM, Sergei Shtylyov wrote:
On 04/09/2014 08:13 PM, Larry Finger wrote:
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by
stack, the array may not be
sorted correctly.
Signed-off-by: Geert Uytterhoeven
---
Acked-by: Larry Finger
Geert,
Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.
Larry
drivers/staging/rtl8723au/core/rtw_wlan_util.c |2 +-
1 file changed, 1 insertion(+), 1
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparison against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8712/rtl871x_recv.c | 13 ++---
1 file
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparison against eapol_type
would always fail.
Reported-by: Jes Sorensen
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 15 ++-
1
ng: symbol
'process_pwrbit_data' was not declared. Should it be static?
drivers/staging/rtl8188eu/core/rtw_recv.c:1828:5: warning: symbol
'enqueue_reorder_recvframe' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Larry Finger
Cc: Dan C
On 04/22/2014 09:14 AM, Dan Carpenter wrote:
On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
Hi dan
it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.
Smatch issues the warning
CHECK drivers/staging/rtl8723bs/os_dep/xmit_linux.c
drivers/staging/rtl8723bs/os_dep/xmit_linux.c:42 _rtw_pktfile_read() warn:
inconsistent indenting
A simple indent changes fixes this.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep
Smatch lists the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c:102 rtw_drv_proc_open() warn:
inconsistent indenting
This warning is fixed with a simple change in the white space.
Signed-off-by: Larry Finger
---
drivers
A number of routines have indenting, off by one, and possible usage
while null warnings or errors listed by Smatch. This set of patches
fix all but one of these, and it is in code that will be removed in a
subsequent patch.
Signed-off-by: Larry Finger
Larry Finger (22):
staging: rtl8723bs
t line 353.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index c677a5216b54..e731ab4e2bd7 100644
---
Smatch logs the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/os_intfs.c
drivers/staging/rtl8723bs/os_dep/os_intfs.c:1082 ips_netdrv_open() warn:
inconsistent indenting
A simple change in the white space handles this warning.
Signed-off-by: Larry Finger
---
drivers/staging
changes.
The section where 'scanned' could be null required an immediate exit from
the routine at that point. A similar fix was required where 'skb' could be null.
The two buffer overflow errors were caused by off-by-one errors. While
locating these problems, another one was f
rror exits from this routine.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_in
Smatch reports the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/mlme_linux.c:149 rtw_os_indicate_disconnect()
warn: inconsistent indenting
Again, a simple change in the white space fixes this problem.
Signed-off-by: Larry Finger
ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: for statement not indented
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:586
ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: inconsistent indenting
These were all fixed with white-space changes.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 6
/rtl8723bs/core/rtw_xmit.c:295 _rtw_free_xmit_priv() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rtw_xmit.c:946 xmitframe_addmic() warn:
inconsistent indenting
These are fixed with white-space changes.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 10
nfo() warn:
variable dereferenced before check 'phead' (see line 454)
In the code, there are two successive calls to get_head(). The second
is removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/st
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_ap.c:382 expire_timeout_chk() warn:
inconsistent indenting
Fixing this requires changing the indentatikon of a long for loop.
Signed-off-by: Larry Finger
---
drivers/staging
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090
Hal_ChannelPlanToRegulation() warn: inconsistent indenting
Fixed by changing the white space.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal
not indented
These warnings are fixed with white-space changes.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers/staging
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090
Hal_ChannelPlanToRegulation() warn: inconsistent indenting
This warning is fixed with a white-space change.
Signed-off-by: Larry Finger
---
drivers
:1809 aes_decipher() warn:
inconsistent indenting
All of the above are fixed with white-space changes. A few unneeded
blank lines are deleted.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_security.c | 469 +-
1 file changed, 229 insertions(+), 240
Sparse reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:25 _rtw_init_stainfo() warn:
inconsistent indenting
This problem is fixed with a white-spcae change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs
drivers/staging/rtl8723bs/core/rtw_wlan_util.c:815 rtw_camid_alloc() warn:
should '1 << (cam_id)' be a 64 bit type?
The first two are fixed with white-space changes. The third is fixed by
restricting cam_id to be less than 32.
Signed-off-by: Larry Finger
---
drivers/stagin
h white-space changes. The error at
line 1595 was the result of an off-by-one error in a for loop. The error
at line 4969 was not fixed as that code lies inside a block of code that
only is needed for 5G channels. This chip only works at 2.4 GHz.
Signed-off-by: Larry Finger
---
drivers/staging/rtl
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:641 LeaveAllPowerSaveModeDirect()
warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
1 file changed
All of there are simple white-space errors. A typo is also fixed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 37 +++
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
b/drivers
: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c
b/drivers/staging/rtl8723bs/core/rtw_odm.c
index 5bc573386ad1..3144e8ec2fa2 100644
--- a/drivers/staging/rtl8723bs
/rtw_recv.c:1547 validate_recv_frame() warn:
inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging
: Julia Lawall
Signed-off-by: Fengguang Wu
Thank you for these patches. Larry Finger has just
posted a large cleanup series for the rtl8723bs
driver, which will likely conflict with these.
Can you rebase and resend these patches once Larry's
series has been merged please?
OK, thanks fo
On 04/09/2017 10:28 AM, Bastien Nocera wrote:
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470
rtw_cfg80211_ibss_indicate_connect() error: we
On 04/10/2017 08:43 AM, Aishwarya Pant wrote:
kfree(..) on a NULL pointer is a no-op; the null test here is redundant.
Detected by coccicheck.
Signed-off-by: Aishwarya Pant
Acked-by: Larry Finger
Thanks,
Larry
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++
drivers
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
The patch is OK, but most maintainers require a non-blank commit message.
Larry
drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +--
1 file changed, 44 insertions(+), 36 deletions(-
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h
b/drivers/staging/rtl8723bs/hal/odm.h
index 0b3541a91548..13c4aebd178e 1
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +--
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++--
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++
3 files changed, 1
ented
affected boxes from booting even after that patch was applied.
The actual cause of the original problem is unknown as none of the
developers have systems that are affected.
Signed-off-by: Larry Finger
Cc: Stable [V4.1+]
---
Kalle,
I hope this patch can be applied to 4.4.
Thanks,
On 11/12/2015 01:54 PM, Kalle Valo wrote:
Larry Finger writes:
In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
("rtlwifi: Remove the clear interrupt routine from all drivers&q
The instructions for submitting patches state that changes destined for
networking should not be marked with a Cc to stable. This restriction does
not apply to the wireless portion of networking. The instructions are
updated to clarify this case.
Signed-off-by: Larry Finger
---
Kalle,
Is this
To: kv...@codeaurora.org
Cc: linux-wirel...@vger.kernel.org
de...@driverdev.osuosl.org
Several of the rtlwifi-driver family have errors in the handling of
module parameters. These 8 patches for the -next repo contain fixes.
Signed-off-by: Larry Finger
Larry Finger (8):
rtlwifi: rtl8723be
: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
index d091f1d..a78eaed 100644
--- a
The module parameter for software encryption was never transferred to
the location used by the driver.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi
This driver fails to copy the module parameter for software encryption
to the locations used by the main code.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek
Two of the module parameter descriptions show incorrect default values.
In addition the value for software encryption is not transferred to
the locations used by the driver.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c | 6 --
1 file
to the module named and description macros.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c
b/drivers/net/wireless/realtek/rtlwifi
In this driver, parameters disable_watchdog and sw_crypto are never
copied into the locations used in the main code. While modifying the
parameter handling, the copying of parameter msi_support is moved to
be with the rest.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless
Two of the module parameters are listed with incorrect default values.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
b
of the parameters.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae
reported on the linix-wireless mailing list and also at
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/ as
bug #1527603 (kernel crashes due to rtl8192ee driver on ubuntu 15.10).
Fixes: 38506ecefab9
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi
Shi
Signed-off-by: Larry Finger
Cc: Yong Shi
---
drivers/staging/rtl8192u/r8192U_core.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index f4a4eae..87093c0 100644
--- a
On 01/05/2016 09:53 AM, Jes Sorensen wrote:
Julian Calaby writes:
Hi Sven,
On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote:
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
index 1662c03c..57f5941 100644
--- a/drivers/staging/rtl872
On 03/09/2016 03:54 PM, Claudiu Beznea wrote:
This patch tries to improve a part of the code from
rtl8712_led.c by removing duplicates condition checks.
Signed-off-by: Claudiu Beznea
---
drivers/staging/rtl8712/rtl8712_led.c | 31 +++
1 file changed, 15 insertions
Smatch lists the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c:243
rtl92c_dm_false_alarm_counter_statistics() warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek
101 - 200 of 621 matches
Mail list logo
