On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
>
> Signed-off-by: Joe Perches
Reviewed-by: Kieran Bingham
> ---
> drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git
Hi Dan, Greg,
On 17/09/2020 10:47, Dan Scally wrote:
> Hi Greg - thanks for the comments, appreciate it (sorry there's so many,
> I'm new to both C and kernel work)
>
> On 17/09/2020 08:53, Greg KH wrote:
>> On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote:
>>> MAINTAINERS
Hi Andy,
On 17/09/2020 15:08, Andy Shevchenko wrote:
> On Thu, Sep 17, 2020 at 4:31 PM Kieran Bingham
> wrote:
>> On 17/09/2020 10:47, Dan Scally wrote:
>>> On 17/09/2020 08:53, Greg KH wrote:
>>>> On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote
Hi Kai-Heng,
On 27/01/2019 05:56, Kai-Heng Feng wrote:
> Hi,
>
> We have a bug report [1] that the ipu3 doesn’t work.
> Does ipu3 need special userspace to work?
Yes, it will need further userspace support to configure the pipeline,
and to provide 3A algorithms for white balance, focus, and expo
copy/paste error perhaps and is
locking the wrong video.
> Signed-off-by: Julia Lawall
Reviewed-by: Kieran Bingham
> ---
> drivers/staging/media/davinci_vpfe/dm365_resizer.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media
s is a good option ;-)
Reviewed-by: Kieran Bingham
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 24
> drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/i2c/adv
Hi Alex,
On 02/04/2020 19:34, Alex Riesen wrote:
> To follow the established practice of not depending on others to
> pull everything in. While at it, make sure it stays like this.
Good call!
Small extra trivial comment below...
Reviewed-by: Kieran Bingham
> Signed-off-by: Alexand
driver to
regmap :-) (although looking at the history I think that was
pre-submission of the driver, so it's all a long time ago anyway).
This also should prevent the issues we solved in 0d962e061a (media: i2c:
adv748x: Fix unsafe macros), so I think it's still a good move.
Reviewed
Hi Alex,
On 02/04/2020 19:34, Alex Riesen wrote:
> Signed-off-by: Alexander Riesen
> ---
> drivers/media/i2c/adv748x/adv748x.h | 32 +
> 1 file changed, 32 insertions(+)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x.h
> b/drivers/media/i2c/adv748x/adv748x.h
> i
Hi Alex,
With all the changes you've described below:
Reviewed-by: Kieran Bingham
On 07/04/2020 18:13, Alex Riesen wrote:
> Hi Kieran,
>
> Kieran Bingham, Tue, Apr 07, 2020 18:21:00 +0200:
>> On 02/04/2020 19:34, Alex Riesen wrote:
>>> diff --git a/drivers/media
+ if (!state->endpoints[ADV748X_PORT_I2S]) {
> + adv_info(state, "no I2S port, DAI disabled\n");
> + ret = 0;
> + goto fail;
How about just 'return 0'?
> + }
And a blank line here ...
Otherwise,
Reviewed-by: Ki
if (ret)
> + goto fail;
With no action required to cleanup here, I would just
return ret;
and remove the fail: label.
Newline...
> + ret = clk_prepare_enable(mclk_of(state));
> + if (ret)
> + goto fail_pwdn;
newline...
> + return 0;
new
Hi Alex,
On 02/04/2020 19:35, Alex Riesen wrote:
> As the driver has some support for the audio interface of the device,
> the bindings file should mention it.
>
> Signed-off-by: Alexander Riesen
> Reviewed-by: Rob Herring
> Reviewed-by: Laurent Pinchart
Reviewed-
2 /* HDMI1 */
> + &rsnd_port3>; /* adv7482 hdmi-in */
Ah - that was confusing at first... but HDMI0 and HDMI1 are *outputs*,
where of course the adv7482 is an input ;-)
Otherwise, I can't spot anything else yet so:
Reviewed-by: Kieran Bingham
But I fear there
Hi Alex,
On 18/06/2020 17:32, Kieran Bingham wrote:
> Hi Alex,
>
> On 02/04/2020 19:35, Alex Riesen wrote:
>> As all known variants of the Salvator board have the HDMI decoder
>> chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482
>> endpoint and the
15 matches
Mail list logo
