Since the function brw_inject_one_error() is used only within
brw_test.c, make it static. This was reported as a warning by sparse.
Signed-off-by: Karthik Nayak
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
/drivers//ni_pcimio.c:1229:32:got unsigned int
This is done by introducing a temporary variable which is of type
'__be32' and converting the existing variable to type 'unsigned int'.
Signed-off-by: Karthik Nayak
---
drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
dr
Hello,
On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote:
> On 07/02/17 19:06, Karthik Nayak wrote:
>>
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect
>> type in assignment (different base types
Hi,
On Wed, Feb 8, 2017 at 7:18 PM, Ian Abbott wrote:
> On 08/02/17 13:26, Karthik Nayak wrote:
>>
>> Hello,
>>
>> On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote:
>>>
>>> On 07/02/17 19:06, Karthik Nayak wrote:
>>>>
>>>>
&
Drop the 'serial_number' variable from the struct 'ni_private' since
its never used after assignment.
Signed-off-by: Karthik Nayak
---
This is to be based on top of "staging: comedi: Fix incorrect type assignment"
to which this is replied to.
drivers/staging/
Hey,
On Wed, Feb 8, 2017 at 11:10 PM, Ian Abbott wrote:
> On 08/02/2017 16:55, Karthik Nayak wrote:
>>
>> Drop the 'serial_number' variable from the struct 'ni_private' since
>> its never used after assignment.
>>
>> Signed-off-by: Kart
atch, thanks :)
>
Sorry for the multiple messages, now that we're deleting the whole
block, I think it makes sense to
squash the commits, so I'll send one single patch.
--
Regards,
Karthik Nayak
___
devel mailing list
de...@linuxdriverproje
/drivers//ni_pcimio.c:1229:32:got unsigned int
This is done by removing the whole code block, since the variable
'serial_number' is only assigned but never used.
Helped-by: Ian Abbott
Signed-off-by: Karthik Nayak
---
drivers/staging/comedi/drivers/ni_pcimio.c | 9 -
drivers/stag
Hello,
On Thu, Feb 9, 2017 at 4:34 PM, Greg KH wrote:
> On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type
>> in assignment
ning: incorrect type in
assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted
__be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:got unsigned int
Signed-off-by: Karthik Nayak
---
drivers/staging/comedi
Removes the 'out of memory' warning issues by checkpatch
Signed-off-by: Karthik Nayak
---
drivers/staging/et131x/et131x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0..f1a9296 100644
--- a/drive
1. WARNING: else is not generally useful after a break or return
2. WARNING: quoted string split across lines
3. WARNING: break quoted strings at a space character
Signed-off-by: Karthik Nayak
---
drivers/staging/bcm/InterfaceIdleMode.c | 11 +--
1 file changed, 5 insertions(+), 6
Oops, i sent the old commit again, sorry!
Regards,
Karthik Nayak
On Tue, Sep 30, 2014 at 11:10 PM, Fabio Estevam wrote:
> On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak wrote:
>> Removes the 'out of memory' warning issues by checkpatch
>>
>> Signed-off-by: Ka
Removes the 'out of memory' warning issued by checkpatch
Signed-off-by: Karthik Nayak
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0..f92cceb 10
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.
Signed-off-by: Karthik Nayak
---
drivers/staging/bcm/InterfaceMisc.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b
15 matches
Mail list logo