Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: > On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: > > FMODE_EXEC is type fmode_t but is used in operations > > with integers which leads to sparse warnings: > > drivers/staging/lustre/lustre/mdc/mdc_

[PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

integer Fix by using __FMODE_EXEC macro defined in fs.h. Note the same warnings occurs with other fmode flags here but they don't have a corresponding int macro. Signed-off-by: Juston Li --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4 ++-- drivers/staging/lustre/lustre/mdc/mdc_locks.

[PATCH v2] staging: lustre: mdc: use __FMODE_EXEC macro

integer Fix by using __FMODE_EXEC macro defined in fs.h. Note the same warnings occurs with other fmode flags here but they don't have a corresponding int macro. Changes since v1: remove ifdefs. FMODE_EXEC and __FMODE_EXEC should always be defined in fs.h Signed-off-by: Juston Li --- dr

[PATCH] staging: rtl8723au: fix sparse warning

change cast to __le16 to fix the following warning: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16 Signed-off-by: Juston Li --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] staging: sm750fb: fix c99 comments

d up later. Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 11 ++-- drivers/staging/sm750fb/ddk750_dvi.c| 4 +-- drivers/staging/sm750fb/ddk750_help.c | 2 -- drivers/staging/sm750fb/ddk750_sii164.c | 11 drivers/staging/sm750fb/sm750.h | 10 +++---

Re: [PATCH] staging: sm750fb: fix c99 comments

> Does the code compile? I'm worried that the above line will produce > error as the comment block is not properly closed. > > - konrad Good catch, can't believe I missed that. I'll fix, actually test compile this time and resend. Regards Juston

[PATCH v2] staging: sm750fb: fix c99 comments

d up later. Changes since v1: close a comment block Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 11 ++-- drivers/staging/sm750fb/ddk750_dvi.c| 4 +-- drivers/staging/sm750fb/ddk750_help.c | 2 -- drivers/staging/sm750fb/ddk750_sii164.c | 11 drive

[PATCH] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl warning 'WARNING: please, no spaces at the start of a line' checkpatch doesn't catch comments indented by spaces but I fixed comments adjacent to warnings as well so they would remain aligned. Signed-of

[PATCH v2] staging: sm750fb: use tabs for indentation

ix alignment in ddk750_display.c:154 didn't remove a space in ddk750_hwi2c.c:48 Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 96 drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_dvi.c | 66 ++--- drivers/staging/s

Re: [PATCH v2] staging: sm750fb: use tabs for indentation

On Fri, Jun 19, 2015 at 10:21 PM, Greg KH wrote: > > On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote: > > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > > 'WARNING: please, no spaces at the start of a line' > > > > ch

[PATCH v3] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl warning 'WARNING: please, no spaces at the start of a line' checkpatch doesn't catch comments indented by spaces but I fixed comments adjacent to warnings as well so they would remain aligned. Signed-off-by: Juston

Re: [PATCH] Staging: sm750fb: Fix C99 Comments

ve already been added in the staging-next tree included in commit 'staging: sm750fb: fix c99 comments' You should base future changes against gregkh staging-testing branch. Regards Juston ___ devel mailing list de

Re: [PATCH v3] staging: sm750fb: use tabs for indentation

On Sat, Jun 20, 2015 at 12:43 AM, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote: >> Replace spaces with tabs for indentation to fix the checkpatch.pl warning >> 'WARNING: please, no spaces at the start of a line' >> >&

[PATCH 0/4] staging: sm750fb: checkpatch.pl fixes

This patch set includes 4 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - drivers/staging/sm750fb/ddk750_chip.c| 15 +-- drivers/staging/sm750fb/ddk750_chip.h| 12

[PATCH 3/4] staging: sm750fb: fix brace placement

Fix brace placement errors and warnings caught by checkpatch.pl ERROR: that open brace { should be on the previous line WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 ++ drivers/staging/sm750fb

[PATCH 2/4] staging: sm750fb: fix spacing issues

wline Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 14 ++-- drivers/staging/sm750fb/ddk750_display.c | 22 +++--- drivers/staging/sm750fb/ddk750_display.h | 6 +- drivers/staging/sm750fb/ddk750_dvi.c | 4 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- dri

[PATCH 4/4] staging: sm750fb: add missing blank line after declarations

fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3

[PATCH 1/4] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb

Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation

My apologies, I thought I removed all of those. Fixed for real this time, resending. Regards Juston On Sat, Jun 20, 2015 at 3:45 AM, Sudip Mukherjee wrote: > On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote: >> Replace spaces with tabs for indentation to fix the checkpatch

Re: [PATCH] staging: sm750fb: use tabs for indentation

On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter wrote: > On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote: >> void sii164ClearInterrupt(void) >> { >> -unsigned char detectReg; >> + unsigned char detectReg; >> >> -/* Clear the MDI inte

[PATCH v3 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v2: * Fix Subject * Don't rearrange lines in PATCH 01 * Split up spacing fixes pat

[PATCH v3 02/19] staging: sm750fb: remove spacing after open parenthesis

fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 drivers/stagi

[PATCH v3 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb

[PATCH v3 05/19] staging: sm750fb: remove space between function name and parenthesis

fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c

[PATCH v3 04/19] staging: sm750fb: add space before open parenthesis

fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 20 +-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- drivers/stagi

[PATCH v3 03/19] staging: sm750fb: remove space before close parenthesis

fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3 insert

[PATCH v3 07/19] staging: sm750fb: add space after close brace

fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750

[PATCH v3 06/19] staging: sm750fb: add space before open brace

fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 14 drivers/staging/sm750fb/ddk750_mode.c| 8 ++--- drivers/staging/sm750fb/ddk750_power.c | 4 +-- drivers/stagi

[PATCH v3 17/19] staging: sm750fb: move while statement to follow do close brace

fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/stagi

[PATCH v3 10/19] staging: sm750fb: add space after return type

fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 124921e

[PATCH v3 08/19] staging: sm750fb: add space after enum definition

fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

fixes checkpatch.pl error: ERROR: need consistent spacing around '' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c

[PATCH v3 18/19] staging: sm750fb: remove unnecessary braces

fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a

[PATCH v3 15/19] staging: sm750fb: remove unnecessary whitespace

fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v3 13/19] staging: sm750fb: add space after semicolon

fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v3 12/19] staging: sm750fb: add spaces around operators

fixes checkpath.pl error: ERROR: spaces required around that '' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-

[PATCH v3 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 54 ++-- drivers/staging/sm750fb

[PATCH v3 14/19] staging: sm750fb: remove trailing whitespace

fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/staging/sm750fb/sm750_hw.c| 24 3 files changed, 15 insertions(+), 15 deletions

[PATCH v3 09/19] staging: sm750fb: add space after struct definition

fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v3 19/19] staging: sm750fb: add missing blank line after declarations

fixes checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3

Re: [PATCH] staging: sm750fb: use tabs for indentation

On Wed, Jun 24, 2015 at 2:28 AM, Dan Carpenter wrote: > Have you sent this patchset to the list? I don't see it in my inbox. > > regards, > dan carpenter Odd, I sent it on Saturday. Anyways made a change to it and just sent in v

Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote: >> Fix brace placement errors caught by checkpatch.pl >> ERROR: that open brace { should be on the previous line >> >> Signed-off-by: Juston Li &g

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: >> fixes checkpatch.pl error: >> ERROR: need consistent spacing around '' > little bit confused. > 1) Your subject says consistent space ar

Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

#x27;ll change it, thanks. Patchset was responded by Greg's patch bot, I'll resend when I figure out why. Regards Juston ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

d if you use this checkpatch you will see these warnings > also. :) Thanks for the tip, I'll use the latest checkpatch and fix the warnings. Your help has been much appreciated Regards Juston ___ devel mailing list de...@linuxdr

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

ace preferred before that '|' (ctx:VxE) Are these the warnings you are referring too? Do you want me to fix all of these for this patch? Regards Juston ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v4 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v3: * Fix comment placement 16/19 * Rebase to current staging-testing Changes since v2

[PATCH v4 02/19] staging: sm750fb: remove spacing after open parenthesis

Fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 3 files changed, 8

[PATCH v4 05/19] staging: sm750fb: remove space between function name and parenthesis

Fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c

[PATCH v4 03/19] staging: sm750fb: remove space before close parenthesis

Fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3 insert

[PATCH v4 04/19] staging: sm750fb: add space before open parenthesis

Fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 20 +-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- drivers/stagi

[PATCH v4 07/19] staging: sm750fb: add space after close brace

Fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750

[PATCH v4 09/19] staging: sm750fb: add space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v4 11/19] staging: sm750fb: consistent spacing around operators

Fixes checkpatch.pl error: ERROR: need consistent spacing around operator Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c

[PATCH v4 08/19] staging: sm750fb: add space after enum definition

Fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v4 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb

[PATCH v4 13/19] staging: sm750fb: add space after semicolon

Fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v4 12/19] staging: sm750fb: add spaces around operators

Fixes checkpath.pl error: ERROR: spaces required around that operator Note running checkpatch.pl with '--strict' catches more of these errors along with cases where spacing is optional but preferred. Take care of these in a future patch. Signed-off-by: Juston Li --- drivers/stagi

[PATCH v4 14/19] staging: sm750fb: remove trailing whitespace

Fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/staging/sm750fb/sm750_hw.c| 24 3 files changed, 15 insertions(+), 15 deletions

[PATCH v4 15/19] staging: sm750fb: remove unnecessary whitespace

Fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v4 17/19] staging: sm750fb: move while to follow do close brace

Fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/stagi

[PATCH v4 10/19] staging: sm750fb: add space after return type

Fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 9989ff6

[PATCH v4 18/19] staging: sm750fb: remove unnecessary braces

Fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a

[PATCH v4 06/19] staging: sm750fb: add space before open brace

Fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 14 drivers/staging/sm750fb/ddk750_mode.c| 8 ++--- drivers/staging/sm750fb/ddk750_power.c | 4 +-- drivers/stagi

[PATCH v4 19/19] staging: sm750fb: add missing blank line after declarations

Fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3

[PATCH v4 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 56 ++-- drivers/staging/sm750fb

[PATCH v5 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v4: * Rebase to current staging-testing Changes since v3: * Fix comment placement 16/19

[PATCH v5 02/19] staging: sm750fb: remove spacing after open parenthesis

Fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 3 files changed, 8

[PATCH v5 04/19] staging: sm750fb: add space before open parenthesis

Fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 20 ++-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- drive

[PATCH v5 08/19] staging: sm750fb: add space after enum definition

Fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v5 03/19] staging: sm750fb: remove space before close parenthesis

Fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3 insert

[PATCH v5 06/19] staging: sm750fb: add space before open brace

Fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 14 +++--- drivers/staging/sm750fb/ddk750_mode.c| 8 drivers/staging/sm750fb/ddk750_power.c | 4 ++-- drive

[PATCH v5 05/19] staging: sm750fb: remove space between function name and parenthesis

Fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c

[PATCH v5 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb

[PATCH v5 09/19] staging: sm750fb: add space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v5 07/19] staging: sm750fb: add space after close brace

Fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750

[PATCH v5 10/19] staging: sm750fb: add space after return type

Fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 9989ff6

[PATCH v5 13/19] staging: sm750fb: add space after semicolon

Fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v5 11/19] staging: sm750fb: consistent spacing around operators

Fixes checkpatch.pl error: ERROR: need consistent spacing around operator Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- 3 files changed, 5 insertions(+), 5

[PATCH v5 15/19] staging: sm750fb: remove unnecessary whitespace

Fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH v5 12/19] staging: sm750fb: add spaces around operators

Fixes checkpath.pl error: ERROR: spaces required around that operator Note running checkpatch.pl with '--strict' catches more of these errors along with cases where spacing is optional but preferred. Take care of these in a future patch. Signed-off-by: Juston Li --- drivers/stagi

[PATCH v5 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 56 ++-- drivers/staging/sm750fb

[PATCH v5 19/19] staging: sm750fb: add missing blank line after declarations

Fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3

[PATCH v5 18/19] staging: sm750fb: remove unnecessary braces

Fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a

[PATCH v5 14/19] staging: sm750fb: remove trailing whitespace

Fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging

[PATCH v5 17/19] staging: sm750fb: move while to follow do close brace

Fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/stagi

[PATCH] staging: lustre: lmv: lmv_internal.h: fix checkpatch.pl spacing errors

lmv_internal.h:96: ERROR: space prohibited after that open parenthesis '(' lmv_internal.h:96: ERROR: space required before the open parenthesis '(' lmv_internal.h:147: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston L

[PATCH] staging/lustre: use __noreturn for lbug_with_loc

s Use the __noreturn macro instead of __attribute__((noreturn)) The macro is exactly that but its usage seems more common and it is bit more readable. Signed-off-by: Juston Li --- drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +- drivers/staging/lustre/lustre/libcfs/linux/lin