Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

ple (CC'd) may have been working on / had an interest in writing such a driver. I'm not sure what the status of that effort is though. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ __

Re: [PATCH 0/20] fix misspelling of current function in string

there be any value in doing this for _all_ cases where the function name is written in a format string? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___ devel mailin

Re: [PATCH 0/20] fix misspelling of current function in string

Hi Julia, On Mon, Dec 8, 2014 at 5:43 PM, Julia Lawall wrote: > On Mon, 8 Dec 2014, Julian Calaby wrote: > >> Hi Julia, >> >> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: >> > These patches replace what appears to be a reference to the name of the >&g

Re: [PATCH V2] staging: wilc1000: drop explicit conversion to bool

ing/wilc1000/wilc_wlan.c > @@ -11,7 +11,7 @@ > > static inline bool is_wilc1000(u32 id) > { > - return ((id & 0xf000) == 0x10 ? true : false); > + return ((id & 0xf000) == 0x100000); Whilst you're here, you might as well remove the superfluous p

Re: [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis

Hi All, On Fri, Mar 3, 2017 at 4:05 AM, Georgios Emmanouil wrote: > Fixed alignment to match parenthesis. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style

s Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_spi.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ _

Re: [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error

Hi All, On Fri, Mar 3, 2017 at 4:06 AM, Georgios Emmanouil wrote: > Fixed spelling error. 'unkmown' to 'unknown'. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_spi.c | 8 > 1 file

Re: [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style

Hi All, On Fri, Mar 3, 2017 at 4:07 AM, Georgios Emmanouil wrote: > Added blank line after function and modified comment style. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_spi.c | 7 ++- > 1 file changed,

Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

Hi All, On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil wrote: > Modified the 'if-else' statement to make it more readable. > > Signed-off-by: Georgios Emmanouil Again, I'm dubious if this is needed or helpful, but Reviewed-by: Julian Calaby > --- > drivers

Re: [PATCH] Staging:wilc1000:wilc_sdio: Modified comment style to preferred kernel comment style

Hi All, On Fri, Mar 3, 2017 at 3:41 AM, Georgios Emmanouil wrote: > Modified comment style to preferred kernel comment style. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_sdio.c | 13 + > 1 file cha

Re: [PATCH 1/3] Staging:wilc1000:host_interface: Removed unnecessary blank line

Hi All, On Fri, Mar 3, 2017 at 2:35 AM, Georgios Emmanouil wrote: > Removed unnecessary blank line. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/host_interface.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis

Hi All, On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil wrote: > Fixed alignment to match open parenthesis. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/host_interface.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement

Hi All, On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil wrote: > Removed unnecessary 'if' statement and integrated the condition to the > previous 'if' statement. > > Signed-off-by: Georgios Emmanouil Reviewed-by: Julian Calaby > --- > drivers/

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

return -1; > @@ -327,7 +303,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff > *skb, int hdr_len, void *priv) > tkey->tx_iv32); > tkey->tx_phase1_done = 1; > } > -tkip_mixing_phase2(rc

Re: [PATCH 1/4] staging: wilc1000: use runtime configuration for sdio oob interrupt

tree and detect it based on that? I'm pretty sure that the Broadcom fmac driver does something like this. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___ d

Re: [linux-sunxi] [PATCH 21/23] staging: mt29f_spinand: switch to mtd_ooblayout_ops

NGE; > + > + return ((eccbyte / 6) * 16) + 1; Are you sure this is correct? My reading of this is that we'd get 1 for eccbytes 0 through 5. Would ((eccbyte / 6) * 16) + (eccbyte % 6) + 1 be more correct? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

gt; - } else { > - return 0; > - } > - This isn't equivalent code as both arms of the if statement eventually call return 0. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wilc1000: remove wilc_sdio_init

Hi Glen, On Thu, Dec 24, 2015 at 2:06 PM, glen lee wrote: > > > On 2015년 12월 24일 11:39, Julian Calaby wrote: >> >> Hi Glen, >> >> On Wed, Dec 23, 2015 at 1:33 PM, Glen Lee wrote: >>> >>> wilc_sdio_init return always 1. It is needless, so

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

rsion into the function call following these lines so that they remain "clean". That said, I'm not sure this particular snippet of code would work on big-endian at all as I'm pretty sure that BIT() produces cpu-endian values and we know from the line you remove that h2c

Re: [PATCH 09/26] staging: wilc1000: use unified firmware

-DP2P_CONCURRENCY_FIRMWARE=\"atmel/wilc1000_p2p_fw.bin\" > +ccflags-y += -DFIRMWARE_1002=\"atmel/wilc1002_firmware.bin\" \ > + -DFIRMWARE_1003=\"atmel/wilc1003_firmware.bin\" You can probably put these defines in a header somewhere instead of here. Also

Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

ion? Or should we ignore this as this driver will eventually be going away? Thanks, Julian Calaby > --- > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > b

Re: [PATCH] Staging: rtl8723au: Remove unused functions

oks right to me. Reviewed-by: Julian Calaby > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 10 -- > drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 2 -- > 2 files changed, 12 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c &

Re: [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head}

mika Goyal Looks right to me. Reviewed-by: Julian Calaby > --- > drivers/staging/rtl8723au/core/rtw_recv.c| 25 - > drivers/staging/rtl8723au/include/rtw_recv.h | 2 -- > 2 files changed, 27 deletions(-) > > diff --git a/drivers/staging/rtl8723au/

Re: [PATCH] staging: wilc1000: rework comments in wilc_sdio.c

a signed-off-by line here. > --- > drivers/staging/wilc1000/wilc_sdio.c | 136 > --- > 1 file changed, 31 insertions(+), 105 deletions(-) > Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.goo

Re: Move wlan-ng out of staging?

ible. > > And uses wireless extensions, yuck. There's a lot of work to get it into > reasonable shape, fixing checkpatch warnings will not be enough. On the same subject, the wilc1000 driver has taken some pretty big steps in the past few days, how far away do you think it is from gr

Re: Move wlan-ng out of staging?

Hi Greg, On Thu, Jan 28, 2016 at 10:07 AM, Greg KH wrote: > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote: >> Hi Glen, >> >> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo wrote: >> > Dan Carpenter writes: >> > >> >> On Mon, J

Re: [PATCH 08/12] staging: wilc1000: rename variable s32Error

kfree(pstrConnectRespInfo->pu8RespIEs); > pstrConnectRespInfo->pu8RespIEs = NULL; > } else { > - s32Error = -EFAULT; > + result = -EFAULT; > } > > kfre

Re: Move wlan-ng out of staging?

Hi Greg, On Thu, Jan 28, 2016 at 10:32 AM, Greg KH wrote: > On Thu, Jan 28, 2016 at 10:28:38AM +1100, Julian Calaby wrote: >> Hi Greg, >> >> On Thu, Jan 28, 2016 at 10:07 AM, Greg KH wrote: >> > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote: >

Re: [PATCH 08/12] staging: wilc1000: rename variable s32Error

en more clear, these were ideas for the next round of changes, not changes you should make to this patch. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___ devel mailing list de

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

kpatch should have picked this up, you did run the patch through checkpatch before you sent it, right? Jes, I know you have strong feelings on coding style, but there are a lot of people out there who see deviations from the standard as bugs to be fixed, so stuff like this isn't going to stop unti

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Hi Joe, On Sat, Jan 30, 2016 at 12:28 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: >> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen >> wrote: >> > Bhaktipriya Shridhar writes: >> > > This patch fixes checkpat

Re: [PATCH v2] staging: rtl8723au: Fixes unnecessary return warning

On Sat, Jan 30, 2016 at 4:57 PM, Bhaktipriya Shridhar wrote: > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > WARNING: void function return statements are not generally useful > > Signed-off-by: Bhaktipriya Shridhar Looks sane to me. Reviewed-by: J

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

\n. 6. Report the middle line the preceding regular expression matches to the user. I'm confident I can write it as a shell script, but I don't know enough Perl to add that test to checkpatch.pl Thanks, -- Julian Calaby Email: julian.cal...@g

Re: [PATCH 02/26] staging: wilc1000: removes function 'wilc_dealloc_assoc_resp_info()'

e work! Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/coreconfigurator.c | 22 -- > drivers/staging/wilc1000/coreconfigurator.h | 1 - > drivers/staging/wilc1000/host_interface.c | 4 ++-- > 3 files changed, 2 insertions(+), 25 deletions(

Re: [PATCH 01/26] staging: wilc1000: removes function 'wilc_dealloc_network_info()'

Nice work! Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/coreconfigurator.c | 22 -- > drivers/staging/wilc1000/coreconfigurator.h | 1 - > drivers/staging/wilc1000/host_interface.c | 4 ++-- > 3 files changed, 2 insertions(+), 25 delet

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

_entry*() calls You need to either specify all of these in the changelog or split it up into multiple patches. Thanks, Julian Calaby > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding style fixing in v

Re: [PATCH V2 18/24] staging: wilc1000: linux_wlan.c: removes unnecessary log messages

uct net_device *dev) > > void wilc_dbg(u8 *buff) > { > - PRINT_D(INIT_DBG, "%d\n", *buff); > } Are you sure this is right? If so, why not just remove this function entirely? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/prof

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

return -ENOBUFS; > + return PTR_ERR(wilc->txq_thread); Are you sure changing the error returned is correct? Do all the callers of wlan_initialize_threads() handle the full range of errors from kthread_run()? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir, On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: > Hi Julian, > > On 10.03.2016 01:27, Julian Calaby wrote: >> Hi Vladimir, >> >> On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy wrote: >>> The kthread_run() function returns eithe

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Vladimir, On Thu, Mar 10, 2016 at 11:02 AM, Vladimir Zapolskiy wrote: > Hi Julian, > > On 10.03.2016 01:42, Julian Calaby wrote: >> Hi Vladimir, >> >> On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy wrote: >>> Hi Julian, >>> >>> On 1

Re: [PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

> #define MAX_MAC_HDR_LEN 26 /* QOS_MAC_HDR_LEN */ > #define SUB_MSDU_HEADER_LENGTH 14 > +#ifdef CONFIG_64BIT > +#define SNAP_HDR_LEN12 > +#else > #define SNAP_HDR_LEN8 > +#endif > #define ETHERNET_HDR_LEN 14 > #define WORD_AL

Re: Clarification for the use of additional fields in the message body

ot;improve" on the system are unnecessary and annoying people. The instructions there are the recommended way to do things for a reason. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Clarification for the use of additional fields in the message body

the data structure "author" by design > in this content management system? The information stored for a commit is: = = = = = = tree 09496defc9eb793c665a7b80aa22f24c7bd5f204 parent 63c07589832bfe5ec49f2523ddb0e94a20af0f31 author Julian Calaby 1435196810 +1000 committer Julian Calaby 1436322

Re: Clarification for the use of additional fields in the message body

functionality from the Git software. Git was originally written to manage the Linux kernel. This feature was probably added by either Linus himself or one of the original developers who I believe were kernel developers. The patch submission process has been around for a long time, if this featu

Re: Clarification for the use of additional fields in the message body

could insert a patch at any point in the history of Linux in my own repository, however any attempt to push that upstream would cause enormous amounts of pain and annoyance, to everyone who attempted to deal with it, so I don't. Thanks, -- Julian Calaby Email: julian.cal..

Re: [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

g_frame_in_use = 1; > > /*Edited by Amr - BugID_4720*/ > - if (wilc_wlan_cfg_commit(WILC_CFG_QUERY, drvHandler)) > + if (wilc_wlan_cfg_commit(WILC_CFG_QUERY, (tstrWILC_WFIDrv > *)drvHandler)) Ditto. Thanks, -- Julian Calaby Email: j

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

(counter == > u32WIDsCount - 1), drvHandler)) { > + (counter == > u32WIDsCount - 1), (void *)drvHandler)) { If I recall correctly, you shouldn't need void * casts. Thanks, -- Ju

Re: [PATCH 3/3] staging: wilc1000: wilc_wlan_cfg_set(): replace integer with void pointer

> pstrWIDs[counter].s32ValueSize, > - (counter == > u32WIDsCount - 1), drvHandler)) { > + (counter == > u32WIDsCount - 1), (void *)drvHandler)) { Ag

Re: [PATCH 4/5] staging: wilc1000: SendConfigPkt(): replace integer with void pointer

is defined, the function can not refer to the structure type. > So this patch change the argument to void type pointer. Same comments again, why not move the structure definition? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/prof

Re: [PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

Hi Johnny, On Fri, Jul 10, 2015 at 5:58 PM, Johnny Kim wrote: > > On 2015년 07월 10일 15:20, Julian Calaby wrote: >> >> Hi Johnny, >> >> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: >>> >>> A argument of wilc_wlan_cfg_commit() is address of s

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

Hi Johnny, On Fri, Jul 10, 2015 at 6:11 PM, Johnny Kim wrote: > > On 2015년 07월 10일 15:25, Julian Calaby wrote: >> >> Hi Johnny, >> >> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote: >>> >>> Last argument of wilc_wlan_cfg_get function is actu

Re: [PATCH 1/2] staging: wilc1000: fix uninitialized variablie warning

} > WILC_memcpy(pstrSetBeaconParam->pu8Head, pu8Head, u32HeadLen); > pstrSetBeaconParam->u32TailLen = u32TailLen; > > @@ -7159,6 +7162,7 @@ s32 host_int_add_beacon(WILC_WFIDrvHandle hWFIDrv, u32 > u32Interval, > WILC_FREE(pstrSetB

Re: [PATCH 1/4] staging: wilc1000: use memset instead of WILC_memset

memset((void *)gps8ConfigPacket, 0, MAX_PACKET_BUFF_SIZE); I believe you can get rid of these void* casts, you're modifying the line anyway. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used

addr, 0, &pdvobjpriv->usb_buf.val32, >>> sizeof(data), >>> RTW_USB_CONTROL_MSG_TIMEOUT); >> >> Again, fix the formatting if you want to make this change. >> >> NACK >> >> Jes > > &

Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

f -1 is more > appropriate. These two changes could be argued to be separate changes deserving of their own patches. > Signed-off-by: Luis de Bethencourt However if everyone else is ok with that, this is: Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail

Re: [PATCH] staging: wilc1000: fix return value check in wlan_initialize_threads()

The return value of wlan_initialize_threads() is only checked to be non-zero, so this looks right to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ___

Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

Hi Luis, On Thu, Jun 23, 2016 at 9:25 PM, Luis de Bethencourt wrote: > On 23/06/16 02:29, Julian Calaby wrote: >> Hi All, >> >> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt >> wrote: >>> The common format to check if a function returned an error poin

Re: [PATCH] staging: wilc1000: arrays can't be NULL

a hit to the >> kernelnewbies mailing list :) > > Or not. > > really_long_identifiers™ makes using 80 columns silly. > > The hungarian could probably be converted though. The main developers of this driver are slowly working through the driver's style issues, which is part of the r

Re: [PATCH] staging: wilc1000: arrays can't be NULL

Hi Luis, On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt wrote: > On 24/06/16 00:15, Julian Calaby wrote: >> Hi Joe, >> >> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote: >>> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote: >>>

Re: [PATCH] staging: wilc1000: fix spelling mistake: "interupts" -> "interrupts"

Hi All, On Thu, Jun 23, 2016 at 11:14 PM, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dev_err messages > > Signed-off-by: Colin Ian King Looks right to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gm

Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection

pointer > for a valid data item. > > Improve this implementation detail by the introduction of another > jump label. > > Signed-off-by: Markus Elfring This is pointless micro-optimisation: kfree(NULL) is perfectly valid and buff is either malloc'd memory or NULL when it

Re: [PATCH] staging: wilc1000: fix spelling mistake: "retyring" -> "retrying"

Hi All, On Sun, Aug 28, 2016 at 9:28 PM, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http:/

Re: [PATCH 03/10] staging: wilc1000: rename s32Error in host_int_set_mac_chnl_num

result = -EINVAL; Why not just have return -EINVAL; here? > } > > - return s32Error; > + return result; and return 0; here? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ _

Re: [PATCH 08/10] staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle

&msg, sizeof(struct host_if_msg)); > + if (result) { > PRINT_ER("wilc mq send fail\n"); > - s32Error = -EINVAL; > + result = -EINVAL; Same comments here: Why not return -EINVAL; > } > > /* wait untill MSG Q

Re: [PATCH 3/3] staging: wilc1000: return error code direclty in host_int_wait_msg_queue_idle

PRINT_ER("wilc mq send fail\n"); > - result = -EINVAL; > + return -EINVAL; Returning here means that we don't call down: > } > > /* wait untill MSG Q is empty */ > down(&hWaitResponse); h

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

/// matched code has to be contiguous > /// > /// Blatantly cribbed from: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > @@ > type T, T2; > expression x; > expression E1,E2,E3; > statement S; > @@ > > - x = (T)pci_alloc_consistent(E1,E2,E3); > + x = pci_za

Re: [PATCH 5/5] staging: wilc1000: use id value as argument

tstrWILC_WFIDrv *)drvHandler; > + id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | > (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24)); Would be32_to_cpu() or something like that be able to help you do this?

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

32 result = 0; > > PRINT_D(CORECONFIG_DBG, "CoreConfiguratorDeInit()\n"); > > > - return s32Error; > + return result; Ditto. > } > > /*Using the global handle of the driver*/ > diff --git a/drivers/staging/wilc1000/host_interface.c > b