On 19/11/16 11:08, Christophe JAILLET wrote:
> Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and
> commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add
> some dereference of 'st' which is an un-initialized pointer at this point.
>
> Re-order code and tweak
On 27/11/16 08:37, Boyan Vladinov wrote:
> Fixes warnings found by checkpatch.pl:
> - AD7280A_DEVADDR macro to use typeof, because of possible side effects
Such as? I can't tell from this description whether this is a bug, or just
some good coding practice stuff.
> - sysfs entries user/group modes
On 26/11/16 22:39, Boyan Vladinov wrote:
> Fixes warnings found by checkpatch.pl:
> - sysfs entries user/group modes to use their octal representation
> - use the IIO_DEVICE_ATTR_[RO|RW] macroses
> - coding style
>
> Signed-off-by: Boyan Vladinov
Unfortunately this isn't quite as straight forward
On Thu, 29 Jun 2017 13:03:51 -0400
Brian Masney wrote:
> tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes
> that IIO_EV_INFO_VALUE is the only iio_event_info that will be
> passed in. This patch refactors these two functions so that
> additional iio_event_infos can be passed in
On Fri, 30 Jun 2017 11:21:14 -0400
Brian Masney wrote:
> On Thu, Jun 29, 2017 at 01:03:46PM -0400, Brian Masney wrote:
> > This begins my work to clean this driver up and eventually move it out
> > of staging. Driver changes were tested using a TSL2771 hooked up to a
> > Raspberry Pi 2.
> >
> >
On Sat, 1 Jul 2017 06:37:07 -0400
Brian Masney wrote:
> On Sat, Jul 01, 2017 at 10:40:20AM +0100, Jonathan Cameron wrote:
> > On Thu, 29 Jun 2017 13:03:51 -0400
> > Brian Masney wrote:
> >
> > > tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assume
On Thu, 6 Jul 2017 18:56:18 -0400
Brian Masney wrote:
> Add device tree support for the tsl2x7x IIO driver with no custom
> properties. The device tree documentation is in a separate commit so
> that the changes to trivial-devices.txt can go in via the device
> tree subsystem.
>
> Signed-off-by
On Thu, 6 Jul 2017 18:56:19 -0400
Brian Masney wrote:
> Add device tree documentation for the tsl2x7x IIO driver.
>
> Signed-off-by: Brian Masney
> CC: Rob Herring
> CC: Mark Rutland
> CC: devicet...@vger.kernel.org
For what it's worth given the simplicity of the pa
On Thu, 6 Jul 2017 18:56:20 -0400
Brian Masney wrote:
> The TSL2X7X driver has a custom power_state sysfs attribute. Remove this
> attribute since the runtime power management code provides a sysfs
> attribute to control the power state of the device.
>
> Signed-off-by: Brian Masney
Applied.
>
On Thu, 6 Jul 2017 18:56:21 -0400
Brian Masney wrote:
> tsl2x7x_i2c_read() would call i2c_smbus_write_byte() and
> i2c_smbus_read_byte(). These two i2c functions can be replaced with a
> single call to i2c_smbus_read_byte_data(). This patch removes the
> tsl2x7x_i2c_read() function and replaces
On Thu, 6 Jul 2017 18:56:22 -0400
Brian Masney wrote:
> The calibration function calls i2c_smbus_write_byte() and
> i2c_smbus_read_byte(). These two function calls are replaced with a
> single call to i2c_smbus_read_byte_data() by this patch. This patch
> also removes an unnecessary call that re
On Thu, 6 Jul 2017 18:56:23 -0400
Brian Masney wrote:
> tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes
> that IIO_EV_INFO_VALUE is the only iio_event_info that will be
> passed in. This patch refactors these two functions so that
> additional iio_event_infos can be passed in
On Thu, 6 Jul 2017 18:56:24 -0400
Brian Masney wrote:
> This driver in some cases can busy wait for upwards of 15ms. Since the
> kernel at this point is not running in atomic context, and is running in
> process context, we can safely use usleep_range() instead. This patch
> changes the two occu
On Thu, 6 Jul 2017 18:56:25 -0400
Brian Masney wrote:
> The driver explicitly creates the in_illuminance0_integration_time sysfs
> attribute outside the IIO core. This attribute is available in the IIO
> core so this patches migrates the attribute to be created by
> the iio_chan_spec.
>
> Signe
On Thu, 6 Jul 2017 18:56:26 -0400
Brian Masney wrote:
> The return value from tsl2x7x_invoke_change() was not checked in most
> places in the driver. This patch adds the proper error checks. The
> return values inside tsl2x7x_invoke_change() are now checked by
> this patch as well.
>
> Previous
On Wed, 12 Jul 2017 15:19:40 +0200
Christian Gromm wrote:
> On Wed, 12 Jul 2017 14:51:01 +0200
> Greg KH wrote:
>
> > On Wed, Jul 12, 2017 at 02:18:54PM +0200, Christian Gromm wrote:
> > >
> > > Hi,
> > >
> > > Microchip is planning to introduce a driver for a new companion
> > > chip serie
On Fri, 14 Jul 2017 12:33:02 +0200
Christian Gromm wrote:
> On 14.07.2017 11:40, Lars-Peter Clausen wrote:
> > On 07/14/2017 11:00 AM, Guenter Roeck wrote:
> >> On 07/14/2017 01:07 AM, Jonathan Cameron wrote:
> >>> On Wed, 12 Jul 2017 15:19:40 +020
On Fri, 14 Jul 2017 11:31:03 +0200
Arnd Bergmann wrote:
> gcc-7 points out an older regression:
>
> drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw':
> drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean
> context, did you mean '<' ? [-Werror=int-in-bo
On 18 July 2017 06:38:08 BST, Hari Prasath wrote:
>Fix checkpatch warning to add space around the substraction operation
>
>Signed-off-by: Hari Prasath
>---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/iio/adc/ad7
On Wed, 19 Jul 2017 17:55:56 +0530
Jaya Durga wrote:
> Replace symbolic permissions with their
> octect representation to fix checkpatch warnings.
>
> Signed-off-by: Jaya Durga
The IIO drivers in staging are handled via the iio
tree on git.kernel.org from which Greg pulls a few
times a cycle (w
On Wed, 19 Jul 2017 17:55:57 +0530
Jaya Durga wrote:
> CHECK: Macro argument reuse 'addr' - possible side-effects?
>
> convert AD7280A_DEVADDR to ad7280a_devaddr static function
> to fix checkpath check
>
> v3: small style changes
>
> Signed-off-by: Jaya Durga
This patch is fine so I've appl
On Wed, 9 Aug 2017 10:38:56 -0500
"Gustavo A. R. Silva" wrote:
> platform_get_irq() returns an error code, but the ad7606_par driver
> ignores it and always returns -ENODEV. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value
On Mon, 21 Aug 2017 13:11:03 +0300
Dan Carpenter wrote:
> The second part of this patch is probably the most interesting. We
> use "TSL2X7X_MAX_LUX_TABLE_SIZE * 3" as the limit instead of just
> "TSL2X7X_MAX_LUX_TABLE_SIZE". It creates a static checker warning that
> we are going of of bounds,
On Tue, 22 Aug 2017 10:51:37 +0530
Arvind Yadav wrote:
> Hi
>
>
> On Tuesday 22 August 2017 01:50 AM, Dan Carpenter wrote:
> > Don't say "[PATCH 4/4]". It's not a patchset or a part of an email
> > thread.
> Yes, It's part of these patchset.
>[PATCH 1/4] misc: apds9802als: constify i2c_d
On 8 September 2017 05:47:52 BST, Himanshi Jain wrote:
>Added space around(one on each side of) binary
>operator(-) as preferred according to kernel
>coding style.
>
>Signed-off-by: Himanshi Jain
Take a closer look at that macro. It isn't doing what you think... To give a
hint, changing this
On Fri, 8 Sep 2017 07:29:06 +0100
Jonathan Cameron wrote:
> On 8 September 2017 05:47:52 BST, Himanshi Jain
> wrote:
> >Added space around(one on each side of) binary
> >operator(-) as preferred according to kernel
> >coding style.
> >
> >Signed-off-by: Hima
On Fri, 8 Sep 2017 11:37:56 +0200
Lars-Peter Clausen wrote:
> On 09/08/2017 11:32 AM, Jonathan Cameron wrote:
> > On Fri, 8 Sep 2017 07:29:06 +0100
> > Jonathan Cameron wrote:
> >
> >> On 8 September 2017 05:47:52 BST, Himanshi Jain
> >> wrote:
&g
On 27/09/15 20:39, Shraddha Barke wrote:
>
>
> On Sun, 27 Sep 2015, Jonathan Cameron wrote:
>
>> On 26/09/15 18:14, Lars-Peter Clausen wrote:
>>> On 09/25/2015 07:23 PM, Shraddha Barke wrote:
>>>> Replace bit shifting on 1 with the BIT(x) macro
On 15/08/15 21:05, Jonathan Cameron wrote:
> On 08/08/15 20:16, Dan Carpenter wrote:
>> "num_read" is in byte units but we are write u16s so we end up write
>> twice as much as intended.
>>
>> Signed-off-by: Dan Carpenter
> Hi Dan,
>
> This is fin
On 04/10/15 17:30, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment blocks end with a */
> on a separate line, and start with a /* on an empty line.
>
> Signed-off-by: Hugo Camboulive
Thanks.
Applied to the togreg branch of iio.git - initially pushed out
as staging for the autom
On 19/10/15 09:16, Daniel Baluta wrote:
> On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann wrote:
>> The iio dummy code was recently changed to use irq_work_queue, but
>> that code is compiled into the kernel only if IRQ_WORK is set, so
>> we can get a link error here:
>>
>> drivers/built-in.o: In f
I'm looking for some Tested-by: or Acks on this before applying the series.
I got the impression from the comments on the previous version that the
series has now been reasonably thoroughly tested on both i.MX28 and i.MX23
boards.
This is not yet reflected in the sign off trail and in fact a coupl
On 10/01/13 10:28, Jürgen Beisert wrote:
> Hi Jonathan,
>
> On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
>> a couple of the patch descriptions say that they are untested on i.MX28.
>
> On Monday 23 September 2013 16:36:35 Juergen Beisert wrote:
>> For b
On 09/24/13 08:50, Jürgen Beisert wrote:
> Hi Fabio,
>
> On Monday 23 September 2013 17:13:03 Fabio Estevam wrote:
>> On 09/23/2013 11:36 AM, Juergen Beisert wrote:
>>> + lradc->clk = devm_clk_get(&pdev->dev, NULL);
>>> + clk_prepare_enable(lradc->clk);
>>
>> clk_prepare_enable() may fail, so
..@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dri
in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 61
> -
> 1 file changed
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 66
ad.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 204
> +
On 10/01/13 11:51, Jonathan Cameron wrote:
> On 10/01/13 10:28, Jürgen Beisert wrote:
>> Hi Jonathan,
>>
>> On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
>>> a couple of the patch descriptions say that they are untested on i.MX28.
>>
>> On
On 09/23/13 15:36, Juergen Beisert wrote:
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg bra
On 09/23/13 15:36, Juergen Beisert wrote:
> This is an RFC for the new touchscreen properties.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio
CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks.
Please check over the entire series as it was more than a little
fiddly to apply and I may well have messed it up!
Jonathan
> ---
> drivers/staging/iio/TODO | 11 +++
> 1 file changed, 11 ins
On 10/01/13 12:14, Jonathan Cameron wrote:
> On 09/23/13 15:36, Juergen Beisert wrote:
>> Some things have still to be done to the LRADC driver.
>>
>> Signed-off-by: Juergen Beisert
>> CC: linux-arm-ker...@lists.infradead.org
>> CC: linux-in...@vger.kernel.org
On 10/01/13 12:21, Jonathan Cameron wrote:
> On 10/01/13 12:14, Jonathan Cameron wrote:
>> On 09/23/13 15:36, Juergen Beisert wrote:
>>> Some things have still to be done to the LRADC driver.
>>>
>>> Signed-off-by: Juergen Beisert
>>> CC: linux-ar
On 10/11/13 00:07, Joe Perches wrote:
> These aren't necessary after switch, if and while statements.
>
> Also remove some unnecessary braces where these
> semicolons were removed around single statement
> and some unnecessary blank lines.
>
> Signed-off-by: Joe P
On 10/07/13 13:42, Sebastian Andrzej Siewior wrote:
> The `ret´ variable is only initialized in the error case. For some reason
> it was always != 0 while I played with generic_buffer so here is a patch.
>
> Signed-off-by: Sebastian Andrzej Siewior
Thanks,
Applied to the togreg branch of iio.git
On 10/23/13 20:14, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
>
> Signed-off-by: Joe Perches
Acked-by: Jonathan Cameron
(for iio driver)
> ---
> drivers/stagin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/01/13 05:35, NeilBrown wrote:
>
>
> No configuration, just a compatible string and documentation.
>
> Signed-off-by: NeilBrown
Looks fine to me and it's been a 3 weeks without any negative feedback so
applied to the togreg branch of iio.git.
On 12/06/13 19:31, Alexandre Belloni wrote:
> The mxs LRADC is able to read an internal die temperature sensor. The
> temperature has to be calculated from the value read on channel 8 and channel
> 9.
> To be able to expose the result to hwmon, implement iio channel 8 as
> (channel 9 - channel 8).
On 01/01/14 13:07, Julia Lawall wrote:
From: Julia Lawall
iio_kfifo_allocate returns NULL in case of error.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression *x;
identifier f;
statement S1,S2;
@@
*x = f(...);
if (x) { <+... when != i
On 14/01/14 15:45, Richard Weinberger wrote:
On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.
drivers/staging/iio/adc/spear_adc.c: In function ‘spear_adc_probe’:
drivers/staging/iio/adc/spear_adc.c:393:2: error: implicit declaratio
On 14/01/14 15:45, Richard Weinberger wrote:
On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.
drivers/built-in.o: In function `lpc32xx_adc_probe':
drivers/staging/iio/adc/lpc32xx_adc.c:149: undefined reference to `devm_ioremap'
On 28/04/14 17:00, Masanari Iida wrote:
Fix two format string mismatch in ad7280a.c
Signed-off-by: Masanari Iida
Applied to the togreg branch of iio.git
Note this will initially get pushed out as testing for
the autobuilders to play.
Thanks,
Jonathan
---
drivers/staging/iio/adc/ad7280a.c
On 02/06/14 18:05, Federico Di Pierro wrote:
Hi!
This is my latest task of the eudyptula challenge.
Just a very small patch! It fixes 3 little coding style problems.
I'm using linux-next.
Fair enough, but you need to spend a little time working
on the 'how' of your patch submission.
See Document
On 05/06/14 21:48, Arnd Bergmann wrote:
An obviously missing 'select' statement, without this we
get a link error
Signed-off-by: Arnd Bergmann
Cc: Jonathan Cameron
Cc: linux-...@vger.kernel.org
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
---
drivers/s
On 13/06/14 06:56, Jimmy Picard wrote:
This patch fixes coding style reported by checkpatch.pl that missing
a blank line after declarations.
Signed-off-by: Jimmy Picard
Hmm. This is in the trivial enough to be marginally annoying
category of basically noise. Normally I'd only take this as
par
On 09/04/14 19:09, Joel Porquet wrote:
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.
Signed-off-by: Joel Porquet
This line has been removed by another patch in the meantime.
---
Only tested by compilation.
drivers/staging/iio/trigger/iio-tr
On 20/06/14 20:22, Dan Carpenter wrote:
We should be returning a negative error code instead of success here.
This would have been detected by GCC, except that the "ret" variable was
initialized with a bogus value to disable GCC's uninitialized variable
warnings. I've cleaned that up, as well.
, 2014 at 9:35 PM, Belisko Marek wrote:
Hi Jonathan,
On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron wrote:
On 14/02/14 14:25, Marek Belisko wrote:
Signed-off-by: Marek Belisko
I wonder how this got missed. However, for those data elements to be
useful, you will
need to read them
On 29/06/14 10:41, Federico Di Pierro wrote:
Fix some little style issues in drivers/staging/iio/frequency/ad9832.c .
This is my latest task of the eudyptula challenge (third attempt!)
Signed-off-by: Federico Di Pierro
I'd have preferred more meaty work on this driver, but I guess every
little
On 20/08/14 10:32, Sanjeev Sharma wrote:
> This patch removes the .owner field for drivers which use the
> platform_driver_register api because this is overriden in
> _platform_driver_register.
>
> Signed-off-by: Sanjeev Sharma
Thanks for cleaning these up.
Applied to the togreg branch of iio.gi
On 29/08/14 15:26, Laurentiu Palcu wrote:
> isl29108 was used, instead of isl29018.
>
> Signed-off-by: Laurentiu Palcu
Applied to the togreg branch of iio.git - initially pushed out as testing for
the
autobuilders to play.
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 8
On 29/08/14 15:26, Laurentiu Palcu wrote:
> Intersil chips ISL29018, ISL29023 and ISL29035 are very similar. They're
> all ambience light sensors. The ISL29018, however, is also a proximity
> sensor. The registers are similar too:
>
> -+--+--
> AVAILABLE IN | ADDR REG |
On 29/08/14 15:26, Laurentiu Palcu wrote:
> Add support for enumerating the device through ACPI.
>
> Signed-off-by: Laurentiu Palcu
Mostly fine, but I'm unclear on why we have a cast to a char * for name.
Maybe I just haven't had enough coffee this morning :)
Jonathan
> ---
> drivers/staging/ii
On 31/08/14 07:57, Sören Brinkmann wrote:
> Fix the checkpatch complaint regarding unnecessary line continuation.
> WARNING: Avoid unnecessary line continuations
> #143: FILE: ad7606_core.c:143:
>
> Signed-off-by: Sören Brinkmann
Applied to the togreg branch of iio.git. Initially pushed out
On 01/09/14 10:20, Laurentiu Palcu wrote:
> Add support for enumerating the device through ACPI.
>
> Signed-off-by: Laurentiu Palcu
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play.
Thanks,
Jonathan
> ---
>
> Changes in v2:
> * fix the unn
Please repost this series with the device tree list and maintainers cc'd.
What you have looks fine to me, but as it is effecting bindings they must
have the opportunity to comment. Rules are either an Ack from them or
a least 3 weeks on their list then I can make up my own mind :)
On 30/09/14 12:5
On 07/10/14 16:19, Darshana Padmadas wrote:
> This patch adds the correct vendor-prefix for device isl29028 and
> maintains deprecated vendor-prefix found by checkpatch warning
> for older kernel releases.
>
> Signed-off-by: Darshana Padmadas
Acked-by: Jonathan Cameron
Which
On 05/08/15 13:22, Daniel Baluta wrote:
> On Wed, Aug 5, 2015 at 3:15 PM, Lars Svensson
> wrote:
>> Fixing indentation errors in
>> drivers/staging/iio/iio_simple_dummy_events.c.
>>
>> Signed-off-by: Lars Svensson
>
> Good catch.
>
> Acked-by: Daniel Baluta
>
Thanks. Applied to the togreg bra
On 12/08/15 16:21, Lars-Peter Clausen wrote:
> On 08/12/2015 03:25 PM, sdliy...@gmail.com wrote:
>> From: Yong Li
>>
>> Load the driver using the below command:
>> echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
>>
>> In sysfs, the iio name is hmc5843, however the i2c name is hmc5983,
>>
On 11/08/15 19:43, Lars-Peter Clausen wrote:
> On 08/10/2015 11:51 PM, Joe Perches wrote:
>> Using 'extern' is not necessary for function prototypes.
>>
>> Signed-off-by: Joe Perches
>
> Acked-by: Lars-Peter Clausen
>
Applied to the togreg branch of iio.git. 4.4 material now
probably.
Thanks,
On 11/08/15 11:18, Cristina Opriceana wrote:
> Fix alignment for function parameters as suggested by checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana
Whilst I find it a little hard to care about tidying up in these two drivers,
we haven't explicitly noted they are both on their way out in the
On 11/08/15 11:20, Cristina Opriceana wrote:
> Fix style issue related to missing braces, detected by checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana
Applied to the togreg branch of iio.git.
This one used to be left as optional, so there are a lot of these in older
code (and in IIO you don'
On 08/08/15 20:16, Dan Carpenter wrote:
> "num_read" is in byte units but we are write u16s so we end up write
> twice as much as intended.
>
> Signed-off-by: Dan Carpenter
Hi Dan,
This is fine. Given it's an old bug, Greg is not going to take this
sort of fix until after the merge window. I w
On 15/08/15 21:05, Lars-Peter Clausen wrote:
> On 08/15/2015 09:57 PM, Jonathan Cameron wrote:
>> On 11/08/15 19:43, Lars-Peter Clausen wrote:
>>> On 08/10/2015 11:51 PM, Joe Perches wrote:
>>>> Using 'extern' is not necessary for function prototyp
On 20/08/15 08:07, Javier Martinez Canillas wrote:
> The SPI core always reports the MODALIAS uevent as "spi:"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: SPI id table or OF
On 30/08/15 09:12, Peng Fan wrote:
> To lpc32xx_adc driver, when platform_get_resource or
> platform_get_irq failed, we should use -ENXIO as a
> return value, but not -EBUSY.
>
> Signed-off-by: Peng Fan
> Cc: Jonathan Cameron
> Cc: Hartmut Knaack
> Cc: Lars-Peter Claus
On 01/09/15 00:09, Javier Martinez Canillas wrote:
> Hello Jonathan,
>
> On 08/22/2015 07:59 PM, Jonathan Cameron wrote:
>> On 20/08/15 08:07, Javier Martinez Canillas wrote:
>>> The SPI core always reports the MODALIAS uevent as "spi:"
>>> regardless
On 26/09/15 18:14, Lars-Peter Clausen wrote:
> On 09/25/2015 07:23 PM, Shraddha Barke wrote:
>> Replace bit shifting on 1 with the BIT(x) macro
>>
>> Signed-off-by: Shraddha Barke
>
> Acked-by: Lars-Peter Clausen
>
This is a good little patch, so applied to the togreg branch
of iio.git. This w
On 26/09/15 18:14, Lars-Peter Clausen wrote:
> On 09/25/2015 07:23 PM, Shraddha Barke wrote:
>> Remove dev_info as the information can be obtained by other means
>>
>> Signed-off-by: Shraddha Barke
>
> Acked-by: Lars-Peter Clausen
Applied, thanks Shraddha,
Keep up the good work, these drivers h
On 01/07/14 22:19, Himangi Saraogi wrote:
This patch introduces the use of the managed version of kzalloc and
removes the kfrees in the probe and remove functions. More return
paths are added and the labels are renamed to order them.
Signed-off-by: Himangi Saraogi
Looks sane, but I'd like an a
On 01/07/14 19:44, Himangi Saraogi wrote:
This patch introduces the use of devm_ioremap_resource. It does away
with call to request_mem_region and the error checking on
platform_get_resource. Also, the calls to free the allocated resources
like release_mem_region and iounmap are done away with. T
On 07/07/14 15:12, Daniel Baluta wrote:
Otherwise, compiling iio_event_monitor program fails:
io_event_monitor.c: In function ‘event_is_known’:
iio_event_monitor.c:125:2: error: duplicate case value
case IIO_MOD_LIGHT_BOTH:
^
iio_event_monitor.c:121:2: error: previously used here
case I
On 07/07/14 13:36, Lars-Peter Clausen wrote:
On 07/07/2014 02:36 PM, Jonathan Cameron wrote:
On 01/07/14 19:44, Himangi Saraogi wrote:
This patch introduces the use of devm_ioremap_resource. It does away
with call to request_mem_region and the error checking on
platform_get_resource. Also, the
On 07/07/14 13:37, Lars-Peter Clausen wrote:
On 07/07/2014 02:34 PM, Jonathan Cameron wrote:
On 01/07/14 22:19, Himangi Saraogi wrote:
This patch introduces the use of the managed version of kzalloc and
removes the kfrees in the probe and remove functions. More return
paths are added and the
On 02/07/14 14:50, Josef Gajdusek wrote:
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
Hi Josef,
A few little bits and pieces inline.
Peter, could y
: Shubhrajyoti Datta
- Acknowledgement: Jonathan Cameron for valuable inputs.
-
-Support for HMC5883 and HMC5883L by Peter Meerwald .
-
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-
On 02/07/14 14:52, Josef Gajdusek wrote:
Changed structure of struct hmc5843_chip_info to include length of translation
arrays. Code previously using #defined constant has been changed accordingly.
This allows to integrate devices which do have different amounts of available
rates/scales.
Signed
On 02/07/14 14:53, Josef Gajdusek wrote:
This patch adds support for the hmc5983 i2c interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
Very n
On 02/07/14 14:54, Josef Gajdusek wrote:
This patch adds support for the hmc5983 spi interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
Someti
On 12/07/14 20:16, Marcus Folkesson wrote:
Line over 80 characters. This is for Eudyptula Challenge.
Signed-off-by: Marcus Folkesson
Sorry Marcus,
There is a level of trivial cleanup below which it's not worth
taking patches. The 80 character limit is not a hard and fast
rule. Here, if this h
On 08/07/14 14:38, Josef Gajdusek wrote:
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
Applied to the togreg branch of iio.git.
Ideally we would hav
ivers/staging/iio/magnetometer/hmc5843.c
deleted file mode 100644
index a458160..000
--- a/drivers/staging/iio/magnetometer/hmc5843.c
+++ /dev/null
@@ -1,702 +0,0 @@
-/* Copyright (C) 2010 Texas Instruments
-Author: Shubhrajyoti Datta
-Acknowledgement: Jonathan Cameron for valuable inpu
On 13/07/14 14:27, Marek Vasut wrote:
On Sunday, July 13, 2014 at 01:44:38 PM, Chen Gang wrote:
MXS_LRADC need HAS_IOMEM, so let it depend on HAS_IOMEM
The related error (with allmodconfig under score):
MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/staging/iio/adc/mxs-lr
On 14/07/14 21:31, Himangi Saraogi wrote:
Hi,
The code seems to have a memory leak. The function ad7280_attr_init
calls kasprintf a number of times, which calls kmalloc (or more
precisely kmalloc_track_caller), but this data does not ever seem to
be freed. I propose to introduce a devm_ version
On 15/07/14 13:24, Josef Gajdusek wrote:
This patch series modifies the hmc5843 driver to support the hmc5983 i2c and
spi interfaces.
v2:
* Reverted the changed order of iio unregister and setting hmc mode to
sleep
v3:
* Fixed bug introduced in the first patch
* Readded
On 19/07/14 11:33, Himangi Saraogi wrote:
This patch moves data allocated using unmanaged interfaces to managed
interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,
devm_request_threaded_irq and does away with the calls to free the
allocated memory in the probe and remove funct
On 19/07/14 21:46, Julia Lawall wrote:
On Sat, 19 Jul 2014, Jonathan Cameron wrote:
On 19/07/14 11:33, Himangi Saraogi wrote:
This patch moves data allocated using unmanaged interfaces to managed
interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf
On 16/07/14 14:07, Josef Gajdusek wrote:
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
Applied to the togreg branch of iio.git. Will be initially pu
On 16/07/14 14:07, Josef Gajdusek wrote:
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek
Unfortunately taking t
801 - 900 of 1076 matches
Mail list logo
