On 07/10/16 01:48, Brian Masney wrote:
> Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012)
> about the infrared suppression that can be controlled
> with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
>
> Signed-off-by: Brian Masney
> ---
> drivers/stagi
On 07/10/16 01:48, Brian Masney wrote:
> Fix the following warnings from checkpatch:
>
> WARNING: DT compatible string "isil,isl29018" appears un-documented --
> check ./Documentation/devicetree/bindings/
> WARNING: DT compatible string "isil,isl29023" appears un-documented --
> check ./Documentat
On 09/10/16 09:43, Jonathan Cameron wrote:
> On 07/10/16 01:48, Brian Masney wrote:
>> Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012)
>> about the infrared suppression that can be controlled
>> with the proximity_on_chip_ambient_infrared_suppre
On 07/10/16 01:48, Brian Masney wrote:
> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
Time for a nitpick tastic review ;)
The nature of a move out of staging patch is that we'll go over it
with the level of fine toothed comb we apply to a n
On 07/10/16 01:48, Brian Masney wrote:
> Rename CONFIG_SENSORS_ISL29018 to CONFIG_ISL29018 for consistency with
> the other light drivers in mainline.
>
> Signed-off-by: Brian Masney
I'm always a bit split on these. It would be lovely to tidy
it up, but it may cause unnecessary breakage to peopl
On 09/10/16 11:35, Brian Masney wrote:
> On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote:
>> On 07/10/16 01:48, Brian Masney wrote:
>>> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
>>>
>>> Signed-off-by: Brian Masney
On 10/10/16 08:19, Brian Masney wrote:
> Add newlines to improve code readability in preparation for moving the
> driver out of staging.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
On 10/10/16 08:19, Brian Masney wrote:
> isl29035_detect() did not do chip detection. Move functionality directly
> into isl29018_chip_init() to avoid naming confusion.
It kind of does do detection (or at least verification). Key point is that
it does other things as well.
I added the word 'just'
On 10/10/16 08:19, Brian Masney wrote:
> Change multiline comments from:
>
> /* line1
> * line2
> * ...
> */
>
> to
>
> /*
> * line1
> * line2
> * ...
> */
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> driv
On 10/10/16 08:19, Brian Masney wrote:
> Use the return value from isl29018_set_integration_time() as the return
> value for isl29018_chip_init() since this is the last piece of work
> inside that function.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as
On 10/10/16 08:20, Brian Masney wrote:
> Rename description from "ISL 29018" to "Intersil 29018" in Kconfig for
> consistency with other drivers in mainline.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On 10/10/16 08:19, Brian Masney wrote:
> Remove blank line between MODULE_DEVICE_TABLE() and its corresponding
> structure for consistency with the other device table entries.
>
> Signed-off-by: Brian Masney
Applied.
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 1 -
> 1 file
On 10/10/16 08:20, Brian Masney wrote:
> Add ABI documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8,
> 2012) about the infrared suppression that can be controlled
> with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
>
> Signed-off-by: Brian Masney
I'm going to let t
On 11/10/16 12:12, Dan Carpenter wrote:
> The "drivers/" part of the path name was missing.
>
> Signed-off-by: Dan Carpenter
Applied - thanks.
Jonathan
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0c7d973..63f15c9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -779,7 +779,7 @@ S:
On 10/10/16 21:57, Jonathan Cameron wrote:
> On 10/10/16 08:20, Brian Masney wrote:
>> Add ABI documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8,
>> 2012) about the infrared suppression that can be controlled
>> with the proximity_on_chip_ambient_infrared_suppre
On 10/10/16 08:20, Brian Masney wrote:
> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks Brian for taking this one on and your hard
On 19 October 2016 11:32:06 BST, Brian Masney wrote:
>Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
>macros to create the device attributes.
>
>Signed-off-by: Brian Masney
Hi Brian,
One very quick comment. Driver should be using an iio_chan_spec array and
relevant
inf
On 19/10/16 12:37, Dan Carpenter wrote:
> I appologize for laughing, but I am still secretly amused in my heart.
>
> regards,
> dan carpenter
>
Fewer beers or less caffeine for Dan!
Key take away here is keep things simple. The gotos in my mind
would actually have made sense, but I wouldn't do
On 19/10/16 11:32, Brian Masney wrote:
> taos_get_lux() calls mutex_trylock(). If the lock could not be acquired,
> then chip->als_cur_info.lux is returned. The issue is that this value
> is updated while the mutex is held and could cause a half written value
> to be returned to the caller. This pa
On 19/10/16 14:11, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
>> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
>>> What does illuminance0_ mean? Can we remove that?
>>
>> I left the names of the existing sysfs attributes intact to not brea
On 19/10/16 11:32, Brian Masney wrote:
> taos_gain_store() and taos_als_calibrate() both have a code path where
> -1 was returned. This patch changes the code so that a proper error code
> is returned to make the code consistent with the error paths that are
> present within those same functions.
>
ed register values,
> to ensure this cannot happen.
>
> Fixes: e0f3fc9b47e6 ("iio: accel: sca3000_core: implemented
> IIO_CHAN_INFO_SAMP_FREQ")
> Signed-off-by: Arnd Bergmann
> Cc: Ico Doornekamp
> Cc: Jonathan Cameron
> ---
> I submitted this on Sept 22, and Jonat
On 25/10/16 16:56, Arnd Bergmann wrote:
> As found by "gcc -Wmaybe-uninitialized", the latest change to the
> driver lacked an initalization for the return code in one of the
> added cases:
>
> drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’:
> drivers/staging/iio/cdc/ad7746.c:655:
On 24/10/16 16:22, Arnd Bergmann wrote:
> The ad5933_i2c_read function returns an error code to indicate
> whether it could read data or not. However ad5933_work() ignores
> this return code and just accesses the data unconditionally,
> which gets detected by gcc as a possible bug:
>
> drivers/sta
On 25/10/16 18:00, Lars-Peter Clausen wrote:
> On 10/25/2016 06:57 PM, Jonathan Cameron wrote:
>> On 24/10/16 16:22, Arnd Bergmann wrote:
>>> The ad5933_i2c_read function returns an error code to indicate
>>> whether it could read data or not. However ad5933_work() ignor
On 28/10/16 09:26, Eva Rachel Retuya wrote:
> Introduce defines for shifting and mask under the config register for
> better readability. Also, introduce helper variables for index
> calculation.
>
> Signed-off-by: Eva Rachel Retuya
Looks good to me.
Lars could you sanity check this one as well?
On 28/10/16 11:00, Brian Masney wrote:
> Add device tree support for the tsl2583 IIO driver with no custom
> properties.
>
> Signed-off-by: Brian Masney
Trivial enough that I feel I can take this without an explicit devicetree
ack. Of course one is always welcome if anyone gets a chance to look
On 30/10/16 17:43, Jonathan Cameron wrote:
> On 28/10/16 11:00, Brian Masney wrote:
>> Add device tree support for the tsl2583 IIO driver with no custom
>> properties.
>>
>> Signed-off-by: Brian Masney
> Trivial enough that I feel I can take this without an explici
On 28/10/16 11:00, Brian Masney wrote:
> taos_i2c_read() and taos_als_calibrate() does not check to see if the
> value returned by i2c_smbus_read_byte() was an error code. This patch
> adds the appropriate error handling.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and
On 28/10/16 11:00, Brian Masney wrote:
> taos_als_calibrate() has a code path where -1 is returned. This patch
> changes the code so that a proper error code is returned.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play
On 28/10/16 11:00, Brian Masney wrote:
> IIO devices have a /sys/bus/iio/devices/iio:deviceX/power/ directory
> that allows viewing and controling various power parameters. The tsl2583
> driver also has an additional custom sysfs attribute named power_state
> that is not needed. This patch removes
On 28/10/16 11:00, Brian Masney wrote:
> The return value from taos_chip_on() and taos_chip_off() was not
> checked in taos_luxtable_store() and taos_probe(). This patch adds
> proper error checking to these function calls.
>
> Signed-off-by: Brian Masney
This does raise the question of whether w
On 28/10/16 11:00, Brian Masney wrote:
> The tsl2583 driver directly creates sysfs attributes that should instead
> be created by the IIO core on behalf of the driver. This patch adds the
> iio_chan_spec array, the relevant info_mask elements and the read_raw()
> and write_raw() functions to take a
On 28/10/16 11:00, Brian Masney wrote:
> The illuminance0_calibscale sysfs attribute is not currently created by
> the IIO core. This patch adds the appropriate mask to iio_chan_spec,
> along with the appropriate data handling in the read_raw() and
> write_raw() functions, so that the sysfs attribu
On 28/10/16 11:00, Brian Masney wrote:
> Use the IIO_CONST_ATTR, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> macros for creating the in_illuminance_calibscale_available,
> in_illuminance_integration_time_available, in_illuminance_input_target,
> in_illuminance_calibrate, and in_illuminance_lux_tab
On 28/10/16 11:00, Brian Masney wrote:
> in_illuminance_input_target_store() and in_illuminance_calibrate_store()
> validated the data from userspace, however it would not return an
> error code to userspace if an invalid value was passed in. This patch
> changes these functions so that they return
On 28/10/16 11:00, Brian Masney wrote:
> in_illuminance_input_target_show(), in_illuminance_input_target_store(),
> in_illuminance_calibrate_store(), and in_illuminance_lux_table_store()
> accesses data from the tsl2583_chip struct. Some of these fields can be
> modified by other parts of the drive
On 30/10/16 17:46, Lars-Peter Clausen wrote:
> On 10/30/2016 06:41 PM, Jonathan Cameron wrote:
>> On 28/10/16 09:26, Eva Rachel Retuya wrote:
>>> Introduce defines for shifting and mask under the config register for
>>> better readability. Also, introduce helper variable
On 30 October 2016 20:04:09 GMT+00:00, Brian Masney
wrote:
>On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote:
>> On 28/10/16 11:00, Brian Masney wrote:
>> > The illuminance0_calibscale sysfs attribute is not currently
>created by
>> > the
On 31/10/16 08:05, Eva Rachel Retuya wrote:
> On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote:
>> On Sun, Oct 30, 2016 at 06:49:00PM +, Jonathan Cameron wrote:
>>> On 30/10/16 17:46, Lars-Peter Clausen wrote:
>>>> On 10/30/2016 06:41 PM, Jonathan
On 01/11/16 19:58, Lars-Peter Clausen wrote:
> On 11/01/2016 05:03 AM, Matt Ranostay wrote:
>> On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya
>> wrote:
>>> The name passed to devm_regulator_get() should match the name of the
>>> supply as specified in the device datasheet. This makes it clea
On 05/11/16 12:58, Jonathan Cameron wrote:
> On 01/11/16 19:58, Lars-Peter Clausen wrote:
>> On 11/01/2016 05:03 AM, Matt Ranostay wrote:
>>> On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya
>>> wrote:
>>>> The name passed to devm_regulator_get() shou
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> The name passed to devm_regulator_get() should match the name of the
> supply as specified in the device datasheet. This makes it clear what
> power supply is being referred to in case of presence of other
> regulators.
>
> Currently, the supply name s
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> Currently, the affected drivers ignore all errors from regulator_get().
> The way it is now, it also breaks probe deferral (EPROBE_DEFER). The
> correct behavior is to propagate the error to the upper layers so they
> can handle it accordingly.
>
> Rew
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> The AD7190/AD7192/AD7193/AD7195 is supplied with two power sources:
> AVdd as analog supply voltage and DVdd as digital supply voltage.
>
> Attempt to fetch and enable the regulator 'dvdd'. Bail out if any error
> occurs.
>
> Suggested-by: Lars-Peter
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> Rename regulator 'reg' to 'avdd' so as to be clear what regulator it
> stands for specifically. Also, update the goto label accordingly.
>
> Signed-off-by: Eva Rachel Retuya
Applied.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 22 ++
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> The AD9832/AD9835 is supplied with two power sources: AVDD as analog
> supply voltage and DVDD as digital supply voltage.
>
> Attempt to fetch and enable the regulator 'dvdd'. Bail out if any error
> occurs.
>
> Suggested-by: Lars-Peter Clausen
> Sig
On 31/10/16 17:04, Eva Rachel Retuya wrote:
> Rename regulator 'reg' to 'avdd' so as to be clear what regulator it
> stands for specifically. Additionally, get rid of local variable 'reg'
> and use direct assignment instead. Update also the goto label pertaining
> to the avdd regulator during disab
On 03/11/16 12:56, Brian Masney wrote:
> There were several places where the driver would first call
> i2c_smbus_write_byte() to select the register on the device, and then
> call i2c_smbus_read_byte() to get the contents of that register. The
> code would look roughly like:
>
> /* Select register
On 03/11/16 12:56, Brian Masney wrote:
> There were several places where the driver would first call
> i2c_smbus_write_byte() to select the register on the device, and then
> call i2c_smbus_read_byte() to get the contents of that register. The
> code would look roughly like:
>
> /* Select register
On 03/11/16 12:56, Brian Masney wrote:
> taos_probe() queries the all of the sensor's registers and loads all of
> the values into a buffer stored on the stack. Only the chip ID register
> was actually used. Change the probe function to just query the chip ID
> register on the device.
>
> Verified
On 03/11/16 12:56, Brian Masney wrote:
> in taos_defaults()
>
> The comments in taos_defaults() appear after the line of code
> that they apply to. This patch moves the comments so that they appear
> before the code. Some of the comments were updated to be more
> informative.
>
> Signed-off-by: B
On 03/11/16 12:56, Brian Masney wrote:
> taos_chip_on() explicitly turns the sensor power on and then writes the
> 8 registers that are stored in taos_config. The first register in
> taos_config is the CONTROL register and the configuration is set to
> turn the power off. The existing state sequenc
On 03/11/16 12:56, Brian Masney wrote:
> in_illuminance_lux_table_store() shuts down the chip, updates the
> contents of the lux table, and then turns the chip back on. The values
> in lux table are not used by the chip and are only used internally by
> the driver. It is not necessary to change the
On 03/11/16 12:56, Brian Masney wrote:
> taos_als_calibrate() queries the control register to determine if the
> unit is powered on and has the ADC enabled. It then queries the same
> register a second time to determine if the ADC reading is valid. This
> patch removes the redundant i2c_smbus_read_
On 03/11/16 12:56, Brian Masney wrote:
> When updating the in_illuminance_calibscale and
> in_illuminance_integration_time sysfs attributes, these values were not
> actually written to the chip. The chip would continue to use the old
> parameters. Extracted out tsl2583_set_als_gain() and
> tsl2583_
On 03/11/16 12:56, Brian Masney wrote:
> in_illuminance_calibrate_store() did not check to see if the chip is
> suspended. This patch adds the proper check. The return value from
> taos_als_calibrate() was also not checked in this function, so the
> proper check was also added while changes are bei
On 03/11/16 12:56, Brian Masney wrote:
> taos_probe() calls i2c_smbus_write_byte() to select the control
> register, however there is no subsequent calls to i2c_smbus_read_byte().
> The write call is unnecessary and is removed by this patch.
>
> Verified that the driver still functions correctly u
On 06/11/16 14:23, Brian Masney wrote:
> On Sun, Nov 06, 2016 at 12:03:53PM +0000, Jonathan Cameron wrote:
>> On 03/11/16 12:56, Brian Masney wrote:
>>> When updating the in_illuminance_calibscale and
>>> in_illuminance_integration_time sysfs attributes, these values we
On 08/11/16 14:00, Arnd Bergmann wrote:
> The regulator changes assigned data to an uninitialized pointer:
>
> drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe':
> drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used
> uninitialized in this function [-Werror=may
On 08/11/16 14:01, Arnd Bergmann wrote:
> Removing a call to the taos_chip_off() makes it unused when CONFIG_PM
> is disabled:
>
> drivers/staging/iio/light/tsl2583.c:438:12: error: ‘taos_chip_off’ defined
> but not used [-Werror=unused-function]
>
> This removes all the #ifdef in this file, and
On 08/11/16 10:16, Brian Masney wrote:
> Added Brian Masney's copyright to the header and to the MODULE_AUTHOR
> for all of the staging cleanups that has been done to this driver.
>
> Signed-off-by: Brian Masney
> ---
> drivers/staging/iio/light/tsl2583.c | 3 ++-
> 1 file changed, 2 insertions(
On 08/11/16 10:16, Brian Masney wrote:
> Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
A few minor bits and bobs inline - might need to push one or two into relevant
earlier patches, but was easier to just review the whole code in here as
I'm
On 10/11/16 09:25, Brian Masney wrote:
> taos_chip_on() reads an eight member array called taos_config
> that contains the desired state of the chip's registers. Only four
> of the registers actually need to be written to. The four that do
> not need to be written to are for the {low,high} byte of
On 10/11/16 09:25, Brian Masney wrote:
> When updating the in_illuminance_calibscale and
> in_illuminance_integration_time sysfs attributes, these values were not
> actually written to the chip. The chip would continue to use the old
> parameters. Extracted out tsl2583_set_als_gain() and
> tsl2583_
On 10/11/16 09:25, Brian Masney wrote:
> in_illuminance_calibrate_store() did not check to see if the chip is
> suspended. This patch adds the proper check. The return value from
> taos_als_calibrate() was also not checked in this function, so the
> proper check was also added while changes are bei
On 12/11/16 16:24, Jonathan Cameron wrote:
> On 10/11/16 09:25, Brian Masney wrote:
>> in_illuminance_calibrate_store() did not check to see if the chip is
>> suspended. This patch adds the proper check. The return value from
>> taos_als_calibrate() was also not checked in
On 10/11/16 09:25, Brian Masney wrote:
> taos_get_lux checks to see if the chip is in a working state. This
> check is not necessary since it is only called from tsl2583_read_raw
> and in_illuminance_calibrate_store (via taos_als_calibrate). The chip
> state is already checked by these functions.
>
On 10/11/16 09:25, Brian Masney wrote:
> The device probing and the suspend/resume code checks a flag internal to
> the driver that determines whether or not the chip is in a working
> state. These checks are not needed. This patch removes the unnecessary
> checks. It will do no harm to the hardwar
On 10/11/16 09:25, Brian Masney wrote:
> If channel 0 does not have any data, then the code sets the lux to zero.
> The corresponding comment says that the last value is returned. This
> updates the comment to correctly reflect what the code does.
>
> Signed-off-by: Brian Masney
Better perhaps to
On 10/11/16 09:25, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
> Replace this with sizeof(unsigned int).
>
> Signed-off-by: Brian Masney
Preferred to use sizeof(value[0]) in case it changes type sometime in the
future?
> ---
> drivers/staging/ii
On 10/11/16 09:25, Brian Masney wrote:
> The driver contains a global lux table that can be updated via sysfs.
> Change this to a per device lux table so that multiple devices can be
> hooked up to the same system with different lux tables.
>
> There are 10 entries, plus 1 for the termination segm
On 10/11/16 09:26, Brian Masney wrote:
> Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
The rest of the series (that I haven't commented on) looks good to me.
I'll pick them up once those few minor changes are sorted.
Thanks,
Jonathan
> ---
On 12/11/16 16:59, Brian Masney wrote:
> On Sat, Nov 12, 2016 at 04:36:37PM +0000, Jonathan Cameron wrote:
>> On 10/11/16 09:25, Brian Masney wrote:
>>> If channel 0 does not have any data, then the code sets the lux to zero.
>>> The corresponding comment says that the l
On 12/11/16 18:19, Brian Masney wrote:
> taos_get_lux checks to see if the chip is in a working state. This
> check is not necessary since it is only called from tsl2583_read_raw
> and in_illuminance_calibrate_store (via taos_als_calibrate). The chip
> state is already checked by these functions.
>
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_calibrate_store() did not check to see if the chip is
> in a working state. This patch adds the proper check. The return value
> from taos_als_calibrate() was also not checked in this function, so the
> proper check was also added while change
On 12/11/16 18:19, Brian Masney wrote:
> The device probing and the suspend/resume code checks a flag internal to
> the driver that determines whether or not the chip is in a working
> state. These checks are not needed. This patch removes the unnecessary
> checks. It will do no harm to the hardwar
On 12/11/16 18:19, Brian Masney wrote:
> The current chip state is represented as a tristate (working, suspended,
> and unknown). The unknown state was not used. This patch changes the
> chip state so that it is now represented as a single boolean value
> (suspended).
>
> Signed-off-by: Brian Masn
On 12/11/16 18:19, Brian Masney wrote:
> taos_probe() calls i2c_smbus_write_byte() to select the control
> register, however there are no subsequent calls to
> i2c_smbus_read_byte(). The write call is unnecessary and is removed by
> this patch.
>
> Verified that the driver still functions correctl
On 12/11/16 18:19, Brian Masney wrote:
> Address warning from checkpatch:
>
> CHECK: Do not include the paragraph about writing to the Free Software
> Foundation's mailing address from the sample GPL notice. The FSF has
> changed addresses in the past, and may do so again. Linux already
> includes
On 12/11/16 18:19, Brian Masney wrote:
> There are several places in the code where the function name is
> hardcoded in the log message. Use the __func__ constant string to build
> the log message. This also clarifies some of the error messages to match
> the code and ensures that the correct prior
On 12/11/16 18:19, Brian Masney wrote:
> Some functions and variables were prefixed with either taos, tsl258x,
> taos2583, or tsl2583. Change everything to use the tsl2583 prefix since
> that is the name of the .c file. The taos_settings member inside the
> taos_settings struct was renamed to als_s
On 12/11/16 18:19, Brian Masney wrote:
> Most of the values in the #defines have their values aligned on a single
> column, but some do not. This changes the remaining defines to use
> consistent alignment with the majority to improve code readability.
>
> Signed-off-by: Brian Masney
Applied.
> -
On 12/11/16 18:19, Brian Masney wrote:
> Fixed warning found by make W=2:
>
> warning: comparison between signed and unsigned integer expressions
> [-Wsign-compare]
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 7 ---
> 1 file changed, 4 insertions(+
On 12/11/16 18:19, Brian Masney wrote:
> Add and remove newlines to improve code readability in preparation for
> moving the driver out of staging.
>
> Signed-off-by: Brian Masney
Applied
> ---
> drivers/staging/iio/light/tsl2583.c | 14 --
> 1 file changed, 12 insertions(+), 2 delet
On 12/11/16 18:19, Brian Masney wrote:
> There are two separate files describing the tsl2583 sysfs attributes.
> Combine the two files into one. Updated the name of the sysfs attributes
> to match the current ABI.
>
> Signed-off-by: Brian Masney
> Suggested-by: Peter Meerwald-Stadler
Applied.
>
On 12/11/16 18:19, Brian Masney wrote:
> The definition of the tsl2583_device_lux struct has a series of single
> line comments. There are two other cases where the multiline comments
> did not have an initial blank line. Change these comments to use the
> proper multiline syntax.
>
> Signed-off-b
On 12/11/16 18:19, Brian Masney wrote:
> If channel 0 does not have any data, then the code sets the lux to zero.
> The corresponding comment says that the last value is returned. This
> updates the comment to correctly reflect what the code does. It also
> clarifies the comment about why 0 is retu
On 12/11/16 18:19, Brian Masney wrote:
> The check for ch1lux > ch0lux inside tsl2583_get_lux is only valid if
> the ratio is not equal to zero. Move the code block inside the else
> statement. This does away with the need to initialize the variables to
> zero.
>
> Signed-off-by: Brian Masney
App
On 12/11/16 18:19, Brian Masney wrote:
> tsl2583_als_calibrate() returns the newly computed gain_trim if the
> calibration was successful. This function is only called by
> in_illuminance_calibrate_store() and the return value inside that
> sysfs attribute is only checked to see if an error was ret
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store() contains some unnecessary parentheses.
> This patch removes them since they provide no value.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 4 ++--
> 1 file changed, 2 insertions(+)
On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
> Replace this with sizeof(value[1]).
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 12/11/16 18:19, Brian Masney wrote:
> The driver contains a global lux table that can be updated via sysfs.
> Change this to a per device lux table so that multiple devices can be
> hooked up to the same system with different lux tables.
>
> There are 10 entries, plus 1 for the termination segm
On 12/11/16 18:19, Brian Masney wrote:
> The header only listed the tsl2580 and tsl2581 devices as supported by
> this driver. This patch adds the tsl2583 since it is also supported by
> this driver.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 2 +-
> 1
On 12/11/16 18:19, Brian Masney wrote:
> The comment for tsl2583_probe() does not provide any useful value.
> This patch removes the comment.
>
> Signed-off-by: Brian Masney
Applied
> ---
> drivers/staging/iio/light/tsl2583.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/
On 12/11/16 18:19, Brian Masney wrote:
> The comment that describes the code that clears the interrupt bit was
> vague and didn't provide much value. This patch adds more detail about
> why that bit needs to be cleared.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/t
On 12/11/16 18:19, Brian Masney wrote:
> The entries in the lux table (als_device_lux) can be updated via sysfs
> through the function in_illuminance_lux_table_store(). The last row in
> the table must be terminated with values that are zero. The sysfs code
> already ensures that the last row is al
On 12/11/16 18:19, Brian Masney wrote:
> The ret variable in tsl2583_suspend() and tsl2583_resume() was
> initialized to 0. This is not necessary so this patch removes the
> initialization.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 4 ++--
> 1 file ch
On 12/11/16 18:19, Brian Masney wrote:
> Add Brian Masney's copyright to the header and to the MODULE_AUTHOR
> for all of the staging cleanups that has been done to this driver.
>
> The original MODULE_AUTHOR() did not have a space between his name and
> email address. This patch also adds the mis
On 12/11/16 18:19, Brian Masney wrote:
> Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline.
>
> Signed-off-by: Brian Masney
I had another read through on this one. A few oddites.
I fixed up the indentation one way back in your patch fixing alignment.
Made applying this patch mo
701 - 800 of 1076 matches
Mail list logo
