On Sat, 17 Mar 2018 01:36:24 +0530
Himanshu Jha wrote:
> Prefer reverse christmas tree ordering of declarations to improve
> readability.
>
> Signed-off-by: Himanshu Jha
As ever, this sort of change is only worth doing if you are working on the
relevant code anyway. You are, so good to tidy up
On Sat, 17 Mar 2018 01:36:25 +0530
Himanshu Jha wrote:
> In adis16201_read_raw() adjust an argument to match an open parentheses
> using tabs and spaces.
>
> Signed-off-by: Himanshu Jha
Applied, thanks
Jonathan
> ---
> v2:
>-aligned perfectly to match open parentheses.
>
> drivers/stagi
On Sat, 17 Mar 2018 01:36:26 +0530
Himanshu Jha wrote:
> Move the adis16201 driver out of staging directory and merge to the
> mainline IIO subsystem.
>
> Signed-off-by: Himanshu Jha
Hi Himanshu,
You have made great progress on this, but this final posting of a patch moving
a driver out of sta
On Fri, 16 Mar 2018 19:48:33 -0300
Rodrigo Siqueira wrote:
> The original code does not correctly handle the error related to I2C
> read and write. This patch fixes the error handling related to all
> read/write functions for I2C. This patch is an adaptation of the John
> Syne patches.
>
> Signe
On Fri, 16 Mar 2018 19:48:51 -0300
Rodrigo Siqueira wrote:
> The function ade7854_i2c_read_reg_32() have to invoke the
> i2c_master_recv() for read 32 bits values, however, the counter is set
> to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to
> 32 bits. Finally, this patch
On Fri, 16 Mar 2018 19:49:08 -0300
Rodrigo Siqueira wrote:
> The write operation using I2C has many code duplications and four
> different interfaces per data size. This patch introduces a single
> function that centralizes the main tasks.
>
> The central function inserted by this patch can easi
On Fri, 16 Mar 2018 19:49:24 -0300
Rodrigo Siqueira wrote:
> The write operation using SPI has a many code duplications (similar to
> I2C) and four different interfaces per data size. This patch introduces
> a single function that centralizes the main task related to SPI.
>
> Signed-off-by: Rodr
On Fri, 16 Mar 2018 19:49:40 -0300
Rodrigo Siqueira wrote:
> This patch removes code duplications related to the write_reg_*
> functions and centralizes them in a single function. Also, it eliminates
> the legacy functions and replaces them by a unique signature that is
> used by SPI and I2C.
>
On Fri, 16 Mar 2018 19:49:59 -0300
Rodrigo Siqueira wrote:
> The read operation for the I2C function has many duplications that can
> be generalized into a single function. This patch reworks the read
> operation for I2C to centralizes all similar code in a single function.
> Part of the rework i
On Fri, 16 Mar 2018 19:50:29 -0300
Rodrigo Siqueira wrote:
> The original code had a read function per data size; after updates, all
> read functions tasks were centralized in a single function, but the old
> signature was kept to maintain the module working without problems. This
> patch removes
On Sun, 18 Mar 2018 15:18:44 +0530
Shreeya Patel wrote:
> On 10 March 2018 21:27:31 GMT+05:30, Jonathan Cameron
>
> Hi Jonathan
>
> >On Sat, 10 Mar 2018 15:50:23 +0530
> >Shreeya Patel wrote:
> >
> >> Move the adis16209 driver out of staging direc
ine cycles.
Some of these are event controls. Map them as such.
> 0xE705CFCYC register_CFCYC R/W 8 8 U 0x01
> Number of CF pulses between two consecutive energy latches. See the
> Synchronizing Energy Registers with CFx Outputs section.
> 0xE
On Sun, 18 Mar 2018 14:35:46 +0100
David Veenstra wrote:
> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly
> used in ad2s1200_probe.
>
> Signed-off-by: David Veenstra
I'm a little unconvinced by this one. It adds code to save
a really very trivial bit of repetition.
On Sun, 18 Mar 2018 14:36:15 +0100
David Veenstra wrote:
> After a successful spi transaction, a udelay(1) is needed.
> This doesn't happen for the default case of the switch statement
> in ad2s1200_read_raw. This patch makes sure that it does.
>
> Signed-off-by: David Veenstra
Given this one c
On Sun, 18 Mar 2018 14:36:33 +0100
David Veenstra wrote:
> The legacy, integer based gpio ABI is replaced with the descriptor
> based ABI.
>
> For compatibility, it is first tried to use the platform data to
> request the gpio's. Otherwise, it looks for the "sample" and "rdvel"
> gpio function.
On Sun, 18 Mar 2018 14:37:04 +0100
David Veenstra wrote:
> The angle channel is not defined in sysfs iio ABI. So it is replaced
> with an inclination channel, because it is defined in the ABI, and has the
> semantics of an angle.
>
> In addition, a fractional scaling factor of 360 / (2^12 -1) is
On Sun, 18 Mar 2018 14:37:22 +0100
David Veenstra wrote:
> Signed-off-by: David Veenstra
Please disable git move detection for a patch moving an IIO driver
out of staging. It provides the opportunity for a full review of the
code as if we were considering a new driver.
Thanks for the set - I'm
On Fri, 23 Mar 2018 00:42:42 +0530
Himanshu Jha wrote:
> Remove few unused headers files since the adis core handles the buffer and
> sysfs support.
>
> Signed-off-by: Himanshu Jha
Please avoid sending a series in reply to a previous series.
It is far to easy for people to miss that this is new
On Fri, 23 Mar 2018 11:22:10 -0300
John Syne wrote:
> Fixes: correctly handle errors on the read and write operation for I2C
Please look at the Submitting patches documentation. This is not
what a fixes tag is about! I'll fix it up this time but please
look at it.
>
> The original code does no
On Fri, 23 Mar 2018 11:25:48 -0300
John Syne wrote:
> Fixes: correctly handle the data size in the read operation for I2C
>
> The function ade7854_i2c_read_reg_32() have to invoke the
> i2c_master_recv() for read 32 bits values, however, the counter is set
> to 3 which means 24 bits. This patch
On Fri, 23 Mar 2018 11:26:06 -0300
Rodrigo Siqueira wrote:
> The write operation using I2C has many code duplications and four
> different interfaces per data size. This patch introduces a single
> function that centralizes the main tasks.
>
> The central function inserted by this patch can easi
On Fri, 23 Mar 2018 11:26:25 -0300
Rodrigo Siqueira wrote:
> The write operation using SPI has a many code duplications (similar to
> I2C) and four different interfaces per data size. This patch introduces
> a single function that centralizes the main task related to SPI.
>
> Signed-off-by: Rodr
On Fri, 23 Mar 2018 11:26:41 -0300
Rodrigo Siqueira wrote:
> This patch removes code duplications related to the write_reg_*
> functions and centralizes them in a single function. Also, it eliminates
> the legacy functions and replaces them by a unique signature that is
> used by SPI and I2C.
>
On Fri, 23 Mar 2018 11:26:57 -0300
Rodrigo Siqueira wrote:
> The read operation for the I2C function has many duplications that can
> be generalized into a single function. This patch reworks the read
> operation for I2C to centralizes all similar code in a single function.
>
> It is possible to
On Fri, 23 Mar 2018 11:27:12 -0300
Rodrigo Siqueira wrote:
> Rework read SPI function to reduce the code duplication and centralizes
> all the task in a single function.
>
> Signed-off-by: Rodrigo Siqueira
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to
On Fri, 23 Mar 2018 11:27:27 -0300
Rodrigo Siqueira wrote:
> The original code had a read function per data size; after updates, all
> read functions tasks were centralized in a single function, but the old
> signature was kept to maintain the module working without problems. This
> patch removes
On Wed, 21 Mar 2018 06:29:02 -0400
Brian Masney wrote:
> As a follow up to the work in commit a0722d05a195 ("staging: iio:
> tsl2x7x: convert mutex_trylock() to mutex_lock()"), this patch removes
> the unnecessary calls to tsl2x7x_get_prox() and tsl2x7x_get_lux() in
> tsl2x7x_event_handler(). Pre
On Wed, 21 Mar 2018 06:29:03 -0400
Brian Masney wrote:
> tsl2x7x_event_handler() was not called as expected when the device was
> asserting a hardware interrupt. This patch changes the interrupt line
> trigger from rising to falling.
I guess the original test board used for driver development mus
On Wed, 21 Mar 2018 06:29:04 -0400
Brian Masney wrote:
> tsl2x7x_get_lux() does not need to clear the interrupt flag when
> querying the ALS. The interrupt flag is cleared in
> tsl2x7x_event_handler(). This patches removes the unnecessary code.
>
> Signed-off-by: Brian Masney
Applied.
Thanks,
On Wed, 21 Mar 2018 06:29:05 -0400
Brian Masney wrote:
> tsl2x7x_prox_cal() would set the interrupt flag, and reset the device to
> start doing the calibration routine. However, this did not actually
> affect the readings since they are polled. This patch drops the interrupt
> code.
>
> This pat
On Wed, 21 Mar 2018 06:29:06 -0400
Brian Masney wrote:
> The struct tsl2x7x_settings contained an interrupts_en member that was
> a bitmask for which interrupts are enabled. This required having
> bitmasks in several parts of the code. This patch splits this field
> out into two booleans to remov
On Wed, 21 Mar 2018 06:29:07 -0400
Brian Masney wrote:
> This patch updates all of the logging commands so that they are
> consistent with the other messages, includes __func__ in the message,
> and all of the messages include newlines. This patch also removes some
> debug log messages.
>
> Sign
On Wed, 21 Mar 2018 06:29:09 -0400
Brian Masney wrote:
> tsl2x7x_get_lux() has a ch0lux and ch1lux variables that are not used
> so this patch removes them.
>
> Signed-off-by: Brian Masney
Had to argue with this one ;)
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/tsl2x7x.c |
On Wed, 21 Mar 2018 06:29:08 -0400
Brian Masney wrote:
> The struct tsl2x7x_settings contained a persistence member that
> contained both the ALS and proximity persistence fields. This patch
> splits this out into two separate fields so that the bitmasks in
> several parts of the code are no long
On Wed, 21 Mar 2018 06:29:10 -0400
Brian Masney wrote:
> Remove the ch0 and ch1 variables from tsl2x7x_get_lux() and
> write those values directly into the chip->als_cur_info.als_ch0
> and chip->als_cur_info.als_ch01 variables.
>
> Signed-off-by: Brian Masney
Hmm. A marginal improvement in read
On Wed, 21 Mar 2018 06:29:11 -0400
Brian Masney wrote:
> This patch ensures that all of the local variable declarations are in
> reverse Christmas tree order where possible to increase code
> readability.
>
> Signed-off-by: Brian Masney
Applied. As ever it's a minor improvement but I suppose wo
On Wed, 21 Mar 2018 06:29:12 -0400
Brian Masney wrote:
> Add Brian Masney's copyright and to the list of module authors for all
> of the staging cleanups. This patch also update's Jon Brenner's current
> work email address since AMS now owns TAOS.
>
> Signed-off-by: Brian Masney
Applied to the
On Sat, 24 Mar 2018 13:22:22 +0100
David Julian Veenstra wrote:
> On 23, March 2018 14:17, Jonathan Cameron wrote:
>
> > On Sun, 18 Mar 2018 14:35:46 +0100
> > David Veenstra wrote:
> >
> >> Add variable to hold &spi->dev in ad2s1200_prob
On Sat, 24 Mar 2018 13:36:44 +0100
David Julian Veenstra wrote:
> On 23, March 2018 14:27, Jonathan Cameron wrote:
>
> > On Sun, 18 Mar 2018 14:37:04 +0100
> > David Veenstra wrote:
> >
> >> The angle channel is not defined in sysfs iio ABI. So it is replaced
On Fri, 23 Mar 2018 00:42:42 +0530
Himanshu Jha wrote:
> Remove few unused headers files since the adis core handles the buffer and
> sysfs support.
>
> Signed-off-by: Himanshu Jha
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/staging/ii
On Fri, 23 Mar 2018 00:42:43 +0530
Himanshu Jha wrote:
> Use GENMASK to improve readability and remove the local variables used to
> store intermediate data.
>
> Signed-off-by: Himanshu Jha
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16201
On Fri, 23 Mar 2018 00:42:44 +0530
Himanshu Jha wrote:
> Split the line over 80 characters limit to fix checkpatch
> warning.
>
> Signed-off-by: Himanshu Jha
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16201.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
On Fri, 23 Mar 2018 00:42:45 +0530
Himanshu Jha wrote:
> Move adis16201 driver out of staging and merge into mainline
> IIO subsystem.
>
> Signed-off-by: Himanshu Jha
There are a few really minor points inline. However,
non prevent this moving out of staging (and I'll fix one up anyway).
App
are focused in
other areas currently :(
> Anyway, please see my comments inline below
>
> Regards,
> John
>
>
>
>
>
> > On Mar 18, 2018, at 5:23 AM, Jonathan Cameron wrote:
> >
> > On Sat, 17 Mar 2018 23:11:45 -0700
> > John Syne wrote:
> &
8 8 This address can be used in
> manipulating the SS/HSA pin when SPI is chosen as the active port. See the
> Serial Interfaces section for details.
> 0xEC00LPOILVL LPOILVL DT in
> R/W 8 8
On Sat, 24 Mar 2018 15:57:19 +0100
David Julian Veenstra wrote:
> On 24, March 2018 14:12, Jonathan Cameron wrote:
>
> > On Sat, 24 Mar 2018 13:36:44 +0100
> > David Julian Veenstra wrote:
> >
> >> On 23, March 2018 14:27, Jonathan Cameron wrote:
> >&
On Sat, 24 Mar 2018 15:45:21 -0700
John Syne wrote:
> > On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote:
> >
> > On Mon, 19 Mar 2018 22:57:16 -0700
> > John Syne wrote:
> >
> >> Hi Jonathan,
> >>
> >> Thank you for
On Sat, 24 Mar 2018 16:06:17 -0700
John Syne wrote:
This thread is becoming unmanageable so I am cropping this down to just
the questions that remain open.
> >> Probably easier to copy and paste this table into a spreadsheet. Let me
> >> know if there is anything I got wrong. Thank you again fo
On Sun, 25 Mar 2018 01:29:41 -0700
John Syne wrote:
> Hi Jonathan,
Hi John,
Please wrap your normal emails (excepting tables) to 80 chars.
>
> I was speaking with Rodrigo and here is what I think must be done to move
> ADE7878 out of staging
>
> Here are the steps as I see them:
>
> 1) Defin
On Sat, 24 Mar 2018 16:05:52 -0400
Brian Masney wrote:
> The hardware supports 16-bit ALS and proximity readings, however the
> datasheet recommends using the I2C auto increment protocol so that the
> correct high and low bytes are read even if the integration cycle ends
> between reading the low
On Sat, 24 Mar 2018 16:05:53 -0400
Brian Masney wrote:
> The IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_CALIBBIAS masks are
> currently associated with the IIO_INTENSITY channel but should be
> associated with the IIO_LIGHT channel since these values are used to
> calculate the lux. Directory lis
On Sat, 24 Mar 2018 16:05:54 -0400
Brian Masney wrote:
> The events IIO_EV_INFO_VALUE and IIO_EV_INFO_ENABLE currently have a
> falling and rising direction configured. There does not need to be a
> separate distinction so this patch changes these to use the
> either direction. Directory listing
On Sat, 24 Mar 2018 16:05:55 -0400
Brian Masney wrote:
> Move the tsl2x7x driver out of staging and into mainline.
>
> Signed-off-by: Brian Masney
Various comments inline.
I'm wondering if we should rename the driver before moving it.
The wild cards bother me as we are very likely to see some
On Sun, 25 Mar 2018 13:36:40 -0700
John Syne wrote:
> > On Mar 25, 2018, at 9:29 AM, Jonathan Cameron wrote:
> >
> > On Sat, 24 Mar 2018 15:45:21 -0700
> > John Syne wrote:
> >
> >>> On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote:
>
On Sun, 25 Mar 2018 13:53:02 -0700
John Syne wrote:
> > On Mar 25, 2018, at 9:54 AM, Jonathan Cameron wrote:
> >
> > On Sun, 25 Mar 2018 01:29:41 -0700
> > John Syne wrote:
> >
> >> Hi Jonathan,
> > Hi John,
> >
> > Please wrap yo
On Thu, 29 Mar 2018 14:42:02 +0530
Shreeya Patel wrote:
> Have indentation in field definitions to make them
> clearly different from the register addresses.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
On Thu, 29 Mar 2018 14:43:23 +0530
Shreeya Patel wrote:
> Prefer reverse christmas tree ordering of declarations to
> improve readability.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
On Thu, 29 Mar 2018 14:44:42 +0530
Shreeya Patel wrote:
> Add a blank line after return statements to improve the code
> readability.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> --
On Thu, 29 Mar 2018 14:49:22 +0530
Shreeya Patel wrote:
> Remove few unused header files since the adis core handles
> the sysfs and buffer support.
>
> Signed-off-by: Shreeya Patel
Applied,
Thanks,
Jonathan
> ---
>
> Changes in v6
> -Introduce this new patch in the series.
>
> drivers/
On Thu, 29 Mar 2018 14:51:19 +0530
Shreeya Patel wrote:
> Use GENMASK to improve readability and remove the local
> variables used to store intermediate data.
>
> Signed-off-by: Shreeya Patel
See below.
Fixed up and applied to the togreg branch of iio.git and pushed out
as testing for the auto
On Thu, 29 Mar 2018 14:52:51 +0530
Shreeya Patel wrote:
> Move the adis16209 driver out of staging directory and merge to the
> mainline IIO subsystem.
>
> Signed-off-by: Shreeya Patel
Other than fixing up for the patch 5 indentation change there
was some 'fuzz' due to the adis16201 moving befo
On Fri, 22 May 2020 11:56:40 +0300
Andy Shevchenko wrote:
> On Fri, May 22, 2020 at 11:36 AM Alexandru Ardelean
> wrote:
> >
> > The change passes the parent device to the iio_device_alloc() call. This
> > also updates the devm_iio_device_alloc() call to consider the device object
> > as the par
On Wed, 29 Jul 2020 13:38:28 +0300
Andy Shevchenko wrote:
> On Wed, Jul 29, 2020 at 11:12 AM Ankit Baluni
> wrote:
> >
> > Added a missing comma and changed 'it it useful' to 'it is useful'.
>
> Reviewed-by: Andy Shevchenko
Gah. I had kind of forgotten these docs existed and they have
rotted
On 07/24/13 06:36, Jingoo Han wrote:
> The usage of strict_strto*() is not preferred, because
> strict_strto*() is obsolete. Thus, kstrto*() should be
> used.
>
> Previously, there were only strict_strtol(), strict_strtoul(),
> strict_strtoull(), and strict_strtoll(). Thus, when converting
> to the
ingoo Han
Applied to the togreg branch of iio.git
Thanks,
> ---
> Changes since v2:
> - Fixed the type of variables suggested by Jonathan Cameron
>
> drivers/staging/iio/accel/sca3000_core.c |8 ++---
> drivers/staging/iio/accel/sca3000_ring.c |4 +--
On 08/29/13 21:14, Derek Basehore wrote:
> The lux_uscale value is not initialized at probe. The value will be
> uninitialized unless a value is written to it through the iio channel
> interface.
> This fixes that.
>
> Signed-off-by: Derek Basehore
> Reviewed-on: https://gerrit.chromium.org/gerr
@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
I'd personally have gone for LRADC_MX28_CTRL0_* but I'm not that fussed.
I am looking for an Acked-by from Marek for this series though.
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 61
adead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
One little suggestion inline but I'm basically happy with this.
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 204
> +---
>
test them soon?
Minor code layout comment inline but otherwise I'm just looking for an
ack from Marek.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Came
rrupt and CPU load.
>
> Note: this is only tested on an i.MX23 SoC yet.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
While this driver is plac
On 09/15/13 11:56, Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
>> For battery driven systems it is a very bad idea to collect the touchscreen
>> data within a kernel busy loop.
>>
>> This change uses the features of the hardware to delay an
"Jürgen Beisert" wrote:
>Hi Jonathan,
>
>On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
>> On 09/11/13 09:18, Juergen Beisert wrote:
>> > For battery driven systems it is a very bad idea to collect the
>> > touchscreen data within a kerne
On 09/16/13 09:17, Jürgen Beisert wrote:
> Hi Jonathan,
>
> On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
>> [...]
>>> +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
>>> +{
>>> + writel(va
.
"Jürgen Beisert" wrote:
>Hi Jonathan,
>
>On Monday 16 September 2013 17:30:32 Jonathan Cameron wrote:
>> >On Sunday 15 September 2013 12:56:25 Jonathan ,,, wrote:
>> >> On 09/11/13 09:18, Juergen Beisert wrote:
>> >> > For batt
rrupt and CPU load.
>
> Note: this is only tested on an i.MX23 SoC yet.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Please repost with Dmitry To
ong tree ;)
On 09/19/13 13:22, Juergen Beisert wrote:
> This is an RFC for the new touchscreen properties.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
>
1001 - 1076 of 1076 matches
Mail list logo
