On Sat, 8 Dec 2018 22:10:43 +0100
Greg KH wrote:
> On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> > Parts of this work came from contributions of Alexandru Ardelean and
> > Dragos Bogdan, I and Gabriel would like to thank for the insights
> > provided by their previous patches
On Mon, 10 Dec 2018 13:03:33 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Looks good to me. I'll let it sit for a few days though to give
time for a final review from anyone else who wants to and for
Rob to take a final
On Mon, 10 Dec 2018 13:03:33 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Hi Stefan, I've been a bit silly here and only been looking
at the 'new code' and assuming this was a straight copy.
Please could you split the p
On Wed, 10 Mar 2021 11:51:31 +0200
Alexandru Ardelean wrote:
> This change converts the driver to use device-managed functions in the
> probe function. For the clock and regulator disable, some
> devm_add_action_or_reset() calls are required, and then
> devm_iio_device_register() function can be
On Mon, 15 Mar 2021 19:07:11 +0530
Mugilraj Dhavachelvan wrote:
> Fixes a W=1 warning.
> -Added ``:`` to lock parameter in 'ad9832_state' description.
> -It's a reference comment so removed /**
>
> Signed-off-by: Mugilraj Dhavachelvan
Great. Thanks for tidying this up.
Applied to the togreg
place.
Otherwise reasonable cleanup.
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/ipu3/ipu3.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3.c
> b/drivers/staging/media/ipu3/ipu3.c
> index ee1bba6bdc
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Jonathan Cameron
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
On Wed, 28 Apr 2021 16:51:42 +0200
Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new AP
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
LGTM
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/tegra-vde/vde.c | 19 ---
> 1 file changed, 16 insertions(+), 3 deletions(-)
On Fri, 30 Apr 2021 18:08:36 +0100
Jonathan Cameron wrote:
> On Wed, 28 Apr 2021 16:51:46 +0200
> Mauro Carvalho Chehab wrote:
>
> > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > with usage counter")
> > added pm
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
NOP patch so
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/tegra-video/csi.c | 3 +--
> drivers/staging/media/tegra-video/vi.c | 3 +--
&g
On Wed, 28 Apr 2021 16:52:39 +0200
Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> While there's
On Tue, 18 May 2021 17:27:07 +0800
tangbin wrote:
> Hi Dan：
>
> On 2021/5/18 15:52, Dan Carpenter wrote:
> > On Mon, May 17, 2021 at 11:00:06PM +0800, Tang Bin wrote:
> >> @@ -730,11 +730,7 @@ static int ad7746_probe(struct i2c_client *client,
> >>if (ret < 0)
> >>return ret;
>
On Tue, 18 May 2021 13:16:26 +0300
Dan Carpenter wrote:
> On Tue, May 18, 2021 at 05:56:47PM +0800, Tang Bin wrote:
> > In the function ad7746_probe(), the initialized value of 'ret' is unused,
> > because it will be assigned by the function i2c_smbus_write_byte_data(),
> > thus remove it.
> >
>
On Tue, 15 Sep 2020 11:33:36 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/accel/adis16201.c | 16 +++--
On Tue, 15 Sep 2020 11:33:38 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/gyro/adis16136.c | 9 ++---
> 1
On Tue, 15 Sep 2020 11:33:42 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/imu/adis16480.c | 7 ++-
> 1 fil
On Tue, 15 Sep 2020 11:33:45 +0200
Nuno Sá wrote:
> Drop `adis_setup_buffer_and_trigger()`. All users were updated to use
> the devm version of this function. This avoids having almost the same
> code repeated.
>
> Signed-off-by: Nuno Sá
Good to see this cleanup, as long as we tidy up the few
On Tue, 15 Sep 2020 10:20:20 +
"Sa, Nuno" wrote:
> > -Original Message-
> > From: Jonathan Cameron
> > Sent: Tuesday, September 15, 2020 12:10 PM
> > To: Sa, Nuno
> > Cc: linux-...@vger.kernel.org; de...@driverdev.osuosl.org; Lar
On Mon, 25 Jan 2021 15:08:17 +0100
Greg KH wrote:
> On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote:
> > On Sun, Jan 24, 2021 at 4:58 AM Greg KH wrote:
> >
> > >
> > > David Lechner (1):
> > > counter:ti-eqep: remove floor
> >
> > I'm not sure why that ti-eqep counter
On 12 December 2018 08:31:32 GMT, Dan Carpenter
wrote:
>On Tue, Dec 11, 2018 at 05:55:02PM -0700, Jeremy Fertic wrote:
>> Based on the output of adt7316_show_all_DAC_update_modes() and
>> adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode()
>should
>> expect the user to enter an int
Rob, Clk experts, questions for you below.
Jonathan
On Thu, 13 Dec 2018 17:39:22 -0800
Stephen Boyd wrote:
> Quoting Jonathan Cameron (2018-12-08 07:29:54)
> > On Thu, 6 Dec 2018 11:10:51 +0200
> > Mircea Caprioru wrote:
> >
> > > This patch adds a clock to
On Tue, 11 Dec 2018 17:54:53 -0700
Jeremy Fertic wrote:
> Change two register addresses and one bit definition to match the
> datasheet.
>
> Signed-off-by: Jeremy Fertic
One comment inline. I added a fixes tag but also a note saying I would
not suggest backporting to stable.
There are too man
On Fri, 14 Dec 2018 09:18:20 +0300
Dan Carpenter wrote:
> On Thu, Dec 13, 2018 at 03:06:29PM -0700, Jeremy Fertic wrote:
> > On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote:
> > > On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote:
> > > > ADT7316_DA_EN_VIA_DAC_LDCA i
On Tue, 11 Dec 2018 17:54:55 -0700
Jeremy Fertic wrote:
> The only assignment to dac_bits is in adt7316_store_da_high_resolution().
> This function enables or disables 10 bit dac resolution for the adt7316/7
> and adt7516/7 when they're set to output voltage proportional to
> temperature. Remove
On Tue, 11 Dec 2018 17:54:57 -0700
Jeremy Fertic wrote:
> The calculation of the current dac value is using the wrong bits of the
> dac lsb register. Create two macros to shift the lsb register value into
> lsb position, depending on whether the dac is 10 or 12 bit. Initialize
> data to 0 so, wit
On Tue, 11 Dec 2018 17:54:58 -0700
Jeremy Fertic wrote:
> The lsb calculation is not masking the correct bits from the user input.
> Subtract 1 from (1 << offset) to correctly set up the mask to be applied
> to user input.
>
> The lsb register stores its value starting at the bit 7 position.
> a
On Tue, 11 Dec 2018 17:54:59 -0700
Jeremy Fertic wrote:
> The dac internal vref settings are part of the ldac config register rather
> than the dac config register. Change the variable being used so the read
> returns the correct result.
>
> Signed-off-by: Jeremy Fertic
Is this a follow through
On Tue, 11 Dec 2018 17:55:00 -0700
Jeremy Fertic wrote:
> With adt7516/7/9, internal vref is available for dacs a and b, dacs c and
> d, or all dacs. The driver doesn't currently support internal vref for all
> dacs. Change the else if to an if so both bits are checked rather than
> just one or t
On Tue, 11 Dec 2018 17:55:01 -0700
Jeremy Fertic wrote:
> The option to allow the external vref to bypass the reference buffer is
> only available for adt7316/7/8. Remove the attributes for adt751x as
> well as the chip->id checks from the show and store functions.
>
> Signed-off-by: Jeremy Fert
On Tue, 11 Dec 2018 17:55:02 -0700
Jeremy Fertic wrote:
> Based on the output of adt7316_show_all_DAC_update_modes() and
> adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode() should
> expect the user to enter an integer input from 0 to 3. The user input is
> currently expected to acco
On Tue, 11 Dec 2018 17:55:03 -0700
Jeremy Fertic wrote:
> Change LDCA to LDAC.
>
> Signed-off-by: Jeremy Fertic
Ah. Here it is ;) As commented on earlier.
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> driv
On Wed, 12 Dec 2018 22:17:46 +0530
Hardik Singh Rathore wrote:
> Initialization is unnecessary when the variable is written before it is
> read. There were some occasions in which the driver would initialize `ret'
> during declaration without need.
>
> Purely a cosmetic change with no functional
On Fri, 14 Dec 2018 01:13:35 +0530
Shreeya Patel wrote:
> ADT7316 driver no more uses platform data and hence use device tree
> data instead of platform data for assigning irq_type field and
> implement this in adt7316_irq_setup function.
> Switch case figures out the type of irq and if it's the
On Sat, 8 Dec 2018 16:19:08 -0200
Marcelo Schmitt wrote:
> Set a single voltage regulator for all voltage references.
> Remove voltage reference value from default platafrom data struct.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
App
On Sat, 8 Dec 2018 16:19:38 -0200
Marcelo Schmitt wrote:
> Add the option to specify the external clock (MCLK) using the clock
> framework.
> Also remove the old platform data structure.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
App
On Mon, 10 Dec 2018 21:27:02 +
Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 16:19:59 -0200
> Marcelo Schmitt wrote:
>
> > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > converter, network analyzer.
> >
> > Signed-off-by: Marcelo Sc
On Wed, 12 Dec 2018 23:27:07 +0530
Hardik Singh Rathore wrote:
> Initialization is unnecessary when the variable is written before it is
> read. There were some occasions in which the driver would initialize `ret'
> during declaration without need.
>
> Signed-off-by: Hardik Singh Rathore
Applie
On Thu, 13 Dec 2018 14:46:15 +0200
Stefan Popa wrote:
> This patch replaces the use of wait_event_interruptible() with
> wait_for_completion_timeout() when reading the result of a single
> conversion. In this way, if the interrupt never occurs, the program will
> not remain blocked.
>
> Signed-o
On Thu, 13 Dec 2018 14:46:16 +0200
Stefan Popa wrote:
> Switch to devm version of request_irq, iio_triggered_buffer_setup,
> iio_device_register. To avoid potential ordering issues in probe,
> devm_add_action_or_reset() is used for the regulator_disable(). This
> simplifies the code and decreases
On Thu, 13 Dec 2018 14:46:17 +0200
Stefan Popa wrote:
> This patch replaces the use of a polling ring buffer with a threaded
> interrupt.
>
> Enabling the buffer sets the CONVST signal to high. When the rising edge
> of the CONVST is applied, BUSY signal goes logic high and transitions low
> at
On Thu, 13 Dec 2018 14:46:18 +0200
Stefan Popa wrote:
> When looking for the available scale or oversampling ratio, it is better
> to use the find_closest() macro. This simplifies the code and also does
> not require an exact value to be entered from the user space.
>
> Signed-off-by: Stefan Pop
On Thu, 13 Dec 2018 14:46:19 +0200
Stefan Popa wrote:
> The 'adi' vendor prefix needs to be added to conversion-start, range,
> first-data and oversampling-ratio properties.
>
> Signed-off-by: Stefan Popa
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to
On Thu, 13 Dec 2018 14:46:20 +0200
Stefan Popa wrote:
> The driver does not have a struct of_device_id table, but supported
> devices are registered via Device Trees. This patch adds and OF device
> ID table.
>
> Signed-off-by: Stefan Popa
Applied.
Thanks,
Jonathan
> ---
> drivers/staging/i
On Thu, 13 Dec 2018 14:46:21 +0200
Stefan Popa wrote:
> * Placed includes in alphabetical order
> * Added brackets around num and mask through out for AD760X_CHANNEL
> * Used single line comments where needed
> * Removed extra lines and spaces
>
> Signed-off-by: Stefan Popa
Looks fine, but unsu
On Thu, 13 Dec 2018 14:46:23 +0200
Stefan Popa wrote:
> Document support for AD7606 Analog to Digital Converter.
>
> Signed-off-by: Stefan Popa
> Reviewed-by: Rob Herring
Will have to wait on this as the MAINTAINERS bit obviously isn't there yet.
Otherwise I would have just added it now. Oh w
On Thu, 13 Dec 2018 14:46:22 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Other than the things already mentioned in earlier patches, looks good to
me.
Thanks
Jonathan
> ---
> MAINTAINERS |
On Tue, 18 Dec 2018 01:06:01 +0300
Sergey Efimochkin wrote:
> staging: iio: adc: ad7280a: fix codestyle in ad7280_event_handler
> Signed-off-by: Sergey Efimochkin
Hi,
I wouldn't say this is a real improvement on readability.
If you are really determined to 'fix it', then I would suggest introdu
On Fri, 21 Dec 2018 15:26:26 -0800
Amir Mahdi Ghorbanian wrote:
> Replaced bool in struct with unsigned int bitfield to conserve space and
> more clearly define size of varibales
>
> Signed-off-by: Amir Mahdi Ghorbanian
Hi Amir,
I'm a bit in two minds on this one. It's not a size critical str
On Mon, 17 Dec 2018 14:23:35 +0200
Stefan Popa wrote:
> There is no point in having three menu entries that can be selected
> individually. Instead, the SPI and parallel interfaces should select
> AD7606.
>
> Signed-off-by: Stefan Popa
I think this looks right, but I've gotten these wrong too m
On Mon, 17 Dec 2018 14:23:36 +0200
Stefan Popa wrote:
> This patch replaces the license text at the top of ad7606 driver files
> and instead adds SPDX GPL-2.0 license identifier.
>
> Signed-off-by: Stefan Popa
> ---
> drivers/staging/iio/adc/ad7606.c | 5 ++---
> drivers/staging/iio/adc/ad
On Mon, 17 Dec 2018 14:23:37 +0200
Stefan Popa wrote:
> This patch replaces the use of a polling ring buffer with a threaded
> interrupt.
>
> Enabling the buffer sets the CONVST signal to high. When the rising edge
> of the CONVST is applied, BUSY signal goes logic high and transitions low
> at
On Mon, 17 Dec 2018 14:23:38 +0200
Stefan Popa wrote:
> * Placed includes in alphabetical order
> * Added brackets around num and mask through out for AD760X_CHANNEL
> * Used single line comments where needed
> * Removed extra lines and spaces
>
> Signed-off-by: Stefan Popa
Applied.
Thanks,
J
On Mon, 17 Dec 2018 14:23:39 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Obviously the license detail change in patch 2 made this 'amusing' to
apply. I think I got it in right, but please check I didn't mess it up.
Ap
On Mon, 17 Dec 2018 14:23:40 +0200
Stefan Popa wrote:
> Document support for AD7606 Analog to Digital Converter.
>
> Signed-off-by: Stefan Popa
> Reviewed-by: Rob Herring
Applied to the togreg branch of iio.git and pushed out as testing
for this to be mostly ignored. Thanks,
Jonathan
> ---
On Mon, 17 Dec 2018 14:30:59 -0700
Jeremy Fertic wrote:
> On Sun, Dec 16, 2018 at 11:37:56AM +0000, Jonathan Cameron wrote:
> > On Tue, 11 Dec 2018 17:54:55 -0700
> > Jeremy Fertic wrote:
> >
> > > The only assignment to dac_bits is in adt7316_store_da_high_res
+CC Jeremy who is also working with this device.
On Sun, 23 Dec 2018 19:32:24 +0530
Shreeya Patel wrote:
> Both i2c and spi drivers have functions for reading and writing
> to/from registers. Remove this redundant and common code by using
> regmap API.
> Also remove multi_read and multi_write fu
+ CC Shreeya who is working on the same driver.
On Sat, 22 Dec 2018 21:57:40 -0700
Jeremy Fertic wrote:
> The value of dac_bits is used in adt7316_show_DAC() and adt7316_store_DAC(),
> and it should be either 8, 10, or 12 bits depending on the device in use. The
> driver currently only assigns a
On Sat, 22 Dec 2018 21:57:41 -0700
Jeremy Fertic wrote:
> The adt7316/7 and adt7516/7 have the option to output voltage proportional
> to temperature on dac a and/or dac b. The default dac resolution in this
> mode is 8 bits with the dac high resolution option enabling 10 bits. None
> of these se
On Sat, 22 Dec 2018 21:57:42 -0700
Jeremy Fertic wrote:
> The calculation of the current dac value is using the wrong bits of the
> dac lsb register. Create two macros to shift the lsb register value into
> lsb position, depending on whether the dac is 10 or 12 bit. Initialize
> data to 0 so, wit
On Sat, 22 Dec 2018 21:57:43 -0700
Jeremy Fertic wrote:
> The lsb calculation is not masking the correct bits from the user input.
> Subtract 1 from (1 << offset) to correctly set up the mask to be applied
> to user input.
>
> The lsb register stores its value starting at the bit 7 position.
> a
On Sat, 22 Dec 2018 21:58:25 -0500
indigo omega wrote:
> Hello Jonathan,
>
> I'd be happy to help cleanup this driver, and I'd greatly appreciate some
> direction as to what needs to be done.
>
> Thank you,
>
> Amir Ghorbanian
Sure, I'll give the current state a quick review...
Major items
On Mon, 7 Jan 2019 23:27:48 +0530
Himanshu Jha wrote:
> On Wed, Jan 02, 2019 at 01:25:27PM -0800, Matt Ranostay wrote:
> >
> > > On Dec 24, 2018, at 01:58, Himanshu Jha
> > > wrote:
> > >
> > >> On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
> > >> Replaced bool in
...
> > > diff --git a/drivers/staging/iio/addac/adt7316.h
> > > b/drivers/staging/iio/addac/adt7316.h
> > > index fd7c5c92b599..2c72cf3f71cd 100644
> > > --- a/drivers/staging/iio/addac/adt7316.h
> > > +++ b/drivers/staging/iio/addac/adt7316.h
> > > @@ -11,16 +11,13 @@
> > >
> > > #include
On Fri, 18 Jan 2019 18:19:40 -0200
Renato Lui Geh wrote:
> Hi,
>
> Sorry for the (extremely) late reply.
>
> Comments inline.
>
> Renato
>
> On 12/01, Jonathan Cameron wrote:
> >On Thu, 29 Nov 2018 11:02:46 -0200
> >Giuliano Augusto Faulin Belinas
On Sun, 20 Jan 2019 00:09:30 +0530
Shreeya Patel wrote:
> interrupt request is not needed to be present in the bus
> structure. It is a good option to pass it as a parameter
> in the probe function instead of having it in the bus structure.
>
> Signed-off-by: Shreeya Patel
Hi Shreeya,
I just t
On Sun, 20 Jan 2019 00:09:29 +0530
Shreeya Patel wrote:
> This patchset consist of some initial patches for heading
> towards the regmap implementation and also the final patch
> which enables the driver to use regmap API thus removing
> the redundant and common code.
>
> Shreeya Patel (3):
>
On Fri, 25 Jan 2019 10:19:54 +0200
Alexandru Ardelean wrote:
> On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro wrote:
> >
> > Remove the checkpatch.pl check:
> >
> > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
>
> Hey,
>
> A bit curios about this one.
> Are you using this chip/
On Fri, 25 Jan 2019 22:14:32 -0200
Rodrigo Ribeiro wrote:
> Em sex, 25 de jan de 2019 às 21:46, Rodrigo Ribeiro
> escreveu:
> >
> > Em sex, 25 de jan de 2019 às 06:20, Alexandru Ardelean
> > escreveu:
> > >
> > > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro
> > > wrote:
> > > >
> > > >
On Sat, 26 Jan 2019 23:04:02 +0530
Shreeya Patel wrote:
> Both i2c and spi drivers have functions for reading and writing
> to/from registers. Remove this redundant and common code by using
> regmap API.
>
> Signed-off-by: Shreeya Patel
I hadn't previously looked closely at the spi side of thi
On Sun, 27 Jan 2019 18:33:52 -0200
Renato Lui Geh wrote:
> Move ad7780 ADC driver out of staging and into the mainline.
>
> The ad7780 is a sigma-delta analog to digital converter. This driver provides
> reading voltage values and status bits from both the ad778x and ad717x series.
> Its interfa
On Tue, 29 Jan 2019 16:31:00 -0200
Camylla Cantanheide wrote:
> From: Feulo
>
> Align broken line to match upper line parenthesis. Solves the
> checkpatch.pl's message
>
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Feulo
For reference should be full name (though I'm o
On Fri, 1 Feb 2019 17:01:37 +0200
Beniamin Bia wrote:
> From: Beniamin Bia
>
> The values from platform data were replaced by statically values.
> This was just a intermediate step of taking this driver out of staging and
> load data from device tree.
>
> Signed-off-by: Beniamin Bia
Applied t
On Fri, 1 Feb 2019 17:01:38 +0200
Beniamin Bia wrote:
> From: Beniamin Bia
>
> The clock frequency is loaded from device-tree using clock framework
> instead of statically value. The change allow configuration of
> the device via device-trees and better initialization sequence.
> This is part o
On Tue, 5 Feb 2019 15:13:00 -0200
Renato Lui Geh wrote:
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
>
> Signed-off-by: Renato Lui Geh
> Signed-off-by: Giuliano Belinassi
> Co-developed-by: Giuliano Be
On Tue, 5 Feb 2019 15:13:21 -0200
Renato Lui Geh wrote:
> To maintain consistency between ad7780_probe and ad7780_remove orders,
> regulator initialization has been moved to after GPIO initializations.
>
> Signed-off-by: Renato Lui Geh
This looks fine, will pick up with the earlier patches when
On Tue, 5 Feb 2019 15:14:03 -0200
Renato Lui Geh wrote:
> Move ad7780 ADC driver out of staging and into the mainline.
>
> The ad7780 is a sigma-delta analog to digital converter. This driver provides
> reading voltage values and status bits from both the ad778x and ad717x series.
> Its interfac
On Wed, 6 Feb 2019 14:25:41 +0200
Beniamin Bia wrote:
> From: Beniamin Bia
>
> Frequency attribute is added with a standard type from iio framework
> instead of custom attribute. This is a small step towards removing any
> unnecessary custom attribute.
>
> Signed-off-by: Beniamin Bia
Hi,
Ho
On Wed, 6 Feb 2019 14:05:41 +0200
Beniamin Bia wrote:
> Frequency attribute is added with a standard type from iio framework
> instead of custom attribute. This is a small step towards removing any
> unnecessary custom attribute.
>
> Signed-off-by: Beniamin Bia
> ---
> drivers/staging/iio/freq
On Wed, 6 Feb 2019 14:05:42 +0200
Beniamin Bia wrote:
> The custom phase and scale attributes were moved to standard iio types.
>
> Signed-off-by: Beniamin Bia
Similar comments apply as to patch 1.
Jonathan
> ---
> drivers/staging/iio/frequency/ad9834.c | 54 +++---
> 1 fi
On Thu, 14 Feb 2019 10:51:49 +
"Popa, Stefan Serban" wrote:
> On Mi, 2019-02-13 at 22:25 -0200, Rodrigo Ribeiro wrote:
> > [External]
> >
> >
> > Em ter, 29 de jan de 2019 às 07:10, Alexandru Ardelean > l.com> escreveu:
> > >
&g
On Thu, 14 Feb 2019 18:31:12 -0200
Renato Lui Geh wrote:
> Hi Jonathan,
>
> Thanks for the review. Comments inline.
>
> Renato
>
> On 02/09, Jonathan Cameron wrote:
> >On Tue, 5 Feb 2019 15:13:00 -0200
> >Renato Lui Geh wrote:
> >
> >> Previ
On Thu, 14 Feb 2019 18:48:15 -0200
Renato Lui Geh wrote:
> On 02/09, Jonathan Cameron wrote:
> >On Tue, 5 Feb 2019 15:14:03 -0200
> >Renato Lui Geh wrote:
> >
> >> Move ad7780 ADC driver out of staging and into the mainline.
> >>
> >> The ad7
On Thu, 14 Feb 2019 18:41:29 +0200
Beniamin Bia wrote:
> Frequency attribute is added with a standard type from iio framework
> instead of custom attribute. This is a small step towards removing any
> unnecessary custom attribute. Ad9834 will diverge from ad9833 in the
> future, that is why we ha
On Thu, 14 Feb 2019 18:41:30 +0200
Beniamin Bia wrote:
> The custom phase and scale attributes were moved to standard iio types.
>
> Signed-off-by: Beniamin Bia
Hi,
This hits the same fundamental questions of ABI as the FSK
elements in the previous patch, just now for Phase Shift Keying.
Unf
...
>
> Thanks for answering Jonathan and Stefan.
>
> I would like to contribute with the ad7150 driver. Could you please
> give me some hints on what can I do to move this driver
> out of staging?
>
> I note that device registration (devm_iio_device_register) is not
> the last function called a
On Fri, 1 Mar 2019 06:56:14 +
"Ardelean, Alexandru" wrote:
> On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote:
> >
> >
> > Previously, the AD7780 driver only supported gpio for the 'powerdown'
> > pin. This commit adds suppport for the 'gain' and 'filter' pin.
> >
> > Signed-off-by:
On Fri, 1 Mar 2019 07:17:04 +
"Ardelean, Alexandru" wrote:
> On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
> >
> >
> > The AD7780 driver contains status pattern bits designed for checking
> > whether serial transfers have been correctly performed. Pattern macros
> > were previous
On Fri, 1 Mar 2019 07:38:45 +
"Ardelean, Alexandru" wrote:
> On Thu, 2019-02-28 at 11:25 -0300, Renato Lui Geh wrote:
> >
> >
> > To maintain consistency between ad7780_probe and ad7780_remove orders,
> > regulator initialization has been moved to after GPIO initializations.
> >
> > Signed
On Thu, 28 Feb 2019 11:26:28 -0300
Renato Lui Geh wrote:
> Adds a device tree binding for the ad7780 driver.
>
> Signed-off-by: Renato Lui Geh
Looks good to me, but we'll see if Rob picks up on things
I've missed.
Jonathan
> ---
> .../bindings/iio/adc/adi,ad7780.txt | 48 ++
On Thu, 28 Feb 2019 11:26:08 -0300
Renato Lui Geh wrote:
> Move ad7780 ADC driver out of staging and into the mainline.
>
> The ad7780 is a sigma-delta analog to digital converter. This driver provides
> reading voltage values and status bits from both the ad778x and ad717x series.
> Its interfa
On Sat, 2 Mar 2019 19:07:16 +
Jonathan Cameron wrote:
> On Fri, 1 Mar 2019 07:17:04 +
> "Ardelean, Alexandru" wrote:
>
> > On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
> > >
> > >
> > > The AD7780 driver contains sta
On Mon, 25 Feb 2019 21:17:30 +0200
Beniamin Bia wrote:
> Frequency attribute is added with a standard type from iio framework
> instead of custom attribute. This is a small step towards removing any
> unnecessary custom attribute. Ad9834 will diverge from ad9833 in the
> future, that is why we ha
On Mon, 25 Feb 2019 21:17:31 +0200
Beniamin Bia wrote:
> The custom phase and scale attributes were moved to standard iio types.
>
> Signed-off-by: Beniamin Bia
> ---
> Changes in v3:
> -abi documentation added
>
> .../testing/sysfs-bus-iio-frequency-ad9834| 10 ++--
> drivers/sta
On Sun, 3 Mar 2019 11:01:09 -0300
Renato Lui Geh wrote:
> On 03/01, Ardelean, Alexandru wrote:
> >On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
> >>
> >>
> >> The ad7780 supports both the ad778x and ad717x families. Each chip has
> >> a corresponding ID. This patch provides a mask fo
On Fri, 22 Feb 2019 13:10:26 +
"Bia, Beniamin" wrote:
> Thank you for taking some time reviewing my code.
> Ad9833/ad9834 has two frequency and phase registers and only one
> output. The user can select which register is selected as input with a
> mux.Because I wanted to reduce as much as pos
osed interface. Certainly, if they are in one series,
put the doc patch at the end and just document the result.
Jonathan
>
> Thanks,
> Ben
> ________
> From: Jonathan Cameron
> Sent: Sunday, March 3, 2019 15:28
> To: Beniamin Bia
> Cc: l...@met
On Fri, 8 Mar 2019 21:19:29 -0300
Renato Lui Geh wrote:
> On 03/04, Ardelean, Alexandru wrote:
> >On Sun, 2019-03-03 at 14:53 +, Jonathan Cameron wrote:
> >> [External]
> >>
> >>
> >> On Sun, 3 Mar 2019 11:01:09 -0300
> >> Renato Lui G
On Mon, 11 Mar 2019 11:31:59 +0300
Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote:
> > On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
> > wrote:
> > >
> > > Add spaces around minus operator to fix readibility.
> > >
> > > Signed-off-by: Karen Palacio
On Fri, 15 Mar 2019 23:12:27 -0300
Renato Lui Geh wrote:
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
>
> Signed-off-by: Renato Lui Geh
> Signed-off-by: Giuliano Belinassi
> Co-developed-by: Giuliano B
101 - 200 of 1076 matches
Mail list logo
