[PATCH v6 6/8] staging: rtl8192e: Correct declaration of HTResetIOTSetting - Coding Style

Declaration of function was spread over three lines. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u

[PATCH v6 7/8] staging: rtl8192e: Optimise Comparison to NULL tests - Coding Style

Change comparison to NULL to better adhere to coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers

[PATCH v6 4/8] staging: rtl8192e: Correct alignment of if statements - Coding Style

Function HTIOTPeerDetermine used incorrect indentation in if statements. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

Re: [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

On Fri, Jun 08, 2018 at 03:18:51PM +0300, Dan Carpenter wrote: > On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote: > > @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device > > *ieee) > > pHTInfo->CurrentAMPDUFactor

[PATCH v7 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

Remove unneccessary parentheses, and removed unnecessary (void *) cast Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

Re: staging: rtl8192e: Series of coding style changes

On Wed, Jun 06, 2018 at 12:39:55PM +0100, John Whitmore wrote: > Version 6 : Sorry to send this out again but version 5 contained a little less > verbosity then required. > > Again these are just some simple coding style changes to the file, so nothing > of importance. > Rec

[PATCH 2/9] staging: rtl8192u: Correct indentation of switch statement - Coding Style

Removed an extra indentation from the code of the various case options in a switch statement. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style

Changed a number of hard coded function names to use %s and __func__ Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

[PATCH 6/9] staging: rtl8192u: Remove braces from single statement blocks - Style

Removed the unrequired braces from single statement blocks - Coding Style. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

[PATCH 9/9] staging: rtl8192u: Correction of spelling mistake in comment.

Simple spelling correction. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index

[PATCH 7/9] staging: rtl8192u: Correciton of block comments - Coding Style

Correcton of a few block comments to comply with Coding Style. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers

[PATCH 1/9] staging: rtl8192u: change block comments to prefered style - Coding Style

Some of the comment blocks are commening out code so have been left for the moment. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 366 ++ 1 file changed, 195 insertions(+), 171 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 3/9] staging: rtl8192u: Truncate block comments to 80 character length - Style

Where possible truncation of block comments to the 80 character length prefered by the coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 157 +++--- 1 file changed, 98 insertions(+), 59 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 8/9] staging: rtl8192u: Correct if statement - Coding Style

Corrected the coding style of if statement. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211

v1 Coding style changes

Simple coding style changes to single file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4/9] staging: rtl8192u: Removal of white space from end of lines - Coding Style

Previous truncation of comment blocks to 80 character line length resulted in some white space at endof line. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging

V2 Coding style changes. Plus one change to use memset()

Simple coding style changes to single file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c Given feedback on some of the comments, I truncated to the 80 character limit, in code, (as opposed to function block comments). I have left a number of the contentious comments as they are. Another pie

[PATCH v2 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

Replaced memory initialising loop with memset, as suggested by Andy Shevchenko Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

[PATCH v2 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style

Changed a number of hard coded function names to use %s and __func__ Mailing list response suggest that there is a better method for debugging using netdev_dbg(). I can't argue with that, but for the moment this change will clear the checkpatch.pl Warning. Signed-off-by: John Whi

<    2   3   4   5   6   7