[PATCH 19/21] staging:rtl8192u: Rename ExtHTCapInfo - Style

is is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --g

[PATCH 13/21] staging:rtl8192u: Rename Rsvd1 - Style

ntime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h index 7f11257e2675..132a6da3bf51

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > On 08/29/2018 04:14 PM, Joe Perches wrote: > > On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue > > > with CamelCase na

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Thu, Aug 30, 2018 at 11:26:28AM +0300, Dan Carpenter wrote: > On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote: > > > Rename the bit field element AdvCoding, as it causes a checkpatch issue &g

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On Thu, Aug 30, 2018 at 03:34:01PM -0700, Joe Perches wrote: > On Wed, 2018-08-29 at 22:55 +0100, John Whitmore wrote: > > On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote: > > > On 08/29/2018 04:14 PM, Joe Perches wrote: > [] > > > > Perhaps support f

[PATCH 03/20] staging:rtl8192u: Remove unused functions - Style

Remove unused function declarations. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 10 -- drivers/staging/rtl8192u/r8192U_core.c | 7 --- 2 files changed, 17 deletions

[PATCH 10/20] staging:rtl8192u: Rename PHY_Beacon_RSSI_SLID_WIN_MAX - Style

Rename the Macro PHY_Beacon_RSSI_SLID_WIN_MAX to PHY_BEACON_RSSI_SLID_WIN_MAX, this clears the checkpatch issue with CamelCase naming. This is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 14/20] staging:rtl8192u: Rename Offset - Style

Rename the member variable 'Offset' to 'offset', this clears the checkpatch issue with CamelCase naming. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- driv

[PATCH 15/20] staging:rtl8192u: Rename Reserved... structure members - Style

Rename the 'Reserved...' members of the 'tx_desc_819x_usb' structure to 'reserved...'. This change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore

[PATCH 19/20] staging:rtl8192u: Rename LINIP - Style

Rename the member variable 'LINIP' to 'linip', this change is to conform to the coding style guidelines, member variables in lowercase. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/stagi

[PATCH 16/20] staging:rtl8192u: Rename CmdInit - Style

Rename the member variable 'CmdInit, to 'cmd_init', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 18/20] staging:rtl8192u: Rename FirstSeg - Style

Rename the member variable 'FirstSeg' to 'first_seg', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change and as such should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl819

[PATCH 17/20] staging:rtl8192u: Rename LastSeg - Style

Rename the member variable 'LastSeg' to 'last_seg', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 05/20] staging:rtl8192u: Rename RTL819xU_MODULE_NAME - Style

Rename the MACRO RTL819xU_MODULE_NAME to RTL819XU_MODULE_NAME, this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers

[PATCH 00/20] staging:rtl8192u: r8192U.h cleanup - Style

Yet another series of patchs to cleanup and clear some checkpatch isses, this time the file r8192U.h. These are all simple changes which are mostly renaming variables. A MACRO has been removed as it's not used in the code, and added SPDX-License-Identifier. John Whitmore (20): staging:rtl

[PATCH 01/20] staging:rtl8192u: Remove write_cam() - Style

Remove the function write_cam() as it is unused. Simple style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 1 - drivers/staging/rtl8192u/r8192U_core.c | 7 --- 2 files changed, 8 deletions(-) diff --git a

[PATCH 04/20] staging:rtl8192u: Add SPDX-License-Identifier - Style

Add SPDX-License-Identifier tag to the start of header file. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u

[PATCH 07/20] staging:rtl8192u: Refactor RT_TRACE - Style

Refactor the MACRO RT_TRACE to add parentheses around the parameter 'component', this clears the checkpatch warning with respect to precedence issues. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/stagin

[PATCH 02/20] staging:rtl8192u: Remove read_cam() - Style

Remove the function read_cam(), as it is unused in code. Simple style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 -- drivers/staging/rtl8192u/r8192U_core.c | 9 - 2 files changed, 11 deletions

[PATCH 13/20] staging:rtl8192u: Rename PktSize Style

Rename the member variable 'PktSize' to 'pkt_size', this change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h

[PATCH 20/20] staging:rtl8192u: Rename OWN - Style

Rename the member variable 'OWN' to 'own', this is to comply with the coding standard, where variables are named in lowercase. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl819

[PATCH 08/20] staging:rtl8192u: Fix space characters - Style

Fix the spacing issues, remove space after cast operation, and replace spaces at start of line with tab. These changes are purely coding style changes to resolve checkpatch issues. There should be no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 11/20] staging:rtl8192u: Rename OFDM_Table_Length - Style

Rename the defined constant OFDM_Table_Length to OFDM_TABLE_LENGTH, this clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h| 2 +- drivers

[PATCH 09/20] staging:rtl8192u: Remove RT_DEBUG_DATA - Style

Remove the RT_DEBUG_DATA Macro. The macro causes a number of checkpatch issues, and is not actually used in code, so can simply be removed without issue. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 12/20] staging:rtl8192u: Rename CCK_Table_length - Style

Rename the constant CCK_Table_length to CCK_TABLE_LENGTH, this clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h| 2 +- drivers/staging

[PATCH 06/20] staging:rtl8192u: Rename Rx_Smooth_Factor - Style

Rename the MACRO Rx_Smooth_Factor to RX_SMOOTH_FACTOR, this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging

[PATCH 0/1] staging:rtl8192u: Fix naming clash of exported symbol

I can only apologise for the oversight, sorry. John Whitmore (1): staging:rtl8192u: Rename dot11d_init to fix name clash drivers/staging/rtl8192u/ieee80211/dot11d.c | 6 +++--- drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 3 files chang

[PATCH 1/1] staging:rtl8192u: Rename dot11d_init to fix name clash

The function dot11d_init() was previously renamed to clear a style issue. Unfortunately the new name used, dot11d_init(), clashes with a sybmol which is exported with the same name. To correct this problem the function has been renamed to rtl8192u_dot11d_init(). Signed-off-by: John Whitmore

Coding Style of drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

There were a lot of coding style issues with this file, but I think I've reduced the number down to mainly line length and CamelCase issues. I've put it in 13 patches to, hopefully, make it easier to review, and see that I've made no changes to functionality of the code, (I hope). John __

[PATCH 02/13] coding style chages to the switch statements in the file.

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93 ++ 1 file changed, 44 insertions(+), 49 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index

[PATCH 01/13] Coding style changes to block comments

The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of coding style issues, this will be the first of many small patches which clear up some, if not all, of the problems with the file. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 319

[PATCH 04/13] coding style corrections, spaces around ', ' characters and removal of blank lines

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 134 +++-- 1 file changed, 42 insertions(+), 92 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index

[PATCH 03/13] coding style corrections for if statements

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 273 + 1 file changed, 112 insertions(+), 161 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index

[PATCH 09/13] Coding style, corrected bad indentation of a statement.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 254d536c21d8..f26b01c56d66

[PATCH 13/13] Coding style, corrected an indentation issue, (use tabs).

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index af6508dfd897..7a765b022f8c

[PATCH 07/13] Coding style, removal of redundant returns from void functions.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 13f1eee7d8b1..56cc1192cf9f 100644 --- a

[PATCH 05/13] Coding style corrections. Added spaces around operators.

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 148 ++--- 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index

[PATCH 11/13] Coding style: corrections to for statements.

I few other minor coding style issues. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 42 ++ 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u

[PATCH 08/13] Coding style, added blank line after declarations.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 56cc1192cf9f

[PATCH 10/13] Coding style: Removal of prohibited spaces.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index f26b01c56d66

[PATCH 12/13] Coding style, removal of braces from single statement blocks

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 742eb35ae442

[PATCH 06/13] Coding style, removal of redundant braces.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 925a8f313e9f

[PATCH 02/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: space before ', '

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that ',' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 07/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct indentation of switch statements

Coding style edit to clear the checkpatch.pl error: ERROR: switch and case should be at the same indent Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 01/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: that open brace { should be on the previous line Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 197 - 1 file changed, 70 insertions(+), 127 deletions(-) diff

[PATCH 03/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct space before ')'

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) di

[PATCH 09/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

Coding style edit to clear the checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 04/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct spaces around operators

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: spaces required around that... Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 122 ++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging

[PATCH 08/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct whitespace style errors

Coding style edit to clear the remaining checkpatch.pl errors: ERROR: trailing whitespace ERROR: space prohibited after that open parenthesis '(' ERROR: space required before the open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT

[PATCH 10/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added missing blank line after declarations.

Coding style edit to clear the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 15/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Use __func__ instead of hardcoded function name

Coding style edit to clear the checkpatch.pl warnings: WARNING: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--

coding style changes to drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

Second attempt at this commit, apologies for that. Coding style changes to resolve some of the scripts/checkpatch.pl issues with the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c. There remain line length and CamelCase issues unresolved in the file. ___

[PATCH 17/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added blank line after function

Coding style edit to clear the checkpatch.pl check: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging

[PATCH 24/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of NULL tests

Coding style edit to clear the checkpatch.pl check: CHECK: Comparison to NULL could be written "!..." Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/stagin

[PATCH 16/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed blank lines before closing brace

Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/s

[PATCH 18/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Removed blank lines after opening brace

Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 06/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces of else statement

Coding style edit to clear the checkpatch.pl error: ERROR: space required after that close brace '}' And balanced the brace of the same else statement: CHECK: Unbalanced braces around else statement Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT

[PATCH 14/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comment style

Coding style edit to clear the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH 19/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed extra blank lines

Coding style edit to clear the checkpatch.pl check: CHECK: Please don't use multiple blank lines Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee

[PATCH 11/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comments

Coding style edit to clear the checkpatch.pl Warnings: WARNING: Block comments should align the * on each line Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 181 +++-- 1 file changed, 97 insertions(+), 84 deletions(-) diff --git a/drivers

[PATCH 13/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant braces

Coding style edit to clear the checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 21/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected indentation

Coding style edit to clear the checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 05/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct missing space before '('

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space required before the open parenthesis '(' Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 176 ++--- 1 file changed, 87 insertions(+), 89 deletions(-) di

[PATCH 26/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Spelling correction in a comment

Spelling correction in comment: singal -> signal Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80

[PATCH 25/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added prefered spacing around operators

Coding style edit to clear the checkpatch.pl check: CHECK: spaces preferred around that 'x' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/stagin

[PATCH 27/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

Coding style edit to clear the checkpatch.pl warnings: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 22/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of a function declaration

Coding style edit to clear the checkpatch.pl check: CHECK: Lines should not end with a '(' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 12/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed space from start of line

Coding style edit to clear the checkpatch.pl warning: WARNING: please, no spaces at the start of a line Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 23/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed unnecessary parentheses

Coding style edit to clear the checkpatch.pl check: CHECK: Unnecessary parentheses around ... Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

driverdev-devel@linuxdriverproject.org

Coding style edit to clear the checkpatch.pl check: CHECK: spaces preferred around that '&' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8

[Patch v3] staging: rtl8192e: Clear coding sytle errors

Clear various coding style errors in drivers/staging/rtl8192u/ieee80211//rtl819x_HTProc.c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 1/7] staging: rtl8192e: Remove blank space before ', ' - coding style.

Corrected coding style issue: "ERROR: space prohibited before that ','" Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x

[PATCH v3 2/7] staging: rtl8192e: Added blank space around ':' - coding style.

Corrected coding style issue: "ERROR: spaces required around that ':'" Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/stagin

[PATCH v3 4/7] staging: rtl8192e: Added blank space around operators - coding style.

Corrected coding style issue: ERROR: spaces required around that '==' etc. etc. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 108 ++--- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH v3 3/7] staging: rtl8192e: Add blank space before '(' - coding style.

Corrected coding style issue: "ERROR: space required before the open parenthesis '('" Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 166 ++--- 1 file changed, 83 insertions(+), 83 deletions(-) diff --git a/driv

[PATCH v3 6/7] staging: rtl8192e: Remove blank space before or after '(' & ')' - style.

Corrected coding style issues: ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 ++-- 1 file changed,

[PATCH v3 5/7] staging: rtl8192e: Correct style of braces - coding style.

Corrected coding style issue: ERROR: that open brace { should be on the previous line Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 203 - 1 file changed, 72 insertions(+), 131 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH v3 7/7] staging: rtl8192e: Correct indentation of 'switch' & remove trailing spaces

Corrected coding style issues: ERROR: switch and case should be at the same indent ERROR: trailing whitespace Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 49 +++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH v4 3/5] staging: rtl8192e: Correct indentation of switch statements - coding style

Two switch statements had wrong indentation of 'case' options Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_H

[PATCH v4 4/5] staging: rtl8192e: Add and remove blank lines - Coding style

Coding style requires blank line after definitions and function definition, blank lines removed. Correction of some indentation. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 96 -- 1 file changed, 34 insertions(+), 62 deletions

[PATCH v4 5/5] staging: rtl8192e: Remove unrequired blank lines - Coding Style

Missed these in the last pass. Coding style does not require blank line after opening brace of a function. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH v4 1/5] staging: rtl8192e: Add spaces where required by coding standard

There were numerous coding syle errors in this file where spaces were required around operators. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 126 ++--- 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/staging

[PATCH v4] staging: rtl8192e: Coding style changes

five patches with simple coding style changes to the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c The last two patches should probably have been combined as both dealt with the addition or removal of blank lines, but I missed one style issue on the first pass. In that situation I guess

[PATCH v4 2/5] staging: rtl8192e: correct position of '{', '}', '(' and ')' - coding style

Correct the coding style of parenthesis and braces in various code blocks Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 217 - 1 file changed, 79 insertions(+), 138 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

staging: rtl8192e: Series of coding style changes

Another attempt at cleaning up some of the coding style issues with this file. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v5 3/8] staging: rtl8192e: Remove unnecessary return statements - Coding style

Return statments from void functions are not required by the coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging

[PATCH v5 1/8] staging: rtl8192e: Add and remove blank lines - Coding style

Simple addition & removal of blank lines as required Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +-- 1 file changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/sta

[PATCH v5 7/8] staging: rtl8192e: Optimise Comparison to NULL tests - Coding Style

Change comparison to NULL to better adhere to coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers

[PATCH v5 4/8] staging: rtl8192e: Correct alignment of if statements - Coding Style

Function HTIOTPeerDetermine used incorrect indentation in if statements. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

[PATCH v5 6/8] staging: rtl8192e: Correct declaration of HTResetIOTSetting - Coding Style

Declaration of function was spread over three lines. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u

[PATCH v5 2/8] staging: rtl8192e: Addition of prefered spacing - Coding style

Added spaces around various operators, as preferred by coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

[PATCH v5 5/8] staging: rtl8192e: Remove unrequired space at start of line - Coding Style

Function HTIOTActIsDisableMCS14 contained spurious space at start of line. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers

[PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 9cca4a8f1cf5

Re: [PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

On Sun, Jun 03, 2018 at 02:28:35PM +0200, Greg KH wrote: > On Sun, Jun 03, 2018 at 01:04:13PM +0100, John Whitmore wrote: > > Signed-off-by: John Whitmore > > --- > > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- > > 1 file changed, 6 insertion

[PATCH v6 1/8] staging: rtl8192e: Add and remove blank lines - Coding style

Simple addition & removal of blank lines as required Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +-- 1 file changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/sta

[PATCH v6 3/8] staging: rtl8192e: Remove unnecessary return statements - Coding style

Return statments from void functions are not required by the coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging

[PATCH v6 5/8] staging: rtl8192e: Remove unrequired space at start of line - Coding Style

Function HTIOTActIsDisableMCS14 contained spurious space at start of line. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers

staging: rtl8192e: Series of coding style changes

Version 6 : Sorry to send this out again but version 5 contained a little less verbosity then required. Again these are just some simple coding style changes to the file, so nothing of importance. ___ devel mailing list de...@linuxdriverproject.org ht

[PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

Remove unneccessary parentheses - Coding Style change Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging

[PATCH v6 2/8] staging: rtl8192e: Addition of prefered spacing - Coding style

Added spaces around various operators, as preferred by coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b

<    1   2   3   4   5   6   7   >