impact on
runtime execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 6 +++---
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
b
ld have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h| 4 ++--
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u
The union ECW is never used in code so has simply been removed.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 12
1 file changed, 12 deletions(-)
diff --git a
These are a few coding style changes to the file
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
I had more patches in the list but had to dump some of the later
patches as I made a mistake. Thought I'd send these 8.
John Whitmore (8):
staging:rtl8192u: Add spaces around operators -
Rename the member variables of union aci_aifsn, which should be named
in lowercase. The only member variable, of this union, which is
actually used is 'acm'.
This are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drive
on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h| 6 +++---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
The union ACM_PARAM is never actually used in code so removed. This
is a coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 15 ---
1 file changed, 15 deletions(-)
diff --git
On Sun, Jul 29, 2018 at 10:10:55AM +0200, Greg KH wrote:
> On Wed, Jul 25, 2018 at 11:16:21PM +0100, John Whitmore wrote:
> > -typedef struct tag_cmd_pkt_tx_feedback {
> > +struct cmpk_txfb_t {
> > /* DWORD 0 */
> > u8 element_id;
On Sun, Jul 29, 2018 at 10:17:26AM +0200, Greg KH wrote:
> On Sat, Jul 28, 2018 at 12:28:18AM +0100, John Whitmore wrote:
> > Refactor the use of the enumerated type dm_dig_sta_e, which is not
> > actually used for type checking by the compiler.
> >
> > The enumerated
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b
impact on
runtime execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 6 +++---
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
b
Add the required spaces around '+' and '*' operators. This is a
coding style change to clear the checkpatch issue. There should be
no impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 2 +-
1 file change
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
Correct the spelling of a number of comments, which cause a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2
hould have no
impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
Second attempt correcting my initial attempt where I left '_t'
and '_e' trailing the structures defined. These have now been
corrected.
John Whitmore (15):
staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
staging:rtl8192u: Remove unused CMPK_TX_SET
Rename the member variables of union aci_aifsn, which should be named
in lowercase. The only member variable, of this union, which is
actually used is 'acm'.
This are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drive
Correct the spelling of a number of comments, which cause a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b
g the enumerated type.
These changes, whilst convoluted, are purely coding style in nature and
should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/dr
value DIG_CONNECT_MAX has been removed since it is
never used in code.
The resulting changes are all coding style in nature and should not
impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 15 +++
1 file changed, 7 insertions(+), 8
The enumerated type dm_dig_dbg_e is never used in code so has simply
been removed from the source code.
this is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 6 --
1 file changed, 6
issue with CamelCase naming. And the enumerated constant
CCK_Rx_Version_MAX has been removed, since it is never used in code.
The changes are all coding style in nature and so should have no
impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 13
new types, and the type renamed to
enum dig_algorithm.
The enumerated constant DIG_ALGO_MAX has been removed from the type
since it is never used in the code.
These changes are all coding style in nature and as such should have
no impact on runtime code execution.
Signed-off-by: John Whitmore
---
d
oding style changes and should not impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h
b/drivers/staging/rtl8192u/r8192U_dm.h
ypes, and the value
'DIG_PD_MAX' has been removed from the enumeration, since it is never
used in code.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/r
Second attempt correcting my initial attempt where I left '_t'
and '_e' trailing the structures defined. These have now been
corrected.
John Whitmore (15):
staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
staging:rtl8192u: Remove unused CMPK_TX_SET
een left as enum dynamic_ratr_state
This is a coding style change and should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U.h| 10 +-
drivers/staging/rtl8192u/r8192U_dm.h | 8
2 files changed, 9 insertions(+), 9
Remove the typedef of struct cmpk_intr_sta_t, the name of the structure
has been left as cmd_pkt_interrupt_status. This clears the checkpatch
issue with creating new types in code. The change is purely a coding
style change and should have no impact on runtime code execution.
Signed-off-by: John
Remove the typedef from cmpk_set_cfg_t, leaving the structure as
struct cmd_pkt_set_configuration. This change clears the checkpatch
issue with defining new types. The change is purely a coding
style change which should have no impact on runtime code execution.
Signed-off-by: John Whitmore
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
hould have no
impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
enumeration is never used. In
any case there should be no impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 91
drivers/staging/rtl8192u/r8192U_dm.h | 20 --
2 files changed, 111 deletions(-)
diff --git a
On Sun, Jul 29, 2018 at 10:05:17PM +0100, John Whitmore wrote:
> Rename the member variables of union aci_aifsn, which should be named
> in lowercase. The only member variable, of this union, which is
> actually used is 'acm'.
>
> This are coding style changes which
On Sun, Jul 29, 2018 at 10:05:15PM +0100, John Whitmore wrote:
> Rename the union ACI_AIFSN to aci_aifsn and remove the typedef directive.
>
> The removal of the typedef clears the checkpatch issue with defining
> new types. The renaming is to adhere to the coding style where types
&
On Sun, Jul 29, 2018 at 10:05:11PM +0100, John Whitmore wrote:
> Second attempt correcting my initial attempt where I left '_t'
> and '_e' trailing the structures defined. These have now been
> corrected.
>
> John Whitmore (15):
> staging:rtl8192u: Remove
On Mon, Jul 30, 2018 at 11:11:38AM +0200, Greg KH wrote:
> On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote:
> > Remove the typedef of the structure cmpk_txfb_t. This clears the
> > checkpatch issue with defining new types.
> >
> > Additionally the type is
is included in the declaration. As a result
I totally cut the block comment.
All the remaining 13 patches fix coding style and checkpatch issues
with the file rtl819x_Qos.h. Possibly the major change is the
truncation of a number of unions to the structure which is actually
being used.
John
A number of structures have been commented out of code. Obviously they
are not used and as a result have been removed from the code.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211
has been removed from the structure to clear
the checkpatch issue with defining new types. Additionally the name has
been changed to lowercase to comply with coding style.
These changes are all coding style changes which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
is a coding style change, there should be no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
b/drivers/staging/rtl8192u
Move the union QOS_TCLAS from the header file rtl819x_Qos.h to header
file rtl819x_TS.h, where the structure is actually used, as the member
of another structure.
This is a coding style change, which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
.../staging
Rename TSInfo, the memeber variable of struct tspec_body to ts_info.
This change clears the checkpatch issue with CamelCase naming.
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
coding style change and
should not impact runtime code execution.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 23 ---
drivers/staging/rtl8192u/r8192U_dm.c | 4 ++--
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a
The macro UP2AC is commented out of the header file so the macro and its
associated comment are removed.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 3 ---
1 file
field has been changed
from u8 to u16. Compilers have probably moved on from having an issue
with this, call it OCD.
The changes are coding style in nature and should not impact runtime
code execution.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +-
.../st
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++--
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 +++---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff
Rename the structure octet_string's member variables Octet to octet and
Length to length. This change clears the checkpatch issue with CamelCase
naming of variables.
This is purely a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whi
style changes which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
.../rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +-
.../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 20 -
.../rtl8192u/ieee80211/rtl819x_TSProc.c | 22 +--
3
execution.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 30 +--
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
index db0392cfd6d4
-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h| 2 +-
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
b/drivers/staging/rtl8192u/ieee80211
A number of block comments have been changed to comply with the coding
standard. These are coding style changes which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 14 +++---
1 file changed, 7
the test. Since the
member variables are then actually used both have been removed, along
with the enumerated type which defines debug status, on/off.
These are coding style changes to remove unused or redundant code, there
should be no impact on runtime code execution.
Signed-off-by: John Wh
Rename the two constants defined in the enumerated type enum
cck_rx_path_method so that they are both uppercase, as suggested by
the coding style.
This is purely a coding style change and should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u
constant 'DM_DIG_MAX' the code might as well simply use that
constant, rather the a member variable set to that constant.
The member variable has been removed and the constant used directly
in the code. This is a coding style change which should not impact
runtime code execution.
patch removes member variables from two separate structures which
seem to have been intended to add functionality for debugging. Whether
that feature was forgotten about I'm not sure but as it serves no
purpose both member variables were removed.
I hope I've not missed something
John Wh
tion.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 1 -
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8192U_dm.c
index 8b9d011e9eec..ede596a91c03 100644
--- a/driv
This is a coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 3 ---
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drive
checkpatch issue with
CamelCase naming.
These changes are coding style in nature and should not impact
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 3 +--
drivers/staging/rtl8192u/r8192U_dm.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions
Rename the member variable disabledRF to disabled_rf. This change
resolves the checkpatch issue with CamelCase naming.
The change is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 10
7;12' have both been replaced with sizeof()
calls, as they both represent the size of data elements.
These are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 10 +-
drivers/staging/
have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
drivers/staging/rtl8192u/r8192U_dm.h | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s
The constant RateAdaptiveTH_High causes a checkpatch issue with respect
to CamelCase naming. As a result the constant has been renamed to
RATE_ADAPTIVE_TH_HIGH.
This is purely a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers
coding style change which should not impact runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_core.c | 8
drivers/staging/rtl8192u/r8192U_dm.c | 8
drivers/staging/rtl8192u/r8192U_dm.h | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u
Rename the member variable cck_Rx_path to cck_rx_path. This clears
the checkpatch issue with CamelCase naming.
This is a coding style change which should have no impact one runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 8
drivers
RX_PATH_SELECTION_DIFF_TH, to clear
the checkpatch issue with CamelCase naming.
These are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 3 +--
drivers/staging/rtl8192u/r8192U_dm.h | 3 +--
2
The constant DM_DIG_MIN_Netcore causes a checkpatch issue with CamelCase
naming so has been renamed to DM_DIG_MIN_NETCORE.
This is a simple coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 2
Multiple blank line, which cause an issue with checkpath, have been
removed and the spacing of definitions have been aligned to look
cleaner.
These are coding style changes which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u
: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h
b/drivers/staging/rtl8192u/r8192U_dm.h
index 74742cb27a2c..66dfcbbf6e43 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u
, 'TX_RETRY_COUNT_REG' and
'REG_C38_TH' respectively.
These are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.c | 16
drivers/staging/rtl8192u/r8192U_dm.h | 8 ++
Cleanup of the drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h file as
the QOS_TCLAS union was moved into this file, in a previous patch. The
type contained a number of naming issues.
John Whitmore (7):
staging:rtl8192u: Remove typedef and rename QOS_TCLAS - Style
staging:rtl8192u: Rename
Removal of a blank like which causes a checkpatch issue.
This is a simple coding style change and should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging
impact on runtime code execution.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_TS.h | 20 +--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
b/drivers/staging/rtl8192u/ieee80211
Replace the magic number '8' with defined constant which is normally used
'MAX_DEV_ADDR_SIZE'.
This is a coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +
ntime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
index 3cfeac0d7214..fc449806d
Remove the typedef from the union QOS_TCLAS, which causes a checkpatch
issue with defining new types. In addition, as a type, the name should
be in lowercase so has been changed.
These are coding style changes and should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_TS.h | 66 +--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
index c352ba0bcd8f..508ed639cda5
.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
index 93984e8e87c3..924d4b373099 100644
--- a
The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
naming, so has been renamed to eq_mac_addr(a, b).
This is a coding style change which should not impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 4
Rename the Macro cpMacAddr(des, src), as it causes a checkpatch issue
due its use of CamelCase naming, to cp_mac_addr(des, src).
This is a coding style change so should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h
Rename the function ToLegalChannel, which causes a checkpatch issue due
to its use of CamelCase naming. The function has been renamed to
to_legal_channel.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging
Removed unused macro definitions as they add nothing to the code.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers
e execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 47 +
1 file changed, 10 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 72fc04e08b34..cb6d6
Remove a comment which appears to be from a previous version of code.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
Add spaces around '+' operator as required by the coding standard.
This clears the checkpatch issue.
This change is purely coding style in nature and should have not
effect on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 4 ++
The macro parameter __pTa causes a checkpatch issue because of its use
of CamelCase naming. The parameter has this been renamed to addr.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211
The function dot11d_get_max_tx_pwr_in_dbm() uses a parameter name,
Channel, which causes a checkpatch issue with CamelCase naming. The
parameter has been renamed to channel.
The change is a coding style change which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore
This series includes a number of simple coding style changes.
There are a number of patches which rename symbols which are
exported with EXPORT_SYMBOL. This may be a problem, as code
using those symbols will have to be changed accordingly.
John Whitmore (17):
staging:rtl8192u: Remove stale
The function Dot11d_Init() causes a checkpatch issue due to its use
of CamelCase naming. The function has been renamed to dot11d_init.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211
The function dot11d_update_country_ie() uses parameter names which
cause a checkpatch issue de to the use of CamelCase naming.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 6
The function DOT11D_ScanComplete causes a checkpatch issue due to its
use of CamelCase naming. The function has been renamed to
dot11d_scan_complete.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u
The function IsLegalChannel causes a checkpatch issue due to its use
of CamelCase naming. The function has been renamed to is_legal_channel.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211
The function DOT11D_GetMaxTxPwrInDbm causes a checkpatch issue due to
its use of CamelCase naming. The function has been renamed to
dot11d_get_max_tx_pwr_in_dbm.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers
The function Dot11d_UpdateCountryIe causes a checkpatch issue due to
its use of CamelCase naming, the function has been renamed to
dot11d_update_country_ie.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging
The function Dot11d_Reset causes a checkpatch issue due to its use of
CamelCase naming, so has been rename to dot11d_reset.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.c
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index a53f6454262a..01adf747f7c8
On Wed, Aug 08, 2018 at 01:12:53AM -0700, Joe Perches wrote:
> On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> > The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
> > naming, so has been renamed to eq_mac_addr(a, b).
> >
> > This is a codin
re-ordered member variables
in two structures. This strikes me as being a bit shaky as
any change to a structure might upset that alignment.
Apart from that my only concern is renaming functions
which are exported symbols. As far as I can see they are
exported using EXPORT_SYMBOL but are not used anywh
e execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 47 +
1 file changed, 10 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 0263eca375fe..0856d
301 - 400 of 619 matches
Mail list logo
