Re: [PATCH 03/12] staging:rtl8192u: Remove blank lines before '}' and after '{' characters

2018-07-09 Thread John Whitmore
On Sun, Jul 08, 2018 at 05:38:11PM +0200, Greg KH wrote: > On Sat, Jul 07, 2018 at 03:55:04PM +0100, John Whitmore wrote: > > Coding style change to simply remove the unrequired spaces before a closing > > brace or before an opening brace. > > That would be good, but that&

[PATCH v2 0/8] staging:rtl8192u Coding style changes

2018-07-10 Thread John Whitmore
My last attempt saw some patches applied but a bad commit message resulted in a rejection and subsequent patches not applying. These patches are more or less the same but the numbers have changed from 3, 5, 7, 8, 9, 10, 11 & 12 to 1-8. ___ devel mail

[PATCH v2 1/8] staging:rtl8192u: Remove blank lines before '}' and after '{' characters

2018-07-10 Thread John Whitmore
Coding style change to simply remove the unrequired blanks lines before a closing brace or after an opening brace. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH v2 5/8] staging:rtl8192u: Move trailing conditional statement to the following line

2018-07-10 Thread John Whitmore
Coding standard requires that the conditional statement is not on the same line as the 'if' or 'else' but on the following line. Statements moved accordingly. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 25 +-- 1 file ch

[PATCH v2 2/8] staging:rtl8192u: Correct indentation and spacing for braces of code blocks

2018-07-10 Thread John Whitmore
Simple style change to fix the indentaiton and spacing of the braces around multiline code blocks. Braces removed from code block with a single line. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 254 -- 1 file changed, 107 insertions(+), 147

[PATCH v2 4/8] staging:rtl8192u: Remove prohibited spaces - Coding Style

2018-07-10 Thread John Whitmore
Simple removal of spaces prohibited by the coding standard. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers

[PATCH v2 6/8] staging:rtl8192u: Remove unnecessary parentheses - Coding Style

2018-07-10 Thread John Whitmore
checkpatch.pl flags unnecessary parentheses, so removed from code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b

[PATCH v2 7/8] staging:rtl8192u: Correct indentation of ieee80211_softmac_new_net()

2018-07-10 Thread John Whitmore
Coding style change to correct the indentation of the function ieee80211_softmac_new_net(). A large proportion of the function's if statements were incorrectly indented. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 101 +- 1 file change

[PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-10 Thread John Whitmore
Corrected coding style issues aroung opening and closed parenthesis. Spaces, or blank line, removed from after '(' or before ')' Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 78 +-- 1 file changed, 36 insertions(+), 4

[PATCH v2 8/8] staging:rtl8192u: Correction of indentation issues - Coding Style

2018-07-10 Thread John Whitmore
Simple changes to correct indentation issues. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 76 +-- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging

Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-11 Thread John Whitmore
On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > Corrected coding style issues aroung opening and closed parenthesis. > > Spaces, or blank line, removed from after '(' or before ')'

Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-11 Thread John Whitmore
On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > > > Correc

Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-11 Thread John Whitmore
On Wed, Jul 11, 2018 at 05:29:43PM +0300, Dan Carpenter wrote: > On Wed, Jul 11, 2018 at 03:27:11PM +0100, John Whitmore wrote: > > On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote: > > > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > > > >

[PATCH 01/10] staging:rtl8192u: typedef struct tx_desc_819x_usb > struct tx_desc_819x_usb

2018-07-11 Thread John Whitmore
Change structure tx_desc_819x_usb from being typedef to being a simple structure, without the typedef. checkpatch warns about defining new types in code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 6 +++--- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 2 files

[PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

2018-07-11 Thread John Whitmore
Simple rename of the preprosessor switch, protecting against multiple inclusion of the header file. Change to clear the checkpatch coding style issue. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 06/10] staging:rtl8192u: typedef struct tx_fwinfo_819x_usb remove typedef

2018-07-11 Thread John Whitmore
Change structure tx_fwinfo_819x_usb from being typedef to being a simple structure, without the typedef. Clears the coding style issue flagged by checkpatch, (new type definitions) Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 6 +++--- drivers/staging/rtl8192u

[PATCH 09/10] staging:rtl8192u: remove typedef from struct rx_drvinfo_819x_usb

2018-07-11 Thread John Whitmore
Removed the typedef from the struct rx_drvinfo_819x_usb to leave it as a simple structure. This clears the issue flagged by checkpatch, defining new types. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- drivers/staging/rtl8192u/r8192U_core.c | 10

[PATCH 02/10] staging:rtl8192u: trim multiple blank lines - Coding Style

2018-07-11 Thread John Whitmore
Trim the extra blank lines from the code, to clear checkpatch messages. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index

[PATCH 03/10] staging:rtl8192u: remove unused structure tx_desc_819x_usb_aggr_subframe

2018-07-11 Thread John Whitmore
Structure tx_desc_819x_usb_aggr_subframe is defined in a local header file but is not used outside of the header file. Removed from the code as a result. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 28 1 file changed, 28 deletions(-) diff

[PATCH 07/10] staging:rtl8192u: typedef struct rx_desc_819x_usb remove typedef

2018-07-11 Thread John Whitmore
Change structure rx_desc_819x_usb from being typedef to being a simple structure, without the typedef. Clears a checkpatch issue, definging new types in the code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- drivers/staging/rtl8192u/r8192U_core.c | 14

[0/10] staging:rtl8192u: One significant change...

2018-07-11 Thread John Whitmore
The first 9 patches in this series are coding style changes, including a number of patches to remove the "typedef" directive from a number of data structure definitions. This clears the checkpatch warning about defining new data types in the code. The last patch in the series, however, changes the

[PATCH 05/10] staging:rtl8192u: typedef struct tx_desc_cmd_819x_usb remove typedef

2018-07-11 Thread John Whitmore
Change structure tx_desc_cmd_819x_usb from being typedef to being a simple structure, without the typedef. checkpatch warns about defining new types in the code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 2

[PATCH 08/10] staging:rtl8192u: Remove struct rx_desc_819x_usb_aggr_subframe

2018-07-11 Thread John Whitmore
Removal of structure rx_desc_819x_usb_aggr_subframe from local header file, which is not used outside the header file. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b

[PATCH 10/10] staging:rtl8192u: Change struct r8192_priv member Rf_Mode from u8 > enum

2018-07-11 Thread John Whitmore
om memory and populated with data in the function rtl8192_usb_probe() in the file r8192U_core.c. As such the physical size of the member variable Rf_Mode is not significant, so the change should have no impact on code execution, bar the move from a u8 type to an int, (or whatever size compiler uses

[PATCH 01/13] staging:rtl8192u: remove typedef of enumeration SwChnlCmdID - Style

2018-07-13 Thread John Whitmore
To clear a checkpatch issue removed the typedef of the enumeration SwChnlCmdID this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.h | 12 ++-- 2

[0/13] staging:rtl8192u: Coding style changes

2018-07-13 Thread John Whitmore
This series is just coding style changes to clear checkpatch issues. I don't think that there are any changes that impact code execution. I tacked on the end a patch from my last series that failed, again just a rename to avoid CamelCase warning. jwhitmore __

[PATCH 04/13] staging:rtl8192u: remove typedef from structure SwChnlCmd - Style

2018-07-13 Thread John Whitmore
Checkpatch warns against creation of new types in code. This patch simply removes the "typedef" declaration of the structure SwChnlCmd to clear this issue. Simple coding style issue which should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8

[PATCH 02/13] staging:rtl8192u: remove typdef from enumeration HW90_BLOCK_E - Style

2018-07-13 Thread John Whitmore
Checkpatch warns about the creation of new types in code. This patch simply removes the typedef from the enumeration HW90_BLOCK_E to clear this warning. There should be no impact on run time code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 6

[PATCH 07/13] staging:rtl8192u: rename CmdID_SetTxPowerLevel > CMD_ID_SET_TX_PWR_LEVEL

2018-07-13 Thread John Whitmore
Rename enumeration label CmdID_SetTxPowerLevel to CMD_ID_SET_TX_PWR_LEVEL. This change clears a checkpatch warning on CamelCase. The change should not impact runtime execution, style change only. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 4 ++-- drivers/staging

[PATCH 03/13] staging:rtl8192u: Remove typdef from enumeration RF90_RADIO_PATH_E - Style

2018-07-13 Thread John Whitmore
Checkpatch warns about the creation of new types. This patch simply removes the typedef from the enumeration RF90_RADIO_PATH_E to clear this checkpatch warning. There should be no impact on run time code execution, as this is a coding style issue only. Signed-off-by: John Whitmore --- drivers

[PATCH 06/13] staging:rtl8192u: Rename enum label CmdID_End > CMD_ID_END - Style

2018-07-13 Thread John Whitmore
Rename enum label to clear a CamelCase warning from checkpatch. This is a simple style change and should not impact execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 10 +- drivers/staging/rtl8192u/r819xU_phy.h | 2 +- 2 files changed, 6 insertions

[PATCH 08/13] staging:rtl8192u: Remove unused enum label CmdID_BBRegWrite10

2018-07-13 Thread John Whitmore
The enum label CmdID_BBRegWrite10 is not used in the code, so removed from the source code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy.h b/drivers/staging/rtl8192u/r819xU_phy.h

[PATCH 11/13] staging:rtl8192u: Rename CmdID_WritePortUchar > CMD_ID_WRITE_PORT_UCHAR

2018-07-13 Thread John Whitmore
Rename the enum label CmdID_WritePortUchar to CMD_ID_WRITE_PORT_UCHAR, to clear the checkpatch issue with CamelCase. The change is a coding style change only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging

[PATCH 05/13] staging:rtl8192u: Rename SwChnlCmdID > switch_chan_cmd_id - Coding Style

2018-07-13 Thread John Whitmore
Rename enumerated type to clear a CamelCase warning from checkpatch. The change is style only. No impact on run time execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phy.h | 4 ++-- 2 files changed, 4 insertions(+), 4

[PATCH 09/13] staging:rtl8192u: Rename CmdID_WritePortUlong > CMD_ID_WRITE_PORT_ULONG

2018-07-13 Thread John Whitmore
Rename enum label CmdID_WritePortUlong to CMD_ID_WRITE_PORT_ULONG to clear the checkpatch CamelCase issue. Simple syle change which should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.h | 2 +- 2

[PATCH 13/13] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

2018-07-13 Thread John Whitmore
Simple rename of the preprosessor switch, protecting against multiple inclusion of the header file. Change to clear the checkpatch coding style issue. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 10/13] staging:rtl8192u: Rename CmdID_WritePortUshort > CMD_ID_WRITE_PORT_USHORT

2018-07-13 Thread John Whitmore
Rename the enum label CmdID_WritePortUshort to CMD_ID_WRITE_PORT_USHORT to clear the checkpatch warning on CamelCase naming. This is a coding style change only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging

[PATCH 12/13] staging:rtl8192u: Rename CmdID_RF_WriteReg > CMD_ID_RF_WRITE_REG - Style

2018-07-13 Thread John Whitmore
Rename enum label CmdID_RF_WriteReg to CMD_ID_RF_WRITE_REG. This change clears the checkpatch issue with CamelCase. The change is style only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 6 +++--- drivers/staging/rtl8192u

Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

2018-07-13 Thread John Whitmore
On Fri, Jul 13, 2018 at 11:39:38AM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote: > > Simple rename of the preprosessor switch, protecting against multiple > > inclusion of the header file. Change to clear the checkpatch coding

staging:rtl8192u: [0/10] Coding style changes.

2018-07-13 Thread John Whitmore
All coding style changes, but the second [2/10] is a bit more hairy then most. The original code combined two typedef declarations into one with both the structure and a pointer to the structure defined. I've totally removed the pointer to the structure type since it uses Hungarian notation, which

[PATCH 03/10] staging:rtl8192u: Rename List > list - Coding style

2018-07-13 Thread John Whitmore
In struct TS_COMMON_INFO rename the member List to list. This clears the checkpatch issue concerning CamelCase naming of variables. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- .../rtl8192u/ieee80211/rtl819x_TSProc.c | 64 +-- 2

[PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style

2018-07-13 Thread John Whitmore
pointer type has been completely removed from the code, as: "(so-called Hungarian notation) is brain damaged" according to the coding standard. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- .../staging/rtl8192u/ieee80211/ieee80211

[PATCH 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasProc to t_clas_proc. This change clears the checkpatch issue with CamelCase variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH 07/10] staging:rtl8192u: Rename TSpec > t_spec - Style

2018-07-13 Thread John Whitmore
Rename the TS_COMMON_INFO structure's member TSpec to t_spec. This change clears the checkpatch issue with CamelCase naming of variables. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +- drivers/st

[PATCH 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member SetupTimer to setup_timer. This clears the checkpatch issue with CamelCase variable names. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 8 2

[PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style

2018-07-13 Thread John Whitmore
To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++-- drivers/staging/rtl8192u/ieee

[PATCH 06/10] staging:rtl8192u: Rename Addr > addr - Style

2018-07-13 Thread John Whitmore
Rename the TX_COMMON_INFO structure's member Addr to addr. This change clears the checkpatch issue with CamelCase naming. This is a coding style change only and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c

[PATCH 05/10] staging:rtl8192u: Rename InactTimer > inact_timer - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member InactTimer to inact_timer. This change clears the checkpatch issue with CamelCase naming. The change should not have any impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH 08/10] staging:rtl8192u: Rename TClass > t_class - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable from TClass to t_class. This change clears the checkpatch issue with CamelCase Variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This change clears the checkpatch issue with CamelCase naming. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging

Re: [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style

2018-07-16 Thread John Whitmore
On Mon, Jul 16, 2018 at 10:41:38AM +0200, Greg KH wrote: > On Fri, Jul 13, 2018 at 09:12:38PM +0100, John Whitmore wrote: > > To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT > > this should not impact runtime code as it's only a coding style change.

Re: staging:rtl8192u: [0/10] Coding style changes.

2018-07-16 Thread John Whitmore
On Mon, Jul 16, 2018 at 10:40:20AM +0200, Greg KH wrote: > On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote: > > All coding style changes, but the second [2/10] is a bit more hairy then > > most. The original code combined two typedef declarations into one with both &g

Re: [PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style

2018-07-16 Thread John Whitmore
On Mon, Jul 16, 2018 at 10:42:05AM +0200, Greg KH wrote: > On Fri, Jul 13, 2018 at 09:12:39PM +0100, John Whitmore wrote: > > To clear a checkpatch issue removed the typedef of the structure > > TS_COMMON_INFO. > > > > This change removes the previous declaration, wh

[PATCH v2 03/10] staging:rtl8192u: Rename List > list - Coding style

2018-07-16 Thread John Whitmore
In struct TS_COMMON_INFO rename the member List to list. This clears the checkpatch issue concerning CamelCase naming of variables. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- .../rtl8192u/ieee80211/rtl819x_TSProc.c | 64 +-- 2

[PATCH v2 00/10] staging:rtl8192u: Coding style changes.

2018-07-16 Thread John Whitmore
Simple coding style changes to avoid CamelCase. John Whitmore (10): staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style staging:rtl8192u: Rename List > list - Coding style staging:rtl8192u: rename SetupTi

[PATCH v2 06/10] staging:rtl8192u: Rename Addr > addr - Style

2018-07-16 Thread John Whitmore
Rename the TX_COMMON_INFO structure's member Addr to addr. This change clears the checkpatch issue with CamelCase naming. This is a coding style change only and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c

[PATCH v2 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style

2018-07-16 Thread John Whitmore
Rename the struct TS_COMMON_INFO member SetupTimer to setup_timer. This clears the checkpatch issue with CamelCase variable names. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 8 2

[PATCH v2 07/10] staging:rtl8192u: Rename TSpec > t_spec - Style

2018-07-16 Thread John Whitmore
Rename the TS_COMMON_INFO structure's member TSpec to t_spec. This change clears the checkpatch issue with CamelCase naming of variables. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +- drivers/st

[PATCH v2 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num - Style

2018-07-16 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This change clears the checkpatch issue with CamelCase naming. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging

[PATCH v2 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style

2018-07-16 Thread John Whitmore
To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++-- drivers/staging/rtl8192u/ieee

[PATCH v2 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc - Style

2018-07-16 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasProc to t_clas_proc. This change clears the checkpatch issue with CamelCase variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH v2 05/10] staging:rtl8192u: Rename InactTimer > inact_timer - Style

2018-07-16 Thread John Whitmore
Rename the struct TS_COMMON_INFO member InactTimer to inact_timer. This change clears the checkpatch issue with CamelCase naming. The change should not have any impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH v2 08/10] staging:rtl8192u: Rename TClass > t_class - Style

2018-07-16 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable from TClass to t_class. This change clears the checkpatch issue with CamelCase Variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH v2 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style

2018-07-16 Thread John Whitmore
pointer type has been completely removed from the code, as: "(so-called Hungarian notation) is brain damaged" according to the coding standard. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- .../staging/rtl8192u/ieee80211/ieee80211

[PATCH 05/14] staging:rtl8192u: Rename variable MaxTxPowerInDbm - Style

2018-07-20 Thread John Whitmore
Rename the variable MaxTxPowerInDbm to max_tx_pwr_dbm. This change clears a checkpatch issue with CamelCase naming. This coding style change should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8192u

[PATCH 01/14] staging:rtl8192u: Remove multiple blank lines - Style

2018-07-20 Thread John Whitmore
Remove multiple blank lines which cause checkpatch issues. These are purely coding style changes which should not impact execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 03/14] staging:rtl8192u: Rename structure member FirstChnl - Style

2018-07-20 Thread John Whitmore
Rename structure member FirstChnl to first_channel. This coding style change clears a checkpatch issue with CamelCase naming. This change should not impact the runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 +- drivers/staging

[PATCH 02/14] staging:rtl8192u: Remove typedef from structure - Style

2018-07-20 Thread John Whitmore
Remove the typedef directive from struct _CHNL_TXPOWER_TRIPLE. This is a coding style change which clears a checkpatch issue with declaring new types. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 6 +++--- drivers

[PATCH 12/14] staging:rtl8192u: Rename CountryIeWatchdog > country_ie_watchdog - Style

2018-07-20 Thread John Whitmore
Rename the member variable CountryIeWatchdog to country_ie_watchdog, this change clears the checkpatch issue with CamelCase naming of variables. The change is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 11/14] staging:rtl8192u: Rename CountryIeSrcAddr > country_ie_src_addr - Style

2018-07-20 Thread John Whitmore
Rename variable CountryIeSrcAddr to country_ie_src_addr, this change clears the checkpatch issue with CamelCase naming. This coding style change should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.h | 6 +++--- 1 file changed, 3

[PATCH 06/14] staging:rtl8192u: Remove typedef and rename DOT11D_STATE - Style

2018-07-20 Thread John Whitmore
Remove typedef from enumerated type DOT11D_STATE to clear checkpatch issue with declaring new types. Rename the enumertion from DOT11D_STATE to dot11d_state. These changes are coding style changes which should not effect runtime execution of code. Signed-off-by: John Whitmore --- drivers

[PATCH 04/14] staging:rtl8192u: Rename variable NumChnls - Style

2018-07-20 Thread John Whitmore
Rename the member variable NumChnls to num_channels. This change clears the checkpatch issue with CamelCase naming. The change should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 4 ++-- drivers/staging/rtl8192u/ieee80211/dot11d.h

[PATCH 00/14] staging:rtl8192u: Coding style changes

2018-07-20 Thread John Whitmore
This is a collection of simple coding style chages to clear checkpatch issues in the file drivers/staging/rtl8192u/ieee80211/dot11d.h John Whitmore (14): staging:rtl8192u: Remove multiple blank lines - Style staging:rtl8192u: Remove typedef from structure - Style staging:rtl8192u: Rename

[PATCH 07/14] staging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO - Style

2018-07-20 Thread John Whitmore
Removed the typedef from structure RT_DOT11D_INFO. This change clears the checkpatch issue with declaring new types. Rename the structure from RT_DOT11D_INFO to rt_dot11d_info. Coding style changes which should not impact runtime execution of code. Signed-off-by: John Whitmore --- drivers

[PATCH 08/14] staging:rtl8192u: Rename bEnabled > enabled - Style

2018-07-20 Thread John Whitmore
Rename the member variable bEnabled to enabled. This change clears the checkpatch issue with CamelCase. Purely a coding style change which should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8192u/ieee80211

[PATCH 14/14] staging:rtl8192u: Rename variable State > state - Style

2018-07-20 Thread John Whitmore
Rename the variable State to state, this clears the checkpatch issue with CamelCase naming. The change is purely coding style and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 +- drivers/staging/rtl8192u

[PATCH 09/14] staging:rtl8192u: Rename CountryIeLen > country_ie_len - Style

2018-07-20 Thread John Whitmore
Rename CountryIeLen to country_ie_len, coding style change to clear checkpatch issue with CamelCase naming. The change should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 6 +++--- drivers/staging/rtl8192u/ieee80211

[PATCH 10/14] staging:rtl8192u: Rename CountryIeBuf > country_ie_buf - Style

2018-07-20 Thread John Whitmore
Rename variable CountryIeBuf to country_ie_buf, this clears the checkpatch issue with CamelCase naming. This change is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging

[PATCH 13/14] staging:rtl8192u: Rename MaxTxPwrDbmList > max_tx_pwr_dbm_list - Style

2018-07-20 Thread John Whitmore
Rename the member variable MaxTxPwrDbmList to max_tx_pwr_dbm_list. This change clears the checkpatch issue with CamelCase naming. The change is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211

Re: [PATCH v2 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc - Style

2018-07-21 Thread John Whitmore
On Sat, Jul 21, 2018 at 09:02:15AM +0200, Greg KH wrote: > On Mon, Jul 16, 2018 at 08:04:53PM +0100, John Whitmore wrote: > > Rename the struct TS_COMMON_INFO member variable TClasProc to > > t_clas_proc. This change clears the checkpatch issue with CamelCase variable > > name

[PATCH v2 07/10] staging:rtl8192u: Rename variable CountryIeSrcAddr - Style

2018-07-21 Thread John Whitmore
Rename the member variable CountryIeSrcAddr to country_ie_src_addr, this clears the checkpatch issue with CamelCase naming. The change is purely a coding style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.h | 6

[PATCH v2 05/10] staging:rtl8192u: Rename CountryIeLen > country_ie_len - Style

2018-07-21 Thread John Whitmore
Rename CountryIeLen to country_ie_len, coding style change to clear checkpatch issue with CamelCase naming. The change should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 6 +++--- drivers/staging/rtl8192u/ieee80211

[PATCH v2 01/10] staging:rtl8192u: Rename TClasProc > t_clas_proc - Style

2018-07-21 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasProc to t_clas_proc. This change clears the checkpatch issue with CamelCase variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers

[PATCH v2 00/10] staging:rtl8192u: Coding style changes

2018-07-21 Thread John Whitmore
do so. Guess I'll find out if it is. Thanks John Whitmore (10): staging:rtl8192u: Rename TClasProc > t_clas_proc - Style staging:rtl8192u: Rename TClasNum > t_clas_num - Style staging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO - Style staging:rt

[PATCH v2 03/10] staging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO - Style

2018-07-21 Thread John Whitmore
Removed the typedef from structure RT_DOT11D_INFO. This change clears the checkpatch issue with declaring new types. Rename the structure from RT_DOT11D_INFO to rt_dot11d_info. Coding style changes which should not impact runtime execution of code. Signed-off-by: John Whitmore --- drivers

[PATCH v2 09/10] staging:rtl8192u: Rename MaxTxPwrDbmList > max_tx_pwr_dbm_list - Style

2018-07-21 Thread John Whitmore
Rename the member variable MaxTxPwrDbmList to max_tx_pwr_dbm_list. This change clears the checkpatch issue with CamelCase naming. The change is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211

[PATCH v2 02/10] staging:rtl8192u: Rename TClasNum > t_clas_num - Style

2018-07-21 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This change clears the checkpatch issue with CamelCase naming. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging

[PATCH v2 06/10] staging:rtl8192u: Rename CountryIeBuf to country_ie_buf - Style

2018-07-21 Thread John Whitmore
Rename the member variable CountryIeBuf to country_ie_buf. This change clears the checkpatch issue with CamelCase. The change is purely coding style and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging

[PATCH v2 10/10] staging:rtl8192u: Rename variable State > state - Style

2018-07-21 Thread John Whitmore
Rename the variable State to state, this clears the checkpatch issue with CamelCase naming. The change is purely coding style and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 +- drivers/staging/rtl8192u

[PATCH v2 04/10] staging:rtl8192u: Rename bEnabled > enabled - Style

2018-07-21 Thread John Whitmore
Rename the member variable bEnabled to enabled. This change clears the checkpatch issue with CamelCase. Purely a coding style change which should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8192u/ieee80211

[PATCH v2 08/10] staging:rtl8192u: Rename CountryIeWatchdog > country_ie_watchdog - Style

2018-07-21 Thread John Whitmore
Rename the member variable CountryIeWatchdog to country_ie_watchdog, this change clears the checkpatch issue with CamelCase naming of variables. The change is a simple coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u

[PATCH 13/20] staging:rtl8192u: Remove unused page-a Bit Mask definitions - Style

2018-07-22 Thread John Whitmore
ned-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phyreg.h | 78 1 file changed, 78 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phyreg.h b/drivers/staging/rtl8192u/r819xU_phyreg.h index 53beef72ceda..af98067c0de0 100644 --- a/drivers/stagin

[PATCH 08/20] staging:rtl8192u: Remove unused Zebra4 definitions - Style

2018-07-22 Thread John Whitmore
Remove the unused 'Zebra4' definitions. These definitions fail the checkpatch CamelCase naming test, rather then rename as they are unused definitions they have simply been removed. This is a coding style change which should not impact runtime code execution. Signed-off-by: Joh

[PATCH 00/20] staging:rtl8192u: Remove unused definitions - Style

2018-07-22 Thread John Whitmore
en 20 smaller patch files. John Whitmore (20): staging:rtl8192u: Remove unused page 1 definitions - Style staging:rtl8192u: Remove unused page 8 definitions - Style staging:rtl8192u: Remove unused page 9 definitions - Style staging:rtl8192u: Remove unused page a definitions -

[PATCH 10/20] staging:rtl8192u: Remove unused page-1 Bit Masks - Style

2018-07-22 Thread John Whitmore
Remove the unused 'page-1' Bit Masks. These definitions fail the checkpatch CamelCase naming test. To avoid renaming the definitions have simply been removed. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drive

[PATCH 18/20] staging:rtl8192u: Remove unused RF Zebra1 Bit Mask definitions - Style

2018-07-22 Thread John Whitmore
execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phyreg.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phyreg.h b/drivers/staging/rtl8192u/r819xU_phyreg.h index b3f9f7e65073..09eade1f4dbe 100644 --- a/drivers/stagin

[PATCH 09/20] staging:rtl8192u: Remove unused RTL8258 definitions - Style

2018-07-22 Thread John Whitmore
Remove the unused RTL8258 definitions. These definitions fail the checkpatch CamelCase naming test, rather then renaming, as the definitions are unused they have simply been removed. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore

[PATCH 01/20] staging:rtl8192u: Remove unused page 1 definitions - Style

2018-07-22 Thread John Whitmore
execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phyreg.h | 31 1 file changed, 31 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phyreg.h b/drivers/staging/rtl8192u/r819xU_phyreg.h index c058a9537526..437f3bfcc399 100644 --- a/drive

[PATCH 14/20] staging:rtl8192u: Remove unused page c Bit Mask definitions - Style

2018-07-22 Thread John Whitmore
execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phyreg.h | 163 --- 1 file changed, 163 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phyreg.h b/drivers/staging/rtl8192u/r819xU_phyreg.h index af98067c0de0..b0bcef2e73a6 100644 --- a/drive

[PATCH 06/20] staging:rtl8192u: Remove unused page d definitions - Style

2018-07-22 Thread John Whitmore
Remove the unused 'page d' definitions. These definitions fail the checkpatch CamelCase naming test. Rather then renaming unused definitions they have simply been removed. This change is a coding style change and should have no impact on runtime code execution. Signed-off-by: Joh

<    1   2   3   4   5   6   7   >