if (is_zero_ether_addr(adapter->currmacaddr))
memcpy(adapter->currmacaddr, adapter->macaddr, ETH_ALEN);
if (adapter->netdev)
memcpy(adapter->netdev->dev_addr, adapter->currmacaddr,
ETH_ALEN);
}
Best regards,
Jingoo Han
>
>
> + ether_addr_copy(adapter->currmacaddr, addr->sa_data);
By the way, I am wondering if 'dev->addr_len' is 6 bytes.
Is there anyone who can confirm it?
If nobody can confirm 'dev->addr_len' is 6 bytes, it should
not be changed to 'ether_addr_copy()'.
7;t dare
> removing it. I considered it was not really coding style.
> But after second thought, I will remove it when I resend tomrorrow.
Please, remove unnecessary void cast as below.
- struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
+ struct crystalhd_adp *adp = arg;
T
x27;t cause a checkpatch.pl warning. The
> new one is buggy and won't print the correct text.
Yes, right. In this case, it prints some tabs between 'device'
and 'attributes.' So, this patch should be NAKed.
Best regards,
Jingoo Han
>
> regards,
> dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han
---
drivers/vme/boards/vme_vmivme7805.c |2 +-
drivers/vme/bridges/vme_ca91cx42.c |2 +-
drivers/vme/bridges/vme_tsi148.c|2 +-
3 files changed, 3 insertions(+), 3 dele
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han
---
drivers/staging/comedi/drivers/8255_pci.c |2 +-
drivers/staging/comedi/drivers/addi_apci_035.c|2 +-
drivers/staging/comedi/drivers/addi_apci_1032.c |
s good.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xillybus/xillybus_pcie.c
> b/drivers/staging/xillybus/xillybus_pcie.c
> index 0564f97..51426d8 100644
> --- a/drivers/staging/xillybus/xil
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han
---
drivers/staging/rtl8821ae/base.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/base.c b/drivers
about devm_* functions, please refer
to the following.
Documentation/driver-model/devres.txt
Best regards,
Jingoo Han
>
> return 0;
> }
> --
> 1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
returned.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
>
> diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c
> b/drivers/staging/media/dt3155v4l/dt3155v4l.c
> index afbc2e5..178aa5b 100644
> --- a/drivers/staging/media/dt3155v4l/dt3155v4l.c
> +++ b/drivers/staging
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.
Signed-off-by: Jingoo Han
---
drivers/staging/rts5208/rtsx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.
Signed-off-by: Jingoo Han
---
drivers/staging/tidspbridge/pmgr/dbll.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/pmgr
The usage of strict_strto*() is not preferred, because
strict_strto*() is obsolete. Thus, kstrto*() should be
used.
Signed-off-by: Jingoo Han
---
drivers/staging/iio/accel/sca3000_core.c |4 ++--
drivers/staging/iio/accel/sca3000_ring.c |2 +-
drivers/staging/iio
On Tuesday, July 23, 2013 7:34 PM, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 07:16:21PM +0900, Jingoo Han wrote:
> > The usage of strict_strtol() is not preferred, because
> > strict_strtol() is obsolete. Thus, kstrtol() should be
> > used.
> >
&g
- if (count >= 3)
- strict_strtol(sz_last_token, 10, (long *)&req);
+ if (count >= 3) {
+ status = kstrtos32(sz_last_token, 10, &req);
+ if (status)
+ goto func_cont;
+ }
I really appreciate your comment.
B
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtos32() should be
used in order to convert a string to s32. Also, error handling
is added to get rid of a __must_check warning.
Signed-off-by: Jingoo Han
---
drivers/staging/tidspbridge/pmgr/dbll.c
long long,
and long long can be used.
However, kstrto*() provides various functions handling all types
of variables. Therefore, the types of variables can be changed
properly.
Signed-off-by: Jingoo Han
---
drivers/staging/iio/accel/sca3000_core.c |8 ++---
drivers/staging/iio/accel
On Wednesday, July 24, 2013 4:09 PM, Dan Carpenter wrote:
> On Wed, Jul 24, 2013 at 02:34:08PM +0900, Jingoo Han wrote:
> > The usage of strict_strtol() is not preferred, because
> > strict_strtol() is obsolete. Thus, kstrtos32() should be
> > used in order to convert a strin
Added missing MFD_SYSCON dependency for LVDS display bridge
in order to fix the following link error.
drivers/staging/imx-drm/imx-ldb.c:484: undefined reference to
`syscon_regmap_lookup_by_phandle'
Signed-off-by: Jingoo Han
---
drivers/staging/imx-drm/Kconfig |2 +-
1 file chang
]
*addr
drivers/vme/boards/vme_vmivme7805.c:99:17:got void *static [toplevel]
vmic_base
Signed-off-by: Jingoo Han
---
drivers/vme/boards/vme_vmivme7805.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vme/boards/vme_vmivme7805.c
b/drivers/vme/boards
/vme_ca91cx42.c:959:17:got void *
Signed-off-by: Jingoo Han
---
drivers/vme/bridges/vme_ca91cx42.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42.c
b/drivers/vme/bridges/vme_ca91cx42.c
index 64bfea3..53a3f6a 100644
--- a/drivers/vme/bridges
-by: Jingoo Han
---
drivers/vme/bridges/vme_tsi148.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index 94c892f..9cf8833 100644
--- a/drivers/vme/bridges/vme_tsi148.c
+++ b/drivers/vme/bridges
On Tuesday, August 13, 2013 5:14 AM, Jonathan Cameron wrote:
> On 07/24/13 06:36, Jingoo Han wrote:
[.]
> Sorry it has taken me so long to get to this. Was obviously going
> to be 'almost' as tedious to review as it would have been to put
> it together :)
>
> Y
long long,
and long long can be used.
However, kstrto*() provides various functions handling all types
of variables. Therefore, the types of variables can be changed
properly.
Signed-off-by: Jingoo Han
---
Changes since v2:
- Fixed the type of variables suggested by Jonathan Cameron
drivers
24 matches
Mail list logo
