[PATCH 03/13] staging: rtl8723au: Use rtl8723au_set_media_status() to replace _InitNetworkType()

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Reduce yet another duplicate implementation of set_media_status() Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 13 + drivers/staging/rtl8723au/include/rtl8723a_spec.h | 8 2 files changed, 1 insertion(+), 20

[PATCH 07/13] staging: rtl88723au: Remove no-op _InitOperation_mode() function

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 4161409..0c760e5 100644 --- a/drivers/staging

[PATCH 09/13] staging: rtl8723au: Use proper name REG_CAMCMD and remove wrapper invalidate_cam_all23a()

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c| 7 +-- drivers/staging/rtl8723au/hal/hal_com.c | 8 drivers/staging/rtl8723au/hal/usb_halinit.c | 2 +- drivers/staging/rtl8723au/include/hal_com.h | 2

[PATCH 13/13] staging: rtl8723au: Remove pointless IS_STA_VALID() macro

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/odm_HWConfig.c | 2 +- drivers/staging/rtl8723au/include/odm.h | 4 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 12/13] staging: rtl8723au: Remove unused odm_RegDefine11AC.h

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- .../staging/rtl8723au/include/odm_RegDefine11AC.h | 49 -- drivers/staging/rtl8723au/include/odm_precomp.h| 1 - 2 files changed, 50 deletions(-) delete mode 100644 drivers/staging/rtl8723au/include

[PATCH 04/13] rtl8723au: Corrections in the coding style

2014-07-17 Thread Jes . Sorensen
From: Raphael Silva Some corrections were made to the code in order to conform to the Kernel Coding Style. Jes: Fix build problem Signed-off-by: Raphael Silva Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 42 ++-- 1 file changed, 27

[PATCH 08/13] staging: rtl8723au: Remove RegBcnCtrlVal

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen The value saved in RegBcnCtrlVal was never used. In addition the code was highly endian broken, declaring it as a u32, then accessing it via a u8 * later. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 +- drivers

[PATCH 02/13] staging: rtl8723au: Reduce number of duplicate defines for link state

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen We use the MSR bits to define link state anyway, so no point having an additional two sets of defines for the same thing. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 8 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 112

[PATCH 07/29] staging: rtl8723au: Remove no-op function dm_CheckStatistics()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index 4a3d2e1..3fb54fc 100644 --- a/drivers

[PATCH 20/29] staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 ++-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/odm.h | 3 --- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 19/29] staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 18 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 +--- drivers/staging/rtl8723au/include/odm.h | 4 +--- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a

[PATCH 10/29] staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/odm.h | 6 -- 3 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH 16/29] staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 17 +++-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 3 --- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a

[PATCH 13/29] staging: rtl8723au: Remove another pile of awful unused ODM variables

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 18 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 16 3 files changed, 36 deletions(-) diff --git a/drivers

[PATCH 01/29] staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index ce192de..3292b5f

[PATCH 15/29] staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen This will allow us to access variables in the hal_data struct directly, and get rid of the horrendous ODM_CMNINFO spaghetti API. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 4 +++- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 +- drivers

[PATCH 08/29] staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 - drivers/staging/rtl8723au/include/rtl8723a_dm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal

[PATCH 25/29] staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen The whole antenna diversity selection was completely pointless as all the end functions called were no-ops. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 77 drivers/staging/rtl8723au/hal/odm_HWConfig.c | 2

[PATCH 28/29] staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/hal_intf.h | 1 - drivers/staging/rtl8723au/os_dep/usb_intf.c | 9 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/hal_intf.h b/drivers/staging/rtl8723au/include

[PATCH 17/29] staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 19 --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 3 ++- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- drivers

[PATCH 09/29] staging: rtl8723au: Remove write-only variables struct dm_priv->{Init, }DMFlag

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/hal_com.c | 6 ++ drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 7 --- drivers/staging/rtl8723au/include/rtl8723a_dm.h | 2 -- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a

[PATCH 00/29] staging: rtl8723au: Remove bad layer API

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Greg, Another set of rtl8723au changes - this was meant to be a 'I'll just fix this little issue' but snowballed into a fair bit more, as I realized just how bad the original code was (patch 10 onwards). The bulk of this set removes a bad layered API. The ori

[PATCH 12/29] staging: rtl8723au: Remove another pile of useless ODM variables

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 16 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 5 + drivers/staging/rtl8723au/include/odm.h | 16 +--- 3 files changed, 2 insertions(+), 35 deletions

[PATCH 04/29] staging: rtl8723au: Remove unused DefaultInitialGain array

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/rtl8723a_hal.h b/drivers/staging/rtl8723au/include/rtl8723a_hal.h index 1f63eb1..3b0b06d 100644 --- a

[PATCH 05/29] staging: rtl8723au: Remove some redundant check for hw_init_completed

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index ac47a97..bf1db90

[PATCH 03/29] staging: rtl8723au: bDMInitialGainEnable is always true

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 10 -- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index dd02585

[PATCH 23/29] staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal/rtl8723a_dm.c index fa3e5aa

[PATCH 26/29] staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/hal_com.c | 18 -- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 +++- drivers/staging/rtl8723au/include/hal_com.h | 1 - 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a

[PATCH 06/29] staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 4 drivers/staging/rtl8723au/include/rtl8723a_dm.h | 1 - drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 -- 3 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH 29/29] staging: rtl8723au: rtw_resume(): release semaphore before exit on error

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index c75427f..06c885f 100644 --- a

[PATCH 27/29] staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 52 +++- drivers/staging/rtl8723au/include/hal_intf.h | 4 +-- drivers/staging/rtl8723au/os_dep/os_intfs.c | 6 ++-- drivers/staging/rtl8723au/os_dep/usb_intf.c | 2

[PATCH 24/29] staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 1b39cbe..4e7a198 100644 --- a/drivers/staging

[PATCH 02/29] staging: rtl8723au: Declare odm_EdcaTurbo*() functions static

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 3292b5f..dd02585 100644 --- a/drivers/staging

[PATCH 18/29] staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 10 +++--- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 4 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 21/29] staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 754b816..d420f33 100644 --- a/drivers/staging/rtl8723au/hal/odm.c

[PATCH 14/29] staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 6 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH 22/29] staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 15 --- drivers/staging/rtl8723au/include/odm.h | 2 -- 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index

[PATCH 11/29] staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code

2014-07-21 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 -- drivers/staging/rtl8723au/include/odm.h | 6 -- 3 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8723au/hal

[PATCH 3/5] staging: rtl8723au: Remove never set struct pwrctrl_priv.bHWPowerdown

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 21 - drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 - 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b

[PATCH 5/5] staging: rtl8723au: usb_dvobj_init(): Remove unused variable 'pdev_desc'

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index c5ff1b8..865743e 100644 --- a/drivers/staging

[PATCH 4/5] staging: rtl8723au: Do not duplicate kernel provided USB macros

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 45 +++-- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index

[PATCH 2/5] staging: rtl8723au: Remove two never set variables

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen struct registry_priv.usbss_enable and struct pwrctrl_priv.bHWPwrPindetect are never set. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_cmd.c| 13 - drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 22 -- drivers

[PATCH 0/5] staging: rtl8723au: Removing more unused and duplicate code

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Greg, Please find attached another small set of fixes for the 8723au driver, mostly removing unused code, but also duplication of some in-kernel Linux USB functions. Thanks, Jes Jes Sorensen (5): staging: rtl8723au: RSSI_test is never set staging: rtl8723au: Remove two

[PATCH 1/5] staging: rtl8723au: RSSI_test is never set

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 7 ++- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging

Re: [PATCH] staging: rtl8723au: Fix static symbol sparse warning

2014-08-02 Thread Jes Sorensen
Larry Finger writes: > On 08/01/2014 08:06 AM, Miguel Oliveira wrote: >> Fix sparse warning: >> drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol >> efuse_GetCurrentSize23a' was not declared. Should it be static? >> >> Signed-off-by: Miguel Oliveira >> --- >> drivers/staging/rtl

<    3   4   5   6   7   8