[PATCH 09/24] staging: lustre: make some lnet functions static

2016-02-22 Thread James Simmons
outers' was not declared. Should it be static? Some prototypes were removed from C files and added to the proper header. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 Reviewed-on: http://review.whamcloud.com/12206 Reviewed-by: James Simmons Reviewed

[PATCH 15/24] staging: lustre: improvement to router checker

2016-02-22 Thread James Simmons
n and off by the user. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6003 Reviewed-on: http://review.whamcloud.com/13035 Reviewed-by: Liang Zhen Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/include/linux

[PATCH 17/24] staging: lustre: prevent assert on LNet module unload

2016-02-22 Thread James Simmons
Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6010 Reviewed-on: http://review.whamcloud.com/13110 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/module.c |9 + 1 files changed, 9 insertions(+), 0

[PATCH 20/24] staging: lustre: avoid race during lnet acceptor thread termination

2016-02-22 Thread James Simmons
From: Bruno Faccini This patch will avoid potential race, around socket sleepers wait list, during acceptor thread termination and using sk_callback_lock RW-Lock protection. Signed-off-by: Bruno Faccini Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6476 Reviewed-on: http://review.whamclou

[PATCH 22/24] staging: lustre: Allocate the correct number of rtr buffers

2016-02-22 Thread James Simmons
From: Amir Shehata This patch ensures that the correct number of router buffers are allocated. It keeps a count that keeps track of the number of buffers allocated. Another count keeps the number of buffers requested. The number of buffers allocated is set when creating new buffers and reduced

[PATCH 13/24] staging: lustre: return -EEXIST if NI is not unique

2016-02-22 Thread James Simmons
Huang Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/api-ni.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c index 62a9e45

[PATCH 04/24] staging: lustre: DLC user/kernel space glue code

2016-02-22 Thread James Simmons
-bug-id: https://jira.hpdd.intel.com/browse/LU-2456 Reviewed-on: http://review.whamcloud.com/8023 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin --- .../staging/lustre/include/linux/lnet/lib-lnet.h | 22 ++- .../staging/lustre

[PATCH 07/24] staging: lustre: improve LNet clean up code and API

2016-02-22 Thread James Simmons
l-bug-id: https://jira.hpdd.intel.com/browse/LU-5734 Reviewed-on: http://review.whamcloud.com/12658 Reviewed-by: Liang Zhen Reviewed-by: Isaac Huang Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/include/linux/lnet/lib-lnet.h |2 + drivers/staging/lustre/lne

[PATCH 18/24] staging: lustre: remove messages from lazy portal on NI shutdown

2016-02-22 Thread James Simmons
From: Amir Shehata When shutting down an NI in a busy system, some messages received on this NI, might be on the lazy portal. They would have grabbed a ref count on the NI. Therefore NI will not be removed until messages are processed. In order to avoid this scenario, when an NI is shutdown go

[PATCH 23/24] staging: lustre: Use lnet_is_route_alive for router aliveness

2016-02-22 Thread James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5733 Reviewed-on: http://review.whamcloud.com/14055 Reviewed-by: James Simmons Reviewed-by: Amir Shehata Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/router.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[PATCH 12/24] staging: lustre: reject invalid net configuration for lnet

2016-02-22 Thread James Simmons
the earlier NI, because the src_nid is stored in the ptlrpc layer and is not updated when a local NI is configured. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5874 Reviewed-on: http://review.whamcloud.com/12912 Reviewed-by: Isaac Huang Reviewed-by: James

[PATCH 19/24] staging: lustre: remove unnecessary EXPORT_SYMBOL from lnet layer

2016-02-22 Thread James Simmons
From: Frank Zago A lot of symbols don't need to be exported at all because they are only used in the module they belong to. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829 Reviewed-on: http://review.whamcloud.com/13320 Reviewed-by: James Simmons Review

[PATCH 24/24] staging: lustre: Remove LASSERTS from router checker

2016-02-22 Thread James Simmons
Reviewed-on: http://review.whamcloud.com/17003 Reviewed-by: James Simmons Reviewed-by: Chris Horn Reviewed-by: Matt Ezell Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/router.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet

[PATCH 16/24] staging: lustre: assume a kernel build

2016-02-22 Thread James Simmons
: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-on: http://review.whamcloud.com/13121 Reviewed-by: James Simmons Reviewed-by: Amir Shehata Reviewed-by: Oleg Drokin --- .../staging/lustre/include/linux/lnet/lib-types.h |4 -- drivers/staging/lustre/lnet/lnet/acceptor.c|2

[PATCH 5/6] staging: lustre: make module_init/exit naming consistent

2016-02-23 Thread James Simmons
From: Andreas Dilger Make the name of the module_init()/_exit() functions consistently {module_name}_init and {module_name}_exit. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16787 Reviewed-by: John L. Hammond R

[PATCH 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module

2016-02-23 Thread James Simmons
From: Andreas Dilger For LNet selftest module the MODULE_AUTHOR was missing. Add proper OpenSFS authorship. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/1678

[PATCH 1/6] staging: lustre: move module info to end of libcfs module.c file

2016-02-23 Thread James Simmons
Move the MODULE_* field in module.c that belongs to libcfs to the end of the file like it is done for other kernel drivers. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/libcfs/module.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 3/6] staging: lustre: update the MODULE_VERSION for all lustre modules

2016-02-23 Thread James Simmons
For several lustre modules the MODULE_VERSION has the wrong value, located in the wrong place in the source code, or completely missing. This patch brings it up to date. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com

[PATCH 0/6] staging: lustre: update modinfo data

2016-02-23 Thread James Simmons
: update the MODULE_DESCRIPTION for all lustre modules staging: lustre: make module_init/exit naming consistent staging: lustre: update format for lnet_lib_init/exit comment James Simmons (2): staging: lustre: move module info to end of libcfs module.c file staging: lustre: update the

[PATCH 4/6] staging: lustre: update the MODULE_DESCRIPTION for all lustre modules

2016-02-23 Thread James Simmons
From: Andreas Dilger Fixup the MODULE_DESCRIPTION for several lustre modules. Some wrongly place the version in the string or they are not descriptive enough. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU

[PATCH 6/6] staging: lustre: update format for lnet_lib_init/exit comment

2016-02-23 Thread James Simmons
From: Andreas Dilger The documentation about the return values for lnet_lib_init and lnet_lib_exit was in the old style format. Bring it in sync with the rest of the LNet core. Broken out of patch 16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Revi

[PATCH v2 3/6] staging: lustre: update the MODULE_VERSION for all lustre modules

2016-02-25 Thread James Simmons
For several lustre modules the MODULE_VERSION has the wrong value, located in the wrong place in the source code, or completely missing. This patch brings it up to date. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com

[PATCH v2 1/6] staging: lustre: move module info to end of libcfs module.c file

2016-02-25 Thread James Simmons
Move the MODULE_* field in module.c that belongs to libcfs to the end of the file like it is done for other kernel drivers. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/libcfs/module.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module

2016-02-25 Thread James Simmons
From: Andreas Dilger For LNet selftest module the MODULE_AUTHOR was missing. Add proper OpenSFS authorship. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/1678

[PATCH v2 6/6] staging: lustre: update comment for lnet_lib_init/exit

2016-02-25 Thread James Simmons
From: Andreas Dilger The documentation about the return values for lnet_lib_init and lnet_lib_exit was in the old style format. Bring it in sync with the rest of the LNet core. Broken out of patch 16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Revi

[PATCH v2 5/6] staging: lustre: make module_init/exit naming consistent

2016-02-25 Thread James Simmons
From: Andreas Dilger Make the name of the module_init()/_exit() functions consistently {module_name}_init and {module_name}_exit. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16787 Reviewed-by: John L. Hammond R

[PATCH v2 0/6] staging: lustre: update modinfo data

2016-02-25 Thread James Simmons
dreas Dilger (4): staging: lustre: add missing MODULE_AUTHOR for LNet selftest module staging: lustre: update the MODULE_DESCRIPTION for all lustre modules staging: lustre: make module_init/exit naming consistent staging: lustre: update comment for lnet_lib_init/exit James Simmons (2): st

[PATCH v2 4/6] staging: lustre: update the MODULE_DESCRIPTION for all lustre modules

2016-02-25 Thread James Simmons
From: Andreas Dilger Fixup the MODULE_DESCRIPTION for several lustre modules. Some wrongly place the version in the string or they are not descriptive enough. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU

[PATCH v3 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module

2016-02-26 Thread James Simmons
From: Andreas Dilger For LNet selftest module the MODULE_AUTHOR was missing. Add proper OpenSFS authorship. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/1678

[PATCH v3 0/6] staging: lustre: update modinfo data

2016-02-26 Thread James Simmons
stre: make module_init/exit naming consistent staging: lustre: update comment for lnet_lib_init/exit James Simmons (2): staging: lustre: move module info to end of libcfs module.c file staging: lustre: update the MODULE_VERSION for all lustre modules .../staging/lustre/include/linux/libcf

[PATCH v3 6/6] staging: lustre: update comment for lnet_lib_init/exit

2016-02-26 Thread James Simmons
From: Andreas Dilger The documentation about the return values for lnet_lib_init and lnet_lib_exit was in the old style format. Bring it in sync with the rest of the LNet core. Broken out of patch 16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Revi

[PATCH v3 1/6] staging: lustre: move module info to end of libcfs module.c file

2016-02-26 Thread James Simmons
Move the MODULE_* field in module.c that belongs to libcfs to the end of the file like it is done for other kernel drivers. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/libcfs/module.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v3 5/6] staging: lustre: make module_init/exit naming consistent

2016-02-26 Thread James Simmons
From: Andreas Dilger Make the name of the module_init()/_exit() functions consistently {module_name}_init and {module_name}_exit. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16787 Reviewed-by: John L. Hammond R

[PATCH v3 4/6] staging: lustre: update the MODULE_DESCRIPTION for all lustre modules

2016-02-26 Thread James Simmons
From: Andreas Dilger Fixup the MODULE_DESCRIPTION for several lustre modules. Some wrongly place the version in the string or they are not descriptive enough. Broken out of patch http://review.whamcloud.com/16787. Signed-off-by: Andreas Dilger Intel-bug-id: https://jira.hpdd.intel.com/browse/LU

[PATCH v3 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module

2016-02-26 Thread James Simmons
For several lustre modules the MODULE_VERSION has the wrong value, located in the wrong place in the source code, or completely missing. This patch brings it up to date. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com

[PATCH 00/27] Third batch of LNet fixes

2016-03-02 Thread James Simmons
: lustre: make o2iblnd local functions static staging: lustre: make o2iblnd_cb.c local functions static staging: lustre: corrected some typos and grammar errors James Simmons (3): staging: lustre: return proper error code for LNet core staging: lustre: bind socklnd peers to a specific CPT

[PATCH 03/27] staging: lustre: Ignore hops if not explicitly set

2016-03-02 Thread James Simmons
From: Amir Shehata Since the # of hops is not a mandatory parameter the LU-6060 patch will cause problems to already existing systems since it changes the behavior by which a route is determined down. To fix this case the # of hops now defaults to LNET_UNDEFINED_HOPS if no hop count is specified

[PATCH 01/27] staging: lustre: set downis to 1 if there's no NI for remote net

2016-03-02 Thread James Simmons
/13417 Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/router.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c index 5e8b0ba..2eae8f6

[PATCH 09/27] staging: lustre: set task state before scheduling in lnet_sock_accept

2016-03-02 Thread James Simmons
. Also we can remove setting the task to TASK_RUNNING that is not needed. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6407 Reviewed-on: http://review.whamcloud.com/14265 Reviewed-by: James Simmons Reviewed-by: Amir Shehata Reviewed-by: Oleg Drokin --- drivers

[PATCH 17/27] staging: lustre: make o2iblnd local functions static

2016-03-02 Thread James Simmons
From: Frank Zago This fixes sparse warnings such as: .../o2iblnd.c:424:1: warning: symbol 'kiblnd_get_peer_info' was not declared. Should it be static? This reduces the code size by 400 bytes. The body of "the_o2iblnd" was moved at the end of the file, to avoid having to

[PATCH 13/27] staging: lustre: fix api-ni.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http:

[PATCH 05/27] staging: lustre: remove annoying message in parse_nidrange

2016-03-02 Thread James Simmons
: http://review.whamcloud.com/17916 Reviewed-by: Emoly Liu Reviewed-by: Bobi Jam Reviewed-by: Lai Siyao Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/nidstrings.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging

[PATCH 20/27] staging: lustre: change ibh_mrs from array to pointer

2016-03-02 Thread James Simmons
From: Amir Shehata With the removal of PMR we no longer require ibh_mrs field to be a array so change it to a simple pointer. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6850 Reviewed-on: http://review.whamcloud.com/15788 Reviewed-by: James Simmons Reviewed

[PATCH 07/27] staging: lustre: issue in the offset in lnet match hash table

2016-03-02 Thread James Simmons
/18422 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/lib-ptl.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib

[PATCH 14/27] staging: lustre: fix conctl.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin The function lst_test_add_ioctl is always copying lstio_tes_param from userland even if the user doesn't send this data to LNet selftest. Only consider lstio_tes_param data if lstio_tes_param_len is not zero. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel

[PATCH 12/27] staging: lustre: fix socklnd issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin Null pointer 'best_iface' that comes from line 802 may be dereferenced at line 832. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http://review.whamcloud.com/9386 Reviewed-by: John L. Hammond Reviewed-by: Isaac Huang Rev

[PATCH 15/27] staging: lustre: fix framework.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin The functions sfw_test_buffers() and sfw_unload_test() from LNet selftest both assume sfw_test_instance_t being passed in is never null. This is corrected here. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http://review.w

[PATCH 04/27] staging: lustre: return proper error code for LNet core

2016-03-02 Thread James Simmons
It is consider bad style in the linux kernel to return -1 or a positive number for an error. Instead return the appropriate error codes. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142 Reviewed-on: http://review.whamcloud.com/17626 Reviewed-by: Doug Oucharek

[PATCH 10/27] staging: lustre: replace direct LNet HZ access with kernel APIs

2016-03-02 Thread James Simmons
EC n / HZ * 1000 -> jiffies_to_msecs(n) This patch replaces the direct HZ access in lnet module. Signed-off-by: Jian Yu Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5443 Reviewed-by: Nathaniel Clark Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd

[PATCH 06/27] staging: lustre: Use after free in lnet_ptl_match_delay()

2016-03-02 Thread James Simmons
From: Olaf Weber In lnet_ptl_match_delay() we check msg->msg_rx_delayed to see whether the message has been added to the delay queue. But this check is done after lnet_ptl_unlock() and lnet_res_unlock(), and the message can be processed and freed before the check. Replace the check with checking

[PATCH 19/27] staging: lustre: corrected some typos and grammar errors

2016-03-02 Thread James Simmons
From: Frank Zago Cleanup various typos and grammar errors. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5710 Reviewed-on: http://review.whamcloud.com/12201 Reviewed-by: James Simmons Reviewed-by: Bob Glossman Reviewed-by: Oleg Drokin --- .../staging/lustre

[PATCH 18/27] staging: lustre: make o2iblnd_cb.c local functions static

2016-03-02 Thread James Simmons
From: Frank Zago This reduces the code size by about 1KiB. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 Reviewed-on: http://review.whamcloud.com/11256 Reviewed-by: Patrick Farrell Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin --- .../staging/lus

[PATCH 23/27] staging: lustre: take extra refcount in kiblnd_connreq_done

2016-03-02 Thread James Simmons
/17527 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Tested-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd

[PATCH] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread James Simmons
Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 51 --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 36 +++-- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 156 3 files changed, 146

[PATCH 22/27] staging: lustre: make ko2iblnd connect parameters persistent

2016-03-02 Thread James Simmons
parameters to it as well. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3322 Reviewed-on: http://review.whamcloud.com/17074 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 14

[PATCH 11/27] staging: lustre: bind socklnd peers to a specific CPT

2016-03-02 Thread James Simmons
Currently the socklnd driver doesn't support CPT affinity for its peers. Binding peers to a specific CPT and memory allocated to the NUMA node belonging to the CPT should give a performance boost. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7245 Review

[PATCH 02/27] staging: lustre: recv could access freed message

2016-03-02 Thread James Simmons
From: Liang Zhen When lnet_parse_put calls lnet_ptl_match_md, this function can attach current message on the delayed list if there is no match. It means this message can be taken over and freed by another thread who is posting new MD, then it is not safe for caller of lnet_parse_put to check thi

[PATCH 25/27] staging: lustre: check wr_id returned by ib_poll_cq

2016-03-02 Thread James Simmons
then close current connection. This patch could also be helpful for LU-5271 Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-519 Reviewed-on: http://review.whamcloud.com/12747 Reviewed-by: Isaac Huang Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed

[PATCH 26/27] staging: lustre: avoid intensive reconnecting for ko2iblnd

2016-03-02 Thread James Simmons
r the corresponding peer. Also, after a few rejections, reconnection will have a time interval between each attempt. Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7569 Reviewed-on: http://review.whamcloud.com/17892 Reviewed-by: Doug Oucharek Reviewed-by: James Si

[PATCH 27/27] staging: lustre: do less intense allocating retry for ko2iblnd

2016-03-02 Thread James Simmons
-7054 Reviewed-on: http://review.whamcloud.com/16470 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/l

[PATCH 16/27] staging: lustre: reverse LNet and infinband header order

2016-03-02 Thread James Simmons
: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5140 Reviewed-on: http://review.whamcloud.com/10571 Reviewed-by: Bob Glossman Reviewed-by: Liang Zhen Reviewed-by: Shuichi Ihara Reviewed-by: Patrick Farrell Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd

[PATCH 24/27] staging: lustre: Change connect peer failed cleanup order

2016-03-02 Thread James Simmons
The solution: be sure to decrement the connecting counter before decrementing the peer counter in the peer connect failure path. Signed-off-by: Doug Oucharek Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7210 Reviewed-on: http://review.whamcloud.com/17004 Reviewed-by: James Simmons Reviewed

[PATCH 08/27] staging: lustre: fix 'copy into fixed size buffer' errors

2016-03-02 Thread James Simmons
From: Sebastien Buisson Fix 'copy into fixed size buffer' defects found by Coverity version 6.0.3: Copy into fixed size buffer (STRING_OVERFLOW) The fixed-size string might be overrun by copying without checking the length. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.

[PATCH 4/7] staging: lustre: Change connect peer failed cleanup order

2016-03-02 Thread James Simmons
The solution: be sure to decrement the connecting counter before decrementing the peer counter in the peer connect failure path. Signed-off-by: Doug Oucharek Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7210 Reviewed-on: http://review.whamcloud.com/17004 Reviewed-by: James Simmons Reviewed

[PATCH 0/7] All remaining outstanding bug fixes for ko2iblnd

2016-03-02 Thread James Simmons
Final missing bug fixes to bring the infiniband LND driver up to date with the latest code used in production system. Amir Shehata (1): staging: lustre: make ko2iblnd connect parameters persistent Doug Oucharek (1): staging: lustre: Change connect peer failed cleanup order Jeremy Filizetti (

[PATCH 2/7] staging: lustre: make ko2iblnd connect parameters persistent

2016-03-02 Thread James Simmons
parameters to it as well. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3322 Reviewed-on: http://review.whamcloud.com/17074 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 14

[PATCH 7/7] staging: lustre: do less intense allocating retry for ko2iblnd

2016-03-02 Thread James Simmons
-7054 Reviewed-on: http://review.whamcloud.com/16470 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/l

[PATCH 3/7] staging: lustre: take extra refcount in kiblnd_connreq_done

2016-03-02 Thread James Simmons
/17527 Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Tested-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd

[PATCH 1/7] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread James Simmons
Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 51 --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 36 +++-- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 156 3 files changed, 146

[PATCH 6/7] staging: lustre: avoid intensive reconnecting for ko2iblnd

2016-03-02 Thread James Simmons
r the corresponding peer. Also, after a few rejections, reconnection will have a time interval between each attempt. Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7569 Reviewed-on: http://review.whamcloud.com/17892 Reviewed-by: Doug Oucharek Reviewed-by: James Si

[PATCH 5/7] staging: lustre: check wr_id returned by ib_poll_cq

2016-03-02 Thread James Simmons
then close current connection. This patch could also be helpful for LU-5271 Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-519 Reviewed-on: http://review.whamcloud.com/12747 Reviewed-by: Isaac Huang Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Reviewed

[PATCH] staging: lustre: handle complex strings in cfs_str2num_check

2016-03-03 Thread James Simmons
non digit character before the nob count. Signed-off-by: James Simmons --- .../staging/lustre/lustre/libcfs/libcfs_string.c | 27 +++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lus

[PATCH 01/10] staging: lustre: LNet drop rule implementation

2016-03-04 Thread James Simmons
From: Liang Zhen This is implementation of LNet Drop Rule, which can randomly drop LNet messages at specified rate. LNet Drop Rule can only be applied to receive side of message. User can add drop_rule either on end point of cluster (client/server) or on LNet routers. Here are lctl command to c

[PATCH 04/10] staging: lustre: fix 'NULL pointer dereference' errors

2016-03-04 Thread James Simmons
From: Sebastien Buisson Fix 'NULL pointer dereference' defects found by Coverity version 6.5.3: Dereference after null check (FORWARD_NULL) For instance, Passing null pointer to a function which dereferences it. Dereference before null check (REVERSE_INULL) Null-checking variable suggests that it

[PATCH 03/10] staging: lustre: fix 'data race condition' issue in conrpc.c

2016-03-04 Thread James Simmons
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/

[PATCH 00/10] Last batch of fixes for LNet

2016-03-04 Thread James Simmons
as they are ready after extensive testing. Frank Zago (1): staging: lustre: add last missing sparse annotation __user James Nunez (1): staging: lustre: Correct missing newline James Simmons (3): staging: lustre: change test to asser in LNetGetId staging: lustre: rename proc_call_handler to

[PATCH 02/10] staging: lustre: LNet network latency simulation

2016-03-04 Thread James Simmons
From: Liang Zhen Incoming lnet message can be delayed for seconds if it can match any of LNet Delay Rules. User can add/remove/list Delay Rule by lctl commands: - lctl net_delay_add Add a new Delay Rule to LNet, options <-s | --source SRC_NID> <-d | --dest DST_NID> <<-r | --rate RATE_NUM

[PATCH 05/10] staging: lustre: fix 'data race condition' issue in framework.c

2016-03-04 Thread James Simmons
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/

[PATCH 06/10] staging: lustre: Correct missing newline

2016-03-04 Thread James Simmons
From: James Nunez Several error messages are missing newline characters at the end of the message. Newlines are added where necessary and other minor corrections; no punctuation at the end of an error message, add a return code to the end of error messages, device name at the beginning, etc. The

[PATCH 07/10] staging: lustre: add last missing sparse annotation __user

2016-03-04 Thread James Simmons
From: Frank Zago One of the __user was missed in being applied to upstream client. This is broken out of patch 11819. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 Reviewed-on: http://review.whamcloud.com/11819 Reviewed-by: James Simmons Reviewed-by

[PATCH 10/10] staging: lustre: make LNet use lprocfs_call_handler

2016-03-04 Thread James Simmons
Sometime ago a patch was submitted to duplicate the proc_call_handler code in the LNet layer. This was due to the thinking libcfs was not used by the LNet layer. This was a wrong assumption so lets make LNet use the lprocfs_call_handler from the libcfs layer. Signed-off-by: James Simmons

[PATCH 09/10] staging: lustre: rename proc_call_handler to lprocfs_call_handler

2016-03-04 Thread James Simmons
Using proc_call_handler as a function name is way too generic. Rename to lprocfs_call_handler to avoid possible collisions. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/libcfs/module.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a

[PATCH 08/10] staging: lustre: change test to asser in LNetGetId

2016-03-04 Thread James Simmons
The ln_refcount test was changed into an assert. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/api-ni.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c index

[PATCH v2 3/9] staging: lustre: fix 'data race condition' issue in conrpc.c

2016-03-07 Thread James Simmons
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/

[PATCH v2 0/9] Last batch of fixes for LNet

2016-03-07 Thread James Simmons
ttr->u.drop.da_rate)) was changed to: if (!do_div(rule->dr_stat.fs_count, attr->u.drop.da_rate)) since fs_count is __u64. James Nunez (1): staging: lustre: Correct missing newline James Simmons (3): staging: lustre: change test to assert in LNetGetId staging: lu

[PATCH v2 4/9] staging: lustre: fix 'NULL pointer dereference' errors

2016-03-07 Thread James Simmons
From: Sebastien Buisson Fix 'NULL pointer dereference' defects found by Coverity version 6.5.3: Dereference after null check (FORWARD_NULL) For instance, Passing null pointer to a function which dereferences it. Dereference before null check (REVERSE_INULL) Null-checking variable suggests that it

[PATCH v2 8/9] staging: lustre: rename proc_call_handler to lprocfs_call_handler

2016-03-07 Thread James Simmons
Using proc_call_handler as a function name is way too generic. Rename to lprocfs_call_handler to avoid possible collisions. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/libcfs/module.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a

[PATCH v2 6/9] staging: lustre: Correct missing newline

2016-03-07 Thread James Simmons
From: James Nunez Several error messages are missing newline characters at the end of the message. Newlines are added where necessary and other minor corrections; no punctuation at the end of an error message, add a return code to the end of error messages, device name at the beginning, etc. The

[PATCH v2 5/9] staging: lustre: fix 'data race condition' issue in framework.c

2016-03-07 Thread James Simmons
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/

[PATCH v2 1/9] staging: lustre: LNet drop rule implementation

2016-03-07 Thread James Simmons
From: Liang Zhen This is implementation of LNet Drop Rule, which can randomly drop LNet messages at specified rate. LNet Drop Rule can only be applied to receive side of message. User can add drop_rule either on end point of cluster (client/server) or on LNet routers. Here are lctl command to c

[PATCH v2 7/9] staging: lustre: change test to assert in LNetGetId

2016-03-07 Thread James Simmons
The ln_refcount test was changed into an assert. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/api-ni.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c index

[PATCH v2 9/9] staging: lustre: make LNet use lprocfs_call_handler

2016-03-07 Thread James Simmons
Sometime ago a patch was submitted to duplicate the proc_call_handler code in the LNet layer. This was due to the thinking libcfs was not used by the LNet layer. This was a wrong assumption so lets make LNet use the lprocfs_call_handler from the libcfs layer. Signed-off-by: James Simmons

[PATCH v2 2/9] staging: lustre: LNet network latency simulation

2016-03-07 Thread James Simmons
From: Liang Zhen Incoming lnet message can be delayed for seconds if it can match any of LNet Delay Rules. User can add/remove/list Delay Rule by lctl commands: - lctl net_delay_add Add a new Delay Rule to LNet, options <-s | --source SRC_NID> <-d | --dest DST_NID> <<-r | --rate RATE_NUM

[PATCH 0/4] Support lustre routers with stand alone LNet stack

2016-03-08 Thread James Simmons
LNet stack for the routers which is all that is needed anyways. This patch series allows that option for users of the upstream client. James Simmons (4): staging: lustre: move libcfs to lnet layer staging: lustre: fixup kernel Kconfig option LNET_MAX_PAYLOAD staging: lustre: add help section

[PATCH 3/4] staging: lustre: add help section of Kconfig config LNET

2016-03-08 Thread James Simmons
Include a help section for Kconfig LNET. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/Kconfig |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/staging/lustre/lnet/Kconfig b/drivers/staging/lustre/lnet/Kconfig index 9c85091..980ce44 100644

[PATCH 1/4] staging: lustre: move libcfs to lnet layer

2016-03-08 Thread James Simmons
LNet. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/Makefile |2 +- .../lustre/{lustre => lnet}/libcfs/Makefile|2 +- .../staging/lustre/{lustre => lnet}/libcfs/debug.c |0 .../staging/lustre/{lustre => lnet}/libcfs/fail.c |0 .../stagi

[PATCH 4/4] staging: lustre: make lustre dependent on LNet

2016-03-08 Thread James Simmons
In the case of lustre routers you only need a functioning LNet stack. Especially since often the routers are very light weight and want to avoid any addition software that would create additional pressures on the system. Signed-off-by: James Simmons --- drivers/staging/Makefile

[PATCH 2/4] staging: lustre: fixup kernel Kconfig option LNET_MAX_PAYLOAD

2016-03-08 Thread James Simmons
A few errors exist for the Kconfig option LNET_MAX_PAYLOAD. First mistake is the default size is 1MB not 2MB as it is shown to the person configuring the kernel. Second the LNET_MAX_PAYLOAD option is more closely related to LNET than the LUSTRE_FS option. Signed-off-by: James Simmons

[PATCH 0/9] staging:lustre: remove kernel defines in userland headers

2015-06-11 Thread James Simmons
land will use. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/13792 Reviewed-by: John L. Hammond Reviewed-by: Andreas Dilger James Simmons (6): staging:lustre: Delete all obsolete LND drivers staging:lustre: move

[PATCH v4 3/9] staging:lustre: rename socklnd_lib-linux.c

2015-06-11 Thread James Simmons
-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-on: http://review.whamcloud.com/12932 Reviewed-by: Isaac Huang Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/klnds/socklnd/Makefile |2 +- .../socklnd/{socklnd_lib-linux.c =>

<    2   3   4   5   6   7   8   9   10   11   >