Re: [PATCH] staging: octeon-usb: use __delay() instead of cvmx_wait()

2017-11-17 Thread James Hogan
d9 ("MIPS: Octeon: Remove usage of cvmx_wait() everywhere.") > Signed-off-by: Aaro Koskinen Reviewed-by: James Hogan Should this driver be enabled in the MIPS cavium_octeon_defconfig or should that not happen until the driver comes out of staging? Cheers James > --- >

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
eon_cvmemctl { > /* R/W Size of local memory in cache blocks, 54 (6912 >* bytes) is max legal value. */ > __BITFIELD_FIELD(uint64_t lmemsz:6, > - ;) > + ; > } s; > }; Regardless, the patch l

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-30 Thread James Hogan
On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote: > From: Carlos Munoz > > Add a global resource manager to manage tagged pointers within > bootmem allocated memory. This is used by various functional > blocks in the Octeon core like the FPA, Ethernet nexus, etc. > > Signed-off-by: Ca

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: > On 11/30/2017 01:36 PM, James Hogan wrote: > > On Tue, Nov 28, 2017 at 04:55:34PM -0800, David Daney wrote: > >> Signed-off-by: Carlos Munoz > >> Signed-off-by: Steven J. Hill > >> Signed-off-b

Re: [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-30 Thread James Hogan
On Thu, Nov 30, 2017 at 03:09:33PM -0800, David Daney wrote: > On 11/30/2017 02:56 PM, James Hogan wrote: > > On Thu, Nov 30, 2017 at 01:49:43PM -0800, David Daney wrote: > >> On 11/30/2017 01:36 PM, James Hogan wrote: > >>> On Tue, Nov 28, 2017 at 04:55

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
Hi Chen, On 19/01/14 10:07, Chen Gang wrote: > BTW: this patch is related with another patch which is discussing (so I > have cc that patch to you and Greg too): "if we could sure that it is a > compiler's feature issue, we will skip this patch". If you're referring to the #pragma pack portabilit

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
On 20/01/14 12:30, Dan Carpenter wrote: > Ah. From so metag is a new arch and not a compiler like the changelog > says. > > On Mon, Jan 20, 2014 at 11:56:47AM +, James Hogan wrote: >> struct a { >> struct b { >> unsigned int x; >>

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-20 Thread James Hogan
On 20/01/14 13:01, Dan Carpenter wrote: > It would be easy enough to make the compiler complain about any union > which would normally have size which is not a multiple of 4. > > Warning: union will be padded with 2 bytes unless __attribute__((packed)). > > Otherwise you will be fighting this for

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-21 Thread James Hogan
Hi Dan, On 20/01/14 21:13, Dan Carpenter wrote: > I made a quick and dirty sparse patch to check for this. I don't think > I will bother trying to send it to sparse upstream, but you can if you > want to. > > It found 289 unions which might need a __packed added. The lustre > unions were not in

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-02-03 Thread James Hogan
On 03/02/14 10:05, David Laight wrote: > From: Dan Carpenter >> On Sat, Feb 01, 2014 at 09:57:39PM +0800, Chen Gang wrote: >>> It seems, our kernel still stick to treate 'pack' region have effect >>> with both 'align' and 'sizeof'. >> >> It's not about packed regions. It's about unions. It's sayi

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-02-03 Thread James Hogan
On 03/02/14 10:35, David Laight wrote: > From: James Hogan >> On 03/02/14 10:05, David Laight wrote: >>> Architectures that define such alignment rules are a right PITA. >>> You either need to get the size to 2 without using 'packed', or >>> just not

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-02 Thread James Hogan
safe syscalls. ... > arch/mips/include/asm/compat.h| 11 --- > arch/mips/kernel/signal32.c | 2 +- For MIPS: Acked-by: James Hogan Cheers James signature.asc Description: Digital signature ___ devel mailing