s/staging/wfx/hif_api_cmd.h
> @@ -100,7 +100,7 @@ struct hif_req_update_ie {
> u8 reserved1:5;
> u8 reserved2;
> __le16 num_ies;
> - struct element ie[];
> + u8 ie[];
> } __packed;
>
> struct hif_cnf_update_ie {
> --
> 2.2
on. If you try to compile bh.h alone (with something like
gcc -xc .../bh.h) it won't work.
Maybe it works now because we are lucky in the order the headers are
included, but I think it is not sufficient.
[... same problem repeats multiple times in the following ...]
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Greg,
On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote:
> Hello Muhammad,
>
> Sorry, I am a bit late for the review of this patch. Thank you for your
> contribution.
>
> On Thursday 11 February 2021 15:36:37 CET Muhammad Usama Anjum wrote:
> >
> &g
On Tuesday 9 March 2021 14:07:43 CET Greg KH wrote:
> On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote:
> > Hello Greg,
> >
> > On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote:
> > > Hello Muhammad,
> > >
> > > Sorry, I a
Hi Leon,
On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote:
> On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/Kconfig
"genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
Hello Ulf,
On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/bus_sdio
On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote:
> On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller
> wrote:
> > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> > > wrote:
> &g
g:
wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
in master in version 5.8). Can you check you are working on the last tree?
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Friday 10 September 2021 18:27:18 CEST Kari Argillander wrote:
> On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Comments after the last #endif of header files don't bring any
> > information and are redundant
35PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > During the scan requests, the Tx traffic is suspended. This lock is
> > shared by all the network interfaces. So, a scan request on one
> > interface will block the traffic on a second interface.
On Friday 10 September 2021 18:43:26 CEST Kari Argillander wrote:
>
> On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > API 3.8 introduces new statistic counters. These changes are backward
> > compatible.
>
>
On Friday 10 September 2021 18:57:43 CEST Kari Argillander wrote:
>
> On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Function arguments must be aligned with left parenthesis. Apply that
> > rule.
>
> To m
the content is safe.
> > >
> > >
> > > On Fri, Sep 10, 2021 at 06:04:35PM +0200, Jerome Pouiller wrote:
> > > > From: Jérôme Pouiller
> > > >
> > > > During the scan requests, the Tx traffic is suspended. This lock is
> >
On Friday 10 September 2021 19:07:41 CEST Kari Argillander wrote:
>
> On Fri, Sep 10, 2021 at 06:04:33PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Hi,
> >
> > The following PR contains now usual maintenance for the wfx driver. I have
&g
*enable_ps = false;
> > + if (wvif->vif->bss_conf.assoc &&
> > wvif->vif->bss_conf.ps)
> > + dev_info(wvif->wdev->dev, "ignoring requested
> > PS mode");
> > + re
Hello Ulf,
On Thursday 30 September 2021 12:07:55 CEST Ulf Hansson wrote:
> On Mon, 20 Sept 2021 at 18:12, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/bus
On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > +/* The device needs data about the antenna configuration. This information
> >
On Friday 1 October 2021 13:41:55 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > --- /dev/null
> > +++ b/drivers/net/wireless/silabs/wfx/hif_api_cmd.h
> >
On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip,
> > +
On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Jerome Pouiller writes:
>
>
On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Jerome Pouiller writes:
>
>
On Friday 1 October 2021 18:08:32 CEST Pali Rohár wrote:
> On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote:
> > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > > > From: Jérôme Pouiller
> &g
On Tuesday 5 October 2021 07:56:53 CEST Kalle Valo wrote:
> Jérôme Pouiller writes:
>
> > On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
> >> CAUTION: This email originated from outside of the organization. Do
> >> not click links or open attachments u
On Friday 1 October 2021 17:23:16 CEST Ulf Hansson wrote:
> On Thu, 30 Sept 2021 at 19:06, Pali Rohár wrote:
> > On Thursday 30 September 2021 18:51:09 Jérôme Pouiller wrote:
> > > On Thursday 30 September 2021 12:07:55 CEST Ulf Hansson wrote:
> > > > On Mon,
On Tuesday 5 October 2021 08:12:27 CEST Kalle Valo wrote:
> Pali Rohár writes:
> > On Friday 01 October 2021 17:17:52 Jérôme Pouiller wrote:
> >> On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
> >> > Jerome Pouiller writes:
> &g
On Tuesday 5 October 2021 10:21:27 CEST Greg Kroah-Hartman wrote:
> On Tue, Oct 05, 2021 at 10:17:32AM +0200, Jérôme Pouiller wrote:
> > On Tuesday 5 October 2021 08:12:27 CEST Kalle Valo wrote:
> > > Pali Rohár writes:
> > > > On Friday 01 October 2021 17:17:52 Jérô
On Tuesday 5 October 2021 16:20:19 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
[...]
> >
> > v8:
> > - Change the way the DT is handled. The user can now specify the name of
> > the board (= chip + antenna) he u
On Tuesday 5 October 2021 16:15:22 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
[...]
> > v8:
> > - Change the way the DT is handled. The user can now specify the name of
> > the board (= chip + antenna) he use. It easier for
Hi Kalle,
On Friday 1 October 2021 14:18:04 CEST Kalle Valo wrote:
> Jérôme Pouiller writes:
>
> > On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
> >> Jerome Pouiller writes:
> >>
> >> > From: Jérôme Pouiller
&g
On Wednesday 6 October 2021 17:02:07 CEST Ulf Hansson wrote:
> On Tue, 5 Oct 2021 at 10:14, Jérôme Pouiller
> wrote:
> > On Friday 1 October 2021 17:23:16 CEST Ulf Hansson wrote:
> > > On Thu, 30 Sept 2021 at 19:06, Pali Rohár wrote:
> > > > On Thursday
On Thursday 7 October 2021 10:08:53 CEST Kalle Valo wrote:
> Jérôme Pouiller writes:
> > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
> >> Jerome Pouiller writes:
> >>
> >> > From: Jérôme Pouiller
> >> >
> >> > Signed-o
On Thursday 7 October 2021 10:35:43 CEST Kalle Valo wrote:
> Jérôme Pouiller writes:
> > On Friday 1 October 2021 14:18:04 CEST Kalle Valo wrote:
> >> Jérôme Pouiller writes:
> >> > On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
> >> >> Je
On Thursday 7 October 2021 12:49:47 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Kalle Valo writes:
>
> &
On Wednesday 10 November 2021 10:58:41 CET Kalle Valo wrote:
> Jérôme Pouiller writes:
> > On Thursday 7 October 2021 12:49:47 CEST Kalle Valo wrote:
> >> Kalle Valo writes:
> >> > Jérôme Pouiller writes:
> >> >>> >> >> I&#x
On Wednesday 12 January 2022 08:49:54 CET Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > .../bindings/net/wireless/silabs,wfx.yaml | 125 ---
> > drivers/staging/wfx/Kcon
On Tuesday 11 January 2022 23:19:56 CET Rob Herring wrote:
> On Tue, Jan 11, 2022 at 06:14:02PM +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Prepare the inclusion of the wfx driver in the kernel.
> >
> > Signed-off-by: Jérôme Pouiller
>
; + .probe = wfx_sdio_probe,
> > + .remove = wfx_sdio_remove,
> > + .drv = {
> > + .owner = THIS_MODULE,
> > + .of_match_table = wfx_sdio_of_match,
> > + }
> > +};
> > --
> > 2.34.1
> >
>
--
Jérôme Pouill
On Wednesday 12 January 2022 12:43:32 CET Pali Rohár wrote:
>
> On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote:
> > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote:
> > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote:
> > > > +s
On Wednesday 12 January 2022 18:48:48 CET Pali Rohár wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> On Wednesday 12 January 2022 17:45:
On Thursday 13 January 2022 12:50:23 CET Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Apache-2.0 is not allowed in the kernel.
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/staging/wfx/h
Hi Kalle,
On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/net/wireless/silabs/wfx/main.c | 485 +
> drivers/net/wireless/silabs/wfx/main.h | 42 +++
>
On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote:
>
> Jérôme Pouiller writes:
>
> > Hi Kalle,
> >
> > On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote:
> >> From: Jérôme Pouiller
> >>
> >> Signed-off-by: Jérôme Po
On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote:
> Jérôme Pouiller writes:
> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote:
> >> Jérôme Pouiller writes:
> >>
> >> > Kalle, is this function what you expected? If it is right for y
On Thursday 10 February 2022 17:25:05 CET Kalle Valo wrote:
> Jérôme Pouiller writes:
>
> > On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote:
> >> Jérôme Pouiller writes:
> >> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote
tmp = buf;
> > }
> > ret = sram_buf_write(wdev, addr, tmp, len);
> > - if (!virt_addr_valid(buf))
> > + if (tmp != buf)
> > kfree(tmp);
> > return ret;
> > }
>
> Jerome, any thoughts?
Look
it would be an unnecessary effort?
[1]
https://lore.kernel.org/driverdev-devel/20190919142527.31797-1-jerome.pouil...@silabs.com/
or commits a7a91ca5a23d^..40115bbc40e2
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverp
On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Smatch complains:
> >
> >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn:
> > potential NULL parameter der
On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Jerome Pouiller writes:
>
>
On Saturday 10 October 2020 14:40:34 CEST Greg Kroah-Hartman wrote:
> On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote:
> > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > > > From: Jérôme Pou
ies on the last
development tree.
To get the development tree to use, you can run:
./scripts/get_maintainer.pl --scm -f drivers/staging/wfx/debug.c
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
commented out).
Anyway, if we choose to rely on the DT, should we also check the VID/PID?
Personally, I am in favor to probe the device only if VID/PID match and if
a DT node is found, even if it is not the usual way.
--
Jérôme Pouiller
___
devel
On Tuesday 13 October 2020 18:49:35 CEST Rob Herring wrote:
> On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
[...]
> > + Note that in add of the properties below, the WFx driver also supports
> > + `mac-address` and `local-mac-add
On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote:
> On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote:
> > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote:
> > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote:
> > > >
Hello Ulf,
On Friday 16 October 2020 13:30:30 CEST Ulf Hansson wrote:
> On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
>
> Please fill out this commit message to explain a bit more about the
> patch and the HW it enables support
NTENTS, ALLOC, LOAD, READONLY, CODE
[...]
7 .rodata 002d 1dd4 2**2
CONTENTS, ALLOC, LOAD, READONLY, DATA
The difference of .rodata is exactly what is expected (24 bytes) and we
save 115 bytes of code.
Reviewed-by: Jérôme Pouiller
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
evel/20201019160604.1609180-1-jerome.pouil...@silabs.com/
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wednesday 4 November 2020 20:15:54 CET Rob Herring wrote:
> On Wed, 04 Nov 2020 16:51:45 +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > .../bindings/net/wireless/silabs,wfx.yaml | 131 ++
taIn[3];
> + memcpy(&result->ID, &dataIn[4], sizeof(result->ID));
> + result->CUSTOMER = dataIn[6];
> + result->ROMID = dataIn[7];
> + result->BOND = dataIn[8];
... it would avoid all these lines.
> + } else {
> + dev_err(port->dev,
> + "%s: si4455_send_command_get_response error(%i)",
> + __func__,
> + ret);
> + }
> + return ret;
> +}
[...]
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t; +#include
> > +#else
> > +#include
> > +#include
> > +#define __packed __attribute__((__packed__))
> > +#endif
>
> Why check for __KERNEL__ and redefined __packed? These don't belong to a
> wireless driver.
In the old days, this file was shared with oth
On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > +wfx-$(CONFIG_SPI) += bus_spi.o
> > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdi
t; + */
> >
> > This sounds very hacky to me, I have understood that you should never
> > use stack with DMA.
>
> You should never do that because some platforms do not support it, so no
> driver should ever try to do that as they do not know what platform they
>
nning on.
Just to be curious, why these platforms don't support DMA in a stack
allocated area? If the memory is contiguous (= not vmalloced), correctly
aligned and in the first 4GB of physical memory, it should be sufficient,
shouldn't?
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ing to add this comment:
The device need data about the antenna configuration. This information in
provided by PDS (Platform Data Set, this is the wording used in WF200
documentation) files. For hardware integrators, the full process to create
PDS files is described here:
https://github.com/Silicon
gpio_nreset. What do
you think about it?
(in add, this solution would explicitly change the name of the DT
attribute instead of changing the semantic of the existing attribute)
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thursday 5 December 2019 15:49:55 CET Michał Mirosław wrote:
> On Thu, Dec 05, 2019 at 02:08:23PM +0000, Jérôme Pouiller wrote:
> > On Wednesday 4 December 2019 17:59:46 CET Michał Mirosław wrote:
> > > Driver inverts meaning of GPIO_ACTIVE_LOW/HIGH. Fix it to preve
From: Jérôme Pouiller
There is no reason for a trace to change any bit of the argument. So,
let's make sure that is the case by declaring the arguments constant.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/traces.h | 14 --
1 file changed, 8 insertions(+), 6 dele
From: Jérôme Pouiller
Currently, number of available tx retry policies is checked two times.
Only one is sufficient.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/data_tx.c b/drivers
From: Jérôme Pouiller
Obviously, current code can be replaced by IS_ERR_OR_NULL().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 3b47b6c21ea1
From: Jérôme Pouiller
This new naming allows to save a comment.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bus_spi.c | 2 ++
drivers/staging/wfx/fwio.c| 2 +-
drivers/staging/wfx/hwio.h| 15 +--
3 files changed, 8 insertions(+), 11 deletions(-)
diff --git a
From: Jérôme Pouiller
The original name did not make any sense.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/staging/wfx/hif_api_cmd.h
index 3e77fbe3d5ff
From: Jérôme Pouiller
The driver checks that the number of retries made by the device is
coherent with the rate policy. However, this check make sense only if
the device has returned RETRY_EXCEEDED.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 4 +++-
1 file changed, 3
From: Jérôme Pouiller
When driver receives an unexpected answer from the device, it shows
"unsupported HIF ID". That message does not represent the real error.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletio
From: Jérôme Pouiller
Attribute "aborted" and argument "aborted" are both booleans.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.
From: Jérôme Pouiller
There are no real reason to modify the data received from device. So,
let's mark the arguments constant.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_rx.c | 8 ++-
drivers/staging/wfx/data_rx.h | 4 +-
drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
In fact "mode" is a boolean that indicates if IBSS mode is used. This
patch fixes the name and uses a more adapted memory representation.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 8 ++--
drivers/staging/wfx/sta.c | 2 +
From: Jérôme Pouiller
In wfx driver, when a function is used as a struct member, its name is
the name of the member prefixed with "wfx_".
This patch apply this rule to wfx_spi_remove().
Also remove the useless comment above the function.
Signed-off-by: Jérôme Pouiller
---
drive
From: Jérôme Pouiller
The script that has imported API header has made a mistake "num_i_es".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 2 +-
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
From: Jérôme Pouiller
During chip probing, if error does not come from secure boot (for
exemple when firmware has been found), others errors probably appears.
It is not necessary to say to user that the error does not come from
secure boot. So, drop the message saying "no error report
From: Jérôme Pouiller
We prefer series of simple boolean conditions than computing bitmasks.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers
From: Jérôme Pouiller
hif_tx.c does not use any struct skb.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index cb7cddcb9815..e8c2bd1efbac 100644
--- a/drivers
From: Jérôme Pouiller
The script that has imported API headers has made a mistake in
"num_of_ssi_ds".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 4 ++--
drivers/staging/wfx/hif_tx.c | 10 +-
drivers/staging/wfx/scan.c| 2 +-
3 fil
From: Jérôme Pouiller
It is easier to manipulate a int than an array of booleans.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 17 +++--
drivers/staging/wfx/sta.h | 2 +-
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b
From: Jérôme Pouiller
Error management of wfx_conf_tx() can be simplified.
In add, the hardware command "hif_set_edca_queue_params" never returns
any error.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 42 ++-
1 file c
From: Jérôme Pouiller
It is useless to keep uapsd_info in struct wfx_vif. This structure can
be rebuilt just before to be sent.
In add, the struct hif_mib_set_uapsd_information comes from hardware
API. It is not intended to be manipulated in upper layers of the driver.
So, this patch relocates
From: Jérôme Pouiller
The struct hif_req_set_pm_mode comes from hardware API. It is not
intended to be manipulated in upper layers of the driver. So, this patch
relocate the handling of this struct to hif_set_pm() (the low level
function).
Signed-off-by: Jérôme Pouiller
---
drivers/staging
From: Jérôme Pouiller
Intermediate structure wfx_edca_params does not help. This patch
relocates its members directly in struct wfx_vif.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 4 ++--
drivers/staging/wfx/sta.c | 18 +-
drivers/staging/wfx/sta.h
From: Jérôme Pouiller
The device is not allowed to enter in sleep mode during scan. However,
this is already handled by the device. So driver does not have to care
about it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 3 +--
drivers/staging/wfx/scan.c | 3 ---
drivers
From: Jérôme Pouiller
The structure hif_mib_template_frame come from hardware API. It is not
intended to be manipulated in upper layers of the driver.
In add, the current code for hif_set_template_frame() is dumb. All the
difficult task is left to the caller. So, there is code to factorize
here
From: Jérôme Pouiller
The structures hif_req_start_scan and hif_ssid_def come from hardware
API. It is not intended to be manipulated in upper layers of the driver.
So, this patch relocate handling of theses structures to hif_scan()
(the low level function). This change also allows to drop
From: Jérôme Pouiller
Since wfx_scan_complete() is now only called from
wfx_scan_complete_cb(), it make sense to merge the both functions.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
From: Jérôme Pouiller
The struct hif_req_edca_queue_params comes from hardware API. It is not
intended to be manipulated in upper layers of the driver.
So, this patch:
1. relocate the handling of this struct in hif_set_edca_queue_params()
(the low level function)
2. replace it in
From: Jérôme Pouiller
If scan fails, status is returned in hif_ind_scan_cmpl. hif_scan
always return a success. So, we can simplify the code.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 20 ++--
drivers/staging/wfx/scan.h | 1 -
2 files changed, 2
From: Jérôme Pouiller
mac80211 already call wfx_conf_tx() on every VIF instanciation. So, the
driver does not need to do it.
Note that current code did dirty things with wvif->edca_params. This
struct was initialized, but only 'queue_id' was really used. The other
members are only
From: Jérôme Pouiller
Simplify wfx_hw_scan() by splitting out the update of the probe request.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/scan.c | 57 --
1 file changed, 30 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/wfx/scan.c
From: Jérôme Pouiller
A tx_retry_policy (the equivalent of a list of ieee80211_tx_rate in
hardware API) is not able to include a rate multiple time. So currently,
the driver merges the identical rates from the policy provided by
minstrel (and it try to do the best choice it can in the associated
From: Jérôme Pouiller
Hello all,
This pull request continue to clean up the wfx driver. It can be more or
less divided in four parts:
- 0001 to 0009 fix some issues (should be included in 5.5?)
- 0010 to 0028 mostly contains cosmetics changes
- 0029 to 0043 re-work power save (in station
From: Jérôme Pouiller
When not using HT mode, minstrel always includes 1Mbps as fallback rate.
But, when using HT mode, this fallback is not included. Yet, it seems
that it could save some frames. So, this patch add it unconditionally.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx
From: Jérôme Pouiller
Some weird behaviors were observed when connection is really good and
packets are small. It appears that sometime, number of packets in queues
can exceed 255 and generate an overflow in field usage_count.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.h
From: Jérôme Pouiller
In some rare cases, driver may not have any available tx_retry_policies.
In this case, the driver asks to mac80211 to stop sending data. However,
it seems that a race is possible and a few frames can be sent to the
driver. In this case, driver can't wait for
1 - 100 of 353 matches
Mail list logo
