Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

2017-03-03 Thread Hillf Danton
On March 03, 2017 5:45 AM Laura Abbott wrote: > > +static struct sg_table *dup_sg_table(struct sg_table *table) > +{ > + struct sg_table *new_table; > + int ret, i; > + struct scatterlist *sg, *new_sg; > + > + new_table = kzalloc(sizeof(*new_table), GFP_KERNEL); > + if (!new_

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-03-25 Thread Hillf Danton
On Wed, 25 Mar 2020 01:58:03 -0700 > syzbot has tested the proposed patch but the reproducer still triggered crash: > KASAN: use-after-free Read in hfa384x_usbin_callback > > == > BUG: KASAN: use-after-free in memcpy include/linux/s

Re: [PATCH] arch:arm:mm:Correction in the boundary check for module end address.

2015-11-09 Thread Hillf Danton
y not be intended to work with > non-aligned addresses, but if we're going to round the start down, > then rounding the end down as well like that is also buggy. > > unsigned long start = addr; > unsigned long size = PAGE_SI

Re: [RFC 6/6] drivers: staging: ion: add ION_IOC_TAG ioctl

2016-10-11 Thread Hillf Danton
On Wednesday, October 12, 2016 7:50 AM Ruchi Kandoi wrote: > +/** > + * struct ion_fd_data - metadata passed from userspace for a handle s/fd/tag/ ? > + * @handle: a handle > + * @tag: a string describing the buffer > + * > + * For ION_IOC_TAG userspace populates the handle field with > + * the

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Hillf Danton
On Thu, May 8, 2014 at 5:05 PM, Julian Andres Klode wrote: > On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote: >> +as raw text including all the headers. Run `cat raw_email.txt | git am` > > `cat raw_email.txt | git am` seems a bit pointless. Why not simply > `git am raw_email.txt`?

Re: possible deadlock in shmem_fallocate (4)

2020-07-13 Thread Hillf Danton
Mon, 13 Jul 2020 17:32:19 -0700 > syzbot has found a reproducer for the following crash on: > > HEAD commit:11ba4688 Linux 5.8-rc5 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13f1bf4710 > kernel config: https://syzkaller.appspot.com/x/.config?x

Re: possible deadlock in shmem_fallocate (4)

2020-07-13 Thread Hillf Danton
On Mon, 13 Jul 2020 20:41:11 -0700 Eric Biggers wrote: > On Tue, Jul 14, 2020 at 11:32:52AM +0800, Hillf Danton wrote: > > > > Add FALLOC_FL_NOBLOCK and on the shmem side try to lock inode upon the > > new flag. And the overall upside is to keep the current gfp either

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Hillf Danton
On Tue, 14 Jul 2020 10:26:29 +0200 Michal Hocko wrote: > On Tue 14-07-20 13:32:05, Hillf Danton wrote: > > > > On Mon, 13 Jul 2020 20:41:11 -0700 Eric Biggers wrote: > > > On Tue, Jul 14, 2020 at 11:32:52AM +0800, Hillf Danton wrote: > > > > > > >

Re: possible deadlock in shmem_fallocate (4)

2020-07-14 Thread Hillf Danton
> > > > Thanks for looping me in. > > > > > On Tue, Jul 14, 2020 at 7:18 AM Michal Hocko wrote: > > > > > > > > On Tue 14-07-20 22:08:59, Hillf Danton wrote: > > > > > > > > > > On Tue, 14 Jul 2020 10:26:29 +0200 Michal